Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36547 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 5:03 p.m.,

Re: Review Request 18913: Bump protobuf version to match version used by mesos library.

2014-03-07 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18913/#review36550 --- Ship it! Ship It! - Dan Norris On March 7, 2014, 6:19 p.m.,

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 7, 2014, 6:21 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

2014-03-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/#review36551 --- Ship it! Ship It! - Mark Chu-Carroll On March 6, 2014, 5:42

Re: Review Request 18926: Aurora-102: Investigate adding failOnVersionConfict() to scheduler build

2014-03-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18926/#review36583 --- Do you mind changing the summary of this review? Since that winds

Review Request 18935: Part 1 of converting from Packages to Metadata.

2014-03-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18935/ --- Review request for Aurora, Suman Karumuri and Bill Farner. Bugs: AURORA-158

Re: Review Request 18935: Part 1 of converting from Packages to Metadata.

2014-03-07 Thread Maxim Khutornenko
On March 8, 2014, 12:56 a.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 179 https://reviews.apache.org/r/18935/diff/1/?file=513979#file513979line179 feel free to rename this to packagesDEPRECATED That would require client changes that I would rather

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/ --- (Updated March 7, 2014, 5:20 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 18935: Part 1 of converting from Packages to Metadata.

2014-03-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18935/ --- (Updated March 8, 2014, 2:10 a.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 18935: Part 1 of converting from Packages to Metadata.

2014-03-07 Thread Maxim Khutornenko
On March 8, 2014, 12:56 a.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 179 https://reviews.apache.org/r/18935/diff/1/?file=513979#file513979line179 feel free to rename this to packagesDEPRECATED Maxim Khutornenko wrote: That would require