Re: Review Request 24521: Finalizing DB mapper implementation.

2014-08-11 Thread David McLaughlin
On Aug. 9, 2014, 12:48 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java, line 40 https://reviews.apache.org/r/24521/diff/2/?file=656929#file656929line40 Drive-by partial review, but this seems like an API regression. Do you expect

Re: Review Request 24521: Finalizing DB mapper implementation.

2014-08-11 Thread Bill Farner
On Aug. 9, 2014, 12:48 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java, line 40 https://reviews.apache.org/r/24521/diff/2/?file=656929#file656929line40 Drive-by partial review, but this seems like an API regression. Do you expect

Re: Review Request 24521: Finalizing DB mapper implementation.

2014-08-11 Thread Maxim Khutornenko
On Aug. 9, 2014, 12:48 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java, line 40 https://reviews.apache.org/r/24521/diff/2/?file=656929#file656929line40 Drive-by partial review, but this seems like an API regression. Do you expect

Re: Review Request 24521: Finalizing DB mapper implementation.

2014-08-11 Thread David McLaughlin
On Aug. 9, 2014, 12:48 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java, line 40 https://reviews.apache.org/r/24521/diff/2/?file=656929#file656929line40 Drive-by partial review, but this seems like an API regression. Do you expect

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Bill Farner
On Aug. 7, 2014, 11:24 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java, lines 17-18 https://reviews.apache.org/r/24465/diff/2/?file=655801#file655801line17 It's unclear to me why T is needed here. Also, this description seems

Review Request 24573: Fix bug in aurora job inspect.

2014-08-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: aurora-642

Re: Review Request 24573: Fix bug in aurora job inspect.

2014-08-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50223 --- Issue points out lack of test coverage, can you add that with the

Re: Review Request 24573: Fix bug in aurora job inspect.

2014-08-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50224 --- Issue points out lack of test coverage, can you add that with the

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/#review50232 --- Ship it!

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Bill Farner
On Aug. 11, 2014, 9:05 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java, lines 135-137 https://reviews.apache.org/r/24465/diff/2-3/?file=655800#file655800line135 There is still job/instance state update mix here. What I was

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/ --- (Updated Aug. 11, 2014, 9:29 p.m.) Review request for Aurora, Kevin Sweeney