Re: Review Request 24662: Implementing job update "get" thrift APIs.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24662/#review50891
---


Ping.

- Maxim Khutornenko


On Aug. 14, 2014, 8:20 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24662/
> ---
> 
> (Updated Aug. 14, 2014, 8:20 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-649
> https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implementing job update "get" thrift APIs.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
>  4bad83963b98002f42b470d03e58f832bd96d568 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d34bd6f5fedddb8d70996dc0806b4158f4136874 
> 
> Diff: https://reviews.apache.org/r/24662/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[David McLaughlin]

> On Aug. 15, 2014, 6:02 p.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 558
> > 
> >
> > Rolling back assumes removing new (INSTANCE_REMOVED) and adding old 
> > (INSTANCE_ADDED). Do we want to distinct those actions from the forward 
> > roll?
> 
> David McLaughlin wrote:
> INSTANCE_REMOVED is only used when you remove an instance because the new 
> instanceCount is less than previous one, it's not used if you're removing an 
> instance as part of updating it.
> 
> Maxim Khutornenko wrote:
> I guess I did not see the JobUpdateAction as a post factum update story 
> teller. I thought it would be used more as a facilitator for internal actions 
> to be done (i.e. add_instance, kill_instance, and etc.) 
> 
> I don't have a problem with this high level mapping as long as updater 
> would not rely on it to drive the state machine progress.

We should be careful either way not to leak internal state machines into the 
public API. But yes, I think definitely the purpose of instance events is to 
retell a story of what happened during this update.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50752
---


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[David McLaughlin]

> On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
> > 
> >
> > What action is going to be used for an instance that failed to update 
> > and the job rollback is disabled?

Sounds like we need another state for this. Do you have a suggestion? 
INSTANCE_UPDATE_FAILED ?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50805
---


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/#review50900
---

Ship it!


Ship It!

- Bill Farner


On Aug. 15, 2014, 11:57 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24744/
> ---
> 
> (Updated Aug. 15, 2014, 11:57 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The job lock is now acquired by the startJobUpdate call.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7ef28858ad290c74248b89c49d2a684eb1c7127e 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 62de93bb942adab47590112b76c365fac7877371 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  649afa24b2cfc9a1d67d350473e439d209bd720c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 38bc9ed1ea17cac00920a2f1d066458badd7b4bb 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 96db25d9f7492a0d49e98af27f17b6cee19f5a49 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ab74db34d61e72c50d4ac9252b02cbf69377d194 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
>   src/test/resources/org/apache/aurora/gen/storage.thrift.md5 
> 45762990d33969bedde7340887cde16a535e99fe 
> 
> Diff: https://reviews.apache.org/r/24744/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> ./pants src/test/python/apache/aurora/client/api::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[Bill Farner]

> On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
> > 
> >
> > What action is going to be used for an instance that failed to update 
> > and the job rollback is disabled?
> 
> David McLaughlin wrote:
> Sounds like we need another state for this. Do you have a suggestion? 
> INSTANCE_UPDATE_FAILED ?

INSTANCE_UPDATE_FAILED SGTM


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50805
---


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[Bill Farner]

> On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
> > 
> >
> > What action is going to be used for an instance that failed to update 
> > and the job rollback is disabled?
> 
> David McLaughlin wrote:
> Sounds like we need another state for this. Do you have a suggestion? 
> INSTANCE_UPDATE_FAILED ?
> 
> Bill Farner wrote:
> INSTANCE_UPDATE_FAILED SGTM

And FWIW disabled rollback isn't the only case for this.  It can happen any 
time max_failed_instances > 0.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50805
---


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[Maxim Khutornenko]

> On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
> > 
> >
> > What action is going to be used for an instance that failed to update 
> > and the job rollback is disabled?
> 
> David McLaughlin wrote:
> Sounds like we need another state for this. Do you have a suggestion? 
> INSTANCE_UPDATE_FAILED ?
> 
> Bill Farner wrote:
> INSTANCE_UPDATE_FAILED SGTM
> 
> Bill Farner wrote:
> And FWIW disabled rollback isn't the only case for this.  It can happen 
> any time max_failed_instances > 0.

Do we need a separate INSTANCE_ROLLBACK_FAILED state to set apart a rollback 
failure? Otherwise, we may see two actions in the log: one from a forward 
failure and another one from a rollback failure.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50805
---


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[Bill Farner]

> On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
> > 
> >
> > What action is going to be used for an instance that failed to update 
> > and the job rollback is disabled?
> 
> David McLaughlin wrote:
> Sounds like we need another state for this. Do you have a suggestion? 
> INSTANCE_UPDATE_FAILED ?
> 
> Bill Farner wrote:
> INSTANCE_UPDATE_FAILED SGTM
> 
> Bill Farner wrote:
> And FWIW disabled rollback isn't the only case for this.  It can happen 
> any time max_failed_instances > 0.
> 
> Maxim Khutornenko wrote:
> Do we need a separate INSTANCE_ROLLBACK_FAILED state to set apart a 
> rollback failure? Otherwise, we may see two actions in the log: one from a 
> forward failure and another one from a rollback failure.

I'm ambivalent, and leave it up to what we want to do display-side.  I don't 
plan to have these entries influence the updater.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50805
---


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/
---

(Updated Aug. 18, 2014, 5:49 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Failure states.


Repository: aurora


Description
---

Added some more items to the JobUpdateAction enum. Not married to the labels 
I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
finer-grained actions. 


Expected actions:

1) instance update: INSTANCE_UPDATED
2) instance remove: INSTANCE_REMOVED
3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
4) noop: INSTANCE_SKIPPED
5) instance rolled back: INSTANCE_ROLLED_BACK


Diffs (updated)
-

  src/main/thrift/org/apache/aurora/gen/api.thrift 
af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
f695b85514bcc5cedb16e962124af3db052cb17a 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
21a05f6939da1dd7fc15cf6336bc3fee283f16ab 

Diff: https://reviews.apache.org/r/24720/diff/


Testing
---

./gradlew -Pq build


Thanks,

David McLaughlin

Re: Review Request 24720: Expand actions in JobUpdateAction

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50910
---

Ship it!


Ship It!

- Maxim Khutornenko


On Aug. 18, 2014, 5:49 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 18, 2014, 5:49 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50911
---

Ship it!


Ship It!

- Bill Farner


On Aug. 18, 2014, 5:49 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 18, 2014, 5:49 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 24720: Expand actions in JobUpdateAction

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/
---

(Updated Aug. 18, 2014, 5:59 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

rebase. (also, a reminder that I need someone to commit this for me.)


Repository: aurora


Description
---

Added some more items to the JobUpdateAction enum. Not married to the labels 
I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
finer-grained actions. 


Expected actions:

1) instance update: INSTANCE_UPDATED
2) instance remove: INSTANCE_REMOVED
3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
4) noop: INSTANCE_SKIPPED
5) instance rolled back: INSTANCE_ROLLED_BACK


Diffs (updated)
-

  src/main/thrift/org/apache/aurora/gen/api.thrift 
af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
f669dbe472ea2171b0ac898b71626f0b25c0a9ec 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
78798f29bfbcf04b48953d050e498b3cad2248fb 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
  src/test/resources/org/apache/aurora/gen/storage.thrift.md5 
45762990d33969bedde7340887cde16a535e99fe 

Diff: https://reviews.apache.org/r/24720/diff/


Testing
---

./gradlew -Pq build


Thanks,

David McLaughlin

Re: Review Request 24720: Expand actions in JobUpdateAction

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50913
---

Ship it!


This is now on master, thanks!

commit 4f6093b
Author: David McLaughlin 
Date:   Mon Aug 18 11:27:16 2014 -0700

Expand actions in JobUpdateAction

Reviewed at https://reviews.apache.org/r/24720/

- Bill Farner


On Aug. 18, 2014, 5:59 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> ---
> 
> (Updated Aug. 18, 2014, 5:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f669dbe472ea2171b0ac898b71626f0b25c0a9ec 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 78798f29bfbcf04b48953d050e498b3cad2248fb 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
>   src/test/resources/org/apache/aurora/gen/storage.thrift.md5 
> 45762990d33969bedde7340887cde16a535e99fe 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Review Request 24813: Add a job update controller interface.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-613
https://issues.apache.org/jira/browse/AURORA-613


Repository: aurora


Description
---

Add a job update controller interface.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/24813/diff/


Testing
---


Thanks,

Bill Farner

Review Request 24815: Refactoring SchedulerCore final part.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24815/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-94
https://issues.apache.org/jira/browse/AURORA-94


Repository: aurora


Description
---

Moving the last bits of functionality out of SchedulerCore. 

Also, preparing the ground for task validation logic reuse in updater code.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/base/ScheduleException.java 
e060e5ec88a0ab311415eaa638cf693c99c40049 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
62202810fd5829545fc77b91a20d1bb433a4916a 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
c636fd7fde8b592b167da8e5e9651ac772bc23de 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f 
  src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
6e062b39175255264020bbb1cbd485de9a114a20 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
6ad104b050aabecad1dadc975c27d9d3603659bf 
  src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
cc1eee4e19c092c0d401558ac01b54627f2d1290 
  src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7ef28858ad290c74248b89c49d2a684eb1c7127e 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
c7ae7db16e82c722fae1bccb9178f5ec203e91e5 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
62dce07b42af02d25b788e763e4e2a026dd2d483 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
fa611a913bad40a8c0515c578b394c460340e574 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
1678411ad5c25e74f8b6d004bf491ea26ca0 
  src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageSchedulerCoreImplTest.java
 35bed104d838596abcbb5abd5cad29592b384dfa 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 649afa24b2cfc9a1d67d350473e439d209bd720c 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
43265fdab1ae900fb828374f6c69e562def2d682 

Diff: https://reviews.apache.org/r/24815/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/
---

(Updated Aug. 18, 2014, 8:10 p.m.)


Review request for Aurora, Mark Chu-Carroll and Bill Farner.


Changes
---

Rebasing.


Repository: aurora


Description
---

The job lock is now acquired by the startJobUpdate call.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7ef28858ad290c74248b89c49d2a684eb1c7127e 
  src/main/python/apache/aurora/client/api/__init__.py 
62de93bb942adab47590112b76c365fac7877371 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
2b376d663b3bc9264965db58ef89de59b10169ad 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 649afa24b2cfc9a1d67d350473e439d209bd720c 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
38bc9ed1ea17cac00920a2f1d066458badd7b4bb 
  src/test/python/apache/aurora/client/api/test_api.py 
96db25d9f7492a0d49e98af27f17b6cee19f5a49 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
ab74db34d61e72c50d4ac9252b02cbf69377d194 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
0be4d96782769a2097ce10f8872c4300e9f74e5a 

Diff: https://reviews.apache.org/r/24744/diff/


Testing
---

gradle -Pq build
./pants src/test/python/apache/aurora/client/api::


Thanks,

Maxim Khutornenko

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/#review50930
---

Ship it!


Looks fine, but I don't really understand the reasoning.

To me, it seems like expecting someone to have a lockid for a pause or a resume 
call is a good idea. It allows someone to pass responsibility for an ongoing 
update to another person, without having to allow anyone at all to 
interrupt/resume it.

- Mark Chu-Carroll


On Aug. 18, 2014, 4:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24744/
> ---
> 
> (Updated Aug. 18, 2014, 4:10 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The job lock is now acquired by the startJobUpdate call.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7ef28858ad290c74248b89c49d2a684eb1c7127e 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 62de93bb942adab47590112b76c365fac7877371 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 2b376d663b3bc9264965db58ef89de59b10169ad 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  649afa24b2cfc9a1d67d350473e439d209bd720c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 38bc9ed1ea17cac00920a2f1d066458badd7b4bb 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 96db25d9f7492a0d49e98af27f17b6cee19f5a49 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ab74db34d61e72c50d4ac9252b02cbf69377d194 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 0be4d96782769a2097ce10f8872c4300e9f74e5a 
> 
> Diff: https://reviews.apache.org/r/24744/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> ./pants src/test/python/apache/aurora/client/api::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

[Maxim Khutornenko]

> On Aug. 18, 2014, 8:16 p.m., Mark Chu-Carroll wrote:
> > Looks fine, but I don't really understand the reasoning.
> > 
> > To me, it seems like expecting someone to have a lockid for a pause or a 
> > resume call is a good idea. It allows someone to pass responsibility for an 
> > ongoing update to another person, without having to allow anyone at all to 
> > interrupt/resume it.

With the async updater sharing a lock among users or even accross same user 
sessions becomes a problem. It should be easier to allow update mutations to 
any authorized user, which is true even today (e.g. cancel_update).


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/#review50930
---


On Aug. 18, 2014, 8:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24744/
> ---
> 
> (Updated Aug. 18, 2014, 8:10 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The job lock is now acquired by the startJobUpdate call.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7ef28858ad290c74248b89c49d2a684eb1c7127e 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 62de93bb942adab47590112b76c365fac7877371 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 2b376d663b3bc9264965db58ef89de59b10169ad 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  649afa24b2cfc9a1d67d350473e439d209bd720c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 38bc9ed1ea17cac00920a2f1d066458badd7b4bb 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 96db25d9f7492a0d49e98af27f17b6cee19f5a49 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ab74db34d61e72c50d4ac9252b02cbf69377d194 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 0be4d96782769a2097ce10f8872c4300e9f74e5a 
> 
> Diff: https://reviews.apache.org/r/24744/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> ./pants src/test/python/apache/aurora/client/api::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24813: Add a job update controller interface.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/#review50935
---

Ship it!



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java


s/../.


- Maxim Khutornenko


On Aug. 18, 2014, 7:41 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24813/
> ---
> 
> (Updated Aug. 18, 2014, 7:41 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
> https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a job update controller interface.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 24813: Add a job update controller interface.

[Bill Farner]

> On Aug. 18, 2014, 9:14 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, 
> > line 64
> > 
> >
> > s/../.

Fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/#review50935
---


On Aug. 18, 2014, 7:41 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24813/
> ---
> 
> (Updated Aug. 18, 2014, 7:41 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
> https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a job update controller interface.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 24813: Add a job update controller interface.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/
---

(Updated Aug. 18, 2014, 9:19 p.m.)


Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-613
https://issues.apache.org/jira/browse/AURORA-613


Repository: aurora


Description
---

Add a job update controller interface.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/24813/diff/


Testing
---


Thanks,

Bill Farner

Review Request 24823: Use convenience function in Numbers to group instance IDs.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24823/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

Only realized after review that i had written very similar code once before :-)


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java 
f21f27cdce457c7bc09670a68a865159daff5559 

Diff: https://reviews.apache.org/r/24823/diff/


Testing
---

./gradlew build -Pq


Thanks,

Bill Farner

Re: Review Request 24823: Use convenience function in Numbers to group instance IDs.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24823/#review50941
---

Ship it!


Ship It!

- Maxim Khutornenko


On Aug. 18, 2014, 11:33 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24823/
> ---
> 
> (Updated Aug. 18, 2014, 11:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Only realized after review that i had written very similar code once before 
> :-)
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java 
> f21f27cdce457c7bc09670a68a865159daff5559 
> 
> Diff: https://reviews.apache.org/r/24823/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24827/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-613
https://issues.apache.org/jira/browse/AURORA-613


Repository: aurora


Description
---

asdf


Add a layer that forwards pubsub events to the JobUpdateController.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
066238cfe51557123d1e055e47bd52aeed9d5579 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
3bbd6dda3e6823e1851efa3d45ea7fa5000d0f39 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 
PRE-CREATION 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
a78a4d849e545000725a39fae49f406422c39da0 
  
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/24827/diff/


Testing
---

./gradlew build -Pq


Thanks,

Bill Farner

Review Request 24835: Implementing pause/resume/abort APIs.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24835/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-649
https://issues.apache.org/jira/browse/AURORA-649


Repository: aurora


Description
---

Implementing pause/resume/abort APIs.

Also, dropping JobUpdater in favor of JobUpdateController to avoid a 
"SchedulerCore fate" (thin proxy interfaces with little to no extra logic).


Diffs
-

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
61ba4b2c292bb1a76f6133c7212b3cacded6f693 
  src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java 
eb472e422bdc2e324a4aa48e911c7b13c4639674 
  src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java 
2c6460028fc17c6fb04b8b92d91ed53ff333 
  src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
cc1eee4e19c092c0d401558ac01b54627f2d1290 
  src/main/java/org/apache/aurora/scheduler/state/UUIDGenerator.java 
3938c302a68d3ccdda0dc33418a5db00a717bffd 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
0d8d75bfd4db15d5b00302fa37f90a9e85cce95e 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
066238cfe51557123d1e055e47bd52aeed9d5579 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
3bbd6dda3e6823e1851efa3d45ea7fa5000d0f39 
  src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java 
90b4e8af94c801792658646a01e5756810b9f787 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 04abeeb78b63d65b6b09cf1ebe277324a18a13b0 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
43265fdab1ae900fb828374f6c69e562def2d682 

Diff: https://reviews.apache.org/r/24835/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko