On Sept. 23, 2014, 1:01 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 268
https://reviews.apache.org/r/25812/diff/1/?file=694286#file694286line268
Remember - javadoc is like html. These newlines are not preserved
unless you do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/
---
(Updated Sept. 23, 2014, 4:12 p.m.)
Review request for Aurora, David
On Sept. 23, 2014, 1:01 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1350
https://reviews.apache.org/r/25812/diff/1/?file=694289#file694289line1350
How about 'validateInstanceAddition'? I'm not tied to the name,
On Sept. 23, 2014, 1:01 a.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 547
https://reviews.apache.org/r/25812/diff/1/?file=694290#file694290line547
Can you update JobUpdateControllerImpl to use this as well?
Also, you should wrap this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/
---
(Updated Sept. 23, 2014, 4:48 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review54282
---
psutil 2.1.2 now available, since we are upgrading here might as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/#review54315
---
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/#review54316
---
LGTM with some additional test coverage for the new accounting. I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-741
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/#review54328
---
Ship it!
LGTM with a few minor changes.
On Sept. 23, 2014, 8:48 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java,
line 87
https://reviews.apache.org/r/25953/diff/1/?file=703165#file703165line87
You should include a precondition check for desiredState being set or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/
---
(Updated Sept. 23, 2014, 9:10 p.m.)
Review request for Aurora and Bill Farner.
On Sept. 23, 2014, 1:07 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 180
https://reviews.apache.org/r/25812/diff/3/?file=702913#file702913line180
Unless I'm missing something here, this will throw when there are
multiple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/#review54334
---
Ship it!
LGTM mod Bill's comments and Impl suggestion
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25955/
---
Review request for Aurora and David McLaughlin.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25955/#review54337
---
Ship it!
Ship It!
- David McLaughlin
On Sept. 23, 2014, 9:35
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25958/
---
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25958/#review54345
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 23, 2014, 10:08
On Sept. 23, 2014, 8:10 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 174
https://reviews.apache.org/r/25812/diff/3/?file=702913#file702913line174
Accept JobUpdateStore here, that's all that is used.
Done.
On Sept. 23, 2014,
On Sept. 23, 2014, 8:07 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1469
https://reviews.apache.org/r/25812/diff/3/?file=702916#file702916line1469
Refactor this to live outside the Impl class?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/
---
(Updated Sept. 23, 2014, 11:08 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25963/
---
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25963/#review54363
---
I just realised, we might want to hide the nav if
On Sept. 23, 2014, 11:48 p.m., David McLaughlin wrote:
I just realised, we might want to hide the nav if beta_updates_enabled is
false.
Don't worry abou that - we'll drop the flag entirely soon. Just wanted to put
a gate in place for now.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/
---
Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25969/
---
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25963/#review54371
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25958/#review54372
---
Ship it!
In the future, please allow everyone on the 'People' line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25972/
---
Review request for Aurora, Joe Smith and Kevin Sweeney.
Bugs: AURORA-175
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25963/#review54373
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 23, 2014, 11:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/
---
Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review54378
---
I'm not sure a TASK_FAILED: KeyError: 'getpwuid() uid:0 not found'
32 matches
Mail list logo