Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

2014-12-04 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/#review63783 --- Ship it! Ship It! - David McLaughlin On Dec. 3, 2014, 2:13

Re: Review Request 28660: Reduce minimum branch coverage requirement to avoid flakiness.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28660/#review63707 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 3, 2014, 7:02

Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 28696: Use abstract decorators in CommandLine class.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review63823 --- Master (11da34c) is green with this patch.

Re: Review Request 28660: Reduce minimum branch coverage requirement to avoid flakiness.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28660/#review63708 --- Ship it! Master (4405031) is green with this patch.

Review Request 28692: Simplify logging in the Aurora client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63734 --- Ship it! Master (9b1e9fb) is green with this patch.

Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28693/ --- Review request for Aurora. Repository: aurora Description --- This

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28693/ --- (Updated Dec. 3, 2014, 10:36 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63737 --- Ship it! Ship It! - Zameer Manji On Dec. 3, 2014, 12:34 p.m.,

Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-947

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63733 --- src/main/python/apache/aurora/client/base.py

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/#review63714 --- David, Kevin - ping? - Bill Farner On Dec. 3, 2014, 2:13 a.m.,

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Bill Farner
On Dec. 3, 2014, 2:06 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 56 https://reviews.apache.org/r/28607/diff/2/?file=780608#file780608line56 This can be further simplified (unless you are concerned about

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- (Updated Dec. 3, 2014, 6:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/#review63793 --- Ship it! Ship It! - Zameer Manji On Dec. 3, 2014, 4:36 p.m.,

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63700 --- Ship it! Master (8959b49) is green with this patch.

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/#review63796 ---

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28693/#review63859 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

2014-12-04 Thread Maxim Khutornenko
On Dec. 4, 2014, 5:21 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/__init__.py, lines 172-175 https://reviews.apache.org/r/28693/diff/1/?file=782496#file782496line172 Why not keeping @abstractmethod attributes and dropping the return statements instead?

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28693/ --- (Updated Dec. 4, 2014, 10:14 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28692: Simplify logging in the Aurora client.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/#review63869 --- Can you paste a few examples from vagrant (preferrably job update)

Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 28474: Added manual perf tests for the scheduling pipeline.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28474/#review63888 --- Discarding this in favor of benchmark harness started in

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review63889 --- Ship it! Master (11da34c) is green with this patch.

Re: Review Request 28692: Simplify logging in the Aurora client.

2014-12-04 Thread Zameer Manji
On Dec. 4, 2014, 10:21 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/context.py, line 94 https://reviews.apache.org/r/28692/diff/1/?file=782492#file782492line94 Why is this jumping from TRANSCRIPT to INFO? Will every invocation now log the entire config?

Re: Review Request 28692: Simplify logging in the Aurora client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- (Updated Dec. 4, 2014, 11:54 a.m.) Review request for Aurora, Maxim

Re: Review Request 28692: Simplify logging in the Aurora client.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/#review63894 --- Ship it! Master (11da34c) is green with this patch.

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review63896 --- build.gradle https://reviews.apache.org/r/28710/#comment106209

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-04 Thread Maxim Khutornenko
On Dec. 4, 2014, 8:12 p.m., Kevin Sweeney wrote: build.gradle, line 23 https://reviews.apache.org/r/28710/diff/1/?file=782698#file782698line23 Looks like you want the new-style block here instead: https://plugins.gradle.org/plugin/me.champeau.gradle.jmh Great

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review63900 --- Ship it! Master (11da34c) is green with this patch.

Review Request 28728: Collect HTTP stats on every request.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28728/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 28728: Collect HTTP stats on every request.

2014-12-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28728/#review63930 --- Ship it! Ship It! - Kevin Sweeney On Dec. 4, 2014, 3:44 p.m.,

Re: Review Request 28728: Collect HTTP stats on every request.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28728/#review63932 --- Master (11da34c) is green with this patch.

Re: Review Request 28728: Collect HTTP stats on every request.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28728/#review63933 --- Ship it! This is now on master ``` $ git log -1 origin/master

Review Request 28725: Remove redundant storage.write.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28725/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 28725: Remove redundant storage.write.

2014-12-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28725/#review63936 --- Ship it! Ship It! - Kevin Sweeney On Dec. 4, 2014, 4:20 p.m.,

Re: Review Request 28725: Remove redundant storage.write.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28725/#review63937 --- Master (d26a30e) is green with this patch.

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Bill Farner
On Dec. 4, 2014, 1:12 a.m., Kevin Sweeney wrote: buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy, line 124 https://reviews.apache.org/r/28682/diff/1/?file=782159#file782159line124 Override this in the thriftEntities block in the build.gradle, not in the

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/ --- (Updated Dec. 5, 2014, 12:58 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/#review63943 --- Master (fd37f0d) is green with this patch.

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/ --- (Updated Dec. 5, 2014, 1:09 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Bill Farner
On Dec. 3, 2014, 8:57 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/base.py, line 44 https://reviews.apache.org/r/28674/diff/1/?file=782026#file782026line44 This uses a different quoting style than the rest of the file. Fixed. On Dec. 3, 2014, 8:57 p.m.,

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63946 --- Ship it! Master (fd37f0d) is green with this patch.

Review Request 28731: Implemented TaskScheduler benchmarks.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/#review63947 --- This patch does not apply cleanly on master (fd37f0d), do you need

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

2014-12-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63948 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 1:09

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

2014-12-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/#review63949 --- Ship it! Ship It! - Kevin Sweeney On Dec. 4, 2014, 4:58 p.m.,

Review Request 28738: Remove unused DefaultServlet subclass.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28738/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 28738: Remove unused DefaultServlet subclass.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28738/#review63959 --- Master (905137f) is green with this patch.

Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review63972 --- This patch does not apply cleanly on master (905137f), do you need

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 4, 2014, 11:26 p.m.) Review request for Aurora, Maxim

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review63974 --- Ship it! Master (905137f) is green with this patch.

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 4, 2014, 11:43 p.m.) Review request for Aurora, Maxim