Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32836 --- Ship it! I say ship this, and I imagine more will fall out as we start to kick the tyres on the new client. Thanks for your patience with the review process! src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17185/#comment61841 this one's still missing a Usage (all the others look good) src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17185/#comment61842 kill (dup with 243). also could you add an empty line here? (c.f. 261, 270) src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17185/#comment61840 for future reference/cleanup - would be good to have something like https://cgit.twitter.biz/science/tree/src/python/twitter/aurora/client/api_internal/deployment_cli.py#n214 maybe print_out could support an indent= kwarg? - Jonathan Boulle On Jan. 27, 2014, 2:56 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 2:56 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 and aurora-54 https://issues.apache.org/jira/browse/aurora-53 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Merged all of the open clientv2 reviews into one unified change. - Add clientv2 implementation of job status with jobkey wildcard support. - Add clientv2 implementations of job update and job list - Add clientv2 implementation of job restart - Add clientv2 implementation of job cancel_update - Extract more common options into options.py. - General code cleanup. This supersedes the following reviews: - https://reviews.apache.org/r/17153/ - https://reviews.apache.org/r/17051/ - https://reviews.apache.org/r/17154/ - https://reviews.apache.org/r/16306/ Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/commands/core.py 13657c4827072c4f67e0b05034e575616f02338b src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17185/diff/ Testing --- = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 3 items src/test/python/apache/aurora/admin/test_mesos_maintenance.py ... === 3 passed in 0.29 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.30 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.22 seconds ===
Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 1:21 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- More review changes. Bugs: aurora-53 and aurora-54 https://issues.apache.org/jira/browse/aurora-53 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Merged all of the open clientv2 reviews into one unified change. - Add clientv2 implementation of job status with jobkey wildcard support. - Add clientv2 implementations of job update and job list - Add clientv2 implementation of job restart - Add clientv2 implementation of job cancel_update - Extract more common options into options.py. - General code cleanup. This supersedes the following reviews: - https://reviews.apache.org/r/17153/ - https://reviews.apache.org/r/17051/ - https://reviews.apache.org/r/17154/ - https://reviews.apache.org/r/16306/ Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/commands/core.py 13657c4827072c4f67e0b05034e575616f02338b src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17185/diff/ Testing --- = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 3 items src/test/python/apache/aurora/admin/test_mesos_maintenance.py ... === 3 passed in 0.29 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.30 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.22 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.21 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 0.59 seconds = = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.24 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py
Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32846 --- Ship it! i already shipited two of the previous reviews, so i'm going to defer to jon b's thoroughness for the rest. - Brian Wickman On Jan. 27, 2014, 6:21 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 6:21 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 and aurora-54 https://issues.apache.org/jira/browse/aurora-53 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Merged all of the open clientv2 reviews into one unified change. - Add clientv2 implementation of job status with jobkey wildcard support. - Add clientv2 implementations of job update and job list - Add clientv2 implementation of job restart - Add clientv2 implementation of job cancel_update - Extract more common options into options.py. - General code cleanup. This supersedes the following reviews: - https://reviews.apache.org/r/17153/ - https://reviews.apache.org/r/17051/ - https://reviews.apache.org/r/17154/ - https://reviews.apache.org/r/16306/ Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/commands/core.py 13657c4827072c4f67e0b05034e575616f02338b src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17185/diff/ Testing --- = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 3 items src/test/python/apache/aurora/admin/test_mesos_maintenance.py ... === 3 passed in 0.29 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.30 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.22 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.21 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 0.59 seconds = = test session starts
Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
On Jan. 25, 2014, 6:54 p.m., Jonathan Boulle wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 378 https://reviews.apache.org/r/17185/diff/1/?file=435145#file435145line378 1sp Sorry, don't know what you mean by this. It's a line continuation, so it's indented 4; and I don't see any other extra space. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32577 --- On Jan. 27, 2014, 1:21 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 1:21 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 and aurora-54 https://issues.apache.org/jira/browse/aurora-53 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Merged all of the open clientv2 reviews into one unified change. - Add clientv2 implementation of job status with jobkey wildcard support. - Add clientv2 implementations of job update and job list - Add clientv2 implementation of job restart - Add clientv2 implementation of job cancel_update - Extract more common options into options.py. - General code cleanup. This supersedes the following reviews: - https://reviews.apache.org/r/17153/ - https://reviews.apache.org/r/17051/ - https://reviews.apache.org/r/17154/ - https://reviews.apache.org/r/16306/ Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/commands/core.py 13657c4827072c4f67e0b05034e575616f02338b src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17185/diff/ Testing --- = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 3 items src/test/python/apache/aurora/admin/test_mesos_maintenance.py ... === 3 passed in 0.29 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.30 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.22 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.21 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py
Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32852 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17185/#comment61850 should have clarified: this line = 12 spaces indentation, line 358 = 13 spaces indentation. so maybe you can change the latter instead :-) - Jonathan Boulle On Jan. 27, 2014, 6:21 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 6:21 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 and aurora-54 https://issues.apache.org/jira/browse/aurora-53 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Merged all of the open clientv2 reviews into one unified change. - Add clientv2 implementation of job status with jobkey wildcard support. - Add clientv2 implementations of job update and job list - Add clientv2 implementation of job restart - Add clientv2 implementation of job cancel_update - Extract more common options into options.py. - General code cleanup. This supersedes the following reviews: - https://reviews.apache.org/r/17153/ - https://reviews.apache.org/r/17051/ - https://reviews.apache.org/r/17154/ - https://reviews.apache.org/r/16306/ Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/commands/core.py 13657c4827072c4f67e0b05034e575616f02338b src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17185/diff/ Testing --- = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 3 items src/test/python/apache/aurora/admin/test_mesos_maintenance.py ... === 3 passed in 0.29 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.30 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.22 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.21 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47
Review Request 17412: Quiet noisy status checker debug messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Fix noisy status checker debug log. Diffs - src/main/python/apache/aurora/executor/common/status_checker.py 48e7a442cfb6bda1a6b3891c25f61f0c9003b8a4 Diff: https://reviews.apache.org/r/17412/diff/ Testing --- Thanks, Brian Wickman
Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-30 https://issues.apache.org/jira/browse/AURORA-30 Repository: aurora Description --- Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file. Diffs - 3rdparty/python/BUILD PRE-CREATION aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3 aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568 aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329 aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262 aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6 aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7 aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2 aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627 aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910 aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70 aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3 aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192 aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60 aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4 aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83 aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88 aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479 aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81 aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb6 aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842 src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9 src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4 src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793 src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3 src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472 src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171 src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949 src/main/python/apache/aurora/config/schema/BUILD
Re: Review Request 17412: Quiet noisy status checker debug messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/ --- (Updated Jan. 27, 2014, 9:25 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-56 https://issues.apache.org/jira/browse/AURORA-56 Repository: aurora Description --- Fix noisy status checker debug log. Diffs - src/main/python/apache/aurora/executor/common/status_checker.py 48e7a442cfb6bda1a6b3891c25f61f0c9003b8a4 Diff: https://reviews.apache.org/r/17412/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32887 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/17372/#comment61879 Would be great to have a brief write out here on how primary and secondary are supposed to work together and their consistency/thread-safety expectations. src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/17372/#comment61885 Optional? - Maxim Khutornenko On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/ --- (Updated Jan. 26, 2014, 9:52 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-122 https://issues.apache.org/jira/browse/AURORA-122 Repository: aurora Description --- Add an abstraction for secondary indices, introduce an index on slave host. Diffs - src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32893
---
3rdparty/python/BUILD
https://reviews.apache.org/r/17419/#comment61895
I don't see any good reason to use make_dep over straight up
python_requirements since there's nothing preventing us from doing
python_requirement oneliners:
python_requirement('argparse==1.2.1')
python_requirement('bottle==0.11.6')
...
they will correctly resolve as 3rdparty/python:argparse,
3rdparty/python:bottle, etc.
- Brian Wickman
On Jan. 27, 2014, 8:54 p.m., Jake Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/
---
(Updated Jan. 27, 2014, 8:54 p.m.)
Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
Bugs: AURORA-30
https://issues.apache.org/jira/browse/AURORA-30
Repository: aurora
Description
---
Removes aurora/twitterdeps and moves all external dependency calls to a new
3rdparty/python/BUILD file.
Diffs
-
3rdparty/python/BUILD PRE-CREATION
aurora/twitterdeps/src/python/twitter/common/app/BUILD
f77fea19a50c83bf4b69ffb151de5b13d3146aa3
aurora/twitterdeps/src/python/twitter/common/collections/BUILD
eadff788b625a194e419fab074eca38743595568
aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD
bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
aurora/twitterdeps/src/python/twitter/common/config/BUILD
fdb09af78fcfd400adbb2ca7240af2421057269d
aurora/twitterdeps/src/python/twitter/common/confluence/BUILD
cad6ba1ac79e90302a709b96dae7158f90689262
aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD
4baed1d3a58a2585c951361922f9acdcadeb87b6
aurora/twitterdeps/src/python/twitter/common/decorators/BUILD
d2a378b28456823b84c118a24db160bdd8c00fe7
aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD
199844ff170862d264fe73efbd718e09a12397f2
aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD
358a2bdd6a95af22918eda23ed9aebd0f268230b
aurora/twitterdeps/src/python/twitter/common/http/BUILD
f4460fcd220fc9423d0064ede3e7303aa52d8e5a
aurora/twitterdeps/src/python/twitter/common/lang/BUILD
471c1e51901c42bb658e629123fb3015b1881627
aurora/twitterdeps/src/python/twitter/common/log/BUILD
7dcd83e9910968388cb8d21c7ab765b2e5808910
aurora/twitterdeps/src/python/twitter/common/metrics/BUILD
25f21043d676c0fc16ff774e303d5caa47987d0a
aurora/twitterdeps/src/python/twitter/common/options/BUILD
6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
aurora/twitterdeps/src/python/twitter/common/process/BUILD
661cbec8265105504900ee26edf148ae5e0ba9ac
aurora/twitterdeps/src/python/twitter/common/python/BUILD
88a1eca51588508800694be074a1578a7b2efd9d
aurora/twitterdeps/src/python/twitter/common/quantity/BUILD
479aaae6f21324f496d9061053c45832733e879d
aurora/twitterdeps/src/python/twitter/common/recordio/BUILD
4018def7e375fa9991216b5a360cc9f6e47d9f70
aurora/twitterdeps/src/python/twitter/common/rpc/BUILD
8cc60883829fa8ea911d993cfa3a8ff519691fc3
aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD
1953302370ae4980198effc4aa9e9d5cf0916192
aurora/twitterdeps/src/python/twitter/common/string/BUILD
ed5b958de9e001180036514e35963e1194ff3b5a
aurora/twitterdeps/src/python/twitter/common/testing/BUILD
3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
aurora/twitterdeps/src/python/twitter/common/util/BUILD
807a05385684a01b243eeff3ddf1d2ea8111aa60
aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD
f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD
11cb77ea45a1f569ab655306a948ad9581123c7f
aurora/twitterdeps/src/python/twitter/thermos/common/BUILD
b04ed686c1f3263b82a51ff842f4851dab188b83
aurora/twitterdeps/src/python/twitter/thermos/config/BUILD
4b665533b56c24f2e5f7d2a3334e7e2949e01d88
aurora/twitterdeps/src/python/twitter/thermos/core/BUILD
3039970a26f321447f54f719fcc545310754a479
aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD
b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD
5861a73827a8aa87b6a412cd86428f796bb6
aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD
8a9f8b8f969e02e0f409bc184b302f65323a47ef
aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD
400827cc2e61a54cd4523260aef9339a43a11842
src/main/python/apache/aurora/BUILD.thirdparty
7a43acae1edb5d0474d020a5edabbf687de589f9
src/main/python/apache/aurora/admin/BUILD
530b0cb5fa7b2d970937182638217b46c26824b4
Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32894 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/17372/#comment61900 Does it make sense to special-case the primary-key index here? Seems that the taskId index could implement SecondaryIndex (or just rename SecondaryIndex to Index). - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/ --- (Updated Jan. 26, 2014, 1:52 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-122 https://issues.apache.org/jira/browse/AURORA-122 Repository: aurora Description --- Add an abstraction for secondary indices, introduce an index on slave host. Diffs - src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.
On Jan. 27, 2014, 9:55 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 89 https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line89 Would be great to have a brief write out here on how primary and secondary are supposed to work together and their consistency/thread-safety expectations. Done. On Jan. 27, 2014, 9:55 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 289 https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line289 Optional? Sure, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32887 --- On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/ --- (Updated Jan. 26, 2014, 9:52 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-122 https://issues.apache.org/jira/browse/AURORA-122 Repository: aurora Description --- Add an abstraction for secondary indices, introduce an index on slave host. Diffs - src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.
On Jan. 27, 2014, 10:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 293 https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line293 Does it make sense to special-case the primary-key index here? Seems that the taskId index could implement SecondaryIndex (or just rename SecondaryIndex to Index). I like the idea of a consistent API, but i don't think the current SecondaryIndex fits since it implies non-unique keys. Also, a generalized interface might make the fall-back to a full scan awkward. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32894 --- On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/ --- (Updated Jan. 26, 2014, 9:52 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-122 https://issues.apache.org/jira/browse/AURORA-122 Repository: aurora Description --- Add an abstraction for secondary indices, introduce an index on slave host. Diffs - src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32900 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/ --- (Updated Jan. 26, 2014, 1:52 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-122 https://issues.apache.org/jira/browse/AURORA-122 Repository: aurora Description --- Add an abstraction for secondary indices, introduce an index on slave host. Diffs - src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17412: Quiet noisy status checker debug messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/#review32901 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 1:25 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/ --- (Updated Jan. 27, 2014, 1:25 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-56 https://issues.apache.org/jira/browse/AURORA-56 Repository: aurora Description --- Fix noisy status checker debug log. Diffs - src/main/python/apache/aurora/executor/common/status_checker.py 48e7a442cfb6bda1a6b3891c25f61f0c9003b8a4 Diff: https://reviews.apache.org/r/17412/diff/ Testing --- Thanks, Brian Wickman
Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32916 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 3:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/ --- (Updated Jan. 27, 2014, 3:58 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-126 https://issues.apache.org/jira/browse/AURORA-126 Repository: aurora Description --- Fix regression causing secondary index to store duplicate tasks. Diffs - src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java eaf18dccacaaceb422edcbac0dd2459acd1e19d5 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java ff5bf8993bd143c068df3139479839de8a914c70 Diff: https://reviews.apache.org/r/17432/diff/ Testing --- Added test case to reproduce regression, ./gradlew build passes. Thanks, Bill Farner
Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32917 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 27, 2014, 11:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/ --- (Updated Jan. 27, 2014, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-126 https://issues.apache.org/jira/browse/AURORA-126 Repository: aurora Description --- Fix regression causing secondary index to store duplicate tasks. Diffs - src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java eaf18dccacaaceb422edcbac0dd2459acd1e19d5 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java ff5bf8993bd143c068df3139479839de8a914c70 Diff: https://reviews.apache.org/r/17432/diff/ Testing --- Added test case to reproduce regression, ./gradlew build passes. Thanks, Bill Farner
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32923 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 4:19 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/ --- (Updated Jan. 27, 2014, 4:19 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-30 https://issues.apache.org/jira/browse/AURORA-30 Repository: aurora Description --- Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file. Diffs - 3rdparty/python/BUILD PRE-CREATION aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3 aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568 aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329 aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262 aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6 aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7 aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2 aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627 aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910 aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70 aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3 aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192 aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60 aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4 aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83 aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88 aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479 aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81 aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb6 aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842 src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9 src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4 src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793 src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/commands/BUILD
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32938 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2014, 12:19 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/ --- (Updated Jan. 28, 2014, 12:19 a.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-30 https://issues.apache.org/jira/browse/AURORA-30 Repository: aurora Description --- Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file. Diffs - 3rdparty/python/BUILD PRE-CREATION aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3 aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568 aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329 aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262 aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6 aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7 aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2 aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627 aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910 aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70 aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3 aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192 aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60 aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4 aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83 aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88 aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479 aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81 aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb6 aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842 src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9 src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4 src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793 src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/commands/BUILD
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32937 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2014, 12:19 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/ --- (Updated Jan. 28, 2014, 12:19 a.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-30 https://issues.apache.org/jira/browse/AURORA-30 Repository: aurora Description --- Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file. Diffs - 3rdparty/python/BUILD PRE-CREATION aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3 aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568 aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329 aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262 aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6 aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7 aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2 aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627 aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910 aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70 aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3 aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192 aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60 aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4 aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83 aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88 aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479 aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81 aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb6 aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842 src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9 src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4 src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793 src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/commands/BUILD
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review32945
---
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
https://reviews.apache.org/r/17430/#comment61989
Thinking out loud, a helper function reduces some duplication, and wrapping
in a HashMultimap puts the values in a Set for you (so you can skip the
ImmutableSet.copyOf later):
private static T MultimapString, IJobKey mapByRole(
IterableT entities,
FunctionT, IJobKey keyExtractor) {
return HashMultimap.create(
Multimaps.index(Iterables.transform(tasks, keyExtractor)));
}
Then, your calling code is:
MultimapString, IJobKey jobsByRole = mapByRole(
Storage.weaklyConsistentFetchTasks(storage, Query.unscoped()),
Tasks.SCHEDULED_TO_JOB_KEY);
MultimapString, IJobKey cronJobsByRole =
mapByRole(cronJobManager.getJobs(), JobKeys.FROM_CONFIG);
(note: you'll want to tweak line wrapping, trying to make it pretty in the
comment box here)
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
https://reviews.apache.org/r/17430/#comment61988
Does this test reproduce the bug? I would have expected to see something
like two tasks in the same job resulting in a job count of 1.
- Bill Farner
On Jan. 27, 2014, 11:45 p.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/
---
(Updated Jan. 27, 2014, 11:45 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
---
Updated test cases to catch this bug.
Diffs
-
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
cf9099f307efa23ca34634e3512d9cdbebfa82f2
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
6cefdfad469a9b69a5291ad46be1df14b443472e
Diff: https://reviews.apache.org/r/17430/diff/
Testing
---
gradle clean build
gradle run - tested in local UI.
Thanks,
Suman Karumuri
Re: Review Request 17347: Added non-prod consumption info to getQuota call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/#review32946 --- src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/17347/#comment61990 This confirms my fear of the slippery slope of Quota becoming an overloaded term. I'd love to call this something that doesn't already have an implied meaning about production=True. Mind taking a detour to address this TODO? grep -R ResourceAggregate src/main/java/ src/main/java//org/apache/aurora/scheduler/quota/Quotas.java: // TODO(Suman Karumuri): Rename Quota to something more meaningful (ex: ResourceAggregate) It's really important to do this before we cut our first release (in the next few weeks in theory), since we need to adhere to a stable API at that point. - Bill Farner On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/ --- (Updated Jan. 25, 2014, 12:48 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-65 https://issues.apache.org/jira/browse/AURORA-65 Repository: aurora Description --- This call will be used by the role page in the UI. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17347/diff/ Testing --- gradle clean build. Thanks, Suman Karumuri
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32947 --- Can you also attach the JIRA issue please? - Bill Farner On Jan. 27, 2014, 11:45 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 27, 2014, 11:45 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
