---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/#review32992
---
src/main/python/apache/aurora/client/cli/__init__.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/
---
(Updated Jan. 28, 2014, 10:23 a.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17457/
---
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: aurora-80
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17457/#review32997
---
src/test/sh/org/apache/aurora/e2e/flask/BUILD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/#review33014
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 24, 2014, 1:28 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/#review33035
---
Ship it!
cool, drive-by LGTM!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/
---
(Updated Jan. 28, 2014, 8:51 p.m.)
Review request for Aurora, Kevin Sweeney
On Jan. 28, 2014, 3:37 a.m., Bill Farner wrote:
Can you also attach the JIRA issue please?
Done.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review32947
On Jan. 28, 2014, 3:32 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 384
https://reviews.apache.org/r/17430/diff/1/?file=451962#file451962line384
Thinking out loud, a helper function reduces some duplication, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review33041
---
src/main/thrift/org/apache/aurora/gen/api.thrift
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17464/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17464/#review33045
---
Ship it!
Ship It!
- Bill Farner
On Jan. 28, 2014, 9:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review33054
---
Kevin — ping? Presumably you can review while i fix up Maxim's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review32551
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/
---
(Updated Jan. 28, 2014, 10:17 p.m.)
Review request for Aurora, Kevin Sweeney
On Jan. 28, 2014, 9:02 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 1087
https://reviews.apache.org/r/17430/diff/2/?file=453063#file453063line1087
This task needs to be different from task1 in some way,
On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 42
https://reviews.apache.org/r/16873/diff/1/?file=423020#file423020line42
Missing comments for public methods in this class?
We typically don't bother
On Jan. 28, 2014, 9:50 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java,
lines 543-546
https://reviews.apache.org/r/16873/diff/1/?file=423022#file423022line543
This seems like a big enough gotcha to warrant filing a ticket.
On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 77
https://reviews.apache.org/r/16873/diff/1/?file=423020#file423020line77
Should these be javadoc comments instead?
Good call, done.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/
---
(Updated Jan. 28, 2014, 11:11 p.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review33068
---
build-support/release/tag-release
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/
---
(Updated Jan. 28, 2014, 11:32 p.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/
---
(Updated Jan. 29, 2014, 12:09 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review33074
---
Ship it!
Ship It!
- Bill Farner
On Jan. 28, 2014, 10:17 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review33076
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 28, 2014, 2:17 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review33077
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 28, 2014, 3:32 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17475/
---
Review request for Aurora, Vinod Kone, Bill Farner, and Brian Wickman.
Bugs:
27 matches
Mail list logo