Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review32992 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/17270/#comment62125 I'll add a note about this to the code, but it's also worth explaining here. It's not intended to be truly lazy registration; it's explicit registration, but giving things a chance to initialize before they're registered. The idea is that a command-line object could peek at its environment, and decide whether or not a noun is appropriate. For example, you could have specific commands in the command-line tool for checking AWS quotas - but you don't even want those to be registered if the clusters file doesn't declare and AWS clusters. - Mark Chu-Carroll On Jan. 23, 2014, 6:10 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 23, 2014, 6:10 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 28, 2014, 10:23 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Addressed wfarner's review comments. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs (updated) - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. = 6 passed in 0.10 seconds == test session starts platform darwin -- Python 2.7.2 --
Review Request 17457: Initial version of an end-to-end test using vagrant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-80 https://issues.apache.org/jira/browse/aurora-80 Repository: aurora Description --- Got an initial version of the end-to-end test working. Currently creates a job, probes it via the scheduler pages, updates it, and kills it. AURORA-127 will extend this to run multiple instances; AURORA-125 will extend this to use aurora run and aurora ssh to probe the running tasks. Diffs - src/test/sh/org/apache/aurora/e2e/flask/BUILD PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh PRE-CREATION Diff: https://reviews.apache.org/r/17457/diff/ Testing --- [sun-wukong incubator-aurora (e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. Cloning into '/home/vagrant/test_dev'... done. Already on 'e2e' Already up-to-date. + VIRTUALENV_VERSION=1.10.1 + which python2.7 ++ which python2.7 + PY=/usr/bin/python2.7 + echo 'Using /usr/bin/python2.7' Using /usr/bin/python2.7 + '[' -f build-support/virtualenv-1.10.1/BOOTSTRAPPED ']' + pushd build-support ~/test_dev/build-support ~/test_dev + curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.10.1.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1294k 100 1294k0 0 3261k 0 --:--:-- --:--:-- --:--:-- 3817k + tar zxvf virtualenv-1.10.1.tar.gz virtualenv-1.10.1/ virtualenv-1.10.1/AUTHORS.txt virtualenv-1.10.1/bin/ virtualenv-1.10.1/bin/rebuild-script.py virtualenv-1.10.1/docs/ virtualenv-1.10.1/docs/_theme/ virtualenv-1.10.1/docs/_theme/nature/ virtualenv-1.10.1/docs/_theme/nature/static/ virtualenv-1.10.1/docs/_theme/nature/static/nature.css_t virtualenv-1.10.1/docs/_theme/nature/static/pygments.css virtualenv-1.10.1/docs/_theme/nature/theme.conf virtualenv-1.10.1/docs/conf.py virtualenv-1.10.1/docs/index.rst virtualenv-1.10.1/docs/make.bat virtualenv-1.10.1/docs/Makefile virtualenv-1.10.1/docs/news.rst virtualenv-1.10.1/LICENSE.txt virtualenv-1.10.1/MANIFEST.in virtualenv-1.10.1/PKG-INFO virtualenv-1.10.1/README.rst virtualenv-1.10.1/scripts/ virtualenv-1.10.1/scripts/virtualenv virtualenv-1.10.1/setup.cfg virtualenv-1.10.1/setup.py virtualenv-1.10.1/virtualenv.egg-info/ virtualenv-1.10.1/virtualenv.egg-info/dependency_links.txt virtualenv-1.10.1/virtualenv.egg-info/entry_points.txt virtualenv-1.10.1/virtualenv.egg-info/not-zip-safe virtualenv-1.10.1/virtualenv.egg-info/PKG-INFO virtualenv-1.10.1/virtualenv.egg-info/SOURCES.txt virtualenv-1.10.1/virtualenv.egg-info/top_level.txt virtualenv-1.10.1/virtualenv.py virtualenv-1.10.1/virtualenv_embedded/ virtualenv-1.10.1/virtualenv_embedded/activate.bat virtualenv-1.10.1/virtualenv_embedded/activate.csh virtualenv-1.10.1/virtualenv_embedded/activate.fish virtualenv-1.10.1/virtualenv_embedded/activate.ps1 virtualenv-1.10.1/virtualenv_embedded/activate.sh virtualenv-1.10.1/virtualenv_embedded/activate_this.py virtualenv-1.10.1/virtualenv_embedded/deactivate.bat virtualenv-1.10.1/virtualenv_embedded/distutils-init.py virtualenv-1.10.1/virtualenv_embedded/distutils.cfg virtualenv-1.10.1/virtualenv_embedded/site.py virtualenv-1.10.1/virtualenv_support/ virtualenv-1.10.1/virtualenv_support/__init__.py virtualenv-1.10.1/virtualenv_support/pip-1.4.1.tar.gz virtualenv-1.10.1/virtualenv_support/setuptools-0.9.8.tar.gz + touch virtualenv-1.10.1/BOOTSTRAPPED ~/test_dev + popd + exec /usr/bin/python2.7 build-support/virtualenv-1.10.1/virtualenv.py /tmp/pants.BqUkIw/tcp New python executable in /tmp/pants.BqUkIw/tcp/bin/python2.7 Also creating executable in /tmp/pants.BqUkIw/tcp/bin/python Installing
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review32997 --- src/test/sh/org/apache/aurora/e2e/flask/BUILD https://reviews.apache.org/r/17457/#comment62126 requirements moved to global location in AURORA-30 to 3rdparty/python/BUILD - Jake Farrell On Jan. 28, 2014, 4:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Jan. 28, 2014, 4:24 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-80 https://issues.apache.org/jira/browse/aurora-80 Repository: aurora Description --- Got an initial version of the end-to-end test working. Currently creates a job, probes it via the scheduler pages, updates it, and kills it. AURORA-127 will extend this to run multiple instances; AURORA-125 will extend this to use aurora run and aurora ssh to probe the running tasks. Diffs - src/test/sh/org/apache/aurora/e2e/flask/BUILD PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh PRE-CREATION Diff: https://reviews.apache.org/r/17457/diff/ Testing --- [sun-wukong incubator-aurora (e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. Cloning into '/home/vagrant/test_dev'... done. Already on 'e2e' Already up-to-date. + VIRTUALENV_VERSION=1.10.1 + which python2.7 ++ which python2.7 + PY=/usr/bin/python2.7 + echo 'Using /usr/bin/python2.7' Using /usr/bin/python2.7 + '[' -f build-support/virtualenv-1.10.1/BOOTSTRAPPED ']' + pushd build-support ~/test_dev/build-support ~/test_dev + curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.10.1.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1294k 100 1294k0 0 3261k 0 --:--:-- --:--:-- --:--:-- 3817k + tar zxvf virtualenv-1.10.1.tar.gz virtualenv-1.10.1/ virtualenv-1.10.1/AUTHORS.txt virtualenv-1.10.1/bin/ virtualenv-1.10.1/bin/rebuild-script.py virtualenv-1.10.1/docs/ virtualenv-1.10.1/docs/_theme/ virtualenv-1.10.1/docs/_theme/nature/ virtualenv-1.10.1/docs/_theme/nature/static/ virtualenv-1.10.1/docs/_theme/nature/static/nature.css_t virtualenv-1.10.1/docs/_theme/nature/static/pygments.css virtualenv-1.10.1/docs/_theme/nature/theme.conf virtualenv-1.10.1/docs/conf.py virtualenv-1.10.1/docs/index.rst virtualenv-1.10.1/docs/make.bat virtualenv-1.10.1/docs/Makefile virtualenv-1.10.1/docs/news.rst virtualenv-1.10.1/LICENSE.txt virtualenv-1.10.1/MANIFEST.in virtualenv-1.10.1/PKG-INFO virtualenv-1.10.1/README.rst virtualenv-1.10.1/scripts/ virtualenv-1.10.1/scripts/virtualenv virtualenv-1.10.1/setup.cfg virtualenv-1.10.1/setup.py virtualenv-1.10.1/virtualenv.egg-info/ virtualenv-1.10.1/virtualenv.egg-info/dependency_links.txt virtualenv-1.10.1/virtualenv.egg-info/entry_points.txt virtualenv-1.10.1/virtualenv.egg-info/not-zip-safe virtualenv-1.10.1/virtualenv.egg-info/PKG-INFO virtualenv-1.10.1/virtualenv.egg-info/SOURCES.txt virtualenv-1.10.1/virtualenv.egg-info/top_level.txt virtualenv-1.10.1/virtualenv.py virtualenv-1.10.1/virtualenv_embedded/ virtualenv-1.10.1/virtualenv_embedded/activate.bat virtualenv-1.10.1/virtualenv_embedded/activate.csh virtualenv-1.10.1/virtualenv_embedded/activate.fish virtualenv-1.10.1/virtualenv_embedded/activate.ps1 virtualenv-1.10.1/virtualenv_embedded/activate.sh virtualenv-1.10.1/virtualenv_embedded/activate_this.py virtualenv-1.10.1/virtualenv_embedded/deactivate.bat virtualenv-1.10.1/virtualenv_embedded/distutils-init.py virtualenv-1.10.1/virtualenv_embedded/distutils.cfg virtualenv-1.10.1/virtualenv_embedded/site.py virtualenv-1.10.1/virtualenv_support/
Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/#review33014
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 24, 2014, 1:28 a.m., David Robinson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/
---
(Updated Jan. 24, 2014, 1:28 a.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Repository: aurora
Description
---
s/thermos_observe/thermos_observer/ in README.md
[drobinson@x1 incubator-aurora (master)]$ grep thermos_observe * -R
examples/vagrant/provision-dev-environment.sh: ./pants
src/main/python/apache/thermos/observer/bin:thermos_observer
examples/vagrant/provision-dev-environment.sh: for pex in aurora_admin
aurora_client gc_executor thermos_executor thermos_observer; do
examples/vagrant/provision-mesos-slave.sh:cat
/usr/local/bin/thermos_observer.sh EOF
examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer
\
examples/vagrant/provision-mesos-slave.sh:chmod +x
/usr/local/bin/thermos_observer.sh
examples/vagrant/provision-mesos-slave.sh:install -m 755
/vagrant/dist/thermos_observer.pex /usr/local/bin/thermos_observer
examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer.sh
/var/log/thermos-observer.log 21
src/main/python/apache/thermos/README.md:$ ./pants
src/python/apache/thermos/bin:thermos_observe
src/main/python/apache/thermos/README.md:$ dist/thermos_observe.pex
--root=$HOME/.thermos
src/main/python/apache/thermos/README.md:$ thermos simplerun --daemon -P
http:1338 'dist/thermos_observe.pex --http_port={{thermos.ports[http]}}
--root=$HOME/.thermos'
src/main/python/apache/thermos/observer/bin/BUILD: name = 'thermos_observer',
src/main/python/apache/thermos/observer/bin/BUILD: source =
'thermos_observer.py',
src/main/python/apache/thermos/observer/bin/BUILD: entry_point =
'apache.thermos.observer.bin.thermos_observer:proxy_main',
src/main/python/apache/thermos/observer/BUILD:thermos_observer =
pants('src/main/python/apache/thermos/observer/bin:thermos_observer'),
Diffs
-
src/main/python/apache/thermos/README.md
4bfefd37163dfbc5947acc7adc52f57c95cd174f
Diff: https://reviews.apache.org/r/17293/diff/
Testing
---
None, it's a document and it's out of date.
Thanks,
David Robinson
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33035 --- Ship it! cool, drive-by LGTM! src/main/python/apache/aurora/client/cli/bridge.py https://reviews.apache.org/r/17270/#comment62199 receive src/main/python/apache/aurora/client/cli/bridge.py https://reviews.apache.org/r/17270/#comment62200 kill src/main/python/apache/aurora/client/cli/client.py https://reviews.apache.org/r/17270/#comment62204 s/ // - Jonathan Boulle On Jan. 28, 2014, 3:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 28, 2014, 3:23 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Addressed code review feedback. Fixed the thrift response to use a set instead of a list, since I found an ordering bug while running the test. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
On Jan. 28, 2014, 3:37 a.m., Bill Farner wrote: Can you also attach the JIRA issue please? Done. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32947 --- On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
On Jan. 28, 2014, 3:32 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 384
https://reviews.apache.org/r/17430/diff/1/?file=451962#file451962line384
Thinking out loud, a helper function reduces some duplication, and
wrapping in a HashMultimap puts the values in a Set for you (so you can
skip the ImmutableSet.copyOf later):
private static T MultimapString, IJobKey mapByRole(
IterableT entities,
FunctionT, IJobKey keyExtractor) {
return HashMultimap.create(
Multimaps.index(Iterables.transform(tasks, keyExtractor)));
}
Then, your calling code is:
MultimapString, IJobKey jobsByRole = mapByRole(
Storage.weaklyConsistentFetchTasks(storage, Query.unscoped()),
Tasks.SCHEDULED_TO_JOB_KEY);
MultimapString, IJobKey cronJobsByRole =
mapByRole(cronJobManager.getJobs(), JobKeys.FROM_CONFIG);
(note: you'll want to tweak line wrapping, trying to make it pretty in
the comment box here)
Done.
Changed
Multimaps.index(Iterables.transform(tasks, keyExtractor)));
to
Multimaps.index(Iterables.transform(tasks, keyExtractor),
JobKeys.TO_ROLE));
to match the signature.
On Jan. 28, 2014, 3:32 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 1112
https://reviews.apache.org/r/17430/diff/1/?file=451963#file451963line1112
Does this test reproduce the bug? I would have expected to see
something like two tasks in the same job resulting in a job count of 1.
Good catch. I added the task, but it got lost among other fixes. Fixed it now.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review32945
---
On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/
---
(Updated Jan. 28, 2014, 8:51 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-116
https://issues.apache.org/jira/browse/AURORA-116
Repository: aurora
Description
---
Updated test cases to catch this bug.
Diffs
-
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
cf9099f307efa23ca34634e3512d9cdbebfa82f2
src/main/thrift/org/apache/aurora/gen/api.thrift
74010379baa2e47cefc228943f766c7b3a8b0d97
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
6cefdfad469a9b69a5291ad46be1df14b443472e
src/test/resources/org/apache/aurora/gen/api.thrift.md5
42fdca2759f15d007bee058485c237268c57597a
Diff: https://reviews.apache.org/r/17430/diff/
Testing
---
gradle clean build
gradle run - tested in local UI.
Thanks,
Suman Karumuri
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33041 --- src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/17430/#comment62250 In the future (post-release), i'll ship-block changes like this. Since we're not there yet, and this is a nascent API it LGTM. src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java https://reviews.apache.org/r/17430/#comment62252 This task needs to be different from task1 in some way, otherwise this test could deceivingly pass if the two tasks are ever placed into a Set. - Bill Farner On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Review Request 17464: Upgrade RBTools to 0.5.5.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17464/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Upgrade RBTools to 0.5.5. This pins us to a stable released version of RBTools, with a number of bugfixes [1,2]. [1] https://github.com/reviewboard/rbtools/commits/release-0.5.5 [2] https://github.com/reviewboard/rbtools/commit/c9ce18becce5ef00fa5e70d51511ad43aab03601 Diffs - rbt a05476d175bf3959cc6e5d96aab55215fac9e36b Diff: https://reviews.apache.org/r/17464/diff/ Testing --- Posted this review, verified upgrade works. Thanks, Kevin Sweeney
Re: Review Request 17464: Upgrade RBTools to 0.5.5.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17464/#review33045 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2014, 9:13 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17464/ --- (Updated Jan. 28, 2014, 9:13 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Upgrade RBTools to 0.5.5. This pins us to a stable released version of RBTools, with a number of bugfixes [1,2]. [1] https://github.com/reviewboard/rbtools/commits/release-0.5.5 [2] https://github.com/reviewboard/rbtools/commit/c9ce18becce5ef00fa5e70d51511ad43aab03601 Diffs - rbt a05476d175bf3959cc6e5d96aab55215fac9e36b Diff: https://reviews.apache.org/r/17464/diff/ Testing --- Posted this review, verified upgrade works. Thanks, Kevin Sweeney
Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review33054 --- Kevin — ping? Presumably you can review while i fix up Maxim's non-ship-blocks. - Bill Farner On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 14, 2014, 11:27 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Sorry for the monster diff. The intertwined nature of StateManagerImpl and TaskStateMachine made it pretty challenging to do this partially. I hope the end result is much easier to comprehend. The big picture for this change is that the closures inside TaskStateMachine no longer drop items onto a work queue that feeds back into StateManagerImpl. Instead, it returns these actions in a TransitionResult. I intend to improve this further in the future by exposing only a helper function in TaskStateMachine, to guarantee the one-time-use semantic. Diffs - src/main/java/org/apache/aurora/scheduler/state/SideEffect.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 2bdd4591f2182fe6c44d46f778be562d30eb2392 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2b8ca095d8f108d516a43af8de4ff451ed9a8924 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 11d283d31883b865b224d5af169dd5c42875021d src/main/java/org/apache/aurora/scheduler/state/WorkCommand.java aff74d535eb1237beafbcdf936d5ccc7101377c9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 7fe297a37aee0cb1be495e6a568b66271ee7bc3d src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 53793000de08fe80c0334241d332e3a50fca222a src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java f44ee589430c2d4c0e014a705fd24b1f2fe08f36 Diff: https://reviews.apache.org/r/16873/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32551 --- Ship it! src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java https://reviews.apache.org/r/16873/#comment61431 This seems like a big enough gotcha to warrant filing a ticket. - Kevin Sweeney On Jan. 14, 2014, 3:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 14, 2014, 3:27 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Sorry for the monster diff. The intertwined nature of StateManagerImpl and TaskStateMachine made it pretty challenging to do this partially. I hope the end result is much easier to comprehend. The big picture for this change is that the closures inside TaskStateMachine no longer drop items onto a work queue that feeds back into StateManagerImpl. Instead, it returns these actions in a TransitionResult. I intend to improve this further in the future by exposing only a helper function in TaskStateMachine, to guarantee the one-time-use semantic. Diffs - src/main/java/org/apache/aurora/scheduler/state/SideEffect.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 2bdd4591f2182fe6c44d46f778be562d30eb2392 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2b8ca095d8f108d516a43af8de4ff451ed9a8924 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 11d283d31883b865b224d5af169dd5c42875021d src/main/java/org/apache/aurora/scheduler/state/WorkCommand.java aff74d535eb1237beafbcdf936d5ccc7101377c9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 7fe297a37aee0cb1be495e6a568b66271ee7bc3d src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 53793000de08fe80c0334241d332e3a50fca222a src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java f44ee589430c2d4c0e014a705fd24b1f2fe08f36 Diff: https://reviews.apache.org/r/16873/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 10:17 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Fixed code review comments. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
On Jan. 28, 2014, 9:02 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 1087 https://reviews.apache.org/r/17430/diff/2/?file=453063#file453063line1087 This task needs to be different from task1 in some way, otherwise this test could deceivingly pass if the two tasks are ever placed into a Set. Fixed. On Jan. 28, 2014, 9:02 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 395 https://reviews.apache.org/r/17430/diff/2/?file=453062#file453062line395 In the future (post-release), i'll ship-block changes like this. Since we're not there yet, and this is a nascent API it LGTM. Ok. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33041 --- On Jan. 28, 2014, 10:17 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 10:17 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.
On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 42 https://reviews.apache.org/r/16873/diff/1/?file=423020#file423020line42 Missing comments for public methods in this class? We typically don't bother including a javadoc for one-liner methods. If you feel strongly about this, you might want to push for the checkstyle config to require it. On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 371 https://reviews.apache.org/r/16873/diff/1/?file=423022#file423022line371 s/SideEffect.Action/Action Thanks, fixed. On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 384 https://reviews.apache.org/r/16873/diff/1/?file=423022#file423022line384 \n Done. On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 439 https://reviews.apache.org/r/16873/diff/1/?file=423022#file423022line439 Might be more consistent and easier to follow if case statements are ordered by ACTIONS_IN_ORDER. Sounds good, done. On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line 223 https://reviews.apache.org/r/16873/diff/1/?file=423023#file423023line223 It's hard to follow the logic here. Are both of these conditions desired here? false == false true == true Mind splitting it into two statements and adding proper error messages for each? It's more than two statements, but i believe the desired effect is achieved in the new diff. On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line 553 https://reviews.apache.org/r/16873/diff/1/?file=423023#file423023line553 Better name for a parameter here to avoid confusion with the overload? Done. On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line 566 https://reviews.apache.org/r/16873/diff/1/?file=423023#file423023line566 Since it's fully public, might make sense moving it into a separate file? Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32511 --- On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 14, 2014, 11:27 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Sorry for the monster diff. The intertwined nature of StateManagerImpl and TaskStateMachine made it pretty challenging to do this partially. I hope the end result is much easier to comprehend. The big picture for this change is that the closures inside TaskStateMachine no longer drop items onto a work queue that feeds back into StateManagerImpl. Instead, it returns these actions in a TransitionResult. I intend to improve this further in the future by exposing only a helper function in TaskStateMachine, to guarantee the one-time-use semantic. Diffs - src/main/java/org/apache/aurora/scheduler/state/SideEffect.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 2bdd4591f2182fe6c44d46f778be562d30eb2392 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2b8ca095d8f108d516a43af8de4ff451ed9a8924 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 11d283d31883b865b224d5af169dd5c42875021d src/main/java/org/apache/aurora/scheduler/state/WorkCommand.java aff74d535eb1237beafbcdf936d5ccc7101377c9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 7fe297a37aee0cb1be495e6a568b66271ee7bc3d src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 53793000de08fe80c0334241d332e3a50fca222a src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java f44ee589430c2d4c0e014a705fd24b1f2fe08f36 Diff: https://reviews.apache.org/r/16873/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.
On Jan. 28, 2014, 9:50 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, lines 543-546 https://reviews.apache.org/r/16873/diff/1/?file=423022#file423022line543 This seems like a big enough gotcha to warrant filing a ticket. AURORA-138 - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32551 --- On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 14, 2014, 11:27 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Sorry for the monster diff. The intertwined nature of StateManagerImpl and TaskStateMachine made it pretty challenging to do this partially. I hope the end result is much easier to comprehend. The big picture for this change is that the closures inside TaskStateMachine no longer drop items onto a work queue that feeds back into StateManagerImpl. Instead, it returns these actions in a TransitionResult. I intend to improve this further in the future by exposing only a helper function in TaskStateMachine, to guarantee the one-time-use semantic. Diffs - src/main/java/org/apache/aurora/scheduler/state/SideEffect.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 2bdd4591f2182fe6c44d46f778be562d30eb2392 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2b8ca095d8f108d516a43af8de4ff451ed9a8924 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 11d283d31883b865b224d5af169dd5c42875021d src/main/java/org/apache/aurora/scheduler/state/WorkCommand.java aff74d535eb1237beafbcdf936d5ccc7101377c9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 7fe297a37aee0cb1be495e6a568b66271ee7bc3d src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 53793000de08fe80c0334241d332e3a50fca222a src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java f44ee589430c2d4c0e014a705fd24b1f2fe08f36 Diff: https://reviews.apache.org/r/16873/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.
On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 77 https://reviews.apache.org/r/16873/diff/1/?file=423020#file423020line77 Should these be javadoc comments instead? Good call, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32511 --- On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 14, 2014, 11:27 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Sorry for the monster diff. The intertwined nature of StateManagerImpl and TaskStateMachine made it pretty challenging to do this partially. I hope the end result is much easier to comprehend. The big picture for this change is that the closures inside TaskStateMachine no longer drop items onto a work queue that feeds back into StateManagerImpl. Instead, it returns these actions in a TransitionResult. I intend to improve this further in the future by exposing only a helper function in TaskStateMachine, to guarantee the one-time-use semantic. Diffs - src/main/java/org/apache/aurora/scheduler/state/SideEffect.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 2bdd4591f2182fe6c44d46f778be562d30eb2392 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2b8ca095d8f108d516a43af8de4ff451ed9a8924 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 11d283d31883b865b224d5af169dd5c42875021d src/main/java/org/apache/aurora/scheduler/state/WorkCommand.java aff74d535eb1237beafbcdf936d5ccc7101377c9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 7fe297a37aee0cb1be495e6a568b66271ee7bc3d src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 53793000de08fe80c0334241d332e3a50fca222a src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java f44ee589430c2d4c0e014a705fd24b1f2fe08f36 Diff: https://reviews.apache.org/r/16873/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17063: Update tag-release to allow patch level increments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/ --- (Updated Jan. 28, 2014, 11:11 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- update for major/dev tags. haven't incorporated feedback or even considered it yet. Repository: aurora Description --- Update tag-release to allow patch level increments. (just now noticed I branched off the status checker change -- ignore that for now.) Diffs (updated) - KEYS 0313277754679da0e5e1d2075654eac9006ce448 build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014 Diff: https://reviews.apache.org/r/17063/diff/ Testing --- Nope Thanks, Brian Wickman
Re: Review Request 17063: Update tag-release to allow patch level increments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/#review33068 --- build-support/release/tag-release https://reviews.apache.org/r/17063/#comment62305 A dev tag should update .auroraversion so that generated artifacts have the tag in them. Without this the tag will point to a -snapshot. - Kevin Sweeney On Jan. 28, 2014, 3:11 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/ --- (Updated Jan. 28, 2014, 3:11 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Update tag-release to allow patch level increments. (just now noticed I branched off the status checker change -- ignore that for now.) Diffs - KEYS 0313277754679da0e5e1d2075654eac9006ce448 build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014 Diff: https://reviews.apache.org/r/17063/diff/ Testing --- Nope Thanks, Brian Wickman
Re: Review Request 17063: Update tag-release to allow patch level increments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/ --- (Updated Jan. 28, 2014, 11:32 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- update all the things Repository: aurora Description --- Update tag-release to allow patch level increments. (just now noticed I branched off the status checker change -- ignore that for now.) Diffs (updated) - KEYS 0313277754679da0e5e1d2075654eac9006ce448 build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014 Diff: https://reviews.apache.org/r/17063/diff/ Testing --- Nope Thanks, Brian Wickman
Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 29, 2014, 12:09 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Sorry for the monster diff. The intertwined nature of StateManagerImpl and TaskStateMachine made it pretty challenging to do this partially. I hope the end result is much easier to comprehend. The big picture for this change is that the closures inside TaskStateMachine no longer drop items onto a work queue that feeds back into StateManagerImpl. Instead, it returns these actions in a TransitionResult. I intend to improve this further in the future by exposing only a helper function in TaskStateMachine, to guarantee the one-time-use semantic. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/state/SideEffect.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java 2bdd4591f2182fe6c44d46f778be562d30eb2392 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2b8ca095d8f108d516a43af8de4ff451ed9a8924 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 11d283d31883b865b224d5af169dd5c42875021d src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/WorkCommand.java aff74d535eb1237beafbcdf936d5ccc7101377c9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 53d0c852e174557a5ffbe4d48175803ab98546a4 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 7fe297a37aee0cb1be495e6a568b66271ee7bc3d src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 53793000de08fe80c0334241d332e3a50fca222a src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java f44ee589430c2d4c0e014a705fd24b1f2fe08f36 Diff: https://reviews.apache.org/r/16873/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33074 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2014, 10:17 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 10:17 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33076 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 2:17 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 2:17 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-116 https://issues.apache.org/jira/browse/AURORA-116 Repository: aurora Description --- Updated test cases to catch this bug. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17430/diff/ Testing --- gradle clean build gradle run - tested in local UI. Thanks, Suman Karumuri
Re: Review Request 17063: Update tag-release to allow patch level increments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/#review33077 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 3:32 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/ --- (Updated Jan. 28, 2014, 3:32 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Update tag-release to allow patch level increments. (just now noticed I branched off the status checker change -- ignore that for now.) Diffs - KEYS 0313277754679da0e5e1d2075654eac9006ce448 build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014 Diff: https://reviews.apache.org/r/17063/diff/ Testing --- Nope Thanks, Brian Wickman
Review Request 17475: Upgrade mesos to 0.15.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17475/ --- Review request for Aurora, Vinod Kone, Bill Farner, and Brian Wickman. Bugs: AURORA-115 https://issues.apache.org/jira/browse/AURORA-115 Repository: aurora Description --- Upgrade mesos dependency to 0.15.0 Diffs - 3rdparty/python/BUILD 735a0631f2a6e5ae14ab6417fc5f6fac381a2742 build.gradle 4660a2c210f8d5947b7761bdd8ff5a640866b24e examples/vagrant/provision-aurora-scheduler.sh f96c2e79305aab882af9c2f8219b723fe8aab0eb examples/vagrant/provision-dev-environment.sh d8cc1fe9333cd607b0373d9cc49b3a71c683edcc examples/vagrant/provision-mesos-master.sh 0420629182f16b0d10ec27634084e1a32ceb19a7 examples/vagrant/provision-mesos-slave.sh 5170b4076fc6e4424914493208c779f4494ed097 src/main/python/apache/aurora/executor/BUILD 2524b2ee295011cca51fff672adf65cdc8e9137b Diff: https://reviews.apache.org/r/17475/diff/ Testing --- vagrant up ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
