Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

> On Feb. 21, 2014, 11 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 142 > > > > > > it looks like this was never updated. safe_hosts[host] = safe_limits > > != self_hosts[host]

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

> On Feb. 21, 2014, 7:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/sla.py, lines 135-139 > > > > > > The else would fire even if the _hosts is empty producing an unbound > > variable

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 11:10 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

> On Feb. 21, 2014, 7:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/sla.py, lines 135-139 > > > > > > The else would fire even if the _hosts is empty producing an unbound > > variable

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35203 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35202 --- Ship it! Ship It! - Brian Wickman On Feb. 21, 2014, 7:49 p.m., M

Re: Review Request 18316: Aurora-193: fix license plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18316/#review35198 --- Ship it! Ship It! - Bill Farner On Feb. 20, 2014, 7:50 p.m., Jak

Re: Review Request 18316: Aurora-193: fix license plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18316/#review35199 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 11:50 a.m.,

Re: Review Request 18340: Renamed getJobSummary call to getRoleSummary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18340/#review35197 --- Ship it! Ship It! - Bill Farner On Feb. 21, 2014, 2:18 a.m., Sum

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35186 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 21, 2014, 2:49 p.m.

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35182 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 7:49 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

> On Feb. 21, 2014, 6:34 p.m., Bill Farner wrote: > > build-support/pex, line 21 > > > > > > Prefer to keep the naming consistent across the scripts. In the past, > > i've called this variable called HERE, which i lik

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35173 --- This LGTM, deferring ship for the conversation. build-support/pex

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35168 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35170 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18334: Move and unit test Maintenance module and commands

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35160 --- code lgtm, just a few cleanups. src/main/python/apache/aurora/clie

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 4:30 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

> On Feb. 21, 2014, 2:55 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 88 > > > > > > This comment doesn't make sense to me. I don't understand what an > > instance of this cla

Re: Review Request 18334: Move and unit test Maintenance module and commands

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35152 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 20, 2014, 7:05 p.m.

Re: Review Request 16144: ZookeeperSchedulerClient url property errored when no proxy_url was set, and the client was not connected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16144/#review35154 --- Ship it! Ship It! - Mark Chu-Carroll On Dec. 9, 2013, 8:57 p.m.,

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35150 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18239: rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from ExecutorBase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18239/#review35149 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 18, 2014, 4:46 p.m.

Review Request 18354: Add a packaging target for clientv2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-226

Re: Review Request 18267: Implement help for v2 bridge

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/ --- (Updated Feb. 21, 2014, 8:56 a.m.) Review request for Aurora, David Robinson an