---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35810
---
would it be very hard to make that a command line / config file var
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35816
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 28, 2014, 2:37 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35819
---
have you run the executor:long tests?
- Brian Wickman
On Feb.
On Feb. 28, 2014, 11:08 a.m., Brian Wickman wrote:
have you run the executor:long tests?
Are those skipped by CI?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
On Feb. 28, 2014, 10:37 a.m., Jim Youll wrote:
would it be very hard to make that a command line / config file var rather
than an env var? Then it would be set just like all other configurable
params in a config file or with a command line override, and would be more
sustainable.
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35827
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 27, 2014, 8:32
On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19
https://reviews.apache.org/r/17303/diff/1/?file=447781#file447781line19
Do you think this class scales to multiple consumers? i.e. there's a
bunch of hard-coded
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review35831
---
src/main/java/org/apache/aurora/scheduler/base/Jobs.java
On Feb. 28, 2014, 6:37 p.m., Jim Youll wrote:
would it be very hard to make that a command line / config file var rather
than an env var? Then it would be set just like all other configurable
params in a config file or with a command line override, and would be more
sustainable.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35836
---
On Feb. 27, 2014, 7 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java,
line 46
https://reviews.apache.org/r/18580/diff/2/?file=506660#file506660line46
I forget — can this go directly on the deprecated method to limit scope?
It can't
On Feb. 28, 2014, 2:40 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 52
https://reviews.apache.org/r/18546/diff/2/?file=506590#file506590line52
Mind adding the ticket that tracks collapsing work? AURORA-105?
Done.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/
---
(Updated Feb. 28, 2014, 9:48 p.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35861
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/
---
(Updated Feb. 28, 2014, 10:53 p.m.)
Review request for Aurora, Kevin Sweeney
On Feb. 28, 2014, 10:53 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java,
line 80
https://reviews.apache.org/r/18526/diff/3/?file=506631#file506631line80
That would create an empty SetIJobKey in case jobkey is missing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/
---
(Updated Feb. 28, 2014, 3:21 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---
(Updated Feb. 28, 2014, 11:32 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review35871
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18654/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-235
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18654/#review35873
---
Incomplete feature?
- Bill Farner
On March 1, 2014, 12:14 a.m.,
On March 1, 2014, 12:16 a.m., Bill Farner wrote:
Incomplete feature?
This is needed to unlock two additional CRs I am about to post. One that
follows up on supporting jobKeys in scheduler and the other one that uses it on
the client.
- Maxim
On March 1, 2014, 12:16 a.m., Bill Farner wrote:
Incomplete feature?
Maxim Khutornenko wrote:
This is needed to unlock two additional CRs I am about to post. One that
follows up on supporting jobKeys in scheduler and the other one that uses it
on the client.
One that follows up
On March 1, 2014, 12:16 a.m., Bill Farner wrote:
Incomplete feature?
Maxim Khutornenko wrote:
This is needed to unlock two additional CRs I am about to post. One that
follows up on supporting jobKeys in scheduler and the other one that uses it
on the client.
Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-235
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review35885
---
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18658/
---
Review request for Aurora, Suman Karumuri and Bill Farner.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/
---
(Updated March 1, 2014, 1:26 a.m.)
Review request for Aurora, Kevin Sweeney
On Feb. 28, 2014, 8:21 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 2
https://reviews.apache.org/r/17303/diff/2/?file=504348#file504348line2
2014
Done. I wish the license plugin checked for things like these.
On Feb. 28, 2014, 8:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review35889
---
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review35890
---
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 28, 2014, 3:32 p.m.,
On Feb. 28, 2014, 11:54 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 1345
https://reviews.apache.org/r/17347/diff/2/?file=507438#file507438line1345
Mind making this a different value, to prove that the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---
(Updated March 1, 2014, 2:36 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---
(Updated March 1, 2014, 5:11 a.m.)
Review request for Aurora, Kevin Sweeney
34 matches
Mail list logo
