Re: Review Request 18484: Count on task timeouts and task pruning to be idempotent, simplifying handling code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18484/ --- (Updated March 7, 2014, 12:22 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18484: Count on task timeouts and task pruning to be idempotent, simplifying handling code.

> On March 6, 2014, 6:56 p.m., Suman Karumuri wrote: > > src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java, > > line 377 > > > > > > This function can be replaced by Tasks.SCHEDULED_TO_JOB_KEY Th

Re: Review Request 18819: Removing rollback_on_failure from restart options.

> On March 6, 2014, 12:43 a.m., David Robinson wrote: > > I added the missing flag instead: https://reviews.apache.org/r/18746/ > > > > Would it be worthwhile exposing the feature as a flag in addition to a > > config option? > > Brian Wickman wrote: > I'm not sure the flag makes sense for

Re: Review Request 17562: Added cluster name to page title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated March 6, 2014, 11:43 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 17562: Added cluster name to page title.

> On Feb. 25, 2014, 8:10 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java, line 195 > > > > > > doc here has drifted, please being it back in check Done. > On Feb. 25, 2

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

> On March 6, 2014, 10:24 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 67 > > > > > > kill []s Done. > On March 6, 2014, 10:24 p.m., Brian Wickman wrote: > > src/main/python/ap

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/ --- (Updated March 6, 2014, 10:42 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/#review36441 --- Ship it! only style nits src/main/python/apache/aurora/client/api

Re: Review Request 18655: Added JobKey set into TaskQuery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36427 --- Waiting for Kevin. - Maxim Khutornenko On March 4, 2014, 1:03 a.m

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/#review36428 --- Ping. - Maxim Khutornenko On March 4, 2014, 1:20 a.m., Maxim Khut

Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon application exit.

> On March 3, 2014, 6:16 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 236 > > > > > > Not sure how shutdownRegistry.addAction() fits into this specific > >

Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon application exit.

> On March 4, 2014, 2:16 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 236 > > > > > > Not sure how shutdownRegistry.addAction() fits into this specific > >

Re: Review Request 18658: GZIP HTTP thrift API responses

> On March 1, 2014, 5:23 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 40 > > > > > > I can't think of a good reason to not apply this to /, can you? If so, > >

Re: Review Request 18714: Disable log and initiate shutdown upon log storage failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18714/#review36401 --- If I remember the discussion correctly, there is a race condition he

Re: Review Request 18484: Count on task timeouts and task pruning to be idempotent, simplifying handling code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18484/#review36397 --- Ship it! src/test/java/org/apache/aurora/scheduler/async/HistoryPr