Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review37275 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 10:29 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated March 3, 2014, 10:29 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- There are a few nice things falling out of this refactor: - New methods on mutable store interfaces are not implicitly forwarded (ForwardingStore does not implement mutable stores). - Write ahead/behind behavior is more obvious in LogStorage (i found the delegation by calling super tough to catch mistakes.) - Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of a transaction (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation) Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 3d0ff2dfc01404c890dc17d23c3d15732915c438 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 Diff: https://reviews.apache.org/r/18487/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated March 14, 2014, 11:24 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- There are a few nice things falling out of this refactor: - New methods on mutable store interfaces are not implicitly forwarded (ForwardingStore does not implement mutable stores). - Write ahead/behind behavior is more obvious in LogStorage (i found the delegation by calling super tough to catch mistakes.) - Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of a transaction (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation) Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 8758eb7f2d80b88bc13d42fa62021c255a54fdc8 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 3d0ff2dfc01404c890dc17d23c3d15732915c438 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3ccf800a14cb987b798bc28d15dcbef50b4c78e7 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8b26cc0ac2a2a1be6e4cde91b3f84ae00ec98d29 Diff: https://reviews.apache.org/r/18487/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 19245: Fix bash here-document warning.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19245/#review37293 --- Ship it! Ship It! - Maxim Khutornenko On March 14, 2014, 11:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19245/ --- (Updated March 14, 2014, 11:32 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Fixes this warning src/test/sh/org/apache/aurora/verify_thrift_checksum.sh: line 54: warning: here-document at line 50 delimited by end-of-file (wanted `EOF') src/test/sh/org/apache/aurora/verify_thrift_checksum.sh: line 54: warning: here-document at line 50 delimited by end-of-file (wanted `EOF') src/test/sh/org/apache/aurora/verify_thrift_checksum.sh: line 54: warning: here-document at line 50 delimited by end-of-file (wanted `EOF') src/test/sh/org/apache/aurora/verify_thrift_checksum.sh: line 54: warning: here-document at line 50 delimited by end-of-file (wanted `EOF') src/test/sh/org/apache/aurora/verify_thrift_checksum.sh: line 54: warning: here-document at line 50 delimited by end-of-file (wanted `EOF') src/test/sh/org/apache/aurora/verify_thrift_checksum.sh: line 54: warning: here-document at line 50 delimited by end-of-file (wanted `EOF') Diffs - src/test/sh/org/apache/aurora/verify_thrift_checksum.sh 25065b54d52d79ae1d6f0ea8968566064981add0 Diff: https://reviews.apache.org/r/19245/diff/ Testing --- ./gradlew build, no warnings Thanks, Bill Farner
Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- Review request for Aurora. Bugs: AURORA-264 https://issues.apache.org/jira/browse/AURORA-264 Repository: aurora Description --- Properly handle filtering offers when multiple attributes have the same name. Diffs - src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 5f1e4313d542410ded488c50ce8a714fcff73392 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba src/main/thrift/org/apache/aurora/gen/api.thrift f6c444d27771f590c071cc14e9a050e31a46bd68 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 79d14c9460de405c5cb3f1c257c5bc264b4da421 src/test/resources/org/apache/aurora/gen/api.thrift.md5 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 Diff: https://reviews.apache.org/r/19250/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/#review37310 --- Ship it! src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java https://reviews.apache.org/r/19250/#comment68769 Any chance this could be merged with the next statement? src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java https://reviews.apache.org/r/19250/#comment68770 Add checks for 1.6 and 1.7? - Maxim Khutornenko On March 15, 2014, 1:16 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- (Updated March 15, 2014, 1:16 a.m.) Review request for Aurora. Bugs: AURORA-264 https://issues.apache.org/jira/browse/AURORA-264 Repository: aurora Description --- Properly handle filtering offers when multiple attributes have the same name. Diffs - src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 5f1e4313d542410ded488c50ce8a714fcff73392 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba src/main/thrift/org/apache/aurora/gen/api.thrift f6c444d27771f590c071cc14e9a050e31a46bd68 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 79d14c9460de405c5cb3f1c257c5bc264b4da421 src/test/resources/org/apache/aurora/gen/api.thrift.md5 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 Diff: https://reviews.apache.org/r/19250/diff/ Testing --- ./gradlew build Thanks, Bill Farner
