Re: Review Request 19143: Catch errors thrown by authentication modules.
On March 13, 2014, 2:26 p.m., Joshua Cohen wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 243 https://reviews.apache.org/r/19143/diff/2/?file=517784#file517784line243 The broad catch below worries me a bit. Would it be feasible to have the various _connect impls (which presumably are what are raising the various types of exceptions and therefore have a better idea of what types of exceptions might be raised) be responsible for catching the appropriate exception types and re-raising as auth errors if necessary, or is there really no way of narrowing this down to only auth errors? It would be difficult. The way that some of the auth code is patched in makes it very hard to control what exceptions get raised. (I don't want to go into more detail here; discussing how twitter does authentication on the open-source jira isn't a good idea.) - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37080 --- On March 12, 2014, 6:59 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/ --- (Updated March 12, 2014, 6:59 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-259 https://issues.apache.org/jira/browse/aurora-259 Repository: aurora Description --- Catch errors thrown by authentication modules. Authentication modules can throw arbitrary errors - ldap exceptions, password errors, etc, if auth fails with one of these app specific errors, the client current dumps its cookies in a stack dump. This change catches the error cleanly, and transforms it into a handled authentication exception. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 Diff: https://reviews.apache.org/r/19143/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 19143: Catch errors thrown by authentication modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37392 --- Ship it! Ship It! - Brian Wickman On March 12, 2014, 10:59 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/ --- (Updated March 12, 2014, 10:59 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-259 https://issues.apache.org/jira/browse/aurora-259 Repository: aurora Description --- Catch errors thrown by authentication modules. Authentication modules can throw arbitrary errors - ldap exceptions, password errors, etc, if auth fails with one of these app specific errors, the client current dumps its cookies in a stack dump. This change catches the error cleanly, and transforms it into a handled authentication exception. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 Diff: https://reviews.apache.org/r/19143/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.
On March 15, 2014, 1:40 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java, line 90 https://reviews.apache.org/r/19250/diff/1/?file=520227#file520227line90 Any chance this could be merged with the next statement? It could, but i broke it up for readability. LMK if you have any ideas for nesting it without making it harder to grok. On March 15, 2014, 1:40 a.m., Maxim Khutornenko wrote: src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java, line 473 https://reviews.apache.org/r/19250/diff/1/?file=520229#file520229line473 Add checks for 1.6 and 1.7? Sure, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/#review37310 --- On March 15, 2014, 1:16 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- (Updated March 15, 2014, 1:16 a.m.) Review request for Aurora. Bugs: AURORA-264 https://issues.apache.org/jira/browse/AURORA-264 Repository: aurora Description --- Properly handle filtering offers when multiple attributes have the same name. Diffs - src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 5f1e4313d542410ded488c50ce8a714fcff73392 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba src/main/thrift/org/apache/aurora/gen/api.thrift f6c444d27771f590c071cc14e9a050e31a46bd68 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 79d14c9460de405c5cb3f1c257c5bc264b4da421 src/test/resources/org/apache/aurora/gen/api.thrift.md5 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 Diff: https://reviews.apache.org/r/19250/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- (Updated March 17, 2014, 6:55 p.m.) Review request for Aurora. Bugs: AURORA-264 https://issues.apache.org/jira/browse/AURORA-264 Repository: aurora Description --- Properly handle filtering offers when multiple attributes have the same name. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 5f1e4313d542410ded488c50ce8a714fcff73392 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba src/main/thrift/org/apache/aurora/gen/api.thrift f6c444d27771f590c071cc14e9a050e31a46bd68 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 79d14c9460de405c5cb3f1c257c5bc264b4da421 src/test/resources/org/apache/aurora/gen/api.thrift.md5 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 Diff: https://reviews.apache.org/r/19250/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/#review37427 --- - Kevin Sweeney On March 17, 2014, 11:55 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- (Updated March 17, 2014, 11:55 a.m.) Review request for Aurora. Bugs: AURORA-264 https://issues.apache.org/jira/browse/AURORA-264 Repository: aurora Description --- Properly handle filtering offers when multiple attributes have the same name. Diffs - src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 5f1e4313d542410ded488c50ce8a714fcff73392 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba src/main/thrift/org/apache/aurora/gen/api.thrift f6c444d27771f590c071cc14e9a050e31a46bd68 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 79d14c9460de405c5cb3f1c257c5bc264b4da421 src/test/resources/org/apache/aurora/gen/api.thrift.md5 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 Diff: https://reviews.apache.org/r/19250/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Review Request 19313: added killall command
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19313/
---
Review request for Aurora, Chris Lambert, Dave Lester, and Mark Chu-Carroll.
Repository: aurora
Description
---
added killall command
Added killall command, changed kill command doc
Removed content about null-op {{#x}}
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor Constraint/order() correction 2
Minor Constraint/order() correction
Client command hooks doc
Resource isolation doc
Configuration tutorial
User guide doc
Configuration file reference
Tutorial doc
Client commands doc
User doc overview
Doc images
Adding initial image in images directory
Diffs
-
docs/README.md PRE-CREATION
docs/clientcommands.md PRE-CREATION
docs/configurationreference.md PRE-CREATION
docs/configurationtutorial.md PRE-CREATION
docs/hooks.md PRE-CREATION
docs/images/CPUavailability.png PRE-CREATION
docs/images/HelloWorldJob.png PRE-CREATION
docs/images/RoleJobs.png PRE-CREATION
docs/images/ScheduledJobs.png PRE-CREATION
docs/images/TaskBreakdown.png PRE-CREATION
docs/images/aurora_hierarchy.png PRE-CREATION
docs/images/killedtask.png PRE-CREATION
docs/images/lifeofatask.png PRE-CREATION
docs/images/runningtask.png PRE-CREATION
docs/images/stderr.png PRE-CREATION
docs/images/stdout.png PRE-CREATION
docs/resourceisolation.md PRE-CREATION
docs/tutorial.md PRE-CREATION
docs/userguide.md PRE-CREATION
Diff: https://reviews.apache.org/r/19313/diff/
Testing
---
Thanks,
Tom Galloway
Re: Review Request 18714: Disable log and initiate shutdown upon log storage failures.
On March 6, 2014, 7:05 p.m., Suman Karumuri wrote: If I remember the discussion correctly, there is a race condition here, where some actions could still be performed through the memory store, between the time the storage is shutdown and the shutdown actually happens. That prompted us to do this change at the storage layer instead. Is there a reason, we are doing this change at the log layer now? I can't recall the specifics that led us there, but the biggest issue i can see is that nested transactions don't honor the happens-before expectation between storage write and side-effects. Given that we already face this issue, i'm leaning towards keeping this behavior where it is in the diff, and addressing that bug separately. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18714/#review36401 --- On March 3, 2014, 11:35 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18714/ --- (Updated March 3, 2014, 11:35 p.m.) Review request for Aurora, Kevin Sweeney and Suman Karumuri. Bugs: AURORA-221 https://issues.apache.org/jira/browse/AURORA-221 Repository: aurora Description --- Disable log and initiate shutdown upon log storage failures. Diffs - src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 071c4fcf96099819aac6276306034434e3eec879 src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 359f5d44e030a53cedd612a350b161b392d929c4 Diff: https://reviews.apache.org/r/18714/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 19323: [BugFix] Added jobStats on old role page. Disabled job status badge.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/#review37493 --- I started on this in parallel, and have a few additional changes i'd like you to include. Please have a look at the tip commit on origin/wfarner/fix_jobs_page. (Convenience link: https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=commitdiff;h=2ce304215b099687c3d2f89701a81707a11cca7f) Also, please remove [BugFix] from the review summary and instead link the review against the appropriate bug. - Bill Farner On March 17, 2014, 10:14 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/ --- (Updated March 17, 2014, 10:14 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Added jobStats on role page. We have stopped counting recently failed task count which is used to display the health badge. Since this badge is being removed from the new UI, removed it from the old UI as well. Diffs - src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b3f3124a73b56e48339f89dbd3b1067527757d04 src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st 39c1d9527bff88ff191233629babfd6e6035d4e7 Diff: https://reviews.apache.org/r/19323/diff/ Testing --- ./gradlew clean build gradlew run File Attachments job stats https://reviews.apache.org/media/uploaded/files/2014/03/17/65da4a77-4c82-46f8-93d1-34fd319ef60e__Screen_Shot_2014-03-17_at_3.13.36_PM.png Thanks, Suman Karumuri
Review Request 19331: Renaming packages to packagesDEPRECATED in client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository: aurora Description --- Renaming packages to packagesDEPRECATED in client. Diffs - src/main/python/apache/aurora/client/cli/jobs.py b9d4e8305a975d93cf4f024e70bfb9798762d6d7 src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/main/python/apache/aurora/config/thrift.py 65b962607989134c40c6439f3ce64f52e89dd566 src/test/python/apache/aurora/client/api/test_updater.py c3e259ca11b098d1dd5d588f0c9b0d516639a6fb src/test/python/apache/aurora/client/cli/test_diff.py 758b37ea0d4f7d95934a99a588f6a2c172ab7e83 src/test/python/apache/aurora/client/cli/test_status.py 1d8d9b3384a28124624fc8555010efa9d7ed3cf2 src/test/python/apache/aurora/client/cli/test_task_run.py 56eed9534d5b652c85bbc343e47a3247a8112a53 src/test/python/apache/aurora/client/commands/test_diff.py 730f802844f2eb78d8e2a1c8b1695d53a8e7a407 src/test/python/apache/aurora/client/commands/test_run.py bfb9ecc27878815b877151eecb4076a63dbf1036 src/test/python/apache/aurora/client/commands/test_ssh.py 86402f6ea7c0c8d30b5ec957d6bc2fc22e9936fd src/test/python/apache/aurora/client/commands/test_status.py b63f794ec191291591d2587876614f8d1c489717 src/test/python/apache/aurora/config/test_thrift.py 4be11b5d53c286614565f22795f5026cfbe26f0a Diff: https://reviews.apache.org/r/19331/diff/ Testing --- ./build-support/jenkins/build.sh Local client run: - aurora status - aurora update Thanks, Maxim Khutornenko
Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/#review37508 --- Ship it! Ship It! - Bill Farner On March 17, 2014, 11:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- (Updated March 17, 2014, 11:26 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository: aurora Description --- Renaming packages to packagesDEPRECATED in client. Diffs - src/main/python/apache/aurora/client/cli/jobs.py b9d4e8305a975d93cf4f024e70bfb9798762d6d7 src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/main/python/apache/aurora/config/thrift.py 65b962607989134c40c6439f3ce64f52e89dd566 src/test/python/apache/aurora/client/api/test_updater.py c3e259ca11b098d1dd5d588f0c9b0d516639a6fb src/test/python/apache/aurora/client/cli/test_diff.py 758b37ea0d4f7d95934a99a588f6a2c172ab7e83 src/test/python/apache/aurora/client/cli/test_status.py 1d8d9b3384a28124624fc8555010efa9d7ed3cf2 src/test/python/apache/aurora/client/cli/test_task_run.py 56eed9534d5b652c85bbc343e47a3247a8112a53 src/test/python/apache/aurora/client/commands/test_diff.py 730f802844f2eb78d8e2a1c8b1695d53a8e7a407 src/test/python/apache/aurora/client/commands/test_run.py bfb9ecc27878815b877151eecb4076a63dbf1036 src/test/python/apache/aurora/client/commands/test_ssh.py 86402f6ea7c0c8d30b5ec957d6bc2fc22e9936fd src/test/python/apache/aurora/client/commands/test_status.py b63f794ec191291591d2587876614f8d1c489717 src/test/python/apache/aurora/config/test_thrift.py 4be11b5d53c286614565f22795f5026cfbe26f0a Diff: https://reviews.apache.org/r/19331/diff/ Testing --- ./build-support/jenkins/build.sh Local client run: - aurora status - aurora update Thanks, Maxim Khutornenko
Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.
On March 17, 2014, 10:26 p.m., Bill Farner wrote: I started on this in parallel, and have a few additional changes i'd like you to include. Please have a look at the tip commit on origin/wfarner/fix_jobs_page. (Convenience link: https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=commitdiff;h=2ce304215b099687c3d2f89701a81707a11cca7f) Also, please remove [BugFix] from the review summary and instead link the review against the appropriate bug. Done. Thanks for taking a look. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/#review37493 --- On March 17, 2014, 11:57 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/ --- (Updated March 17, 2014, 11:57 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-271 https://issues.apache.org/jira/browse/AURORA-271 Repository: aurora Description --- Added jobStats on role page. We have stopped counting recently failed task count which is used to display the health badge. Since this badge is being removed from the new UI, removed it from the old UI as well. Diffs - build.gradle f3beb00f69f40e81c1be80f5f6ade84720ae src/main/java/org/apache/aurora/scheduler/base/Jobs.java 3f027032a785810bddfb3ff4dd4e472989c9493f src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b3f3124a73b56e48339f89dbd3b1067527757d04 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ee81b494b9b4dff9839a9e32c9b81fa8ef898e1b src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 3143c6afe8adeb18fac44e92f94b9860753c3eb0 src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st 39c1d9527bff88ff191233629babfd6e6035d4e7 src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 6524e2441d25de6573190866a8559be620961330 Diff: https://reviews.apache.org/r/19323/diff/ Testing --- ./gradlew clean build gradlew run File Attachments job stats https://reviews.apache.org/media/uploaded/files/2014/03/17/65da4a77-4c82-46f8-93d1-34fd319ef60e__Screen_Shot_2014-03-17_at_3.13.36_PM.png Thanks, Suman Karumuri
Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- (Updated March 18, 2014, 12:03 a.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Changes --- Rebased over master. Repository: aurora Description --- Renaming packages to packagesDEPRECATED in client. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 5f1e4313d542410ded488c50ce8a714fcff73392 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba src/main/python/apache/aurora/client/cli/jobs.py b9d4e8305a975d93cf4f024e70bfb9798762d6d7 src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/main/python/apache/aurora/config/thrift.py 65b962607989134c40c6439f3ce64f52e89dd566 src/main/thrift/org/apache/aurora/gen/api.thrift f6c444d27771f590c071cc14e9a050e31a46bd68 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 79d14c9460de405c5cb3f1c257c5bc264b4da421 src/test/python/apache/aurora/client/api/test_updater.py c3e259ca11b098d1dd5d588f0c9b0d516639a6fb src/test/python/apache/aurora/client/cli/test_diff.py 758b37ea0d4f7d95934a99a588f6a2c172ab7e83 src/test/python/apache/aurora/client/cli/test_status.py 1d8d9b3384a28124624fc8555010efa9d7ed3cf2 src/test/python/apache/aurora/client/cli/test_task_run.py 56eed9534d5b652c85bbc343e47a3247a8112a53 src/test/python/apache/aurora/client/commands/test_diff.py 730f802844f2eb78d8e2a1c8b1695d53a8e7a407 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f src/test/python/apache/aurora/client/commands/test_run.py bfb9ecc27878815b877151eecb4076a63dbf1036 src/test/python/apache/aurora/client/commands/test_ssh.py 86402f6ea7c0c8d30b5ec957d6bc2fc22e9936fd src/test/python/apache/aurora/client/commands/test_status.py b63f794ec191291591d2587876614f8d1c489717 src/test/python/apache/aurora/config/test_thrift.py 4be11b5d53c286614565f22795f5026cfbe26f0a src/test/resources/org/apache/aurora/gen/api.thrift.md5 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae Diff: https://reviews.apache.org/r/19331/diff/ Testing --- ./build-support/jenkins/build.sh Local client run: - aurora status - aurora update Thanks, Maxim Khutornenko
Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- (Updated March 18, 2014, 12:07 a.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Changes --- Rebased over master. Repository: aurora Description --- Renaming packages to packagesDEPRECATED in client. Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py b9d4e8305a975d93cf4f024e70bfb9798762d6d7 src/main/python/apache/aurora/client/commands/core.py 49fab9f59d744d5b5b59faa33f22318b4219d108 src/main/python/apache/aurora/config/thrift.py 65b962607989134c40c6439f3ce64f52e89dd566 src/test/python/apache/aurora/client/api/test_updater.py c3e259ca11b098d1dd5d588f0c9b0d516639a6fb src/test/python/apache/aurora/client/cli/test_diff.py 758b37ea0d4f7d95934a99a588f6a2c172ab7e83 src/test/python/apache/aurora/client/cli/test_status.py 1d8d9b3384a28124624fc8555010efa9d7ed3cf2 src/test/python/apache/aurora/client/cli/test_task_run.py 56eed9534d5b652c85bbc343e47a3247a8112a53 src/test/python/apache/aurora/client/commands/test_diff.py 730f802844f2eb78d8e2a1c8b1695d53a8e7a407 src/test/python/apache/aurora/client/commands/test_run.py bfb9ecc27878815b877151eecb4076a63dbf1036 src/test/python/apache/aurora/client/commands/test_ssh.py 86402f6ea7c0c8d30b5ec957d6bc2fc22e9936fd src/test/python/apache/aurora/client/commands/test_status.py b63f794ec191291591d2587876614f8d1c489717 src/test/python/apache/aurora/config/test_thrift.py 4be11b5d53c286614565f22795f5026cfbe26f0a Diff: https://reviews.apache.org/r/19331/diff/ Testing --- ./build-support/jenkins/build.sh Local client run: - aurora status - aurora update Thanks, Maxim Khutornenko
Re: Review Request 19078: Part 2 of converting from Packages to Metadata.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/ --- (Updated March 18, 2014, 12:55 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Rebased. Bugs: AURORA-158 https://issues.apache.org/jira/browse/AURORA-158 Repository: aurora Description --- Part 2 of converting from Packages to Metadata. Client side and deprecation removal. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/TransformationUtils.java bfd28a0a3f26128e3763c57a09bb901ab39eb2f9 src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/main/python/apache/aurora/config/__init__.py 58dff95a02ee3777bb8022d84fca42b7b6b5af5c src/main/python/apache/aurora/config/thrift.py 47f592f8c842019e9c7e87592cd3c850a0ade4b6 src/main/thrift/org/apache/aurora/gen/api.thrift e64f844cbd58d92621c6c21b896a9baf0c5a5f07 src/test/python/apache/aurora/client/api/test_updater.py 4a4971d17f49bc716fa1a73b777520b28ae65913 src/test/python/apache/aurora/client/cli/test_diff.py f81e51de66f973b5b9d5f1c725da3057d6a54b05 src/test/python/apache/aurora/client/cli/test_status.py e828f274d7f54581cba763ba965eb87d531f2d81 src/test/python/apache/aurora/client/cli/test_task_run.py 98dc52df0f02a15c41f6b6a00d5876962c6f9045 src/test/python/apache/aurora/client/commands/test_diff.py fc154214574c19e0fff1e4be82cd61dd42f676b6 src/test/python/apache/aurora/client/commands/test_run.py fe666158e0e9ad38b4b4f0c2b91af737eef130cd src/test/python/apache/aurora/client/commands/test_ssh.py 2fe12ef5660f7ae2bf36493e6f1f6bc63ee9ccc7 src/test/python/apache/aurora/client/commands/test_status.py eed798d2475280c787bea749647528cfd0715a40 src/test/python/apache/aurora/config/test_thrift.py 3acd4cce77d5bbab647f1f07facd51d2778a0f35 src/test/resources/org/apache/aurora/gen/api.thrift.md5 456634c76b9993119af2d841073c31a4a1c82ab7 Diff: https://reviews.apache.org/r/19078/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/#review37524 --- build.gradle https://reviews.apache.org/r/19323/#comment69071 revert? - Kevin Sweeney On March 17, 2014, 4:57 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/ --- (Updated March 17, 2014, 4:57 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-271 https://issues.apache.org/jira/browse/AURORA-271 Repository: aurora Description --- Added jobStats on role page. We have stopped counting recently failed task count which is used to display the health badge. Since this badge is being removed from the new UI, removed it from the old UI as well. Diffs - build.gradle f3beb00f69f40e81c1be80f5f6ade84720ae src/main/java/org/apache/aurora/scheduler/base/Jobs.java 3f027032a785810bddfb3ff4dd4e472989c9493f src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b3f3124a73b56e48339f89dbd3b1067527757d04 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ee81b494b9b4dff9839a9e32c9b81fa8ef898e1b src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 3143c6afe8adeb18fac44e92f94b9860753c3eb0 src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st 39c1d9527bff88ff191233629babfd6e6035d4e7 src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 6524e2441d25de6573190866a8559be620961330 Diff: https://reviews.apache.org/r/19323/diff/ Testing --- ./gradlew clean build gradlew run File Attachments job stats https://reviews.apache.org/media/uploaded/files/2014/03/17/65da4a77-4c82-46f8-93d1-34fd319ef60e__Screen_Shot_2014-03-17_at_3.13.36_PM.png Thanks, Suman Karumuri
