Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

[Bill Farner]

> On April 24, 2014, 1:28 p.m., Jake Farrell wrote:
> > Since we are pulling out the run args is there any need for the application 
> > plugin within gradle anymore? can pull out these lines 
> > 
> > apply plugin: 'application'
> > 
> > applicationName = 'aurora-scheduler'
> > mainClassName = 'org.apache.aurora.scheduler.app.SchedulerMain'
> >

At the present time, we still use it for the installApp target in vagrant 
provisioning.  Definitely not a requirement, but makes that ever so slightly 
simpler.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review41295
---


On April 24, 2014, 4:22 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated April 24, 2014, 4:22 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 1bfd4b69584122f62616ce93098a56fe3cf195d8 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> 9186aebef2babc4a76fe05eb3b412be26d7de3c6 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> cc31187607e89a9daebe071a8a180d56d873e4c5 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20469: AURORA-178 - Log snapshot operations

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/#review41437
---


Dave - can you address Maxim's comment?  I assume he will commit at that point.

- Bill Farner


On April 18, 2014, 12:10 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20469/
> ---
> 
> (Updated April 18, 2014, 12:10 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-178
> https://issues.apache.org/jira/browse/AURORA-178
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-178 - Log snapshot operations
> 
> 
> Testing Done:
> ./gradlew build
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> a1a0b428ba42d1abefed18bb40ca54c351154e11 
> 
> Diff: https://reviews.apache.org/r/20469/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

[Dan Norris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20027/
---

(Updated April 25, 2014, 4:21 a.m.)


Review request for Aurora, Jake Farrell and Bill Farner.


Changes
---

Rebase


Bugs: AURORA-234
https://issues.apache.org/jira/browse/AURORA-234


Repository: aurora


Description
---

AURORA-234: Consider using markdown-style tables instead of HTML


Diffs (updated)
-

  docs/configuration-reference.md d469add1088736ce796c8d87324bf7377b444ac1 
  docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
  docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 

Diff: https://reviews.apache.org/r/20027/diff/


Testing
---

Generated the Aurora site using Middleman. Everything renders correctly, though 
I've updated the Jira ticket with a comparison between the two rendered tables.

Commit on Github: 
https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97


Thanks,

Dan Norris

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20027/#review41436
---

Ship it!


Ship It!

- Jake Farrell


On April 9, 2014, 2:31 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20027/
> ---
> 
> (Updated April 9, 2014, 2:31 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-234
> https://issues.apache.org/jira/browse/AURORA-234
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-234: Consider using markdown-style tables instead of HTML
> 
> 
> Diffs
> -
> 
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
>   docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 
> 
> Diff: https://reviews.apache.org/r/20027/diff/
> 
> 
> Testing
> ---
> 
> Generated the Aurora site using Middleman. Everything renders correctly, 
> though I've updated the Jira ticket with a comparison between the two 
> rendered tables.
> 
> Commit on Github: 
> https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20407/#review41435
---


I have some reservations with this, but they're not well-formed.  I like the 
idea of giving committers a chance to chime in on reviews, and we seem to be 
building process around reviewboard for that.  We also have plans to build test 
automation around reviewboard.  This seems to turn github into a "back door" of 
sorts for changes to not receive the same level of scrutiny.  What are your 
thoughts?

- Bill Farner


On April 17, 2014, 4 a.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20407/
> ---
> 
> (Updated April 17, 2014, 4 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-323
> https://issues.apache.org/jira/browse/AURORA-323
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-323:Add ability to merge in github pull requests similar to rbt
> 
> Created a new extension for rbt which adds a new github subcommand to preview 
> and
> merge/commit available pull requests. Adds text to the commit message
> so when github mirrors the given commit the pull request will automatically
> be closed.
> 
> 
> Diffs
> -
> 
>   .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d 
>   rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
> 
> Diff: https://reviews.apache.org/r/20407/diff/
> 
> 
> Testing
> ---
> 
> Preview a pull request patch
> ./rbt github -p 7
> 
> Commit a pull request
> ./rbt github -c 7
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41432
---

Ship it!


Ship It!

- Maxim Khutornenko


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 24, 2014, 8:17 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Add missing @abstracmethod.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.55 seconds 
===

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---



src/main/python/apache/aurora/client/cli/__init__.py


Different cases.

A command hook can signal that a command shouldn't be executed, and return 
the exit code that should be returned to the shell. It's intended to signal 
that there wasn't an error executing the hook, but that the hook requested that 
the command be aborted. 

The hook can also signal an exception, which means that there was an error 
in the hook.




src/main/python/apache/aurora/client/cli/command_hooks.py


d'oh.


- Mark Chu-Carroll


On April 24, 2014, 3:30 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 3:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ===

Re: Review Request 20689: Fixing broken HistoryPruner

[Maxim Khutornenko]

> On April 24, 2014, 10:39 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 
> > 449
> > 
> >
> > for (Map.Entry entry : tasks.entrySet()) {

Wanted to surface any mismatches between IDs and tasks but this is even safer. 
Done, done and done. 


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20689/#review41409
---


On April 24, 2014, 10:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20689/
> ---
> 
> (Updated April 24, 2014, 10:25 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-359
> https://issues.apache.org/jira/browse/AURORA-359
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fetching tasks before handing over to state machine.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 74ef64dd055641d3a74074d4ea51777a70c7cf16 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> af17c2cf0026bea1f339993225590f43b5d44776 
> 
> Diff: https://reviews.apache.org/r/20689/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20689: Fixing broken HistoryPruner

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20689/
---

(Updated April 24, 2014, 10:45 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-359
https://issues.apache.org/jira/browse/AURORA-359


Repository: aurora


Description
---

Fetching tasks before handing over to state machine.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
74ef64dd055641d3a74074d4ea51777a70c7cf16 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
af17c2cf0026bea1f339993225590f43b5d44776 

Diff: https://reviews.apache.org/r/20689/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 20689: Fixing broken HistoryPruner

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20689/#review41409
---

Ship it!



src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java


for (Map.Entry entry : tasks.entrySet()) {



src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java


After the above change,

  Optional.of(entry.getValue())



src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java


remove once Optional.of is used


- Bill Farner


On April 24, 2014, 10:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20689/
> ---
> 
> (Updated April 24, 2014, 10:25 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-359
> https://issues.apache.org/jira/browse/AURORA-359
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fetching tasks before handing over to state machine.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 74ef64dd055641d3a74074d4ea51777a70c7cf16 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> af17c2cf0026bea1f339993225590f43b5d44776 
> 
> Diff: https://reviews.apache.org/r/20689/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 20689: Fixing broken HistoryPruner

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20689/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-359
https://issues.apache.org/jira/browse/AURORA-359


Repository: aurora


Description
---

Fetching tasks before handing over to state machine.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
74ef64dd055641d3a74074d4ea51777a70c7cf16 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
af17c2cf0026bea1f339993225590f43b5d44776 

Diff: https://reviews.apache.org/r/20689/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41384
---


Should the documentation for this feature be part of this review? 


src/main/python/apache/aurora/client/cli/__init__.py


Why error codes rather than exceptions?



src/main/python/apache/aurora/client/cli/command_hooks.py


@abstractmethod



- David McLaughlin


On April 24, 2014, 7:30 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 7:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> === 1 passed in 0.62 seconds 

Re: Review Request 20682: Adding my gpg key.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20682/#review41390
---

Ship it!


Ship It!

- Kevin Sweeney


On April 24, 2014, 2:19 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20682/
> ---
> 
> (Updated April 24, 2014, 2:19 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding my gpg key.
> 
> 
> Diffs
> -
> 
>   KEYS e393e2d16d8ccb5f5bd0d60430b8536908839084 
> 
> Diff: https://reviews.apache.org/r/20682/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 20682: Adding my gpg key.

[Suman Karumuri]

> On April 24, 2014, 7 p.m., Jake Farrell wrote:
> > KEYS, line 299
> > 
> >
> > Missing signature header for key
> > 
> > gpg --list-sigs ...

Added.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20682/#review41370
---


On April 24, 2014, 9:19 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20682/
> ---
> 
> (Updated April 24, 2014, 9:19 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding my gpg key.
> 
> 
> Diffs
> -
> 
>   KEYS e393e2d16d8ccb5f5bd0d60430b8536908839084 
> 
> Diff: https://reviews.apache.org/r/20682/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 20682: Adding my gpg key.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20682/
---

(Updated April 24, 2014, 9:19 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Adding my gpg key.


Diffs (updated)
-

  KEYS e393e2d16d8ccb5f5bd0d60430b8536908839084 

Diff: https://reviews.apache.org/r/20682/diff/


Testing
---


Thanks,

Suman Karumuri

Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

Review request for Aurora, David McLaughlin and Suman Karumuri.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs
-

  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.55 seconds 
===
= test session starts 

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).
> 
> Bill Farner wrote:
> > Is it possible then to exclude everything but the generated-src in dist?
> 
> Yes!  My first attempt was to list and filter the children of dist/.  
> However, this doesn't work if dist/reports or dist/test-results don't exist 
> yet (which would be the case if you ran ./gradlew idea on a fresh clone).
> 
> Maxim Khutornenko wrote:
> This looks promising 
> (http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):
> 
> buildDir.listFiles({d,f->f != 'generated-sources'} as 
> FilenameFilter).each {excludeDirs += it}} // Exclude each buildDir child 
> (except generating-source).
> 
> Jake Farrell wrote:
> excludeDirs = []
> // Exclude everything in dist except the generated-src
> buildDir.listFiles({dir,name -> name != 'generated-src'} as 
> FilenameFilter).each { excludeDirs += it }
>

Rephrasing my comment above, AFAICT you can't do this by listing the contents 
of dist/, since the files you want to exclude might not be there _yet_.  Since 
dist/ is under the project root, anything in there that is not explicitly 
excluded will be indexed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20682: Adding my gpg key.

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20682/#review41370
---



KEYS


Missing signature header for key

gpg --list-sigs ...


- Jake Farrell


On April 24, 2014, 6:55 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20682/
> ---
> 
> (Updated April 24, 2014, 6:55 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding my gpg key.
> 
> 
> Diffs
> -
> 
>   KEYS e393e2d16d8ccb5f5bd0d60430b8536908839084 
> 
> Diff: https://reviews.apache.org/r/20682/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Review Request 20682: Adding my gpg key.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20682/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Adding my gpg key.


Diffs
-

  KEYS e393e2d16d8ccb5f5bd0d60430b8536908839084 

Diff: https://reviews.apache.org/r/20682/diff/


Testing
---


Thanks,

Suman Karumuri

Re: Review Request 20678: Remove unused mootools dependency

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20678/#review41368
---

Ship it!


Ship It!

- Brian Wickman


On April 24, 2014, 6:46 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20678/
> ---
> 
> (Updated April 24, 2014, 6:46 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Brian Wickman.
> 
> 
> Bugs: AURORA-147
> https://issues.apache.org/jira/browse/AURORA-147
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused mootools dependency
> 
> While looking through our dependencies I noticed we don't use this anymore.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/observer/http/assets/mootools-core.js 
> 959afa4a01cfd185c14f8189165bdbde9afee733 
> 
> Diff: https://reviews.apache.org/r/20678/diff/
> 
> 
> Testing
> ---
> 
> git grep mootools
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20678: Remove unused mootools dependency

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20678/#review41365
---

Ship it!


Ship It!

- Jake Farrell


On April 24, 2014, 6:46 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20678/
> ---
> 
> (Updated April 24, 2014, 6:46 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Brian Wickman.
> 
> 
> Bugs: AURORA-147
> https://issues.apache.org/jira/browse/AURORA-147
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused mootools dependency
> 
> While looking through our dependencies I noticed we don't use this anymore.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/observer/http/assets/mootools-core.js 
> 959afa4a01cfd185c14f8189165bdbde9afee733 
> 
> Diff: https://reviews.apache.org/r/20678/diff/
> 
> 
> Testing
> ---
> 
> git grep mootools
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Review Request 20678: Remove unused mootools dependency

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20678/
---

Review request for Aurora, Jake Farrell and Brian Wickman.


Bugs: AURORA-147
https://issues.apache.org/jira/browse/AURORA-147


Repository: aurora


Description
---

Remove unused mootools dependency

While looking through our dependencies I noticed we don't use this anymore.


Diffs
-

  src/main/python/apache/thermos/observer/http/assets/mootools-core.js 
959afa4a01cfd185c14f8189165bdbde9afee733 

Diff: https://reviews.apache.org/r/20678/diff/


Testing
---

git grep mootools


Thanks,

Kevin Sweeney

Re: Review Request 20620: Add machine maintainer auth capability.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20620/#review41356
---

Ship it!


Ship It!

- Maxim Khutornenko


On April 23, 2014, 7:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20620/
> ---
> 
> (Updated April 23, 2014, 7:39 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-348
> https://issues.apache.org/jira/browse/AURORA-348
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add machine maintainer auth capability.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
> a2e215eeebd3f8fc2a5a62b6c6f6dc1c92611a3a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  84151a5308c12b3bee7cf5fd662776e574e8fadf 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  f530c530548444c57d9aeb5ed100a5fda5bd2953 
> 
> Diff: https://reviews.apache.org/r/20620/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Jake Farrell]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).
> 
> Bill Farner wrote:
> > Is it possible then to exclude everything but the generated-src in dist?
> 
> Yes!  My first attempt was to list and filter the children of dist/.  
> However, this doesn't work if dist/reports or dist/test-results don't exist 
> yet (which would be the case if you ran ./gradlew idea on a fresh clone).
> 
> Maxim Khutornenko wrote:
> This looks promising 
> (http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):
> 
> buildDir.listFiles({d,f->f != 'generated-sources'} as 
> FilenameFilter).each {excludeDirs += it}} // Exclude each buildDir child 
> (except generating-source).

excludeDirs = []
// Exclude everything in dist except the generated-src
buildDir.listFiles({dir,name -> name != 'generated-src'} as 
FilenameFilter).each { excludeDirs += it }


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).
> 
> Bill Farner wrote:
> > Is it possible then to exclude everything but the generated-src in dist?
> 
> Yes!  My first attempt was to list and filter the children of dist/.  
> However, this doesn't work if dist/reports or dist/test-results don't exist 
> yet (which would be the case if you ran ./gradlew idea on a fresh clone).

This looks promising 
(http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):

buildDir.listFiles({d,f->f != 'generated-sources'} as FilenameFilter).each 
{excludeDirs += it}} // Exclude each buildDir child (except generating-source).


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 19627: Updates documentation files for markdown consistency

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19627/#review41353
---


Dave - can you push this on a branch to github so we can see it rendered there?

- Bill Farner


On April 24, 2014, 12:43 a.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19627/
> ---
> 
> (Updated April 24, 2014, 12:43 a.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updates documentation to add headers to pages that needed them, cleans up 
> whitespace, and makes markdown for headers consistent.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec 
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 
>   docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
>   docs/developing-aurora-scheduler.md 
> 95bf47278b4cf040ed902e43a151fe9fae19bfc5 
>   docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 
>   docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
>   docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
>   docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 
> 
> Diff: https://reviews.apache.org/r/19627/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 338
> > 
> >
> > +1. This should work just fine:
> > excludeDirs = [file("$buildDir")]
> 
> Bill Farner wrote:
> Replied in thread above.
> 
> Maxim Khutornenko wrote:
> Is it possible then to exclude everything but the generated-src in dist?

Replied in thread above to keep life simpler :-)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).

> Is it possible then to exclude everything but the generated-src in dist?

Yes!  My first attempt was to list and filter the children of dist/.  However, 
this doesn't work if dist/reports or dist/test-results don't exist yet (which 
would be the case if you ran ./gradlew idea on a fresh clone).


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41345
---

Ship it!


Ship It!

- Jake Farrell


On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20583/
> ---
> 
> (Updated April 24, 2014, 1:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pins twitter.common on 0.3.0 (save twitter.common.python which is released 
> out of band.)
> Upgrades aurora to twitter.pants 0.0.18 which uses 
> twitter.common.python==0.5.1 and produces wheels.
> Updates the thrift python namespaces so that the autogenerated python 
> artifacts do not clobber each other.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
>   BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
>   build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
>   pants 56847307fcffb244c1debb14f2250564a9174955 
>   pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 6a21ddeb4203a07a04360f68c4a338fe3da52c70 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> f7605f40b5c4ec864a1bae68649f282268260528 
>   src/main/python/apache/aurora/client/api/health_check.py 
> de7dc69d798e2b90844e95501b4375f90f6e5f94 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 537e417e074468e169062b73ab207331c51d6a30 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> c58bc4bfac47f85f674af15845b06d9f2294fe57 
>   src/main/python/apache/aurora/client/api/restarter.py 
> d060c1b27af2864a33e6524e58b81fe767ec2e98 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> d0e0821a8e8ad38302678ecf686a6028300ebe22 
>   src/main/python/apache/aurora/client/api/sla.py 
> c381de4f1c8eb289efedce9a4efe93d44f44ff62 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9739af025b810c48f10f65edc2c10da88a8b1a2a 
>   src/main/python/apache/aurora/client/base.py 
> a33e65ce2b455148d4944d20bbff638dfca7d34a 
>   src/main/python/apache/aurora/client/cli/context.py 
> 957c788c8b073c3711b81a3d56b29b926c717eaa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 80f7817890c383fec78811ece7d88e90829b067e 
>   src/main/python/apache/aurora/client/cli/task.py 
> e4ee77ede119fc1e3bd196293965073405bb48b3 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 3765a2eb85c1782f0b86d46bec50043d908bb09f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/config.py 
> 855f7091837695658fbcd9003f7f85ee28aacde7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 48e85143040b41f9337fd562151665bc47bb714f 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 53b2a3100a094905b3bf093dd7513aaceaadb074 
>   src/main/python/apache/aurora/config/schema/base.py 
> 4a086b31802a0362a6855390dd0d5b431b3a9551 
>   src/main/python/apache/aurora/config/thrift.py 
> 4cc0f0757df6cae387a1f2c293e361dac95e5914 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 29a05be18febf1a75914b60bc84ad1bd3d629bb1 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> e860a5808ff8c2f2ffc4070d52af5533209b7e59 
>   src/main/python/apache/thermos/testing/runner.py 
> 0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
>   src/main/thrift/org/apache/aurora/gen/BUILD 
> dce379cedc0fe025e59dbed6186f650a58bc42c2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 32596d3da535226e521109a2ae4e5ee112999642 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 95497aea3d3f769b2460adbfe7a7b72d775ced6f 
>   src/test/python/apache/aurora/client/api/test_disambiguator.py 
> d964d9165190ebb86e3cd2a866f537c707456126 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> d503281ac492a72f49f17b48ba306bc2135f4d05 
>   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> f001ba45ca12332c9a2e18ff5348a0e6ce276926 
>   src/test/python/apache/auror

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

> On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 338
> > 
> >
> > +1. This should work just fine:
> > excludeDirs = [file("$buildDir")]
> 
> Bill Farner wrote:
> Replied in thread above.

Is it possible then to exclude everything but the generated-src in dist?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 338
> > 
> >
> > +1. This should work just fine:
> > excludeDirs = [file("$buildDir")]

Replied in thread above.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added

You cannot exclude dist/, since our generated code lands beneath dist (see 
comment immediately above this line).  We could put generated source elsewhere, 
but i don't want to do that without more careful thought (Kevin had the idea to 
use a subproject for code generation, which might be a better route).


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41337
---

Ship it!


Ship It!

- Bill Farner


On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20583/
> ---
> 
> (Updated April 24, 2014, 1:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pins twitter.common on 0.3.0 (save twitter.common.python which is released 
> out of band.)
> Upgrades aurora to twitter.pants 0.0.18 which uses 
> twitter.common.python==0.5.1 and produces wheels.
> Updates the thrift python namespaces so that the autogenerated python 
> artifacts do not clobber each other.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
>   BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
>   build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
>   pants 56847307fcffb244c1debb14f2250564a9174955 
>   pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 6a21ddeb4203a07a04360f68c4a338fe3da52c70 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> f7605f40b5c4ec864a1bae68649f282268260528 
>   src/main/python/apache/aurora/client/api/health_check.py 
> de7dc69d798e2b90844e95501b4375f90f6e5f94 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 537e417e074468e169062b73ab207331c51d6a30 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> c58bc4bfac47f85f674af15845b06d9f2294fe57 
>   src/main/python/apache/aurora/client/api/restarter.py 
> d060c1b27af2864a33e6524e58b81fe767ec2e98 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> d0e0821a8e8ad38302678ecf686a6028300ebe22 
>   src/main/python/apache/aurora/client/api/sla.py 
> c381de4f1c8eb289efedce9a4efe93d44f44ff62 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9739af025b810c48f10f65edc2c10da88a8b1a2a 
>   src/main/python/apache/aurora/client/base.py 
> a33e65ce2b455148d4944d20bbff638dfca7d34a 
>   src/main/python/apache/aurora/client/cli/context.py 
> 957c788c8b073c3711b81a3d56b29b926c717eaa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 80f7817890c383fec78811ece7d88e90829b067e 
>   src/main/python/apache/aurora/client/cli/task.py 
> e4ee77ede119fc1e3bd196293965073405bb48b3 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 3765a2eb85c1782f0b86d46bec50043d908bb09f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/config.py 
> 855f7091837695658fbcd9003f7f85ee28aacde7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 48e85143040b41f9337fd562151665bc47bb714f 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 53b2a3100a094905b3bf093dd7513aaceaadb074 
>   src/main/python/apache/aurora/config/schema/base.py 
> 4a086b31802a0362a6855390dd0d5b431b3a9551 
>   src/main/python/apache/aurora/config/thrift.py 
> 4cc0f0757df6cae387a1f2c293e361dac95e5914 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 29a05be18febf1a75914b60bc84ad1bd3d629bb1 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> e860a5808ff8c2f2ffc4070d52af5533209b7e59 
>   src/main/python/apache/thermos/testing/runner.py 
> 0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
>   src/main/thrift/org/apache/aurora/gen/BUILD 
> dce379cedc0fe025e59dbed6186f650a58bc42c2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 32596d3da535226e521109a2ae4e5ee112999642 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 95497aea3d3f769b2460adbfe7a7b72d775ced6f 
>   src/test/python/apache/aurora/client/api/test_disambiguator.py 
> d964d9165190ebb86e3cd2a866f537c707456126 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> d503281ac492a72f49f17b48ba306bc2135f4d05 
>   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> f001ba45ca12332c9a2e18ff5348a0e6ce276926 
>   src/test/python/apache/aurora

Re: Review Request 20490: Add a "get version" API method.

[Brian Wickman]

Make sure to close the reviewboard, otherwise it will continue to show up
in review dashboards.


On Thu, Apr 24, 2014 at 10:20 AM, Mark Chu-Carroll
wrote:

> It's already pushed.
>
>
> On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman  wrote:
>
>>This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/20490/
>>
>> if this merges to master after r/20583, you will need to kill the directory 
>> wrapper stuff.  if it merges before r/20583, i will have to kill the 
>> directory wrapper stuff :-)  since this goes away in twitter.common.python 
>> >=0.4.0.
>>
>>
>> - Brian Wickman
>>
>> On April 22nd, 2014, 7:59 p.m. UTC, Mark Chu-Carroll wrote:
>>   Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>> By Mark Chu-Carroll.
>>
>> *Updated April 22, 2014, 7:59 p.m.*
>>  *Repository: * aurora
>> Description
>>
>> Add a "get version" API method. (This is needed for a logging-related change 
>> for twitter.)
>>
>> While I'm in there, fix a bug in "job list".
>>
>>   Testing
>>
>> ./pants src/test/python/apache/aurora/client:all
>> Build operating on targets: 
>> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 2 items
>>
>> src/test/python/apache/aurora/client/test_binding_helper.py ..
>>
>> == 2 passed in 0.39 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/test_config.py ..
>>
>> == 6 passed in 0.47 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
>>
>> == 6 passed in 0.46 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 1 items
>>
>> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>>
>> == 1 passed in 0.41 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/api/test_restarter.py ..
>>
>> == 6 passed in 0.36 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 47 items / 1 skipped
>>
>> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
>> ...
>>
>>  47 passed, 1 skipped in 3.83 seconds 
>> 
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 20 items
>>
>> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
>> src/test/python/apache/aurora/client/api/test_health_check.py 
>>
>> = 20 passed in 0.24 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 27 items
>>
>> src/test/python/apache/aurora/client/api/test_updater.py 
>> ...
>>
>> = 27 passed in 0.64 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/api/test_quota_check.py ..
>>
>> == 6 passed in 0.15 seconds 
>> ==
>>  test session starts

Re: Review Request 20490: Add a "get version" API method.

[Mark Chu-Carroll]

It's already pushed.


On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
>
> if this merges to master after r/20583, you will need to kill the directory 
> wrapper stuff.  if it merges before r/20583, i will have to kill the 
> directory wrapper stuff :-)  since this goes away in twitter.common.python 
> >=0.4.0.
>
>
> - Brian Wickman
>
> On April 22nd, 2014, 7:59 p.m. UTC, Mark Chu-Carroll wrote:
>   Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated April 22, 2014, 7:59 p.m.*
>  *Repository: * aurora
> Description
>
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
>
> While I'm in there, fix a bug in "job list".
>
>   Testing
>
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ..
>
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
>
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ..
>
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
>
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
>
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
>
> = 27 passed in 0.64 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ..
>
> == 6 passed in 0.15 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 31 items
>
> src/test/python/apache/aurora/client/api/test_sla.py 
> ...
>
> = 31 pas

Re: Review Request 20394: Add return code to task/process pages

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20394/#review41336
---

Ship it!


in the future it's customary to attach screenshots for UI changes.


src/main/python/apache/thermos/observer/http/templates/task.tpl


kill trailing ws


- Brian Wickman


On April 16, 2014, 9:38 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20394/
> ---
> 
> (Updated April 16, 2014, 9:38 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add return code to task/process pages
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/observer/http/http_observer.py 
> 118bd2f4889c520683ba04b554d699ecf0bc20ce 
>   src/main/python/apache/thermos/observer/http/templates/process.tpl 
> a7fb90d4decec01cb95f9e5d42288eaae9d71edf 
>   src/main/python/apache/thermos/observer/http/templates/task.tpl 
> b71c80d11255c111873a46b99478c36d39cc8733 
>   src/main/python/apache/thermos/observer/task_observer.py 
> ea40bfa610e2af90904487c809bc83b8b5f214d9 
> 
> Diff: https://reviews.apache.org/r/20394/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 20490: Add a "get version" API method.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review41335
---


if this merges to master after r/20583, you will need to kill the directory 
wrapper stuff.  if it merges before r/20583, i will have to kill the directory 
wrapper stuff :-)  since this goes away in twitter.common.python >=0.4.0.

- Brian Wickman


On April 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
> ---
> 
> (Updated April 22, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
> 
> While I'm in there, fix a bug in "job list".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0793a1ae4bd5d641ea57473705076290d77ac2b6 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 
> 
> Diff: https://reviews.apache.org/r/20490/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> = 27 passed in 0.64 seconds 
> =

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41331
---


e2e results:

Built pants-0.0.21.pex
Build operating on targets: 
OrderedSet([PythonBinary(src/main/python/apache/aurora/client/bin/BUILD:aurora_client)])
Building PythonBinary 
PythonBinary(src/main/python/apache/aurora/client/bin/BUILD:aurora_client):
Wrote /home/vagrant/test_dev/dist/aurora_client.pex
+ run_dev 'cd ~/test_dev; ./pants 
src/test/sh/org/apache/aurora/e2e/flask:flask_example'
+ vagrant ssh devcluster -c 'cd ~/test_dev; ./pants 
src/test/sh/org/apache/aurora/e2e/flask:flask_example'
Build operating on targets: 
OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)])
Building PythonBinary 
PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example):
Wrote /home/vagrant/test_dev/dist/flask_example.pex
+ '[' '!' -d deploy_test ']'
+ mkdir deploy_test
+ run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test'
+ vagrant ssh devcluster -c 'cd ~/test_dev; cp dist/flask_example.pex 
/vagrant/deploy_test'
+ run_dev 'cd ~/test_dev; cp dist/aurora_client.pex /vagrant/deploy_test'
+ vagrant ssh devcluster -c 'cd ~/test_dev; cp dist/aurora_client.pex 
/vagrant/deploy_test'
+ test_flask_example devcluster vagrant test flask_example deploy_test 
192.168.33.7 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora
+ local _cluster=devcluster _role=vagrant _env=test _job=flask_example 
_testdir=deploy_test _sched_ip=192.168.33.7
+ local 
_base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora
 
_updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora
+ jobkey=devcluster/vagrant/test/flask_example
+ echo '== Creating job'
== Creating job
+ run_sched '/vagrant/deploy_test/aurora_client.pex create 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex create 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora'
 INFO] Creating job flask_example
 INFO] Response from scheduler: OK (message: 2 new tasks pending for job 
vagrant/test/flask_example)
 INFO] Job url: http://192.168.33.7:8081/scheduler/vagrant/test/flask_example
+ base_url=http://192.168.33.7:8081
++ _curl -s http://192.168.33.7:8081/vars
++ grep jvm_uptime_secs
++ curl --silent --fail --retry 4 --retry-delay 10 -s 
http://192.168.33.7:8081/vars
++ wc -l
+ uptime='   1'
+ test 1 -eq 1
+ echo '== Updating test job'
== Updating test job
+ run_sched '/vagrant/deploy_test/aurora_client.pex update 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex update 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora'
 INFO] Updating job: flask_example
 INFO] Starting job update.
 INFO] Examining instances: [0]
 INFO] Killing instances: [0]
 INFO] Instances killed
 INFO] Adding instances: [0]
 INFO] Instances added
 INFO] Watching instances: [0]
 INFO] Detected RUNNING instance 0
 INFO] Instance 0 has been up and healthy for at least 30 seconds
 INFO] Examining instances: [1]
 INFO] Killing instances: [1]
 INFO] Instances killed
 INFO] Adding instances: [1]
 INFO] Instances added
 INFO] Watching instances: [1]
 INFO] Detected RUNNING instance 1
 INFO] Instance 1 has been up and healthy for at least 30 seconds
 INFO] Update successful
 INFO] Response from scheduler: OK (message: Lock has been released.)
++ run_sched '/vagrant/deploy_test/aurora_client.pex run 
devcluster/vagrant/test/flask_example '\''pwd'\'''
++ wc -l
++ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex run 
devcluster/vagrant/test/flask_example '\''pwd'\'''
+ runlen='   2'
+ test 2 -eq 2
+ run_sched '/vagrant/deploy_test/aurora_client.pex get_quota 
--cluster=devcluster vagrant'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex get_quota 
--cluster=devcluster vagrant'
 INFO] Getting quota for: vagrant
 INFO] Total allocated quota for vagrant:
CPU 0.0
RAM 0.00 GB
Disk0.00 GB
 INFO] Resources consumed by production jobs for vagrant:
CPU 0.0
RAM 0.00 GB
Disk0.00 GB
 INFO] Resources consumed by non-production jobs for vagrant:
CPU 2.0
RAM 0.125000 GB
Disk0.187500 GB
+ run_sched '/vagrant/deploy_test/aurora_client.pex killall  
devcluster/vagrant/test/flask_example'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_cli

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Brian Wickman]

> On April 24, 2014, 1:37 p.m., Jake Farrell wrote:
> > Dan has a review up for testing the version of python in use for 
> > development, do we want to pull 2.6 out of that check list if we are seeing 
> > these errors from stdlib caused in that version?

no, don't worry about it.  the latest pex sync (twitter.common.python 0.5.4) 
mutes these exceptions.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41300
---


On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20583/
> ---
> 
> (Updated April 24, 2014, 1:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pins twitter.common on 0.3.0 (save twitter.common.python which is released 
> out of band.)
> Upgrades aurora to twitter.pants 0.0.18 which uses 
> twitter.common.python==0.5.1 and produces wheels.
> Updates the thrift python namespaces so that the autogenerated python 
> artifacts do not clobber each other.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
>   BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
>   build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
>   pants 56847307fcffb244c1debb14f2250564a9174955 
>   pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 6a21ddeb4203a07a04360f68c4a338fe3da52c70 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> f7605f40b5c4ec864a1bae68649f282268260528 
>   src/main/python/apache/aurora/client/api/health_check.py 
> de7dc69d798e2b90844e95501b4375f90f6e5f94 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 537e417e074468e169062b73ab207331c51d6a30 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> c58bc4bfac47f85f674af15845b06d9f2294fe57 
>   src/main/python/apache/aurora/client/api/restarter.py 
> d060c1b27af2864a33e6524e58b81fe767ec2e98 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> d0e0821a8e8ad38302678ecf686a6028300ebe22 
>   src/main/python/apache/aurora/client/api/sla.py 
> c381de4f1c8eb289efedce9a4efe93d44f44ff62 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9739af025b810c48f10f65edc2c10da88a8b1a2a 
>   src/main/python/apache/aurora/client/base.py 
> a33e65ce2b455148d4944d20bbff638dfca7d34a 
>   src/main/python/apache/aurora/client/cli/context.py 
> 957c788c8b073c3711b81a3d56b29b926c717eaa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 80f7817890c383fec78811ece7d88e90829b067e 
>   src/main/python/apache/aurora/client/cli/task.py 
> e4ee77ede119fc1e3bd196293965073405bb48b3 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 3765a2eb85c1782f0b86d46bec50043d908bb09f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/config.py 
> 855f7091837695658fbcd9003f7f85ee28aacde7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 48e85143040b41f9337fd562151665bc47bb714f 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 53b2a3100a094905b3bf093dd7513aaceaadb074 
>   src/main/python/apache/aurora/config/schema/base.py 
> 4a086b31802a0362a6855390dd0d5b431b3a9551 
>   src/main/python/apache/aurora/config/thrift.py 
> 4cc0f0757df6cae387a1f2c293e361dac95e5914 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 29a05be18febf1a75914b60bc84ad1bd3d629bb1 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> e860a5808ff8c2f2ffc4070d52af5533209b7e59 
>   src/main/python/apache/thermos/testing/runner.py 
> 0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
>   src/main/thrift/org/apache/aurora/gen/BUILD 
> dce379cedc0fe025e59dbed6186f650a58bc42c2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 32596d3da535226e521109a2ae4e5ee112999642 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 95497aea3d3f769b2460adbfe7a7b72d775ced6f 
>   src/test/python/apache/aurora/c

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41330
---


e2e results:

Built pants-0.0.21.pex
Build operating on targets: 
OrderedSet([PythonBinary(src/main/python/apache/aurora/client/bin/BUILD:aurora_client)])
Building PythonBinary 
PythonBinary(src/main/python/apache/aurora/client/bin/BUILD:aurora_client):
Wrote /home/vagrant/test_dev/dist/aurora_client.pex
+ run_dev 'cd ~/test_dev; ./pants 
src/test/sh/org/apache/aurora/e2e/flask:flask_example'
+ vagrant ssh devcluster -c 'cd ~/test_dev; ./pants 
src/test/sh/org/apache/aurora/e2e/flask:flask_example'
Build operating on targets: 
OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)])
Building PythonBinary 
PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example):
Wrote /home/vagrant/test_dev/dist/flask_example.pex
+ '[' '!' -d deploy_test ']'
+ mkdir deploy_test
+ run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test'
+ vagrant ssh devcluster -c 'cd ~/test_dev; cp dist/flask_example.pex 
/vagrant/deploy_test'
+ run_dev 'cd ~/test_dev; cp dist/aurora_client.pex /vagrant/deploy_test'
+ vagrant ssh devcluster -c 'cd ~/test_dev; cp dist/aurora_client.pex 
/vagrant/deploy_test'
+ test_flask_example devcluster vagrant test flask_example deploy_test 
192.168.33.7 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora
+ local _cluster=devcluster _role=vagrant _env=test _job=flask_example 
_testdir=deploy_test _sched_ip=192.168.33.7
+ local 
_base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora
 
_updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora
+ jobkey=devcluster/vagrant/test/flask_example
+ echo '== Creating job'
== Creating job
+ run_sched '/vagrant/deploy_test/aurora_client.pex create 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex create 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora'
 INFO] Creating job flask_example
 INFO] Response from scheduler: OK (message: 2 new tasks pending for job 
vagrant/test/flask_example)
 INFO] Job url: http://192.168.33.7:8081/scheduler/vagrant/test/flask_example
+ base_url=http://192.168.33.7:8081
++ _curl -s http://192.168.33.7:8081/vars
++ grep jvm_uptime_secs
++ curl --silent --fail --retry 4 --retry-delay 10 -s 
http://192.168.33.7:8081/vars
++ wc -l
+ uptime='   1'
+ test 1 -eq 1
+ echo '== Updating test job'
== Updating test job
+ run_sched '/vagrant/deploy_test/aurora_client.pex update 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex update 
devcluster/vagrant/test/flask_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora'
 INFO] Updating job: flask_example
 INFO] Starting job update.
 INFO] Examining instances: [0]
 INFO] Killing instances: [0]
 INFO] Instances killed
 INFO] Adding instances: [0]
 INFO] Instances added
 INFO] Watching instances: [0]
 INFO] Detected RUNNING instance 0
 INFO] Instance 0 has been up and healthy for at least 30 seconds
 INFO] Examining instances: [1]
 INFO] Killing instances: [1]
 INFO] Instances killed
 INFO] Adding instances: [1]
 INFO] Instances added
 INFO] Watching instances: [1]
 INFO] Detected RUNNING instance 1
 INFO] Instance 1 has been up and healthy for at least 30 seconds
 INFO] Update successful
 INFO] Response from scheduler: OK (message: Lock has been released.)
++ run_sched '/vagrant/deploy_test/aurora_client.pex run 
devcluster/vagrant/test/flask_example '\''pwd'\'''
++ wc -l
++ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex run 
devcluster/vagrant/test/flask_example '\''pwd'\'''
+ runlen='   2'
+ test 2 -eq 2
+ run_sched '/vagrant/deploy_test/aurora_client.pex get_quota 
--cluster=devcluster vagrant'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_client.pex get_quota 
--cluster=devcluster vagrant'
 INFO] Getting quota for: vagrant
 INFO] Total allocated quota for vagrant:
CPU 0.0
RAM 0.00 GB
Disk0.00 GB
 INFO] Resources consumed by production jobs for vagrant:
CPU 0.0
RAM 0.00 GB
Disk0.00 GB
 INFO] Resources consumed by non-production jobs for vagrant:
CPU 2.0
RAM 0.125000 GB
Disk0.187500 GB
+ run_sched '/vagrant/deploy_test/aurora_client.pex killall  
devcluster/vagrant/test/flask_example'
+ vagrant ssh devcluster -c '/vagrant/deploy_test/aurora_cli

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---



build.gradle


+1. This should work just fine:
excludeDirs = [file("$buildDir")]


- Maxim Khutornenko


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review41304
---


This is on master now.

- Maxim Khutornenko


On April 24, 2014, 2:55 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> ---
> 
> (Updated April 24, 2014, 2:55 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
> https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> 3db34ecf9a977fe4c84d1d00990d90248b40316e 
> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> ---
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was 
> messed up. I'm not sure how to force a task with the Vagrant file into 
> DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41300
---


Dan has a review up for testing the version of python in use for development, 
do we want to pull 2.6 out of that check list if we are seeing these errors 
from stdlib caused in that version?

- Jake Farrell


On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20583/
> ---
> 
> (Updated April 24, 2014, 1:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pins twitter.common on 0.3.0 (save twitter.common.python which is released 
> out of band.)
> Upgrades aurora to twitter.pants 0.0.18 which uses 
> twitter.common.python==0.5.1 and produces wheels.
> Updates the thrift python namespaces so that the autogenerated python 
> artifacts do not clobber each other.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
>   BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
>   build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
>   pants 56847307fcffb244c1debb14f2250564a9174955 
>   pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 6a21ddeb4203a07a04360f68c4a338fe3da52c70 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> f7605f40b5c4ec864a1bae68649f282268260528 
>   src/main/python/apache/aurora/client/api/health_check.py 
> de7dc69d798e2b90844e95501b4375f90f6e5f94 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 537e417e074468e169062b73ab207331c51d6a30 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> c58bc4bfac47f85f674af15845b06d9f2294fe57 
>   src/main/python/apache/aurora/client/api/restarter.py 
> d060c1b27af2864a33e6524e58b81fe767ec2e98 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> d0e0821a8e8ad38302678ecf686a6028300ebe22 
>   src/main/python/apache/aurora/client/api/sla.py 
> c381de4f1c8eb289efedce9a4efe93d44f44ff62 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9739af025b810c48f10f65edc2c10da88a8b1a2a 
>   src/main/python/apache/aurora/client/base.py 
> a33e65ce2b455148d4944d20bbff638dfca7d34a 
>   src/main/python/apache/aurora/client/cli/context.py 
> 957c788c8b073c3711b81a3d56b29b926c717eaa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 80f7817890c383fec78811ece7d88e90829b067e 
>   src/main/python/apache/aurora/client/cli/task.py 
> e4ee77ede119fc1e3bd196293965073405bb48b3 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 3765a2eb85c1782f0b86d46bec50043d908bb09f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/config.py 
> 855f7091837695658fbcd9003f7f85ee28aacde7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 48e85143040b41f9337fd562151665bc47bb714f 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 53b2a3100a094905b3bf093dd7513aaceaadb074 
>   src/main/python/apache/aurora/config/schema/base.py 
> 4a086b31802a0362a6855390dd0d5b431b3a9551 
>   src/main/python/apache/aurora/config/thrift.py 
> 4cc0f0757df6cae387a1f2c293e361dac95e5914 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 29a05be18febf1a75914b60bc84ad1bd3d629bb1 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> e860a5808ff8c2f2ffc4070d52af5533209b7e59 
>   src/main/python/apache/thermos/testing/runner.py 
> 0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
>   src/main/thrift/org/apache/aurora/gen/BUILD 
> dce379cedc0fe025e59dbed6186f650a58bc42c2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 32596d3da535226e521109a2ae4e5ee112999642 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 95497aea3d3f769b2460adbfe7a7b72d775ced6f 
>   src/test/python/apache/aurora/client/api/test_disambiguator.py 
> d964d9165190ebb86e3cd2a866f537c707456126 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> d503281ac492a72f

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/#review41299
---


Dan has a review up for testing the version of python in use for development, 
do we want to pull 2.6 out of that check list if we are seeing these errors 
from stdlib caused in that version?

- Jake Farrell


On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20583/
> ---
> 
> (Updated April 24, 2014, 1:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pins twitter.common on 0.3.0 (save twitter.common.python which is released 
> out of band.)
> Upgrades aurora to twitter.pants 0.0.18 which uses 
> twitter.common.python==0.5.1 and produces wheels.
> Updates the thrift python namespaces so that the autogenerated python 
> artifacts do not clobber each other.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
>   BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
>   build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
>   pants 56847307fcffb244c1debb14f2250564a9174955 
>   pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 6a21ddeb4203a07a04360f68c4a338fe3da52c70 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> f7605f40b5c4ec864a1bae68649f282268260528 
>   src/main/python/apache/aurora/client/api/health_check.py 
> de7dc69d798e2b90844e95501b4375f90f6e5f94 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 537e417e074468e169062b73ab207331c51d6a30 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> c58bc4bfac47f85f674af15845b06d9f2294fe57 
>   src/main/python/apache/aurora/client/api/restarter.py 
> d060c1b27af2864a33e6524e58b81fe767ec2e98 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> d0e0821a8e8ad38302678ecf686a6028300ebe22 
>   src/main/python/apache/aurora/client/api/sla.py 
> c381de4f1c8eb289efedce9a4efe93d44f44ff62 
>   src/main/python/apache/aurora/client/api/updater.py 
> 9739af025b810c48f10f65edc2c10da88a8b1a2a 
>   src/main/python/apache/aurora/client/base.py 
> a33e65ce2b455148d4944d20bbff638dfca7d34a 
>   src/main/python/apache/aurora/client/cli/context.py 
> 957c788c8b073c3711b81a3d56b29b926c717eaa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 80f7817890c383fec78811ece7d88e90829b067e 
>   src/main/python/apache/aurora/client/cli/task.py 
> e4ee77ede119fc1e3bd196293965073405bb48b3 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 3765a2eb85c1782f0b86d46bec50043d908bb09f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/config.py 
> 855f7091837695658fbcd9003f7f85ee28aacde7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 48e85143040b41f9337fd562151665bc47bb714f 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 53b2a3100a094905b3bf093dd7513aaceaadb074 
>   src/main/python/apache/aurora/config/schema/base.py 
> 4a086b31802a0362a6855390dd0d5b431b3a9551 
>   src/main/python/apache/aurora/config/thrift.py 
> 4cc0f0757df6cae387a1f2c293e361dac95e5914 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 29a05be18febf1a75914b60bc84ad1bd3d629bb1 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> e860a5808ff8c2f2ffc4070d52af5533209b7e59 
>   src/main/python/apache/thermos/testing/runner.py 
> 0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
>   src/main/thrift/org/apache/aurora/gen/BUILD 
> dce379cedc0fe025e59dbed6186f650a58bc42c2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 32596d3da535226e521109a2ae4e5ee112999642 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 95497aea3d3f769b2460adbfe7a7b72d775ced6f 
>   src/test/python/apache/aurora/client/api/test_disambiguator.py 
> d964d9165190ebb86e3cd2a866f537c707456126 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> d503281ac492a72f

Re: Review Request 19627: Updates documentation files for markdown consistency

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19627/#review41296
---

Ship it!


Thanks for tackling this Dave, looks good for doc -> site

- Jake Farrell


On April 24, 2014, 12:43 a.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19627/
> ---
> 
> (Updated April 24, 2014, 12:43 a.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updates documentation to add headers to pages that needed them, cleans up 
> whitespace, and makes markdown for headers consistent.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec 
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 
>   docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
>   docs/developing-aurora-scheduler.md 
> 95bf47278b4cf040ed902e43a151fe9fae19bfc5 
>   docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 
>   docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
>   docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
>   docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 
> 
> Diff: https://reviews.apache.org/r/19627/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review41295
---

Ship it!


Since we are pulling out the run args is there any need for the application 
plugin within gradle anymore? can pull out these lines 

apply plugin: 'application'

applicationName = 'aurora-scheduler'
mainClassName = 'org.apache.aurora.scheduler.app.SchedulerMain'


- Jake Farrell


On April 24, 2014, 4:22 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated April 24, 2014, 4:22 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 1bfd4b69584122f62616ce93098a56fe3cf195d8 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> 9186aebef2babc4a76fe05eb3b412be26d7de3c6 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> cc31187607e89a9daebe071a8a180d56d873e4c5 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Jake Farrell]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?

+1 with dist added


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution

[Jake Farrell]

> On April 1, 2014, 3:38 p.m., Bill Farner wrote:
> > Just for clarity — i'll review/ship this once 
> > https://reviews.apache.org/r/19767/ is on master.

This patch remains the same with the recently committed (and then reverted) 
cron updates.

After this patch FileLogStreamModule.java will be the last testing dep in main, 
unless we count FakeClock (from twitter.commons util-testing)


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19796/#review39162
---


On March 28, 2014, 7:28 p.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19796/
> ---
> 
> (Updated March 28, 2014, 7:28 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-145
> https://issues.apache.org/jira/browse/AURORA-145
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-145:Test dependencies leak into distribution
> 
> Moves testing dependencies out of main src into test.
> 
> 
> Diffs
> -
> 
>   build.gradle f10f22cb27dca28d1087a03b12d0defcaf1a7836 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>   
>   
> src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
>   
> 
> Diff: https://reviews.apache.org/r/19796/diff/
> 
> 
> Testing
> ---
> 
> Was initially waiting on AURORA-132 for this. ran 
> build-support/jenkins/build.sh and created dists with no issues.
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>