Re: Review Request 21025: Adjusting default health check config values.

2014-05-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21025/#review42065 --- Ship it! Ship It! - Kevin Sweeney On May 2, 2014, 1:26 p.m., Max

Re: Review Request 21025: Adjusting default health check config values.

2014-05-02 Thread Maxim Khutornenko
> On May 2, 2014, 9:30 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 89 > > > > > > If we're making a breaking change anyway would it make sense to take > > care of this depre

Re: Review Request 21025: Adjusting default health check config values.

2014-05-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21025/#review42062 --- src/main/python/apache/aurora/config/schema/base.py

Re: Review Request 21025: Adjusting default health check config values.

2014-05-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21025/#review42061 --- Ship it! Ship It! - Brian Wickman On May 2, 2014, 8:26 p.m., Max

Re: Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.

2014-05-02 Thread Mark Chu-Carroll
Thanks guys! This has been pushed to master. On Fri, May 2, 2014 at 4:33 PM, David McLaughlin wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21023/ > > Ship it! > > Ship It! > > > - David McLaughlin > > On May 2nd, 2014, 8:02 p.m. UTC, Mar

Re: Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.

2014-05-02 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/#review42055 --- Ship it! Ship It! - David McLaughlin On May 2, 2014, 8:02 p.m.,

Review Request 21025: Adjusting default health check config values.

2014-05-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21025/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-376

Re: Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.

2014-05-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/ --- (Updated May 2, 2014, 4:02 p.m.) Review request for Aurora, David McLaughlin an

Re: Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.

2014-05-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/#review42049 --- Ship it! src/main/python/apache/aurora/client/cli/bridge.py

Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.

2014-05-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Repository: auro

Re: Review Request 21020: Set owner field correctly in getTasksStatus call

2014-05-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21020/#review42042 --- Ship it! Ship It! - Mark Chu-Carroll On May 2, 2014, 2:55 p.m.,

Review Request 21020: Set owner field correctly in getTasksStatus call

2014-05-02 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21020/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-373 https://is

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review42025 --- Ship it! Ship It! - Brian Wickman On May 1, 2014, 10:21 p.m., Ma

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Brian Wickman
> On May 1, 2014, 8:59 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/job_monitor.py, line 81 > > > > > > >= > > Maxim Khutornenko wrote: > It's safe as is but since Mark asked about this t

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Maxim Khutornenko
> On May 1, 2014, 8:59 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/job_monitor.py, line 81 > > > > > > >= > > Maxim Khutornenko wrote: > It's safe as is but since Mark asked about this t