Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

How about exit non-zero, and re-run the same drain again later if so? -Toby. On Mon, Jun 23, 2014 at 5:25 PM, Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22842/#rev

Re: Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/ --- (Updated June 24, 2014, 2:16 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22794: Add initial_collection_delay flags for stats

> On June 19, 2014, 10:47 p.m., Bill Farner wrote: > > Can you elaborate (preferably in a comment) why an operator would want to > > adjust this, rather than exposing the data as soon as it's available? > > Kevin Sweeney wrote: > What do you have in mind here? Presumably this would be simi

Re: Review Request 22794: Add initial_collection_delay flags for stats

> On June 19, 2014, 3:47 p.m., Bill Farner wrote: > > Can you elaborate (preferably in a comment) why an operator would want to > > adjust this, rather than exposing the data as soon as it's available? What do you have in mind here? - Kevin --

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46479 --- Hm... can we write these unsafe hosts to a file? That'd be very help

Re: Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/#review46480 --- Ship it! Ship It! - Bill Farner On June 23, 2014, 11:49 p.m., Br

Re: Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/#review46478 --- Ship it! Ship It! - Kevin Sweeney On June 23, 2014, 4:49 p.m., B

Re: Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/#review46477 --- Ship it! Ship It! - Joe Smith On June 23, 2014, 4:49 p.m., Brian

Re: Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/ --- (Updated June 23, 2014, 11:49 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22894/#review46471 --- Ship it! thanks- I should've also run the end-to-end tests as part

Re: Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/#review46470 --- examples/vagrant/provision-dev-cluster.sh

Review Request 22896: Fix the end-to-end test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-480

Re: Review Request 22429: Add getConfigGroupSummary API endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 23, 2014, 10:43 p.m.) Review request for Aurora, Kevin Sweeney, M

Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22894/ --- (Updated June 23, 2014, 10:38 p.m.) Review request for Aurora, Joe Smith and Bi

Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22894/ --- (Updated June 23, 2014, 10:38 p.m.) Review request for Aurora, Joe Smith and De

Re: Review Request 22429: Add getConfigGroupSummary API endpoint

> On June 23, 2014, 10:21 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 436 > > > > > > redundant with the line below Removed. > On June 23, 2

Re: Review Request 22429: Add getConfigGroupSummary API endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 23, 2014, 10:36 p.m.) Review request for Aurora, Kevin Sweeney, M

Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22894/#review46465 --- Ship it! Ship It! - Bill Farner On June 23, 2014, 10:17 p.m., Br

Re: Review Request 22429: Add getConfigGroupSummary API endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review46464 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Re: Review Request 22486: Remove red from the config grouping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22486/#review46463 --- Ship it! Ship It! - Mark Chu-Carroll On June 11, 2014, 8:07 p.m.

Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22894/ --- Review request for Aurora and Joe Smith. Bugs: AURORA-543 https://issues.ap

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46461 --- Ship it! Ship It! - David McLaughlin On June 20, 2014, 9:40 p.m.

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /

Re: Review Request 22097: Remove unused thrift flags from scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22097/ --- (Updated June 23, 2014, 2:28 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21459: Database-backed implementation of QuotaStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- (Updated June 23, 2014, 9:23 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21459: Database-backed implementation of QuotaStore.

> On May 15, 2014, 10:44 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java, > > lines 28-36 > > > > > > Please add docs, particularly to merge. Thanks for the nudg

Re: Review Request 22697: Documenting SLA stats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22697/#review46442 --- Overall the content looks good and thorough. Can you push a branch