Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51781 --- Ping, Kevin. - Maxim Khutornenko On Aug. 22, 2014, 8:55 p.m.,

Re: Review Request 24752: combine finalization_wait when combining tasks

2014-08-28 Thread Matthew Jeffryes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/ --- (Updated Aug. 28, 2014, 3:27 p.m.) Review request for Aurora, Bill Farner and

Review Request 25159: Adding pause/resume/abort client APIs.

2014-08-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25159/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-615

Re: Review Request 25159: Adding pause/resume/abort client APIs.

2014-08-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25159/#review51807 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 28, 2014, 2:16

Re: Review Request 25158: Aurora Update UI

2014-08-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25158/#review51808 --- This looks nice! I'm assuming the grid is changes in real time as

Re: Review Request 25158: Aurora Update UI

2014-08-28 Thread Maxim Khutornenko
On Aug. 28, 2014, 6:51 p.m., Joshua Cohen wrote: This looks nice! I'm assuming the grid is changes in real time as instances are updated? I think I prefer the big preview (the one with the grid as opposed to the progress bar). What are your thoughts on including the update

Re: Review Request 25133: Fixing race in task secondary index.

2014-08-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25133/#review51823 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2014, 6:19 p.m.,

Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51824 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 28, 2014, 8:58 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51837 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-28 Thread Maxim Khutornenko
On Aug. 28, 2014, 10:07 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 60 https://reviews.apache.org/r/24995/diff/2/?file=671531#file671531line60 Rather than the deduped map would it make sense to take toKill:

Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51845 --- Ship it! Ship It! - Kevin Sweeney On Aug. 28, 2014, 1:58 p.m.,

Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

2014-08-28 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/ --- Review request for Aurora. Bugs: AURORA-669