Re: Review Request 25839: Fixing python tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25839/#review53975 --- Ship it! Ship It! - Bill Farner On Sept. 19, 2014, 5:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25839/ --- (Updated Sept. 19, 2014, 5:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- The https://reviews.apache.org/r/25807/ broke api tests. Diffs - src/test/python/apache/aurora/client/api/test_api.py 6469ba28eeb76a108fe5667969c46d6308d88de9 Diff: https://reviews.apache.org/r/25839/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Review Request 25815: Improve performance of fetching host attributes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-730 https://issues.apache.org/jira/browse/AURORA-730 Repository: aurora Description --- This patch enables the MyBatis 2nd level cache [1] for the AttributeMapper namespace. Based on some ad-hoc local benchmarking, this improves performance by about 50x (when the cache is primed). MyBatis flushes these caches on insert/update, so it's important we don't unnecessarily write to the table. For this reason, I've also suppressed no-op writes. [1] http://mybatis.github.io/mybatis-3/sqlmap-xml.html#cache Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 1b18ad5ab8e640d64f5de0aebdc98d0f8dc411c2 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 95fbd8950350786582dcd9dbfbe8b56f9f866700 src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 53017c8806d2a5cdd1d181fd156afc9afca2faf7 src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 4a31999559dce4cfe50b22fc97d1500c9528a242 Diff: https://reviews.apache.org/r/25815/diff/ Testing --- ./gradlew build -Pq Lacking a story for performance testing, i failed to come up with a good way to prove that these help. Best answer i have is local testing (creating a store with ~20k attributes and issuing 1M random queries is repeatably ~50x faster), and 100% line/branch test coverage to prove we hit the no-op exit. Thanks, Bill Farner
Re: Review Request 25815: Improve performance of fetching host attributes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- (Updated Sept. 19, 2014, 6:33 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes --- people -= ksweeney, += zmanji Bugs: AURORA-730 https://issues.apache.org/jira/browse/AURORA-730 Repository: aurora Description --- This patch enables the MyBatis 2nd level cache [1] for the AttributeMapper namespace. Based on some ad-hoc local benchmarking, this improves performance by about 50x (when the cache is primed). MyBatis flushes these caches on insert/update, so it's important we don't unnecessarily write to the table. For this reason, I've also suppressed no-op writes. [1] http://mybatis.github.io/mybatis-3/sqlmap-xml.html#cache Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 1b18ad5ab8e640d64f5de0aebdc98d0f8dc411c2 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 95fbd8950350786582dcd9dbfbe8b56f9f866700 src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 53017c8806d2a5cdd1d181fd156afc9afca2faf7 src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 4a31999559dce4cfe50b22fc97d1500c9528a242 Diff: https://reviews.apache.org/r/25815/diff/ Testing --- ./gradlew build -Pq Lacking a story for performance testing, i failed to come up with a good way to prove that these help. Best answer i have is local testing (creating a store with ~20k attributes and issuing 1M random queries is repeatably ~50x faster), and 100% line/branch test coverage to prove we hit the no-op exit. Thanks, Bill Farner
Re: Review Request 25815: Improve performance of fetching host attributes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/#review53988 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 19, 2014, 6:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- (Updated Sept. 19, 2014, 6:42 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-730 https://issues.apache.org/jira/browse/AURORA-730 Repository: aurora Description --- This patch enables the MyBatis 2nd level cache [1] for the AttributeMapper namespace. Based on some ad-hoc local benchmarking, this improves performance by about 50x (when the cache is primed). MyBatis flushes these caches on insert/update, so it's important we don't unnecessarily write to the table. For this reason, I've also suppressed no-op writes. [1] http://mybatis.github.io/mybatis-3/sqlmap-xml.html#cache Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 1b18ad5ab8e640d64f5de0aebdc98d0f8dc411c2 src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 53017c8806d2a5cdd1d181fd156afc9afca2faf7 src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 4a31999559dce4cfe50b22fc97d1500c9528a242 Diff: https://reviews.apache.org/r/25815/diff/ Testing --- ./gradlew build -Pq Lacking a story for performance testing, i failed to come up with a good way to prove that these help. Best answer i have is local testing (creating a store with ~20k attributes and issuing 1M random queries is repeatably ~50x faster), and 100% line/branch test coverage to prove we hit the no-op exit. Thanks, Bill Farner
Re: Review Request 25815: Improve performance of fetching host attributes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/#review53989 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2014, 11:42 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- (Updated Sept. 19, 2014, 11:42 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-730 https://issues.apache.org/jira/browse/AURORA-730 Repository: aurora Description --- This patch enables the MyBatis 2nd level cache [1] for the AttributeMapper namespace. Based on some ad-hoc local benchmarking, this improves performance by about 50x (when the cache is primed). MyBatis flushes these caches on insert/update, so it's important we don't unnecessarily write to the table. For this reason, I've also suppressed no-op writes. [1] http://mybatis.github.io/mybatis-3/sqlmap-xml.html#cache Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 1b18ad5ab8e640d64f5de0aebdc98d0f8dc411c2 src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 53017c8806d2a5cdd1d181fd156afc9afca2faf7 src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 4a31999559dce4cfe50b22fc97d1500c9528a242 Diff: https://reviews.apache.org/r/25815/diff/ Testing --- ./gradlew build -Pq Lacking a story for performance testing, i failed to come up with a good way to prove that these help. Best answer i have is local testing (creating a store with ~20k attributes and issuing 1M random queries is repeatably ~50x faster), and 100% line/branch test coverage to prove we hit the no-op exit. Thanks, Bill Farner
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review53990 --- Ran locally, looks like assets are no longer gzip-encoded. Does that repro for you? - Bill Farner On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 6:41 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: Ran locally, looks like assets are no longer gzip-encoded. Does that repro for you? Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I assumed we were ok on that front. I'll take a look once my vagrant image is back up and running. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review53990 --- On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 6:41 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: Ran locally, looks like assets are no longer gzip-encoded. Does that repro for you? Joshua Cohen wrote: Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I assumed we were ok on that front. I'll take a look once my vagrant image is back up and running. Looks like we don't have a test case that fetches an asset. Can you add a test case that fetches /js/angular.js, verifying gzip? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review53990 --- On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 6:41 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: Ran locally, looks like assets are no longer gzip-encoded. Does that repro for you? Joshua Cohen wrote: Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I assumed we were ok on that front. I'll take a look once my vagrant image is back up and running. Bill Farner wrote: Looks like we don't have a test case that fetches an asset. Can you add a test case that fetches /js/angular.js, verifying gzip? Yep, will do. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review53990 --- On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 6:41 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
Re: Review Request 25812: Implementing quota checking for async job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54000 --- Do you think it makes sense to wait for AURORA-718 before we land this? I think that will help simplify the algorithm: - convert each job to a resource aggregate - convert each job update to a possibly-negative resource aggregate delta - walk each job, add delta if positive - Bill Farner On Sept. 19, 2014, 6:03 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 19, 2014, 6:03 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-686 https://issues.apache.org/jira/browse/AURORA-686 Repository: aurora Description --- Getting it right required a deep refactoring of the QuotaManager. The prod consumption is now calculated from: - production tasks not participating in job updates; - unaffected production tasks from a job being updated (i.e. those that are not covered by the update working set); - production tasks directly affected by the job update (max of old and new resources used). Also, moved all logic back to SchedulerThriftInterface as quota checks are done only there now. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 14b0dd8f86026840d0444c128f656a144eab017d src/main/java/org/apache/aurora/scheduler/state/StateModule.java 54b90127551c69509dbd41ee95c384dbbf1a7ee4 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 5aebbfbc691dfac4a066cb1425d18d3fccc77090 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40156c211a346664c0d2f174235efb2049cf3bb9 Diff: https://reviews.apache.org/r/25812/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25812: Implementing quota checking for async job updates.
On Sept. 19, 2014, 7:38 p.m., Bill Farner wrote: Do you think it makes sense to wait for AURORA-718 before we land this? I think that will help simplify the algorithm: - convert each job to a resource aggregate - convert each job update to a possibly-negative resource aggregate delta - walk each job, add delta if positive This diff is built assuming the AURORA-718. As for the algorithm suggestion, I don't see how it would work for in-flight updates. Once the update started, the baseline for the delta is gone and we may be double counting (or missing) instances that have already been worked on. The current algorithm does not suffer from that flaw as it treats affected instances separately: - convert all instance tasks unaffected by update into resource aggregate - convert all instance tasks affected by update into resource aggregate - add the two above to yield overall consumption - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54000 --- On Sept. 19, 2014, 6:03 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 19, 2014, 6:03 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-686 https://issues.apache.org/jira/browse/AURORA-686 Repository: aurora Description --- Getting it right required a deep refactoring of the QuotaManager. The prod consumption is now calculated from: - production tasks not participating in job updates; - unaffected production tasks from a job being updated (i.e. those that are not covered by the update working set); - production tasks directly affected by the job update (max of old and new resources used). Also, moved all logic back to SchedulerThriftInterface as quota checks are done only there now. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 14b0dd8f86026840d0444c128f656a144eab017d src/main/java/org/apache/aurora/scheduler/state/StateModule.java 54b90127551c69509dbd41ee95c384dbbf1a7ee4 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 5aebbfbc691dfac4a066cb1425d18d3fccc77090 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40156c211a346664c0d2f174235efb2049cf3bb9 Diff: https://reviews.apache.org/r/25812/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote: Reviewboard keeps crashing when I try to go back. But I was a little confused as to why we still need a mapping for some of the static assets? Also, for the goal of faster development iteration on the UI - it would be good to get some docs on expected steps when hacking on the UI in the vagrant image. Joshua Cohen wrote: The mapping is just an intermediate stage, because some files are referenced at names/paths that don't match their actual location under the resource root. We'll need to either change the UI to reference them at their actual name/path, or change the name/path from which they are served. I'm honestly not sure *what* the steps are for faster development cycle after this change though. The resources are still served out of a jar, which means that jarfile needs to be rebuilt to pick up changes... I haven't had a chance to investigate what's involved in actually serving live assets yet, but Bill, I think you had some future changes in mind to get us there? My primary goal here was to simplify HTTP server configuration code. I see this as a stepping-stone to simpler UI development, but surrounding tooling is probably not quite ready for it yet. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54002 --- On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 6:41 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Changes --- Apply gzip to static assets. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs (updated) - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 3rdparty/javascript/bower_components/bootstrap/js/affix.js 3rdparty/javascript/bower_components/bootstrap/js/alert.js 3rdparty/javascript/bower_components/bootstrap/js/button.js 3rdparty/javascript/bower_components/bootstrap/js/carousel.js 3rdparty/javascript/bower_components/bootstrap/js/collapse.js 3rdparty/javascript/bower_components/bootstrap/js/dropdown.js
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54022 --- Ship it! Ship It! - David McLaughlin On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54031 --- waaat... ServletFilterTest.testGzipEncoding is failing via command line (request for /js/angular.js returns a 404) even though it's passing in IntelliJ. So that's neat. - Joshua Cohen On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
This happens when gradle and IntelliJ write class files to the same directory. You need to do a git clean and try again. On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen jco...@twopensource.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54031 --- waaat... ServletFilterTest.testGzipEncoding is failing via command line (request for /js/angular.js returns a 404) even though it's passing in IntelliJ. So that's neat. - Joshua Cohen On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Changes --- Added generated/3rdparty js to test classpath. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs (updated) - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 3rdparty/javascript/bower_components/bootstrap/js/affix.js 3rdparty/javascript/bower_components/bootstrap/js/alert.js 3rdparty/javascript/bower_components/bootstrap/js/button.js 3rdparty/javascript/bower_components/bootstrap/js/carousel.js 3rdparty/javascript/bower_components/bootstrap/js/collapse.js 3rdparty/javascript/bower_components/bootstrap/js/dropdown.js
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
gradle and intellij actually use different classpaths to begin with. The problem was just that some of the js sources were not being included in the test classpath. On Fri, Sep 19, 2014 at 2:29 PM, Zameer Manji zma...@twopensource.com wrote: This happens when gradle and IntelliJ write class files to the same directory. You need to do a git clean and try again. On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen jco...@twopensource.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54031 --- waaat... ServletFilterTest.testGzipEncoding is failing via command line (request for /js/angular.js returns a 404) even though it's passing in IntelliJ. So that's neat. - Joshua Cohen On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
Review Request 25857: Disable updater by default in prod.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25857: Disable updater by default in prod.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 19, 2014, 11:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Review Request 25859: Fix some bugs in the Update UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Angular has a thing where if you have asynchronous data *and* you bind it to isolated scope in a directive, you need to explicitly watch the values for changes. This was also the weird behaviour I saw before with SmartTable. I changed the ordering of update summaries to be reverse sorted by last event time. Going to be required for a future (show me all in-flight updates) feature. I also fixed a couple of problems with: progress stats, a missing terminal state and the instance summary not updating when polling. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js bcb094adbafdf223eda49c012005994937d5dcf6 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 8b7fc0627597d53a788868d0ae16c0c063f36338 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml ad877ed168f80cc56561dffd028cff300336ea55 Diff: https://reviews.apache.org/r/25859/diff/ Testing --- ./gradlew jsHint Thanks, David McLaughlin
Re: Review Request 25859: Fix some bugs in the Update UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54066 --- src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml https://reviews.apache.org/r/25859/#comment94013 This will fail unit tests as is. - Maxim Khutornenko On Sept. 20, 2014, 12:28 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 20, 2014, 12:28 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Angular has a thing where if you have asynchronous data *and* you bind it to isolated scope in a directive, you need to explicitly watch the values for changes. This was also the weird behaviour I saw before with SmartTable. I changed the ordering of update summaries to be reverse sorted by last event time. Going to be required for a future (show me all in-flight updates) feature. I also fixed a couple of problems with: progress stats, a missing terminal state and the instance summary not updating when polling. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js bcb094adbafdf223eda49c012005994937d5dcf6 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 8b7fc0627597d53a788868d0ae16c0c063f36338 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml ad877ed168f80cc56561dffd028cff300336ea55 Diff: https://reviews.apache.org/r/25859/diff/ Testing --- ./gradlew jsHint Thanks, David McLaughlin
Re: Review Request 25859: Fix some bugs in the Update UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54068 --- Ship it! LGTM iff unit tests pass. - Bill Farner On Sept. 20, 2014, 12:28 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 20, 2014, 12:28 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Angular has a thing where if you have asynchronous data *and* you bind it to isolated scope in a directive, you need to explicitly watch the values for changes. This was also the weird behaviour I saw before with SmartTable. I changed the ordering of update summaries to be reverse sorted by last event time. Going to be required for a future (show me all in-flight updates) feature. I also fixed a couple of problems with: progress stats, a missing terminal state and the instance summary not updating when polling. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js bcb094adbafdf223eda49c012005994937d5dcf6 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 8b7fc0627597d53a788868d0ae16c0c063f36338 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml ad877ed168f80cc56561dffd028cff300336ea55 Diff: https://reviews.apache.org/r/25859/diff/ Testing --- ./gradlew jsHint Thanks, David McLaughlin
Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25857: Disable updater by default in prod.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54071 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25857/#comment94020 How about `enable_beta_updater` src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25857/#comment94021 Enable the async updater. Use at your own risk, this feature is not yet complete. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25857/#comment94019 While you're here, can you remove this constructor overload? It's unused. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25857/#comment94018 How about: return addMessage( emptyResponse(), INVALID_REQUEST, Server-side updates are disabled on this cluster.); src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java https://reviews.apache.org/r/25857/#comment94022 I see why you went this route, but it's a precedent i'd rather not set. How about a guice-bound `@EnableUpdater Boolean`. Then, create a new test class that does nothing but create necessary mocks to construct an instance of SchedulerThriftInterface and test the flag. - Bill Farner On Sept. 19, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 19, 2014, 11:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I'd like to use this data to investigate potential changes to the backoff strategy used in TaskGroups. I have a hunch that tasks are usually either scheduled on the first try, or after the 10th. If that is true, we can make difficult-to-schedule tasks much less expensive. Diffs - src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java f64497fcf082defd4a6a0935febce8ed90c7e078 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f Diff: https://reviews.apache.org/r/25872/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner