Review Request 26024: Fix extra constructor arg causing build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Fix extra constructor arg causing build break. Diffs - src/test/python/apache/aurora/client/api/test_api.py f1a383f70ecabbf2fb00c8d3641de6f1a9b1d950 Diff: https://reviews.apache.org/r/26024/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26024: Fix extra constructor arg causing build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/ --- (Updated Sept. 25, 2014, 7:09 a.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Submitting TBR to unbreak build. Repository: aurora Description --- Fix extra constructor arg causing build break. Diffs - src/test/python/apache/aurora/client/api/test_api.py f1a383f70ecabbf2fb00c8d3641de6f1a9b1d950 Diff: https://reviews.apache.org/r/26024/diff/ Testing (updated) --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26024: Fix extra constructor arg causing build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/#review54545 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 25, 2014, 7:09 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/ --- (Updated Sept. 25, 2014, 7:09 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Fix extra constructor arg causing build break. Diffs - src/test/python/apache/aurora/client/api/test_api.py f1a383f70ecabbf2fb00c8d3641de6f1a9b1d950 Diff: https://reviews.apache.org/r/26024/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26015: Skip past irrelevant jobs when running cron show command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26015/ --- (Updated Sept. 25, 2014, 4:30 p.m.) Review request for Aurora, Joe Smith and Maxim Khutornenko. Changes --- Swapping out Mark, who is out today. Bugs: AURORA-753 https://issues.apache.org/jira/browse/AURORA-753 Repository: aurora Description --- Skip past irrelevant jobs when running cron show command. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/26015/diff/ Testing --- Reproduced issue in a test case, now passes: ./pants src/test/python/apache/aurora/client/cli:cron Thanks, Bill Farner
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54550 --- Ship it! Ship It! - Brian Wickman On July 31, 2014, 12:13 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
Review Request 26043: Fix checkstyle broken by rb/26015.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Fix checkstyle broken by rb/26015 (no newline at end of file.) Diffs - src/test/python/apache/aurora/client/cli/test_cron.py e9d0b98f40628ad8d729f5c15145fda590137297 Diff: https://reviews.apache.org/r/26043/diff/ Testing --- My commit made it in. Thanks, Brian Wickman
Re: Review Request 26043: Fix checkstyle broken by rb/26015.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/#review54551 --- Found this when trying to apply r/23330 but commits are being blocked. - Brian Wickman On Sept. 25, 2014, 5:27 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/ --- (Updated Sept. 25, 2014, 5:27 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Fix checkstyle broken by rb/26015 (no newline at end of file.) Diffs - src/test/python/apache/aurora/client/cli/test_cron.py e9d0b98f40628ad8d729f5c15145fda590137297 Diff: https://reviews.apache.org/r/26043/diff/ Testing --- My commit made it in. Thanks, Brian Wickman
Re: Review Request 26043: Fix checkstyle broken by rb/26015.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/#review54556 --- Ship it! Ship It! - Bill Farner On Sept. 25, 2014, 5:27 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/ --- (Updated Sept. 25, 2014, 5:27 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Fix checkstyle broken by rb/26015 (no newline at end of file.) Diffs - src/test/python/apache/aurora/client/cli/test_cron.py e9d0b98f40628ad8d729f5c15145fda590137297 Diff: https://reviews.apache.org/r/26043/diff/ Testing --- My commit made it in. Thanks, Brian Wickman
Re: Review Request 25970: Adding support for retryable storage errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54557 --- src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java https://reviews.apache.org/r/25970/#comment94742 minor nit I think the proper spelling is RETRIABLE src/main/python/apache/aurora/client/api/scheduler_client.py https://reviews.apache.org/r/25970/#comment94743 it seems weird to be adding a new instance of a deprecated feature. can we switch it to use the new results API? - Brian Wickman On Sept. 24, 2014, 5:41 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 24, 2014, 5:41 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Review Request 26044: Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Run python style checks in jenkins. Diffs - build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 Diff: https://reviews.apache.org/r/26044/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26044: Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54561 --- Ship it! Ship It! - Brian Wickman On Sept. 25, 2014, 5:54 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/ --- (Updated Sept. 25, 2014, 5:54 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Run python style checks in jenkins. Diffs - build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 Diff: https://reviews.apache.org/r/26044/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26044: Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54564 --- build-support/jenkins/build.sh https://reviews.apache.org/r/26044/#comment94749 Why's this indirection needed, can't you just do ```bash ./build-support/hooks/pre-commit ``` - Kevin Sweeney On Sept. 25, 2014, 10:54 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/ --- (Updated Sept. 25, 2014, 10:54 a.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Run python style checks in jenkins. Diffs - build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 Diff: https://reviews.apache.org/r/26044/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26044: Run python style checks in jenkins.
On Sept. 25, 2014, 6:03 p.m., Kevin Sweeney wrote: build-support/jenkins/build.sh, lines 27-28 https://reviews.apache.org/r/26044/diff/1/?file=705427#file705427line27 Why's this indirection needed, can't you just do ```bash ./build-support/hooks/pre-commit ``` Yeah, that's a good point - other commands already assume the script is run from the repo root. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54564 --- On Sept. 25, 2014, 5:54 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/ --- (Updated Sept. 25, 2014, 5:54 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Run python style checks in jenkins. Diffs - build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 Diff: https://reviews.apache.org/r/26044/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 25970: Adding support for retryable storage errors.
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Happy to change it. Neither appears to be a valid word though. On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 296 https://reviews.apache.org/r/25970/diff/2/?file=704573#file704573line296 it seems weird to be adding a new instance of a deprecated feature. can we switch it to use the new results API? Sure, done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54557 --- On Sept. 24, 2014, 5:41 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 24, 2014, 5:41 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:16 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Changes --- CR comments. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Maxim Khutornenko wrote: Happy to change it. Neither appears to be a valid word though. ERROR_TRANSIENT? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54557 --- On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:16 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Maxim Khutornenko wrote: Happy to change it. Neither appears to be a valid word though. Bill Farner wrote: ERROR_TRANSIENT? True. I was going by http://en.wiktionary.org/wiki/retriable but the number of google hits for retryable is higher. English is hard, let's go computering. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54557 --- On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:16 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 26044: Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54570 --- Ship it! Ship It! - Joe Smith On Sept. 25, 2014, 11:09 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/ --- (Updated Sept. 25, 2014, 11:09 a.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Run python style checks in jenkins. Diffs - build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 Diff: https://reviews.apache.org/r/26044/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 25970: Adding support for retryable storage errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:26 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Changes --- CR comments. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Maxim Khutornenko wrote: Happy to change it. Neither appears to be a valid word though. Bill Farner wrote: ERROR_TRANSIENT? Brian Wickman wrote: True. I was going by http://en.wiktionary.org/wiki/retriable but the number of google hits for retryable is higher. English is hard, let's go computering. Sigh... - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54557 --- On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:16 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:34 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- -mark as he is out today Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54573 --- src/test/python/apache/aurora/client/api/test_scheduler_client.py https://reviews.apache.org/r/25970/#comment94757 Isn't this not needed if you're specifying a side_effect? - Joe Smith On Sept. 25, 2014, 11:34 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 11:34 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description --- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs - src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Review Request 26048: Cosmetic UI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26048/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Move the breadcumb to be under the nav (like on our public site) and make the page title have consistent markup across pages. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 509639e122821057263703e7662c3e7d659d1c29 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html d305fb58c502dc4dba74fe8557752a5c86da9eb3 Diff: https://reviews.apache.org/r/26048/diff/ Testing --- File Attachments breadcrumb-after https://reviews.apache.org/media/uploaded/files/2014/09/25/0ca9cd6e-a742-40ca-b054-bd409bf66d2a__ui-breadcrumb.png env page after https://reviews.apache.org/media/uploaded/files/2014/09/25/93794e00-6db7-48cd-85e6-6c1550e0957e__ui-env.png role page after https://reviews.apache.org/media/uploaded/files/2014/09/25/2e4590ba-dec9-46a8-8d6e-dde0319e545e__ui-role.png breadcrumb before https://reviews.apache.org/media/uploaded/files/2014/09/25/e37047de-56ee-4f48-91c3-a7f8741571de__ui-breadcrumb-before.png role page before https://reviews.apache.org/media/uploaded/files/2014/09/25/f1fcc383-9757-4632-9dc6-334d7bfb457e__ui-role-before.png env page before https://reviews.apache.org/media/uploaded/files/2014/09/25/a948b4cb-94d4-4e7b-86a9-ecf5d59ef901__ui-env-before.png Thanks, David McLaughlin
Re: Review Request 26048: Cosmetic UI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26048/#review54577 --- Ship it! Ship It! - Bill Farner On Sept. 25, 2014, 6:39 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26048/ --- (Updated Sept. 25, 2014, 6:39 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Move the breadcumb to be under the nav (like on our public site) and make the page title have consistent markup across pages. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 509639e122821057263703e7662c3e7d659d1c29 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html d305fb58c502dc4dba74fe8557752a5c86da9eb3 Diff: https://reviews.apache.org/r/26048/diff/ Testing --- File Attachments breadcrumb-after https://reviews.apache.org/media/uploaded/files/2014/09/25/0ca9cd6e-a742-40ca-b054-bd409bf66d2a__ui-breadcrumb.png env page after https://reviews.apache.org/media/uploaded/files/2014/09/25/93794e00-6db7-48cd-85e6-6c1550e0957e__ui-env.png role page after https://reviews.apache.org/media/uploaded/files/2014/09/25/2e4590ba-dec9-46a8-8d6e-dde0319e545e__ui-role.png breadcrumb before https://reviews.apache.org/media/uploaded/files/2014/09/25/e37047de-56ee-4f48-91c3-a7f8741571de__ui-breadcrumb-before.png role page before https://reviews.apache.org/media/uploaded/files/2014/09/25/f1fcc383-9757-4632-9dc6-334d7bfb457e__ui-role-before.png env page before https://reviews.apache.org/media/uploaded/files/2014/09/25/a948b4cb-94d4-4e7b-86a9-ecf5d59ef901__ui-env-before.png Thanks, David McLaughlin
Re: Review Request 26012: Use BufferedOutputStream for deflater
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 2:24 p.m.) Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Changes --- Add explanatory comment. Repository: aurora Description --- Use BufferedOutputStream for deflater Diffs (updated) - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 45cf7ecf52582ba3fd7bbc8b4a981e396793da4b Diff: https://reviews.apache.org/r/26012/diff/ Testing --- ./gradlew build Also put together a microbenchmark with a scheduler backup from my production environment - using a BufferedOutputStream gets a 4sec speedup with no reduction in compression ratio. ¯_(?)_/¯ # Deflater.BEST_SPEED, No buffer deflate: 11745ms total:12734ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, buf = 512KiB deflate: 11015ms total:12001ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, BufferedOutputStream deflate: 6885ms total:7694ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, BufferedOutputStream at 512KiB deflate: 6752ms total:7585ms compression ratio: 647270930/121616834 = 532.22% # Deflater.DEFAULT_COMPRESSION deflate: 16664ms total:17219ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, buf size = 512KiB deflate: 16516ms total:17103ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream deflate: 12241ms total:12788ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream at 512KiB deflate: 11548ms total:12108ms compression ratio: 647270930/92690409 = 698.31% Thanks, Kevin Sweeney
Re: Review Request 26012: Use BufferedOutputStream for deflater
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 2:24 p.m.) Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Changes --- Add bug link. Bugs: AURORA-722 https://issues.apache.org/jira/browse/AURORA-722 Repository: aurora Description --- Use BufferedOutputStream for deflater Diffs - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 45cf7ecf52582ba3fd7bbc8b4a981e396793da4b Diff: https://reviews.apache.org/r/26012/diff/ Testing --- ./gradlew build Also put together a microbenchmark with a scheduler backup from my production environment - using a BufferedOutputStream gets a 4sec speedup with no reduction in compression ratio. ¯_(?)_/¯ # Deflater.BEST_SPEED, No buffer deflate: 11745ms total:12734ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, buf = 512KiB deflate: 11015ms total:12001ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, BufferedOutputStream deflate: 6885ms total:7694ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, BufferedOutputStream at 512KiB deflate: 6752ms total:7585ms compression ratio: 647270930/121616834 = 532.22% # Deflater.DEFAULT_COMPRESSION deflate: 16664ms total:17219ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, buf size = 512KiB deflate: 16516ms total:17103ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream deflate: 12241ms total:12788ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream at 512KiB deflate: 11548ms total:12108ms compression ratio: 647270930/92690409 = 698.31% Thanks, Kevin Sweeney
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 25, 2014, 2:39 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's Feedback Summary (updated) - Prevent initial ZK timeouts from killing the executor. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description (updated) --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25481: Adding JobUpdateRequest validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 10:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Rebased and refactored to standardize response handling. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25481: Adding JobUpdateRequest validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54613 --- Ship it! Ship It! - Zameer Manji On Sept. 25, 2014, 3:02 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 3:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26012: Use BufferedOutputStream for deflater
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 3:12 p.m.) Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Changes --- Update Testing Done to reflect current code Bugs: AURORA-722 https://issues.apache.org/jira/browse/AURORA-722 Repository: aurora Description --- Use BufferedOutputStream for deflater Diffs (updated) - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 45cf7ecf52582ba3fd7bbc8b4a981e396793da4b Diff: https://reviews.apache.org/r/26012/diff/ Testing (updated) --- ./gradlew build Microbenchmark with a scheduler backup from my production environment. Before: ## Deflater.DEFAULT_COMPRESSION, (No BufferedOutputStream), DeflaterOutputStream( deflate: 16664ms total:17219ms compression ratio: 647270930/92690409 = 698.31% After: # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream(256KiB), DeflaterOutputStream(256KiB) deflate: 11807ms (4857ms speedup) total: 12379ms (4840ms speedup) compression ratio: 647270930/92690409 = 698.31% (0% improvement) Thanks, Kevin Sweeney
Re: Review Request 26012: Use BufferedOutputStream for deflater
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 3:21 p.m.) Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Changes --- Fix truncated line Bugs: AURORA-722 https://issues.apache.org/jira/browse/AURORA-722 Repository: aurora Description --- Use BufferedOutputStream for deflater Diffs - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 45cf7ecf52582ba3fd7bbc8b4a981e396793da4b Diff: https://reviews.apache.org/r/26012/diff/ Testing (updated) --- ./gradlew build Microbenchmark with a scheduler backup from my production environment. Before: ## Deflater.DEFAULT_COMPRESSION, (No BufferedOutputStream), DeflaterOutputStream(512B) deflate: 16664ms total:17219ms compression ratio: 647270930/92690409 = 698.31% After: # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream(256KiB), DeflaterOutputStream(256KiB) deflate: 11807ms (4857ms speedup) total: 12379ms (4840ms speedup) compression ratio: 647270930/92690409 = 698.31% (0% improvement) Thanks, Kevin Sweeney
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54623 --- src/main/python/apache/aurora/executor/common/announcer.py https://reviews.apache.org/r/25974/#comment94848 add a trailing comma here for easy import-sorting src/main/python/apache/aurora/executor/common/announcer.py https://reviews.apache.org/r/25974/#comment94854 log this? src/test/python/apache/aurora/executor/common/test_announcer.py https://reviews.apache.org/r/25974/#comment94851 where is this magic number coming from? extract a constant and import that here? - Kevin Sweeney On Sept. 25, 2014, 2:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 25, 2014, 2:39 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
