Re: Review Request 26089: Renaming update to beta-update in client v2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26089/#review54702 --- Ship it! Ship It! - Bill Farner On Sept. 26, 2014, 5:53 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26089/ --- (Updated Sept. 26, 2014, 5:53 p.m.) Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-757 https://issues.apache.org/jira/browse/AURORA-757 Repository: aurora Description --- Renaming update to beta-update in client v2 Diffs - src/main/python/apache/aurora/client/cli/update.py c6cb98fe6aa42310090167796c971856d3dc177f src/test/python/apache/aurora/client/cli/test_supdate.py 4fb1623e497b9741ae2a350deb20030dd4036506 Diff: https://reviews.apache.org/r/26089/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Re: Review Request 26089: Renaming update to beta-update in client v2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26089/#review54704 --- Ship it! Ship It! - Joe Smith On Sept. 26, 2014, 10:53 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26089/ --- (Updated Sept. 26, 2014, 10:53 a.m.) Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-757 https://issues.apache.org/jira/browse/AURORA-757 Repository: aurora Description --- Renaming update to beta-update in client v2 Diffs - src/main/python/apache/aurora/client/cli/update.py c6cb98fe6aa42310090167796c971856d3dc177f src/test/python/apache/aurora/client/cli/test_supdate.py 4fb1623e497b9741ae2a350deb20030dd4036506 Diff: https://reviews.apache.org/r/26089/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Re: Review Request 25481: Adding JobUpdateRequest validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54705 --- Ship it! Error handling is objectively better, but i'm a -1 on removal of input validation at lower layers. src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java https://reviews.apache.org/r/25481/#comment94971 This code should still be defensive - it cares about these values. Please revert. src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java https://reviews.apache.org/r/25481/#comment94972 Ditto. - Bill Farner On Sept. 25, 2014, 10:02 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 10:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25481: Adding JobUpdateRequest validation.
On Sept. 26, 2014, 6:18 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java, line 80 https://reviews.apache.org/r/25481/diff/2/?file=705767#file705767line80 This code should still be defensive - it cares about these values. Please revert. Feels kind of redundant but I am OK reverting all but the last desiredState.instances validation (AURORA-756). - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54705 --- On Sept. 25, 2014, 10:02 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 10:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25481: Adding JobUpdateRequest validation.
On Sept. 26, 2014, 6:18 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java, line 80 https://reviews.apache.org/r/25481/diff/2/?file=705767#file705767line80 This code should still be defensive - it cares about these values. Please revert. Maxim Khutornenko wrote: Feels kind of redundant but I am OK reverting all but the last desiredState.instances validation (AURORA-756). On the second thought, just removing that assertion is not going to be enough. Will address AURORA-756 separately. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54705 --- On Sept. 25, 2014, 10:02 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 10:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25481: Adding JobUpdateRequest validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 26, 2014, 7 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Reverting UpdateFactory assertions removal. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Review Request 26093: Revert Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Review Request 26095: Fix instance summary visualisation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-755 https://issues.apache.org/jira/browse/AURORA-755 Repository: aurora Description --- See JIRA ticket. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6 Diff: https://reviews.apache.org/r/26095/diff/ Testing --- File Attachments Growing a job shows correct instance ids https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png Instances removed are identified when shrinking job from 5 instances to 1 https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png Thanks, David McLaughlin
Re: Review Request 26093: Revert Run python style checks in jenkins.
On Sept. 26, 2014, 8:29 p.m., Brian Wickman wrote: build-support/jenkins/build.sh, line 27 https://reviews.apache.org/r/26093/diff/1/?file=706245#file706245line27 without seeing the output, we have no idea. rather than remove completely, i'd prefer to change this to something like: if ! ./build-support/hooks/pre-commit; then build-support/python/isort-check || true build-support/python/checkstyle-check || true exit 1 fi (i know this leaks knowledge of the checks from pre-commit to build.sh, so we should probably add a build-support/python/check-all that build.sh and pre-commit can each call.) Bill Farner wrote: From a manual run, this is the error: Traceback (most recent call last): File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 738, in _wrap_method return_code = method() File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 760, in lambda main = lambda: main_method(*args, **kwargs) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/checker.py;, line 155, in main for filename, line_filter in iterator: File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/iterators.py;, line 120, in git_iterator diff_commit = repo.rev_parse(options.diff or 'master') File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 274, in rev_parse obj = name_to_object(repo, rev) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 86, in name_to_object raise BadObject(name) BadObject: BadObject: 6d6173746572 That's...bizarre. checkstyle-check by default runs checkstyle on the diff against master. Oh son of a ...running build-support/python/checkstyle-check src shows that checkstyle has drifted considerably probably for this very reason. The jenkins build should run checkstyle-check src. Let me fix all the checkstyle breaks + combined with an RB with the checkstyle added back to the build.sh. Submit this in the meantime. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/#review54724 --- On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- (Updated Sept. 26, 2014, 7:33 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26093: Revert Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/#review54731 --- Ship it! Ship It! - Brian Wickman On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- (Updated Sept. 26, 2014, 7:33 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Review Request 26098: Fix checkstyle and add checkstyle back to jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/ --- Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository: aurora Description --- Fix checkstyle and add checkstyle back to jenkins. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3 src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654 src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28 src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5 src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9 src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1 src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5 src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e7b1fbbdb7a3cdefa7bfe6a src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19 src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898 src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22 src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4 src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f Diff: https://reviews.apache.org/r/26098/diff/ Testing --- Running build.sh now. Thanks, Brian Wickman
Re: Review Request 26093: Revert Run python style checks in jenkins.
On Sept. 26, 2014, 8:29 p.m., Brian Wickman wrote: build-support/jenkins/build.sh, line 27 https://reviews.apache.org/r/26093/diff/1/?file=706245#file706245line27 without seeing the output, we have no idea. rather than remove completely, i'd prefer to change this to something like: if ! ./build-support/hooks/pre-commit; then build-support/python/isort-check || true build-support/python/checkstyle-check || true exit 1 fi (i know this leaks knowledge of the checks from pre-commit to build.sh, so we should probably add a build-support/python/check-all that build.sh and pre-commit can each call.) Bill Farner wrote: From a manual run, this is the error: Traceback (most recent call last): File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 738, in _wrap_method return_code = method() File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 760, in lambda main = lambda: main_method(*args, **kwargs) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/checker.py;, line 155, in main for filename, line_filter in iterator: File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/iterators.py;, line 120, in git_iterator diff_commit = repo.rev_parse(options.diff or 'master') File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 274, in rev_parse obj = name_to_object(repo, rev) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 86, in name_to_object raise BadObject(name) BadObject: BadObject: 6d6173746572 Brian Wickman wrote: That's...bizarre. checkstyle-check by default runs checkstyle on the diff against master. Oh son of a ...running build-support/python/checkstyle-check src shows that checkstyle has drifted considerably probably for this very reason. The jenkins build should run checkstyle-check src. Let me fix all the checkstyle breaks + combined with an RB with the checkstyle added back to the build.sh. Submit this in the meantime. Thanks!! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/#review54724 --- On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- (Updated Sept. 26, 2014, 7:33 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 26, 2014, 2:24 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Kevin's Feedback. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
On Sept. 25, 2014, 4:29 p.m., Kevin Sweeney wrote: src/test/python/apache/aurora/executor/common/test_announcer.py, line 264 https://reviews.apache.org/r/25974/diff/2/?file=705691#file705691line264 where is this magic number coming from? extract a constant and import that here? This is the default initial health check + (max failures * health check). I'm unsure on the best way to fix this without duplicating the code it is trying to test. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54623 --- On Sept. 25, 2014, 2:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 25, 2014, 2:39 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 26098: Fix checkstyle and add checkstyle back to jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/#review54735 --- Ship it! Beautiful - Bill Farner On Sept. 26, 2014, 9:18 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/ --- (Updated Sept. 26, 2014, 9:18 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository: aurora Description --- Fix checkstyle and add checkstyle back to jenkins. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3 src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654 src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28 src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5 src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9 src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1 src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5 src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e7b1fbbdb7a3cdefa7bfe6a src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19 src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898 src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22 src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4 src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f Diff: https://reviews.apache.org/r/26098/diff/ Testing --- Running build.sh now. Thanks, Brian Wickman
Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26098: Fix checkstyle and add checkstyle back to jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/ --- (Updated Sept. 26, 2014, 9:35 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Changes --- Actually -- the previous CL didn't exactly fix the problem -- pre-commit was still being run against master, which might fail due to git magic. Instead it should run against the src tree. Repository: aurora Description --- Fix checkstyle and add checkstyle back to jenkins. Diffs (updated) - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3 src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654 src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28 src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5 src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9 src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1 src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5 src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e7b1fbbdb7a3cdefa7bfe6a src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19 src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898 src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22 src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4 src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f Diff: https://reviews.apache.org/r/26098/diff/ Testing --- Running build.sh now. Thanks, Brian Wickman
Review Request 26106: Add updater support for disabling rollback and batched update settings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26106/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-744 and AURORA-747 https://issues.apache.org/jira/browse/AURORA-744 https://issues.apache.org/jira/browse/AURORA-747 Repository: aurora Description --- Add updater support for disabling rollback and batched update settings. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 5dec82aef337f42a402084f2c1a1776bb977ab56 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 2794242e71515effdc710cb40e881baca9dc4124 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 866e6587a2deee39228ccabf89bf276cc5e44881 src/main/thrift/org/apache/aurora/gen/api.thrift cebd2c30dc536debbbe8a7d38d81eb5030978135 src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7e4184330bdec271ead0d700bc02c8b3470876a9 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26106/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/#review54751 --- src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java https://reviews.apache.org/r/26102/#comment95041 IIUC you could also trip this with an update that reduces the instance count in a job. Can you add a test case for that? - Bill Farner On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 26, 2014, 9:34 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26102: Dropping assert on empty desired instances set.
On Sept. 26, 2014, 11:35 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line 724 https://reviews.apache.org/r/26102/diff/1/?file=706432#file706432line724 IIUC you could also trip this with an update that reduces the instance count in a job. Can you add a test case for that? Thanks for bringing this up! I now remember exactly why I did not want to address it in my previous changelist as it required changes in SchedulerThriftInterface to avoid setting TaskConfig if Range set is empty. Otherwise, the sql layer assert will fire. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/#review54751 --- On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 26, 2014, 9:34 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26106: Add updater support for disabling rollback and batched update settings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26106/#review54754 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 26, 2014, 10:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26106/ --- (Updated Sept. 26, 2014, 10:44 p.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-744 and AURORA-747 https://issues.apache.org/jira/browse/AURORA-744 https://issues.apache.org/jira/browse/AURORA-747 Repository: aurora Description --- Add updater support for disabling rollback and batched update settings. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 5dec82aef337f42a402084f2c1a1776bb977ab56 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 2794242e71515effdc710cb40e881baca9dc4124 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 866e6587a2deee39228ccabf89bf276cc5e44881 src/main/thrift/org/apache/aurora/gen/api.thrift cebd2c30dc536debbbe8a7d38d81eb5030978135 src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7e4184330bdec271ead0d700bc02c8b3470876a9 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26106/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
