Re: Review Request 26288: Fixing log_response in context.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55650 --- Ship it! Looks good, thanks for changing the approach. Can you update the review title, just so that when we look at reviews, we know what this one actually changed? - Mark Chu-Carroll On Oct. 6, 2014, 7:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 6, 2014, 7:40 p.m.) Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-786 https://issues.apache.org/jira/browse/AURORA-786 Repository: aurora Description --- Fixing log_response in context.py Diffs - src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b Diff: https://reviews.apache.org/r/26288/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
Re: Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55663 --- Ship it! Ship It! - David McLaughlin On Oct. 7, 2014, 5:12 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- (Updated Oct. 7, 2014, 5:12 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
Re: Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55664 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 10:12 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- (Updated Oct. 7, 2014, 10:12 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
Review Request 26422: Drop syncrhonized from JobUpdateEventSubscriber
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-801 https://issues.apache.org/jira/browse/AURORA-801 Repository: aurora Description --- Drop syncrhonized from JobUpdateEventSubscriber This fixes a startup deadlock. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 49d8b7a6c4adc4c58049c439bd09019c9e6885b1 Diff: https://reviews.apache.org/r/26422/diff/ Testing --- ./gradlew -Pq build Manually verified that all delegated calls to the JobUpdateController are already protected by the storage write-lock. Rather than add a potentially-flaky regression test (like the one added in https://reviews.apache.org/r/25556/) I'd prefer to prioritize adding runtime deadlock detection (https://issues.apache.org/jira/browse/AURORA-800). Thanks, Kevin Sweeney
Review Request 26424: Disable requests http connection logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-770 https://issues.apache.org/jira/browse/AURORA-770 Repository: aurora Description --- Disable requests http connection logging. Diffs - src/main/python/apache/aurora/common/transport.py 6f7c355d725b5e537cc4ae471170eaa8431da326 src/test/python/apache/aurora/common/test_transport.py c722eae2d04dec90e9c772f49c578184a2bdf76c Diff: https://reviews.apache.org/r/26424/diff/ Testing --- Added hokey test, ran hokey test. Also verified the lack of http connection logs when running client commands directly. Thanks, Joshua Cohen
Re: Review Request 26424: Disable requests http connection logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55698 --- Ship it! src/test/python/apache/aurora/common/test_transport.py https://reviews.apache.org/r/26424/#comment96076 I think this can be removed- we're validating what we want here. Although I'm not quite a fan of this global state being modified via module import, I'm not sure we need to have an entirely separate test file that gets executed just to check the before/after. - Joe Smith On Oct. 7, 2014, 12:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- (Updated Oct. 7, 2014, 12:58 p.m.) Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-770 https://issues.apache.org/jira/browse/AURORA-770 Repository: aurora Description --- Disable requests http connection logging. Diffs - src/main/python/apache/aurora/common/transport.py 6f7c355d725b5e537cc4ae471170eaa8431da326 src/test/python/apache/aurora/common/test_transport.py c722eae2d04dec90e9c772f49c578184a2bdf76c Diff: https://reviews.apache.org/r/26424/diff/ Testing --- Added hokey test, ran hokey test. Also verified the lack of http connection logs when running client commands directly. Thanks, Joshua Cohen
Re: Review Request 26422: Drop syncrhonized from JobUpdateEventSubscriber
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/#review55700 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 12:28 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/ --- (Updated Oct. 7, 2014, 12:28 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-801 https://issues.apache.org/jira/browse/AURORA-801 Repository: aurora Description --- Drop syncrhonized from JobUpdateEventSubscriber This fixes a startup deadlock. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 49d8b7a6c4adc4c58049c439bd09019c9e6885b1 Diff: https://reviews.apache.org/r/26422/diff/ Testing --- ./gradlew -Pq build Manually verified that all delegated calls to the JobUpdateController are already protected by the storage write-lock. Rather than add a potentially-flaky regression test (like the one added in https://reviews.apache.org/r/25556/) I'd prefer to prioritize adding runtime deadlock detection (https://issues.apache.org/jira/browse/AURORA-800). Thanks, Kevin Sweeney
Re: Review Request 26424: Disable requests http connection logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- (Updated Oct. 7, 2014, 8:32 p.m.) Review request for Aurora, Joe Smith and Bill Farner. Changes --- Slightly cleaner impl. Bugs: AURORA-770 https://issues.apache.org/jira/browse/AURORA-770 Repository: aurora Description --- Disable requests http connection logging. Diffs (updated) - src/main/python/apache/aurora/common/transport.py 6f7c355d725b5e537cc4ae471170eaa8431da326 src/test/python/apache/aurora/common/test_transport.py c722eae2d04dec90e9c772f49c578184a2bdf76c Diff: https://reviews.apache.org/r/26424/diff/ Testing --- Added hokey test, ran hokey test. Also verified the lack of http connection logs when running client commands directly. Thanks, Joshua Cohen
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55712 --- src/test/python/apache/aurora/client/cli/test_api_from_cli.py https://reviews.apache.org/r/26308/#comment96092 Why do these need to be mocks? This would work identically using the Thrift structures directly. If you want to prevent setting a field that doesn't exist you can use the constructor kwargs form of the thrift object, i.e. ```py task = ScheduledTask( key=JobKey(role=..., ...), assignedTask=AssignedTask( slaveHost=..., ... ), ... ) ``` - Kevin Sweeney On Oct. 4, 2014, 10:55 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 4, 2014, 10:55 a.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/__init__.py 26300792594e4005dacc139a9f89711b8a66ab61 src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 src/main/python/apache/aurora/client/api/job_monitor.py 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 src/main/python/apache/aurora/client/api/scheduler_client.py 311c954f1db245b75192d00c6aca0721085fbf32 src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 src/test/python/apache/aurora/client/api/test_job_monitor.py 5b26539f86a0a82f72753a803a769eda77cbc332 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_cancel_update.py c15e142930c9474c7873dd931261b6ab4eb5967f src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_diff.py e1a6f764830e06c73d0bc10a3b5da67219da836c src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 src/test/python/apache/aurora/client/cli/test_task_run.py 1ce9a632874e818eee71573cd481842affae3615 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 src/test/python/apache/aurora/client/commands/test_admin.py 1192556c027dc3adf16bb37adeac7798cf9ef93d src/test/python/apache/aurora/client/commands/test_cancel_update.py 5f05ef7c0643d189de3de38c75aae58c2a3814a4 src/test/python/apache/aurora/client/commands/test_create.py 7503345ea1c0f224a894ce02cc2c2d8719574e32 src/test/python/apache/aurora/client/commands/test_diff.py 8f5da7d2bca9b0486b635afe49d3885151624e12 src/test/python/apache/aurora/client/commands/test_hooks.py 0861f13b13a8406950ba953efba0ffae186a8253 src/test/python/apache/aurora/client/commands/test_kill.py c0a6fd44c5691cde50746ffdec325bb11a33469a src/test/python/apache/aurora/client/commands/test_run.py e97b5156609f80a4170028e780bcd891e56983ff src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 src/test/python/apache/aurora/client/commands/test_status.py bda1f28d544ae48428129f8167d8632ef27f5fba src/test/python/apache/aurora/client/commands/test_update.py af2cbc7f88287201a472ba36902b00d90bc77d3b Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26383: Health Check Disabler
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote: docs/configuration-reference.md, lines 359-360 https://reviews.apache.org/r/26383/diff/1/?file=714257#file714257line359 Is there any reason this needs to be configurable? Why not just hardcode the filename as '.healthchecksnooze' and then allow the user to specify the snooze at runtime, e.g. echo '600' .healthchecksnooze to sleep for 600 seconds. (And if the value is malformed, just unlink and don't snooze.) David Pan wrote: A few questions: 1. In the case if the value is malformed, do we want to force fail the health check in order to alert the user the fact that they failed at setting the snooze duration. Otherwise, the user might not notice the mistake. 2. Should we read the value from the file only the first time the snooze file is created. Or, should we allow the user change the value on the fly. 1. I think force failing the health check would be counterproductive -- if you accidentally fat finger, you don't want to kill the task which might already be a unicorn. Instead just unlinking right away or perhaps using a default snooze value. 2. Maybe do mtime + time in the file as the snooze expiration, and re-read if the mtime changed. This means at least doing a stat() each health check interval, but will allow you to change the snooze on the fly. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55592 --- On Oct. 6, 2014, 9:24 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 6, 2014, 9:24 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The path of the snooze file and the snooze duration can be set in the HealthCheckConfig. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec docs/configuration-tutorial.md 67998e9dab6ac429d96d7c0d2df959336b767f32 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55717 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 4, 2014, 1:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 4, 2014, 1:55 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/__init__.py 26300792594e4005dacc139a9f89711b8a66ab61 src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 src/main/python/apache/aurora/client/api/job_monitor.py 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 src/main/python/apache/aurora/client/api/scheduler_client.py 311c954f1db245b75192d00c6aca0721085fbf32 src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 src/test/python/apache/aurora/client/api/test_job_monitor.py 5b26539f86a0a82f72753a803a769eda77cbc332 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_cancel_update.py c15e142930c9474c7873dd931261b6ab4eb5967f src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_diff.py e1a6f764830e06c73d0bc10a3b5da67219da836c src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 src/test/python/apache/aurora/client/cli/test_task_run.py 1ce9a632874e818eee71573cd481842affae3615 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 src/test/python/apache/aurora/client/commands/test_admin.py 1192556c027dc3adf16bb37adeac7798cf9ef93d src/test/python/apache/aurora/client/commands/test_cancel_update.py 5f05ef7c0643d189de3de38c75aae58c2a3814a4 src/test/python/apache/aurora/client/commands/test_create.py 7503345ea1c0f224a894ce02cc2c2d8719574e32 src/test/python/apache/aurora/client/commands/test_diff.py 8f5da7d2bca9b0486b635afe49d3885151624e12 src/test/python/apache/aurora/client/commands/test_hooks.py 0861f13b13a8406950ba953efba0ffae186a8253 src/test/python/apache/aurora/client/commands/test_kill.py c0a6fd44c5691cde50746ffdec325bb11a33469a src/test/python/apache/aurora/client/commands/test_run.py e97b5156609f80a4170028e780bcd891e56983ff src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 src/test/python/apache/aurora/client/commands/test_status.py bda1f28d544ae48428129f8167d8632ef27f5fba src/test/python/apache/aurora/client/commands/test_update.py af2cbc7f88287201a472ba36902b00d90bc77d3b Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55716 --- Looks good. One note on the change description: I'm willing to bet that there is a way to get that branch active in a test. Every single time that I've ever said that something couldn't be tested, or that some branch couldn't be exercised in a test, I've always been wrong. There's a way. - Mark Chu-Carroll On Oct. 4, 2014, 1:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 4, 2014, 1:55 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/__init__.py 26300792594e4005dacc139a9f89711b8a66ab61 src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 src/main/python/apache/aurora/client/api/job_monitor.py 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 src/main/python/apache/aurora/client/api/scheduler_client.py 311c954f1db245b75192d00c6aca0721085fbf32 src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 src/test/python/apache/aurora/client/api/test_job_monitor.py 5b26539f86a0a82f72753a803a769eda77cbc332 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_cancel_update.py c15e142930c9474c7873dd931261b6ab4eb5967f src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_diff.py e1a6f764830e06c73d0bc10a3b5da67219da836c src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 src/test/python/apache/aurora/client/cli/test_task_run.py 1ce9a632874e818eee71573cd481842affae3615 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 src/test/python/apache/aurora/client/commands/test_admin.py 1192556c027dc3adf16bb37adeac7798cf9ef93d src/test/python/apache/aurora/client/commands/test_cancel_update.py 5f05ef7c0643d189de3de38c75aae58c2a3814a4 src/test/python/apache/aurora/client/commands/test_create.py 7503345ea1c0f224a894ce02cc2c2d8719574e32 src/test/python/apache/aurora/client/commands/test_diff.py 8f5da7d2bca9b0486b635afe49d3885151624e12 src/test/python/apache/aurora/client/commands/test_hooks.py 0861f13b13a8406950ba953efba0ffae186a8253 src/test/python/apache/aurora/client/commands/test_kill.py c0a6fd44c5691cde50746ffdec325bb11a33469a src/test/python/apache/aurora/client/commands/test_run.py e97b5156609f80a4170028e780bcd891e56983ff src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 src/test/python/apache/aurora/client/commands/test_status.py bda1f28d544ae48428129f8167d8632ef27f5fba src/test/python/apache/aurora/client/commands/test_update.py af2cbc7f88287201a472ba36902b00d90bc77d3b Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Review Request 26425: Fixing quota checking for updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-802 https://issues.apache.org/jira/browse/AURORA-802 Repository: aurora Description --- Rolling up prod consumption does not work for quota checking during job update intitiation where per-instance filtering is required. Splitting the QuotaManager interface into 2 use cases: - createJob/addInstances - startJobUpdate Reverting the IResourceAggregate abstraction in QuotaManager in favor of task/update objects to simplify handling. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 2442b06f318c8d0cefe60296950baa1b916b42f7 src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java d197dd515eb646cb4babadf22e9cf6480a919060 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5dcae4a6132026504cf02093ad4c68ab521e4ab8 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b58c8f363e6e7c72accaf590b2a7cb7bf24275ea src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 Diff: https://reviews.apache.org/r/26425/diff/ Testing --- ./gradlew -Pq build Also, tested various update scenarios in vagrant. Thanks, Maxim Khutornenko
Re: Review Request 26288: Fixing unhandled error logging in updater
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 7, 2014, 10:26 p.m.) Review request for Aurora and Mark Chu-Carroll. Changes --- Updating title. Summary (updated) - Fixing unhandled error logging in updater Bugs: AURORA-786 https://issues.apache.org/jira/browse/AURORA-786 Repository: aurora Description (updated) --- Populating details rather than messageDEPRECATED in the client updater to fix logging issue. Diffs - src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b Diff: https://reviews.apache.org/r/26288/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Review Request 26428: Fixing python style violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Pre-commit hook was no longer working properly. Added target to match jenkins definition. Diffs - build-support/hooks/pre-commit 24646e7b1c43a0177beb0084dd2af4c4b3dc686c src/test/python/apache/aurora/client/api/test_updater.py fc6a057c6c650d9ac9800b009e544dfad0c809bf src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1 src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 Diff: https://reviews.apache.org/r/26428/diff/ Testing --- ./build-support/hooks/pre-commit Performing Python import order check. SUCCESS Performing Python checkstyle. SUCCESS $ build-support/python/checkstyle-check src Thanks, Maxim Khutornenko
Re: Review Request 26424: Disable requests http connection logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55727 --- Ship it! Aha, here we go. Thanks!! - Joe Smith On Oct. 7, 2014, 1:32 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- (Updated Oct. 7, 2014, 1:32 p.m.) Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-770 https://issues.apache.org/jira/browse/AURORA-770 Repository: aurora Description --- Disable requests http connection logging. Diffs - src/main/python/apache/aurora/common/transport.py 6f7c355d725b5e537cc4ae471170eaa8431da326 src/test/python/apache/aurora/common/test_transport.py c722eae2d04dec90e9c772f49c578184a2bdf76c Diff: https://reviews.apache.org/r/26424/diff/ Testing --- Added hokey test, ran hokey test. Also verified the lack of http connection logs when running client commands directly. Thanks, Joshua Cohen
Re: Review Request 26428: Fixing python style violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/#review55729 --- build-support/hooks/pre-commit https://reviews.apache.org/r/26428/#comment96117 this argument is ignored for isort-check/isort-run build-support/hooks/pre-commit https://reviews.apache.org/r/26428/#comment96118 the reason i didn't add this to the pre-commit is beause the default behavior for the pre-commit hook is to only check the diff against master. it's possible that it needs more context e.g. +-2 lines in the file beyond the diff, so it might miss stuff. doing against source for every commit might be too time consuming. out of curiosity, how long does it take to run this check on your laptop? - Brian Wickman On Oct. 7, 2014, 11:18 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/ --- (Updated Oct. 7, 2014, 11:18 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Pre-commit hook was no longer working properly. Added target to match jenkins definition. Diffs - build-support/hooks/pre-commit 24646e7b1c43a0177beb0084dd2af4c4b3dc686c src/test/python/apache/aurora/client/api/test_updater.py fc6a057c6c650d9ac9800b009e544dfad0c809bf src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1 src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 Diff: https://reviews.apache.org/r/26428/diff/ Testing --- ./build-support/hooks/pre-commit Performing Python import order check. SUCCESS Performing Python checkstyle. SUCCESS $ build-support/python/checkstyle-check src Thanks, Maxim Khutornenko
Re: Review Request 26428: Fixing python style violations.
On Oct. 7, 2014, 11:31 p.m., Brian Wickman wrote: build-support/hooks/pre-commit, line 41 https://reviews.apache.org/r/26428/diff/1/?file=714987#file714987line41 the reason i didn't add this to the pre-commit is beause the default behavior for the pre-commit hook is to only check the diff against master. it's possible that it needs more context e.g. +-2 lines in the file beyond the diff, so it might miss stuff. doing against source for every commit might be too time consuming. out of curiosity, how long does it take to run this check on your laptop? It's between 15-20 seconds now, which is much slower than usual but I'd rather make it slower and useful or drop completely and rely on jenkins script. Your call. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/#review55729 --- On Oct. 7, 2014, 11:18 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/ --- (Updated Oct. 7, 2014, 11:18 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Pre-commit hook was no longer working properly. Added target to match jenkins definition. Diffs - build-support/hooks/pre-commit 24646e7b1c43a0177beb0084dd2af4c4b3dc686c src/test/python/apache/aurora/client/api/test_updater.py fc6a057c6c650d9ac9800b009e544dfad0c809bf src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1 src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 Diff: https://reviews.apache.org/r/26428/diff/ Testing --- ./build-support/hooks/pre-commit Performing Python import order check. SUCCESS Performing Python checkstyle. SUCCESS $ build-support/python/checkstyle-check src Thanks, Maxim Khutornenko
Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description --- This removes several long deprecated configuration options from aurora. The features removed are cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1 src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Review Request 26431: Moving post_drain script execution into host_maintenance.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/ --- Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-806 https://issues.apache.org/jira/browse/AURORA-806 Repository: aurora Description --- Moving post_drain script functionality into host_maintenance.py to support per batch execution. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388 src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8 src/test/python/apache/aurora/client/commands/test_maintenance.py d86aaf677804301fa5ddf1f76dba552f4fafb8c3 Diff: https://reviews.apache.org/r/26431/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 26432: Reject new GC tasks when shutting down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26432/ --- (Updated Oct. 7, 2014, 5:14 p.m.) Review request for Aurora and Brian Wickman. Changes --- Fix diff Bugs: AURORA-807 https://issues.apache.org/jira/browse/AURORA-807 Repository: aurora Description --- Reject new GC tasks when shutting down Diffs (updated) - src/main/python/apache/aurora/executor/gc_executor.py 80ce6dc93e17f01c95a84ee8bef2ce87cafa88c0 src/test/python/apache/aurora/executor/test_gc_executor.py d90dc68ec1526110a484cfc2b6c4658abdc2e871 Diff: https://reviews.apache.org/r/26432/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:gc_executor Thanks, Kevin Sweeney
Re: Review Request 26428: Fixing python style violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/ --- (Updated Oct. 8, 2014, 12:17 a.m.) Review request for Aurora and Brian Wickman. Changes --- CR comments. Repository: aurora Description --- Pre-commit hook was no longer working properly. Added target to match jenkins definition. Diffs (updated) - build-support/hooks/pre-commit 24646e7b1c43a0177beb0084dd2af4c4b3dc686c src/test/python/apache/aurora/client/api/test_updater.py fc6a057c6c650d9ac9800b009e544dfad0c809bf src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1 src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 Diff: https://reviews.apache.org/r/26428/diff/ Testing --- ./build-support/hooks/pre-commit Performing Python import order check. SUCCESS Performing Python checkstyle. SUCCESS $ build-support/python/checkstyle-check src Thanks, Maxim Khutornenko
Re: Review Request 26328: Improve handling of unknown errors in the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55749 --- Ship it! Ship It! - David McLaughlin On Oct. 6, 2014, 6:55 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 6:55 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review55750 --- Ping Kevin. - Zameer Manji On Oct. 6, 2014, 12:02 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 6, 2014, 12:02 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/#review55751 --- Ship it! Ship It! - Kevin Sweeney On Oct. 6, 2014, 11:12 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/ --- (Updated Oct. 6, 2014, 11:12 a.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures. Diffs - src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413 src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b Diff: https://reviews.apache.org/r/26333/diff/ Testing --- Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here. Update: ran build-support/jenkins/build.sh after the merge of 25972 and it passed. Thanks, Brian Wickman
