Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63783
---

Ship it!


Ship It!

- David McLaughlin


On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28623/
 ---
 
 (Updated Dec. 3, 2014, 2:13 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Kevin Sweeney.
 
 
 Bugs: AURORA-143 and AURORA-467
 https://issues.apache.org/jira/browse/AURORA-143
 https://issues.apache.org/jira/browse/AURORA-467
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove getVersion RPC and DEPRECATEDversion Response field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6b63f04a7113527e26d7f38e877b0ebd07822108 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  0898c62315c5a47628ad629182c3177c86a00bce 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java
  3406722067af40a91fe39340d94ee03d20d7ddbd 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 04979084b5352d3044bd3c2ba7071e10d9992765 
   
 src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
  840b3f88e7de306fa0af73593b5bac6cc00528da 
 
 Diff: https://reviews.apache.org/r/28623/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28660: Reduce minimum branch coverage requirement to avoid flakiness.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28660/#review63707
---

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 3, 2014, 7:02 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28660/
 ---
 
 (Updated Dec. 3, 2014, 7:02 p.m.)
 
 
 Review request for Aurora and Maxim Khutornenko.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Reduce minimum branch coverage requirement to avoid flakiness.
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
 
 Diff: https://reviews.apache.org/r/28660/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28674: Remove Response.messageDEPRECATED field.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/
---

Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Bugs: AURORA-466
https://issues.apache.org/jira/browse/AURORA-466


Repository: aurora


Description
---

Remove Response.message field.


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6b63f04a7113527e26d7f38e877b0ebd07822108 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
d879db4157c7a2c782e3213974067d86b6184f04 
  src/main/python/apache/aurora/client/api/BUILD 
8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
  src/main/python/apache/aurora/client/api/__init__.py 
d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
  src/main/python/apache/aurora/client/api/command_runner.py 
14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
  src/main/python/apache/aurora/client/api/quota_check.py 
5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
  src/main/python/apache/aurora/client/api/restarter.py 
43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
  src/main/python/apache/aurora/client/api/updater.py 
2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
  src/main/python/apache/aurora/client/base.py 
2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
  src/main/python/apache/aurora/client/cli/context.py 
96c386e83db7b7c16419ca05b9155dd527bfb834 
  src/main/python/apache/aurora/client/cli/task.py 
8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
  src/main/python/apache/aurora/client/commands/admin.py 
cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
  src/main/python/apache/aurora/client/commands/core.py 
ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
91efe5248144049d6a13b1ec81ffe08522df1ee9 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
  src/test/python/apache/aurora/client/api/test_api.py 
1f4e9fe9111ac88726d7c45b699b3b91438448b6 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
27d8025bc80cff22c2f025302d1fe0519d8632e9 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
cb443c227589d69559c92444232eb6ba7d9259eb 
  src/test/python/apache/aurora/client/api/test_restarter.py 
eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
  src/test/python/apache/aurora/client/api/test_sla.py 
50a6c47f00c77265328d6eacc835884e158b9e20 
  src/test/python/apache/aurora/client/api/test_task_util.py 
3e772b949b0ec8b9cece62fc1ed46059a8310195 
  src/test/python/apache/aurora/client/api/test_updater.py 
a32fc529cb1b23ab926a9180debb68bb826f66a8 
  src/test/python/apache/aurora/client/cli/util.py 
0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
  src/test/python/apache/aurora/client/commands/test_admin.py 
f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
  src/test/python/apache/aurora/client/commands/test_kill.py 
4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
  src/test/python/apache/aurora/client/commands/util.py 
c06de50e81be57cbf0480b1566f0efcec07f8a9d 
  src/test/python/apache/aurora/client/test_base.py 
785784b3cb8e670111bb367363acc45772a8ea3e 

Diff: https://reviews.apache.org/r/28674/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28696: Use abstract decorators in CommandLine class.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28696/#review63823
---


Master (11da34c) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28696/
 ---
 
 (Updated Dec. 4, 2014, 7:40 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Use abstract decorators in CommandLine class. This ensures the name property 
 and register_nouns method are implemented.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
 
 Diff: https://reviews.apache.org/r/28696/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client::
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28660: Reduce minimum branch coverage requirement to avoid flakiness.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28660/#review63708
---

Ship it!


Master (4405031) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 3, 2014, 7:02 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28660/
 ---
 
 (Updated Dec. 3, 2014, 7:02 p.m.)
 
 
 Review request for Aurora and Maxim Khutornenko.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Reduce minimum branch coverage requirement to avoid flakiness.
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
 
 Diff: https://reviews.apache.org/r/28660/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28692: Simplify logging in the Aurora client.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28692/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-919
https://issues.apache.org/jira/browse/AURORA-919


Repository: aurora


Description
---

This patch removes a custom log level and adds a --verbose flag to the output.


Diffs
-

  src/main/python/apache/aurora/client/cli/BUILD 
ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/context.py 
51c7d24dca664e476e62f1864d095416dfab70e4 
  src/main/python/apache/aurora/client/cli/logsetup.py 
55d99c42f643910db0bf3c24022596383e160276 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28692/diff/


Testing
---

./pants src/test/python/apache/aurora/client::


Thanks,

Zameer Manji

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/#review63734
---

Ship it!


Master (9b1e9fb) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 3, 2014, 8:34 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28674/
 ---
 
 (Updated Dec. 3, 2014, 8:34 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-466
 https://issues.apache.org/jira/browse/AURORA-466
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove Response.message field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6b63f04a7113527e26d7f38e877b0ebd07822108 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 d879db4157c7a2c782e3213974067d86b6184f04 
   src/main/python/apache/aurora/client/api/BUILD 
 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
   src/main/python/apache/aurora/client/api/__init__.py 
 d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
   src/main/python/apache/aurora/client/api/command_runner.py 
 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
   src/main/python/apache/aurora/client/api/quota_check.py 
 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
   src/main/python/apache/aurora/client/api/restarter.py 
 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
   src/main/python/apache/aurora/client/api/updater.py 
 2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
   src/main/python/apache/aurora/client/base.py 
 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
   src/main/python/apache/aurora/client/cli/context.py 
 96c386e83db7b7c16419ca05b9155dd527bfb834 
   src/main/python/apache/aurora/client/cli/task.py 
 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
   src/main/python/apache/aurora/client/commands/admin.py 
 cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
   src/main/python/apache/aurora/client/commands/core.py 
 ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 91efe5248144049d6a13b1ec81ffe08522df1ee9 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
   src/test/python/apache/aurora/client/api/test_api.py 
 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 27d8025bc80cff22c2f025302d1fe0519d8632e9 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 cb443c227589d69559c92444232eb6ba7d9259eb 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
   src/test/python/apache/aurora/client/api/test_sla.py 
 50a6c47f00c77265328d6eacc835884e158b9e20 
   src/test/python/apache/aurora/client/api/test_task_util.py 
 3e772b949b0ec8b9cece62fc1ed46059a8310195 
   src/test/python/apache/aurora/client/api/test_updater.py 
 a32fc529cb1b23ab926a9180debb68bb826f66a8 
   src/test/python/apache/aurora/client/cli/util.py 
 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
   src/test/python/apache/aurora/client/commands/test_admin.py 
 f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
   src/test/python/apache/aurora/client/commands/util.py 
 c06de50e81be57cbf0480b1566f0efcec07f8a9d 
   src/test/python/apache/aurora/client/test_base.py 
 785784b3cb8e670111bb367363acc45772a8ea3e 
 
 Diff: https://reviews.apache.org/r/28674/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28693/
---

Review request for Aurora.


Repository: aurora


Description
---

This makes ConfigurationPlugin inherit from AbstractClass so the 
@abstractmethod annotation is useful. This also removes the annotation for the 
two methods with default values.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28693/diff/


Testing
---

./pants src/test/python/apache/aurora/client::


Thanks,

Zameer Manji

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28693/
---

(Updated Dec. 3, 2014, 10:36 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Add reviewers (kevin, maxim)


Repository: aurora


Description
---

This makes ConfigurationPlugin inherit from AbstractClass so the 
@abstractmethod annotation is useful. This also removes the annotation for the 
two methods with default values.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28693/diff/


Testing
---

./pants src/test/python/apache/aurora/client::


Thanks,

Zameer Manji

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/#review63737
---

Ship it!


Ship It!

- Zameer Manji


On Dec. 3, 2014, 12:34 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28674/
 ---
 
 (Updated Dec. 3, 2014, 12:34 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-466
 https://issues.apache.org/jira/browse/AURORA-466
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove Response.message field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6b63f04a7113527e26d7f38e877b0ebd07822108 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 d879db4157c7a2c782e3213974067d86b6184f04 
   src/main/python/apache/aurora/client/api/BUILD 
 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
   src/main/python/apache/aurora/client/api/__init__.py 
 d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
   src/main/python/apache/aurora/client/api/command_runner.py 
 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
   src/main/python/apache/aurora/client/api/quota_check.py 
 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
   src/main/python/apache/aurora/client/api/restarter.py 
 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
   src/main/python/apache/aurora/client/api/updater.py 
 2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
   src/main/python/apache/aurora/client/base.py 
 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
   src/main/python/apache/aurora/client/cli/context.py 
 96c386e83db7b7c16419ca05b9155dd527bfb834 
   src/main/python/apache/aurora/client/cli/task.py 
 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
   src/main/python/apache/aurora/client/commands/admin.py 
 cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
   src/main/python/apache/aurora/client/commands/core.py 
 ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 91efe5248144049d6a13b1ec81ffe08522df1ee9 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
   src/test/python/apache/aurora/client/api/test_api.py 
 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 27d8025bc80cff22c2f025302d1fe0519d8632e9 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 cb443c227589d69559c92444232eb6ba7d9259eb 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
   src/test/python/apache/aurora/client/api/test_sla.py 
 50a6c47f00c77265328d6eacc835884e158b9e20 
   src/test/python/apache/aurora/client/api/test_task_util.py 
 3e772b949b0ec8b9cece62fc1ed46059a8310195 
   src/test/python/apache/aurora/client/api/test_updater.py 
 a32fc529cb1b23ab926a9180debb68bb826f66a8 
   src/test/python/apache/aurora/client/cli/util.py 
 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
   src/test/python/apache/aurora/client/commands/test_admin.py 
 f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
   src/test/python/apache/aurora/client/commands/util.py 
 c06de50e81be57cbf0480b1566f0efcec07f8a9d 
   src/test/python/apache/aurora/client/test_base.py 
 785784b3cb8e670111bb367363acc45772a8ea3e 
 
 Diff: https://reviews.apache.org/r/28674/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/
---

Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-947
https://issues.apache.org/jira/browse/AURORA-947


Repository: aurora


Description
---

There's a subtle change in 
`buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to avoid 
generating thermos' thrift for the scheduler.  This prevents a conflict on 
index.html.


Diffs
-

  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
31934f551da808951144cd474255105a9d198854 
  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
e6114cf0ec557b8d365140b5f413c69a61dc1563 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
022b9f452e8f7c129b8c202c5f2fff5547f71b0d 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
  src/main/resources/scheduler/assets/index.html 
cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 

Diff: https://reviews.apache.org/r/28682/diff/


Testing
---

./gradlew run, clicked around.


Thanks,

Bill Farner

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/#review63733
---



src/main/python/apache/aurora/client/base.py
https://reviews.apache.org/r/28674/#comment106024

This uses a different quoting style than the rest of the file.



src/main/python/apache/aurora/client/base.py
https://reviews.apache.org/r/28674/#comment106025

This will str() on a ResponseDetail object including the struct details 
that we don't need: 

```
$ ./pants py src/main/python/apache/aurora/client:base
 from gen.apache.aurora.api.ttypes import Response, ResponseDetail, 
ResponseCode
 resp = Response(responseCode=ResponseCode.OK, 
details=[ResponseDetail(message='Quota check successful.')])
 ', '.join(map(str, resp.details or []))
ResponseDetail(message='Quota check successful.')
```



src/test/python/apache/aurora/client/api/test_job_monitor.py
https://reviews.apache.org/r/28674/#comment106028

Use kvarg 'message=' for consistency?



src/test/python/apache/aurora/client/api/test_quota_check.py
https://reviews.apache.org/r/28674/#comment106029

same here



src/test/python/apache/aurora/client/api/test_task_util.py
https://reviews.apache.org/r/28674/#comment106032

same here


- Maxim Khutornenko


On Dec. 3, 2014, 8:34 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28674/
 ---
 
 (Updated Dec. 3, 2014, 8:34 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-466
 https://issues.apache.org/jira/browse/AURORA-466
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove Response.message field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6b63f04a7113527e26d7f38e877b0ebd07822108 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 d879db4157c7a2c782e3213974067d86b6184f04 
   src/main/python/apache/aurora/client/api/BUILD 
 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
   src/main/python/apache/aurora/client/api/__init__.py 
 d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
   src/main/python/apache/aurora/client/api/command_runner.py 
 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
   src/main/python/apache/aurora/client/api/quota_check.py 
 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
   src/main/python/apache/aurora/client/api/restarter.py 
 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
   src/main/python/apache/aurora/client/api/updater.py 
 2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
   src/main/python/apache/aurora/client/base.py 
 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
   src/main/python/apache/aurora/client/cli/context.py 
 96c386e83db7b7c16419ca05b9155dd527bfb834 
   src/main/python/apache/aurora/client/cli/task.py 
 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
   src/main/python/apache/aurora/client/commands/admin.py 
 cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
   src/main/python/apache/aurora/client/commands/core.py 
 ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 91efe5248144049d6a13b1ec81ffe08522df1ee9 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
   src/test/python/apache/aurora/client/api/test_api.py 
 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 27d8025bc80cff22c2f025302d1fe0519d8632e9 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 cb443c227589d69559c92444232eb6ba7d9259eb 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
   src/test/python/apache/aurora/client/api/test_sla.py 
 50a6c47f00c77265328d6eacc835884e158b9e20 
   src/test/python/apache/aurora/client/api/test_task_util.py 
 3e772b949b0ec8b9cece62fc1ed46059a8310195 
   src/test/python/apache/aurora/client/api/test_updater.py 
 a32fc529cb1b23ab926a9180debb68bb826f66a8 
   src/test/python/apache/aurora/client/cli/util.py 
 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
   src/test/python/apache/aurora/client/commands/test_admin.py 
 f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
   src/test/python/apache/aurora/client/commands/util.py 
 c06de50e81be57cbf0480b1566f0efcec07f8a9d 
   src/test/python/apache/aurora/client/test_base.py 
 785784b3cb8e670111bb367363acc45772a8ea3e 
 
 Diff: 

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63714
---


David, Kevin - ping?

- Bill Farner


On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28623/
 ---
 
 (Updated Dec. 3, 2014, 2:13 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Kevin Sweeney.
 
 
 Bugs: AURORA-143 and AURORA-467
 https://issues.apache.org/jira/browse/AURORA-143
 https://issues.apache.org/jira/browse/AURORA-467
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove getVersion RPC and DEPRECATEDversion Response field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6b63f04a7113527e26d7f38e877b0ebd07822108 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  0898c62315c5a47628ad629182c3177c86a00bce 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java
  3406722067af40a91fe39340d94ee03d20d7ddbd 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 04979084b5352d3044bd3c2ba7071e10d9992765 
   
 src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
  840b3f88e7de306fa0af73593b5bac6cc00528da 
 
 Diff: https://reviews.apache.org/r/28623/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28607: Add a caching ClusterState implementation.

[Bill Farner]

 On Dec. 3, 2014, 2:06 a.m., Maxim Khutornenko wrote:
  src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java,
   line 56
  https://reviews.apache.org/r/28607/diff/2/?file=780608#file780608line56
 
  This can be further simplified (unless you are concerned about the heap 
  churn):
  ```java
  victims.remove(slaveId, 
  PreemptionVictim.fromTask(stateChange.getTask().getAssignedTask());
  ```

Good suggestion, this also removed some surrounding code.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28607/#review63637
---


On Dec. 3, 2014, 1:39 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28607/
 ---
 
 (Updated Dec. 3, 2014, 1:39 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-121
 https://issues.apache.org/jira/browse/AURORA-121
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add a caching ClusterState implementation.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
  PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
 3524dc595e7b61a531912843f90b01a87bc57cc4 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
  489c0bfa22aae14fbd3fd2ee9e5bd32b7c3aafa5 
   
 src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28607/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28607: Add a caching ClusterState implementation.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28607/
---

(Updated Dec. 3, 2014, 6:23 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Bugs: AURORA-121
https://issues.apache.org/jira/browse/AURORA-121


Repository: aurora


Description
---

Add a caching ClusterState implementation.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
3524dc595e7b61a531912843f90b01a87bc57cc4 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 
489c0bfa22aae14fbd3fd2ee9e5bd32b7c3aafa5 
  
src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/28607/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/#review63793
---

Ship it!


Ship It!

- Zameer Manji


On Dec. 3, 2014, 4:36 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28682/
 ---
 
 (Updated Dec. 3, 2014, 4:36 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-947
 https://issues.apache.org/jira/browse/AURORA-947
 
 
 Repository: aurora
 
 
 Description
 ---
 
 There's a subtle change in 
 `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to 
 avoid generating thermos' thrift for the scheduler.  This prevents a conflict 
 on index.html.
 
 
 Diffs
 -
 
   
 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
 31934f551da808951144cd474255105a9d198854 
   buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
 e6114cf0ec557b8d365140b5f413c69a61dc1563 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 022b9f452e8f7c129b8c202c5f2fff5547f71b0d 
   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
 ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
   src/main/resources/scheduler/assets/index.html 
 cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 
 
 Diff: https://reviews.apache.org/r/28682/diff/
 
 
 Testing
 ---
 
 ./gradlew run, clicked around.
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28607: Add a caching ClusterState implementation.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28607/#review63700
---

Ship it!


Master (8959b49) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 3, 2014, 6:23 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28607/
 ---
 
 (Updated Dec. 3, 2014, 6:23 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-121
 https://issues.apache.org/jira/browse/AURORA-121
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add a caching ClusterState implementation.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
  PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
 3524dc595e7b61a531912843f90b01a87bc57cc4 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
  489c0bfa22aae14fbd3fd2ee9e5bd32b7c3aafa5 
   
 src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimTest.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28607/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/#review63796
---



buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
https://reviews.apache.org/r/28682/#comment106104

Override this in the thriftEntities block in the build.gradle, not in the 
source for the plugin.

```
thriftEntities {
  inputFiles = fileTree(...)
}
```

But is this just here to exclude thermos? In that case you might consider 
adding an explicit exclude (in the build.gradle).


- Kevin Sweeney


On Dec. 3, 2014, 4:36 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28682/
 ---
 
 (Updated Dec. 3, 2014, 4:36 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-947
 https://issues.apache.org/jira/browse/AURORA-947
 
 
 Repository: aurora
 
 
 Description
 ---
 
 There's a subtle change in 
 `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to 
 avoid generating thermos' thrift for the scheduler.  This prevents a conflict 
 on index.html.
 
 
 Diffs
 -
 
   
 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
 31934f551da808951144cd474255105a9d198854 
   buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
 e6114cf0ec557b8d365140b5f413c69a61dc1563 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 022b9f452e8f7c129b8c202c5f2fff5547f71b0d 
   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
 ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
   src/main/resources/scheduler/assets/index.html 
 cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 
 
 Diff: https://reviews.apache.org/r/28682/diff/
 
 
 Testing
 ---
 
 ./gradlew run, clicked around.
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28693/#review63859
---



src/main/python/apache/aurora/client/cli/__init__.py
https://reviews.apache.org/r/28693/#comment106171

Why not keeping @abstractmethod attributes and dropping the return 
statements instead? With your modification there is no need to keep this noop 
behavior as tests like EmptyPlugin below would not be possible anyway.


- Maxim Khutornenko


On Dec. 4, 2014, 6:36 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28693/
 ---
 
 (Updated Dec. 4, 2014, 6:36 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This makes ConfigurationPlugin inherit from AbstractClass so the 
 @abstractmethod annotation is useful. This also removes the annotation for 
 the two methods with default values.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28693/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client::
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

[Maxim Khutornenko]

 On Dec. 4, 2014, 5:21 p.m., Maxim Khutornenko wrote:
  src/main/python/apache/aurora/client/cli/__init__.py, lines 172-175
  https://reviews.apache.org/r/28693/diff/1/?file=782496#file782496line172
 
  Why not keeping @abstractmethod attributes and dropping the return 
  statements instead? With your modification there is no need to keep this 
  noop behavior as tests like EmptyPlugin below would not be possible 
  anyway.
 
 Zameer Manji wrote:
 The return statements provide default behaviour that plugins should have 
 to prevent AURORA-362. If get_options does not return an iterable the 
 argument handling code will crash and before_dispatch needs to return 
 raw_args to prevent the clobbering of user passed in commandline arguments.
 
 This reduces the work that plugins need to do if they are just interested 
 in implementing before_execution or after_execution.

I don't see how `before_dispatch` is semantically different from 
`before_execution` for the plugin implementor. The only difference is that one 
is expected to return `raw_args` and the other one is void. These noops provide 
no additional value besides questionable convenience on override. I would say 
drop the return statements, convert these methods back to abstract and properly 
document return type expectations. This way there is no second guessing what 
needs to be overriden and what isn't.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28693/#review63859
---


On Dec. 4, 2014, 6:36 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28693/
 ---
 
 (Updated Dec. 4, 2014, 6:36 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This makes ConfigurationPlugin inherit from AbstractClass so the 
 @abstractmethod annotation is useful. This also removes the annotation for 
 the two methods with default values.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28693/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client::
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28693/
---

(Updated Dec. 4, 2014, 10:14 a.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Maxim's feedback.


Repository: aurora


Description
---

This makes ConfigurationPlugin inherit from AbstractClass so the 
@abstractmethod annotation is useful. This also removes the annotation for the 
two methods with default values.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28693/diff/


Testing
---

./pants src/test/python/apache/aurora/client::


Thanks,

Zameer Manji

Re: Review Request 28692: Simplify logging in the Aurora client.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28692/#review63869
---


Can you paste a few examples from vagrant (preferrably job update) before and 
after your change? That would help reviewing.


src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/28692/#comment106184

Why is this jumping from TRANSCRIPT to INFO? Will every invocation now log 
the entire config?



src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/28692/#comment106185

same question here


- Maxim Khutornenko


On Dec. 4, 2014, 6:27 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28692/
 ---
 
 (Updated Dec. 4, 2014, 6:27 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Bugs: AURORA-919
 https://issues.apache.org/jira/browse/AURORA-919
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This patch removes a custom log level and adds a --verbose flag to the output.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/BUILD 
 ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/main/python/apache/aurora/client/cli/context.py 
 51c7d24dca664e476e62f1864d095416dfab70e4 
   src/main/python/apache/aurora/client/cli/logsetup.py 
 55d99c42f643910db0bf3c24022596383e160276 
   src/main/python/apache/aurora/client/cli/standalone_client.py 
 b7c8de66d6e4664b536911f826e36a984e8d0fef 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28692/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client::
 
 
 Thanks,
 
 Zameer Manji
 

Review Request 28710: Adding JMH framework support for scheduler performance analysis.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
---

This RB is superseding the https://reviews.apache.org/r/28474/.


I have spent some time researching the available microbenchmark frameworks and 
JMH [1] came as a clear winner:
- Active development trail [2]
- Advanced featureset and built-in optimizations improving accuracy and 
consistency [3]
- Well documented set of examples [4]
- Large community experience and collective wisdom. 


This RB adds gradle support for running JMH benchmarks and is relying on JMH 
gradle plugin [5]. The benchmarks are run via `./gradlew jmh` command.

[1] - http://openjdk.java.net/projects/code-tools/jmh/
[2] - http://hg.openjdk.java.net/code-tools/jmh/ 
[3] - 
https://groups.google.com/forum/#!msg/mechanical-sympathy/m4opvy4xq3U/7lY8x8SvHgwJ
[4] - 
http://hg.openjdk.java.net/code-tools/jmh/file/adb6047266d8/jmh-samples/src/main/java/org/openjdk/jmh/samples
[5] - https://github.com/melix/jmh-gradle-plugin


Diffs
-

  build.gradle fb729c5096108c535229e266fa9649f997e6da37 
  config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f 
  src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java PRE-CREATION 

Diff: https://reviews.apache.org/r/28710/diff/


Testing
---

$ ./gradlew jmh

Sample results generated:

```
# VM invoker: 
/Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
# VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
-Duser.variant
# Warmup: 1 iterations, 1 s each
# Measurement: 3 iterations, 1 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Throughput, ops/time
# Benchmark: org.apache.aurora.benchmark.SchedulerBenchmark.example

# Run progress: 0.00% complete, ETA 00:00:04
# Fork: 1 of 1
# Warmup Iteration   1: 3156839103.911 ops/s
Iteration   1: 544897.411 ops/s
Iteration   2: 3357230627.218 ops/s
Iteration   3: 3461073727.560 ops/s


Result: 3383949750.729 ±(99.9%) 1237528915.517 ops/s [Average]
  Statistics: (min, avg, max) = (544897.411, 3383949750.729, 
3461073727.560), stdev = 67833135.714
  Confidence interval (99.9%): [2146420835.212, 4621478666.247]


# Run complete. Total time: 00:00:05

Benchmark  Mode  Samples   Score
Error  Units
o.a.a.b.SchedulerBenchmark.examplethrpt3  3383949750.729 ± 
1237528915.517  ops/s

```


Thanks,

Maxim Khutornenko

Re: Review Request 28474: Added manual perf tests for the scheduling pipeline.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28474/#review63888
---


Discarding this in favor of benchmark harness started in 
https://reviews.apache.org/r/28710/.

- Maxim Khutornenko


On Nov. 26, 2014, 6:15 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28474/
 ---
 
 (Updated Nov. 26, 2014, 6:15 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-909
 https://issues.apache.org/jira/browse/AURORA-909
 
 
 Repository: aurora
 
 
 Description
 ---
 
 A manual testbed for the upcoming AURORA-909 work.
 
 
 Diffs
 -
 
   src/test/java/org/apache/aurora/scheduler/async/Offers.java 
 8293dd181b0d062e89776fdc1205c1c227d6bb6c 
   src/test/java/org/apache/aurora/scheduler/async/SchedulerPerfIT.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28474/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 IDE manual run:
 
 Nov 26, 2014 10:12:21 AM 
 org.apache.aurora.scheduler.async.preemptor.PreemptorModule configure
 INFO: Preemptor Enabled.
 Nov 26, 2014 10:12:21 AM com.twitter.common.util.BuildInfo fetchProperties
 INFO: Fetching build properties from build.properties
 Nov 26, 2014 10:12:21 AM com.twitter.common.util.BuildInfo fetchProperties
 WARNING: Failed to fetch build properties from build.properties
 Nov 26, 2014 10:12:21 AM 
 com.twitter.common.application.modules.StatsModule$StartStatPoller execute
 INFO: Build information: {}
 Nov 26, 2014 10:12:26 AM org.apache.aurora.scheduler.async.SchedulerPerfIT 
 runTest
 INFO: Results for: INSUFFICIENT_RESOURCES
 Nov 26, 2014 10:12:26 AM org.apache.aurora.scheduler.async.SchedulerPerfIT 
 logDuration
 INFO: Mean task_schedule_attempt duration: 737660.0796871068 ns
 Nov 26, 2014 10:12:26 AM org.apache.aurora.scheduler.async.SchedulerPerfIT 
 logDuration
 INFO: Mean offer_queue_launch_first duration: 332330.25185686833 ns
 
 
 Thanks,
 
 Maxim Khutornenko
 

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63889
---

Ship it!


Master (11da34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 4, 2014, 7:36 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28710/
 ---
 
 (Updated Dec. 4, 2014, 7:36 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This RB is superseding the https://reviews.apache.org/r/28474/.
 
 
 I have spent some time researching the available microbenchmark frameworks 
 and JMH [1] came as a clear winner:
 - Active development trail [2]
 - Advanced featureset and built-in optimizations improving accuracy and 
 consistency [3]
 - Well documented set of examples [4]
 - Large community experience and collective wisdom. 
 
 
 This RB adds gradle support for running JMH benchmarks and is relying on JMH 
 gradle plugin [5]. The benchmarks are run via `./gradlew jmh` command.
 
 [1] - http://openjdk.java.net/projects/code-tools/jmh/
 [2] - http://hg.openjdk.java.net/code-tools/jmh/ 
 [3] - 
 https://groups.google.com/forum/#!msg/mechanical-sympathy/m4opvy4xq3U/7lY8x8SvHgwJ
 [4] - 
 http://hg.openjdk.java.net/code-tools/jmh/file/adb6047266d8/jmh-samples/src/main/java/org/openjdk/jmh/samples
 [5] - https://github.com/melix/jmh-gradle-plugin
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
   config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f 
   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28710/diff/
 
 
 Testing
 ---
 
 $ ./gradlew jmh
 
 Sample results generated:
 
 ```
 # VM invoker: 
 /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
 # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
 -Duser.variant
 # Warmup: 1 iterations, 1 s each
 # Measurement: 3 iterations, 1 s each
 # Timeout: 10 min per iteration
 # Threads: 1 thread, will synchronize iterations
 # Benchmark mode: Throughput, ops/time
 # Benchmark: org.apache.aurora.benchmark.SchedulerBenchmark.example
 
 # Run progress: 0.00% complete, ETA 00:00:04
 # Fork: 1 of 1
 # Warmup Iteration   1: 3156839103.911 ops/s
 Iteration   1: 544897.411 ops/s
 Iteration   2: 3357230627.218 ops/s
 Iteration   3: 3461073727.560 ops/s
 
 
 Result: 3383949750.729 ±(99.9%) 1237528915.517 ops/s [Average]
   Statistics: (min, avg, max) = (544897.411, 3383949750.729, 
 3461073727.560), stdev = 67833135.714
   Confidence interval (99.9%): [2146420835.212, 4621478666.247]
 
 
 # Run complete. Total time: 00:00:05
 
 Benchmark  Mode  Samples   Score  
   Error  Units
 o.a.a.b.SchedulerBenchmark.examplethrpt3  3383949750.729 ± 
 1237528915.517  ops/s
 
 ```
 
 
 Thanks,
 
 Maxim Khutornenko
 

Re: Review Request 28692: Simplify logging in the Aurora client.

[Zameer Manji]

 On Dec. 4, 2014, 10:21 a.m., Maxim Khutornenko wrote:
  src/main/python/apache/aurora/client/cli/context.py, line 94
  https://reviews.apache.org/r/28692/diff/1/?file=782492#file782492line94
 
  Why is this jumping from TRANSCRIPT to INFO? Will every invocation now 
  log the entire config?

Good catch.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28692/#review63869
---


On Dec. 3, 2014, 10:27 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28692/
 ---
 
 (Updated Dec. 3, 2014, 10:27 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Bugs: AURORA-919
 https://issues.apache.org/jira/browse/AURORA-919
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This patch removes a custom log level and adds a --verbose flag to the output.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/BUILD 
 ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/main/python/apache/aurora/client/cli/context.py 
 51c7d24dca664e476e62f1864d095416dfab70e4 
   src/main/python/apache/aurora/client/cli/logsetup.py 
 55d99c42f643910db0bf3c24022596383e160276 
   src/main/python/apache/aurora/client/cli/standalone_client.py 
 b7c8de66d6e4664b536911f826e36a984e8d0fef 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28692/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client::
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28692: Simplify logging in the Aurora client.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28692/
---

(Updated Dec. 4, 2014, 11:54 a.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-919
https://issues.apache.org/jira/browse/AURORA-919


Repository: aurora


Description
---

This patch removes a custom log level and adds a --verbose flag to the output.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/context.py 
51c7d24dca664e476e62f1864d095416dfab70e4 
  src/main/python/apache/aurora/client/cli/logsetup.py 
55d99c42f643910db0bf3c24022596383e160276 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28692/diff/


Testing
---

./pants src/test/python/apache/aurora/client::


Thanks,

Zameer Manji

Re: Review Request 28692: Simplify logging in the Aurora client.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28692/#review63894
---

Ship it!


Master (11da34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 4, 2014, 7:54 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28692/
 ---
 
 (Updated Dec. 4, 2014, 7:54 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Bugs: AURORA-919
 https://issues.apache.org/jira/browse/AURORA-919
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This patch removes a custom log level and adds a --verbose flag to the output.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/BUILD 
 ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/main/python/apache/aurora/client/cli/context.py 
 51c7d24dca664e476e62f1864d095416dfab70e4 
   src/main/python/apache/aurora/client/cli/logsetup.py 
 55d99c42f643910db0bf3c24022596383e160276 
   src/main/python/apache/aurora/client/cli/standalone_client.py 
 b7c8de66d6e4664b536911f826e36a984e8d0fef 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28692/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client::
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63896
---



build.gradle
https://reviews.apache.org/r/28710/#comment106209

Looks like you want the new-style block here instead:

https://plugins.gradle.org/plugin/me.champeau.gradle.jmh


- Kevin Sweeney


On Dec. 4, 2014, 11:36 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28710/
 ---
 
 (Updated Dec. 4, 2014, 11:36 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This RB is superseding the https://reviews.apache.org/r/28474/.
 
 
 I have spent some time researching the available microbenchmark frameworks 
 and JMH [1] came as a clear winner:
 - Active development trail [2]
 - Advanced featureset and built-in optimizations improving accuracy and 
 consistency [3]
 - Well documented set of examples [4]
 - Large community experience and collective wisdom. 
 
 
 This RB adds gradle support for running JMH benchmarks and is relying on JMH 
 gradle plugin [5]. The benchmarks are run via `./gradlew jmh` command.
 
 [1] - http://openjdk.java.net/projects/code-tools/jmh/
 [2] - http://hg.openjdk.java.net/code-tools/jmh/ 
 [3] - 
 https://groups.google.com/forum/#!msg/mechanical-sympathy/m4opvy4xq3U/7lY8x8SvHgwJ
 [4] - 
 http://hg.openjdk.java.net/code-tools/jmh/file/adb6047266d8/jmh-samples/src/main/java/org/openjdk/jmh/samples
 [5] - https://github.com/melix/jmh-gradle-plugin
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
   config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f 
   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28710/diff/
 
 
 Testing
 ---
 
 $ ./gradlew jmh
 
 Sample results generated:
 
 ```
 # VM invoker: 
 /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
 # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
 -Duser.variant
 # Warmup: 1 iterations, 1 s each
 # Measurement: 3 iterations, 1 s each
 # Timeout: 10 min per iteration
 # Threads: 1 thread, will synchronize iterations
 # Benchmark mode: Throughput, ops/time
 # Benchmark: org.apache.aurora.benchmark.SchedulerBenchmark.example
 
 # Run progress: 0.00% complete, ETA 00:00:04
 # Fork: 1 of 1
 # Warmup Iteration   1: 3156839103.911 ops/s
 Iteration   1: 544897.411 ops/s
 Iteration   2: 3357230627.218 ops/s
 Iteration   3: 3461073727.560 ops/s
 
 
 Result: 3383949750.729 ±(99.9%) 1237528915.517 ops/s [Average]
   Statistics: (min, avg, max) = (544897.411, 3383949750.729, 
 3461073727.560), stdev = 67833135.714
   Confidence interval (99.9%): [2146420835.212, 4621478666.247]
 
 
 # Run complete. Total time: 00:00:05
 
 Benchmark  Mode  Samples   Score  
   Error  Units
 o.a.a.b.SchedulerBenchmark.examplethrpt3  3383949750.729 ± 
 1237528915.517  ops/s
 
 ```
 
 
 Thanks,
 
 Maxim Khutornenko
 

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

[Maxim Khutornenko]

 On Dec. 4, 2014, 8:12 p.m., Kevin Sweeney wrote:
  build.gradle, line 23
  https://reviews.apache.org/r/28710/diff/1/?file=782698#file782698line23
 
  Looks like you want the new-style block here instead:
  
  https://plugins.gradle.org/plugin/me.champeau.gradle.jmh

Great suggestion. Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63896
---


On Dec. 4, 2014, 7:36 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28710/
 ---
 
 (Updated Dec. 4, 2014, 7:36 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This RB is superseding the https://reviews.apache.org/r/28474/.
 
 
 I have spent some time researching the available microbenchmark frameworks 
 and JMH [1] came as a clear winner:
 - Active development trail [2]
 - Advanced featureset and built-in optimizations improving accuracy and 
 consistency [3]
 - Well documented set of examples [4]
 - Large community experience and collective wisdom. 
 
 
 This RB adds gradle support for running JMH benchmarks and is relying on JMH 
 gradle plugin [5]. The benchmarks are run via `./gradlew jmh` command.
 
 [1] - http://openjdk.java.net/projects/code-tools/jmh/
 [2] - http://hg.openjdk.java.net/code-tools/jmh/ 
 [3] - 
 https://groups.google.com/forum/#!msg/mechanical-sympathy/m4opvy4xq3U/7lY8x8SvHgwJ
 [4] - 
 http://hg.openjdk.java.net/code-tools/jmh/file/adb6047266d8/jmh-samples/src/main/java/org/openjdk/jmh/samples
 [5] - https://github.com/melix/jmh-gradle-plugin
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
   config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f 
   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28710/diff/
 
 
 Testing
 ---
 
 $ ./gradlew jmh
 
 Sample results generated:
 
 ```
 # VM invoker: 
 /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
 # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
 -Duser.variant
 # Warmup: 1 iterations, 1 s each
 # Measurement: 3 iterations, 1 s each
 # Timeout: 10 min per iteration
 # Threads: 1 thread, will synchronize iterations
 # Benchmark mode: Throughput, ops/time
 # Benchmark: org.apache.aurora.benchmark.SchedulerBenchmark.example
 
 # Run progress: 0.00% complete, ETA 00:00:04
 # Fork: 1 of 1
 # Warmup Iteration   1: 3156839103.911 ops/s
 Iteration   1: 544897.411 ops/s
 Iteration   2: 3357230627.218 ops/s
 Iteration   3: 3461073727.560 ops/s
 
 
 Result: 3383949750.729 ±(99.9%) 1237528915.517 ops/s [Average]
   Statistics: (min, avg, max) = (544897.411, 3383949750.729, 
 3461073727.560), stdev = 67833135.714
   Confidence interval (99.9%): [2146420835.212, 4621478666.247]
 
 
 # Run complete. Total time: 00:00:05
 
 Benchmark  Mode  Samples   Score  
   Error  Units
 o.a.a.b.SchedulerBenchmark.examplethrpt3  3383949750.729 ± 
 1237528915.517  ops/s
 
 ```
 
 
 Thanks,
 
 Maxim Khutornenko
 

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63900
---

Ship it!


Master (11da34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 4, 2014, 8:20 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28710/
 ---
 
 (Updated Dec. 4, 2014, 8:20 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This RB is superseding the https://reviews.apache.org/r/28474/.
 
 
 I have spent some time researching the available microbenchmark frameworks 
 and JMH [1] came as a clear winner:
 - Active development trail [2]
 - Advanced featureset and built-in optimizations improving accuracy and 
 consistency [3]
 - Well documented set of examples [4]
 - Large community experience and collective wisdom. 
 
 
 This RB adds gradle support for running JMH benchmarks and is relying on JMH 
 gradle plugin [5]. The benchmarks are run via `./gradlew jmh` command.
 
 [1] - http://openjdk.java.net/projects/code-tools/jmh/
 [2] - http://hg.openjdk.java.net/code-tools/jmh/ 
 [3] - 
 https://groups.google.com/forum/#!msg/mechanical-sympathy/m4opvy4xq3U/7lY8x8SvHgwJ
 [4] - 
 http://hg.openjdk.java.net/code-tools/jmh/file/adb6047266d8/jmh-samples/src/main/java/org/openjdk/jmh/samples
 [5] - https://github.com/melix/jmh-gradle-plugin
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
   config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f 
   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28710/diff/
 
 
 Testing
 ---
 
 $ ./gradlew jmh
 
 Sample results generated:
 
 ```
 # VM invoker: 
 /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
 # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
 -Duser.variant
 # Warmup: 1 iterations, 1 s each
 # Measurement: 3 iterations, 1 s each
 # Timeout: 10 min per iteration
 # Threads: 1 thread, will synchronize iterations
 # Benchmark mode: Throughput, ops/time
 # Benchmark: org.apache.aurora.benchmark.SchedulerBenchmark.example
 
 # Run progress: 0.00% complete, ETA 00:00:04
 # Fork: 1 of 1
 # Warmup Iteration   1: 3156839103.911 ops/s
 Iteration   1: 544897.411 ops/s
 Iteration   2: 3357230627.218 ops/s
 Iteration   3: 3461073727.560 ops/s
 
 
 Result: 3383949750.729 ±(99.9%) 1237528915.517 ops/s [Average]
   Statistics: (min, avg, max) = (544897.411, 3383949750.729, 
 3461073727.560), stdev = 67833135.714
   Confidence interval (99.9%): [2146420835.212, 4621478666.247]
 
 
 # Run complete. Total time: 00:00:05
 
 Benchmark  Mode  Samples   Score  
   Error  Units
 o.a.a.b.SchedulerBenchmark.examplethrpt3  3383949750.729 ± 
 1237528915.517  ops/s
 
 ```
 
 
 Thanks,
 
 Maxim Khutornenko
 

Review Request 28728: Collect HTTP stats on every request.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28728/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
---

Collect HTTP stats on every request.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
83ba0e49436034c8b6f9f736c60a726686096362 

Diff: https://reviews.apache.org/r/28728/diff/


Testing
---

./gradlew build


Thanks,

Zameer Manji

Re: Review Request 28728: Collect HTTP stats on every request.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28728/#review63930
---

Ship it!


Ship It!

- Kevin Sweeney


On Dec. 4, 2014, 3:44 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28728/
 ---
 
 (Updated Dec. 4, 2014, 3:44 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Collect HTTP stats on every request.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 83ba0e49436034c8b6f9f736c60a726686096362 
 
 Diff: https://reviews.apache.org/r/28728/diff/
 
 
 Testing
 ---
 
 ./gradlew build
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28728: Collect HTTP stats on every request.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28728/#review63932
---


Master (11da34c) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 4, 2014, 11:44 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28728/
 ---
 
 (Updated Dec. 4, 2014, 11:44 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Collect HTTP stats on every request.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 83ba0e49436034c8b6f9f736c60a726686096362 
 
 Diff: https://reviews.apache.org/r/28728/diff/
 
 
 Testing
 ---
 
 ./gradlew build
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28728: Collect HTTP stats on every request.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28728/#review63933
---

Ship it!


This is now on master
```
$ git log -1 origin/master
commit d26a30ea3878ca90f866ada6ae402562d94c7485
Author: Zameer Manji zma...@twopensource.com
Date:   Thu Dec 4 15:54:18 2014 -0800

Collect HTTP stats on every request.

Reviewed at https://reviews.apache.org/r/28728/
```

- Bill Farner


On Dec. 4, 2014, 11:44 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28728/
 ---
 
 (Updated Dec. 4, 2014, 11:44 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Collect HTTP stats on every request.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 83ba0e49436034c8b6f9f736c60a726686096362 
 
 Diff: https://reviews.apache.org/r/28728/diff/
 
 
 Testing
 ---
 
 ./gradlew build
 
 
 Thanks,
 
 Zameer Manji
 

Review Request 28725: Remove redundant storage.write.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28725/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

This storage.write was already within a storage.write.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
f0d910dc1eb6c84791a9b70b6478b4632c5a34d5 

Diff: https://reviews.apache.org/r/28725/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28725: Remove redundant storage.write.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28725/#review63936
---

Ship it!


Ship It!

- Kevin Sweeney


On Dec. 4, 2014, 4:20 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28725/
 ---
 
 (Updated Dec. 4, 2014, 4:20 p.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This storage.write was already within a storage.write.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  f0d910dc1eb6c84791a9b70b6478b4632c5a34d5 
 
 Diff: https://reviews.apache.org/r/28725/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28725: Remove redundant storage.write.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28725/#review63937
---


Master (d26a30e) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 12:20 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28725/
 ---
 
 (Updated Dec. 5, 2014, 12:20 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This storage.write was already within a storage.write.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  f0d910dc1eb6c84791a9b70b6478b4632c5a34d5 
 
 Diff: https://reviews.apache.org/r/28725/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Bill Farner]

 On Dec. 4, 2014, 1:12 a.m., Kevin Sweeney wrote:
  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy, line 
  124
  https://reviews.apache.org/r/28682/diff/1/?file=782159#file782159line124
 
  Override this in the thriftEntities block in the build.gradle, not in 
  the source for the plugin.
  
  ```
  thriftEntities {
inputFiles = fileTree(...)
  }
  ```
  
  But is this just here to exclude thermos? In that case you might 
  consider adding an explicit exclude (in the build.gradle).

I've gone for the short-term fix, using the inputFiles override.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/#review63796
---


On Dec. 4, 2014, 12:36 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28682/
 ---
 
 (Updated Dec. 4, 2014, 12:36 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-947
 https://issues.apache.org/jira/browse/AURORA-947
 
 
 Repository: aurora
 
 
 Description
 ---
 
 There's a subtle change in 
 `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to 
 avoid generating thermos' thrift for the scheduler.  This prevents a conflict 
 on index.html.
 
 
 Diffs
 -
 
   
 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
 31934f551da808951144cd474255105a9d198854 
   buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
 e6114cf0ec557b8d365140b5f413c69a61dc1563 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 022b9f452e8f7c129b8c202c5f2fff5547f71b0d 
   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
 ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
   src/main/resources/scheduler/assets/index.html 
 cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 
 
 Diff: https://reviews.apache.org/r/28682/diff/
 
 
 Testing
 ---
 
 ./gradlew run, clicked around.
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/
---

(Updated Dec. 5, 2014, 12:58 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-947
https://issues.apache.org/jira/browse/AURORA-947


Repository: aurora


Description
---

There's a subtle change in 
`buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to avoid 
generating thermos' thrift for the scheduler.  This prevents a conflict on 
index.html.


Diffs (updated)
-

  build.gradle 2699db8f9457a07d995d0707b69d10bdb171b873 
  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
31934f551da808951144cd474255105a9d198854 
  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
e6114cf0ec557b8d365140b5f413c69a61dc1563 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
8955a362d8de73263c41ae0184ca384a9e12c6f2 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
  src/main/resources/scheduler/assets/index.html 
cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 

Diff: https://reviews.apache.org/r/28682/diff/


Testing
---

./gradlew run, clicked around.


Thanks,

Bill Farner

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/#review63943
---


Master (fd37f0d) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 12:58 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28682/
 ---
 
 (Updated Dec. 5, 2014, 12:58 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-947
 https://issues.apache.org/jira/browse/AURORA-947
 
 
 Repository: aurora
 
 
 Description
 ---
 
 There's a subtle change in 
 `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to 
 avoid generating thermos' thrift for the scheduler.  This prevents a conflict 
 on index.html.
 
 
 Diffs
 -
 
   build.gradle 2699db8f9457a07d995d0707b69d10bdb171b873 
   
 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
 31934f551da808951144cd474255105a9d198854 
   buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
 e6114cf0ec557b8d365140b5f413c69a61dc1563 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 8955a362d8de73263c41ae0184ca384a9e12c6f2 
   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
 ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
   src/main/resources/scheduler/assets/index.html 
 cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 
 
 Diff: https://reviews.apache.org/r/28682/diff/
 
 
 Testing
 ---
 
 ./gradlew run, clicked around.
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/
---

(Updated Dec. 5, 2014, 1:09 a.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Bugs: AURORA-466
https://issues.apache.org/jira/browse/AURORA-466


Repository: aurora


Description
---

Remove Response.message field.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
7d55dce06c77b17b2f895834e88e5c8543462b31 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
d879db4157c7a2c782e3213974067d86b6184f04 
  src/main/python/apache/aurora/client/api/BUILD 
8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
  src/main/python/apache/aurora/client/api/__init__.py 
d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
  src/main/python/apache/aurora/client/api/command_runner.py 
14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
  src/main/python/apache/aurora/client/api/quota_check.py 
5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
  src/main/python/apache/aurora/client/api/restarter.py 
43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
  src/main/python/apache/aurora/client/api/updater.py 
2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
  src/main/python/apache/aurora/client/base.py 
2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
  src/main/python/apache/aurora/client/cli/context.py 
96c386e83db7b7c16419ca05b9155dd527bfb834 
  src/main/python/apache/aurora/client/cli/task.py 
8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
  src/main/python/apache/aurora/client/commands/admin.py 
cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
  src/main/python/apache/aurora/client/commands/core.py 
ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
91efe5248144049d6a13b1ec81ffe08522df1ee9 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 072ea2b916d9d7d01cd7ba75c79b96896dccca7f 
  src/test/python/apache/aurora/client/api/test_api.py 
1f4e9fe9111ac88726d7c45b699b3b91438448b6 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
27d8025bc80cff22c2f025302d1fe0519d8632e9 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
cb443c227589d69559c92444232eb6ba7d9259eb 
  src/test/python/apache/aurora/client/api/test_restarter.py 
eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
  src/test/python/apache/aurora/client/api/test_sla.py 
50a6c47f00c77265328d6eacc835884e158b9e20 
  src/test/python/apache/aurora/client/api/test_task_util.py 
3e772b949b0ec8b9cece62fc1ed46059a8310195 
  src/test/python/apache/aurora/client/api/test_updater.py 
a32fc529cb1b23ab926a9180debb68bb826f66a8 
  src/test/python/apache/aurora/client/cli/util.py 
0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
  src/test/python/apache/aurora/client/commands/test_admin.py 
f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
  src/test/python/apache/aurora/client/commands/test_kill.py 
4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
  src/test/python/apache/aurora/client/commands/util.py 
c06de50e81be57cbf0480b1566f0efcec07f8a9d 
  src/test/python/apache/aurora/client/test_base.py 
785784b3cb8e670111bb367363acc45772a8ea3e 

Diff: https://reviews.apache.org/r/28674/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Bill Farner]

 On Dec. 3, 2014, 8:57 p.m., Maxim Khutornenko wrote:
  src/main/python/apache/aurora/client/base.py, line 44
  https://reviews.apache.org/r/28674/diff/1/?file=782026#file782026line44
 
  This uses a different quoting style than the rest of the file.

Fixed.


 On Dec. 3, 2014, 8:57 p.m., Maxim Khutornenko wrote:
  src/main/python/apache/aurora/client/base.py, line 48
  https://reviews.apache.org/r/28674/diff/1/?file=782026#file782026line48
 
  This will str() on a ResponseDetail object including the struct details 
  that we don't need: 
  
  ```
  $ ./pants py src/main/python/apache/aurora/client:base
   from gen.apache.aurora.api.ttypes import Response, ResponseDetail, 
  ResponseCode
   resp = Response(responseCode=ResponseCode.OK, 
  details=[ResponseDetail(message='Quota check successful.')])
   ', '.join(map(str, resp.details or []))
  ResponseDetail(message='Quota check successful.')
  ```

Good catch, thanks.  I've fixed and added a test case to mitigate this.


 On Dec. 3, 2014, 8:57 p.m., Maxim Khutornenko wrote:
  src/test/python/apache/aurora/client/api/test_job_monitor.py, line 72
  https://reviews.apache.org/r/28674/diff/1/?file=782036#file782036line72
 
  Use kvarg 'message=' for consistency?

Done.


 On Dec. 3, 2014, 8:57 p.m., Maxim Khutornenko wrote:
  src/test/python/apache/aurora/client/api/test_quota_check.py, line 47
  https://reviews.apache.org/r/28674/diff/1/?file=782037#file782037line47
 
  same here

Done.


 On Dec. 3, 2014, 8:57 p.m., Maxim Khutornenko wrote:
  src/test/python/apache/aurora/client/api/test_task_util.py, line 63
  https://reviews.apache.org/r/28674/diff/1/?file=782040#file782040line63
 
  same here

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/#review63733
---


On Dec. 3, 2014, 8:34 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28674/
 ---
 
 (Updated Dec. 3, 2014, 8:34 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-466
 https://issues.apache.org/jira/browse/AURORA-466
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove Response.message field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 7d55dce06c77b17b2f895834e88e5c8543462b31 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 d879db4157c7a2c782e3213974067d86b6184f04 
   src/main/python/apache/aurora/client/api/BUILD 
 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
   src/main/python/apache/aurora/client/api/__init__.py 
 d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
   src/main/python/apache/aurora/client/api/command_runner.py 
 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
   src/main/python/apache/aurora/client/api/quota_check.py 
 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
   src/main/python/apache/aurora/client/api/restarter.py 
 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
   src/main/python/apache/aurora/client/api/updater.py 
 2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
   src/main/python/apache/aurora/client/base.py 
 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
   src/main/python/apache/aurora/client/cli/context.py 
 96c386e83db7b7c16419ca05b9155dd527bfb834 
   src/main/python/apache/aurora/client/cli/task.py 
 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
   src/main/python/apache/aurora/client/commands/admin.py 
 cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
   src/main/python/apache/aurora/client/commands/core.py 
 ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 91efe5248144049d6a13b1ec81ffe08522df1ee9 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  072ea2b916d9d7d01cd7ba75c79b96896dccca7f 
   src/test/python/apache/aurora/client/api/test_api.py 
 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 27d8025bc80cff22c2f025302d1fe0519d8632e9 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 cb443c227589d69559c92444232eb6ba7d9259eb 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
   src/test/python/apache/aurora/client/api/test_sla.py 
 50a6c47f00c77265328d6eacc835884e158b9e20 
   src/test/python/apache/aurora/client/api/test_task_util.py 
 3e772b949b0ec8b9cece62fc1ed46059a8310195 
   src/test/python/apache/aurora/client/api/test_updater.py 
 

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/#review63946
---

Ship it!


Master (fd37f0d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 1:09 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28674/
 ---
 
 (Updated Dec. 5, 2014, 1:09 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-466
 https://issues.apache.org/jira/browse/AURORA-466
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove Response.message field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 7d55dce06c77b17b2f895834e88e5c8543462b31 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 d879db4157c7a2c782e3213974067d86b6184f04 
   src/main/python/apache/aurora/client/api/BUILD 
 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
   src/main/python/apache/aurora/client/api/__init__.py 
 d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
   src/main/python/apache/aurora/client/api/command_runner.py 
 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
   src/main/python/apache/aurora/client/api/quota_check.py 
 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
   src/main/python/apache/aurora/client/api/restarter.py 
 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
   src/main/python/apache/aurora/client/api/updater.py 
 2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
   src/main/python/apache/aurora/client/base.py 
 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
   src/main/python/apache/aurora/client/cli/context.py 
 96c386e83db7b7c16419ca05b9155dd527bfb834 
   src/main/python/apache/aurora/client/cli/task.py 
 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
   src/main/python/apache/aurora/client/commands/admin.py 
 cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
   src/main/python/apache/aurora/client/commands/core.py 
 ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 91efe5248144049d6a13b1ec81ffe08522df1ee9 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  072ea2b916d9d7d01cd7ba75c79b96896dccca7f 
   src/test/python/apache/aurora/client/api/test_api.py 
 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 27d8025bc80cff22c2f025302d1fe0519d8632e9 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 cb443c227589d69559c92444232eb6ba7d9259eb 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
   src/test/python/apache/aurora/client/api/test_sla.py 
 50a6c47f00c77265328d6eacc835884e158b9e20 
   src/test/python/apache/aurora/client/api/test_task_util.py 
 3e772b949b0ec8b9cece62fc1ed46059a8310195 
   src/test/python/apache/aurora/client/api/test_updater.py 
 a32fc529cb1b23ab926a9180debb68bb826f66a8 
   src/test/python/apache/aurora/client/cli/util.py 
 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
   src/test/python/apache/aurora/client/commands/test_admin.py 
 f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
   src/test/python/apache/aurora/client/commands/util.py 
 c06de50e81be57cbf0480b1566f0efcec07f8a9d 
   src/test/python/apache/aurora/client/test_base.py 
 785784b3cb8e670111bb367363acc45772a8ea3e 
 
 Diff: https://reviews.apache.org/r/28674/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28731: Implemented TaskScheduler benchmarks.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
---

Added baseline benchmarks for a few static veto cases.

This is branched off of https://reviews.apache.org/r/28710


Diffs
-

  build.gradle fb729c5096108c535229e266fa9649f997e6da37 
  src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeEventSink.java 
PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 
PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
ead9d28100673440168a32d114ecaa15874978a6 

Diff: https://reviews.apache.org/r/28731/diff/


Testing
---

Sample run on a local box:
```
# VM invoker: 
/Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
# VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
-Duser.variant
# Warmup: 10 iterations, 1 s each
# Measurement: 100 iterations, 1 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op
# Benchmark: 
org.apache.aurora.benchmark.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example

# Run progress: 0.00% complete, ETA 00:03:40
# Fork: 1 of 1
# Warmup Iteration   1: 104725900.000 ns/op
# Warmup Iteration   2: 20439888.889 ns/op
# Warmup Iteration   3: 13612185.185 ns/op
# Warmup Iteration   4: 5856248.677 ns/op
# Warmup Iteration   5: 5148014.019 ns/op
# Warmup Iteration   6: 4972004.505 ns/op
# Warmup Iteration   7: 4595562.500 ns/op
# Warmup Iteration   8: 4639226.891 ns/op
# Warmup Iteration   9: 4639521.008 ns/op
# Warmup Iteration  10: 4660248.945 ns/op
Iteration   1: 4718478.632 ns/op
Iteration   2: 4800686.957 ns/op
Iteration   3: 4438253.012 ns/op
Iteration   4: 4935376.682 ns/op
Iteration   5: 5236895.735 ns/op
Iteration   6: 6439345.029 ns/op
Iteration   7: 4792708.696 ns/op
Iteration   8: 4579008.299 ns/op
Iteration   9: 4681224.576 ns/op
Iteration  10: 4651143.460 ns/op
Iteration  11: 4394079.681 ns/op
Iteration  12: 4390573.705 ns/op
Iteration  13: 4363304.348 ns/op
Iteration  14: 4419488.000 ns/op
Iteration  15: 4869718.062 ns/op
Iteration  16: 4600612.500 ns/op
Iteration  17: 4475906.883 ns/op
Iteration  18: 4710388.889 ns/op
Iteration  19: 6137000.000 ns/op
Iteration  20: 4467425.101 ns/op
Iteration  21: 4348877.953 ns/op
Iteration  22: 4666907.173 ns/op
Iteration  23: 4431325.301 ns/op
Iteration  24: 4463186.235 ns/op
Iteration  25: 4580074.689 ns/op
Iteration  26: 4467805.668 ns/op
Iteration  27: 4886960.177 ns/op
Iteration  28: 4858515.419 ns/op
Iteration  29: 4734025.751 ns/op
Iteration  30: 4718081.197 ns/op
Iteration  31: 4711688.034 ns/op
Iteration  32: 4462392.713 ns/op
Iteration  33: 4683597.458 ns/op
Iteration  34: 4755176.724 ns/op
Iteration  35: 4530278.689 ns/op
Iteration  36: 4392119.048 ns/op
Iteration  37: 4659722.689 ns/op
Iteration  38: 4805869.565 ns/op
Iteration  39: 4398573.705 ns/op
Iteration  40: 4572547.718 ns/op
Iteration  41: 4643478.992 ns/op
Iteration  42: 4545699.588 ns/op
Iteration  43: 4670266.949 ns/op
Iteration  44: 4506677.551 ns/op
Iteration  45: 4574149.378 ns/op
Iteration  46: 4743154.506 ns/op
Iteration  47: 4777606.061 ns/op
Iteration  48: 4481987.805 ns/op
Iteration  49: 4840921.053 ns/op
Iteration  50: 4637231.092 ns/op
Iteration  51: 4515286.885 ns/op
Iteration  52: 4372884.921 ns/op
Iteration  53: 4385003.968 ns/op
Iteration  54: 4619648.536 ns/op
Iteration  55: 4557822.314 ns/op
Iteration  56: 4594362.500 ns/op
Iteration  57: 7870319.149 ns/op
Iteration  58: 9764495.575 ns/op
Iteration  59: 10302028.037 ns/op
Iteration  60: 6043169.399 ns/op
Iteration  61: 5523472.362 ns/op
Iteration  62: 4513685.714 ns/op
Iteration  63: 4361806.324 ns/op
Iteration  64: 4388615.079 ns/op
Iteration  65: 4548264.463 ns/op
Iteration  66: 4710752.137 ns/op
Iteration  67: 5688128.866 ns/op
Iteration  68: 6109292.818 ns/op
Iteration  69: 5896914.439 ns/op
Iteration  70: 5986548.913 ns/op
Iteration  71: 6093618.785 ns/op
Iteration  72: 6051450.549 ns/op
Iteration  73: 6237870.056 ns/op
Iteration  74: 5954345.946 ns/op
Iteration  75: 6460748.538 ns/op
Iteration  76: 5929037.634 ns/op
Iteration  77: 6170748.603 ns/op
Iteration  78: 6037382.514 ns/op
Iteration  79: 6156776.536 ns/op
Iteration  80: 5987103.261 ns/op
Iteration  81: 

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review63947
---


This patch does not apply cleanly on master (fd37f0d), do you need to rebase?

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 1:27 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28731/
 ---
 
 (Updated Dec. 5, 2014, 1:27 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Added baseline benchmarks for a few static veto cases.
 
 This is branched off of https://reviews.apache.org/r/28710
 
 
 Diffs
 -
 
   build.gradle fb729c5096108c535229e266fa9649f997e6da37 
   src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION 
   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
 PRE-CREATION 
   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
 PRE-CREATION 
   src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION 
   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION 
   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeEventSink.java 
 PRE-CREATION 
   
 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 
 PRE-CREATION 
   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
 ead9d28100673440168a32d114ecaa15874978a6 
 
 Diff: https://reviews.apache.org/r/28731/diff/
 
 
 Testing
 ---
 
 Sample run on a local box:
 ```
 # VM invoker: 
 /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
 # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
 -Duser.variant
 # Warmup: 10 iterations, 1 s each
 # Measurement: 100 iterations, 1 s each
 # Timeout: 10 min per iteration
 # Threads: 1 thread, will synchronize iterations
 # Benchmark mode: Average time, time/op
 # Benchmark: 
 org.apache.aurora.benchmark.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
 
 # Run progress: 0.00% complete, ETA 00:03:40
 # Fork: 1 of 1
 # Warmup Iteration   1: 104725900.000 ns/op
 # Warmup Iteration   2: 20439888.889 ns/op
 # Warmup Iteration   3: 13612185.185 ns/op
 # Warmup Iteration   4: 5856248.677 ns/op
 # Warmup Iteration   5: 5148014.019 ns/op
 # Warmup Iteration   6: 4972004.505 ns/op
 # Warmup Iteration   7: 4595562.500 ns/op
 # Warmup Iteration   8: 4639226.891 ns/op
 # Warmup Iteration   9: 4639521.008 ns/op
 # Warmup Iteration  10: 4660248.945 ns/op
 Iteration   1: 4718478.632 ns/op
 Iteration   2: 4800686.957 ns/op
 Iteration   3: 4438253.012 ns/op
 Iteration   4: 4935376.682 ns/op
 Iteration   5: 5236895.735 ns/op
 Iteration   6: 6439345.029 ns/op
 Iteration   7: 4792708.696 ns/op
 Iteration   8: 4579008.299 ns/op
 Iteration   9: 4681224.576 ns/op
 Iteration  10: 4651143.460 ns/op
 Iteration  11: 4394079.681 ns/op
 Iteration  12: 4390573.705 ns/op
 Iteration  13: 4363304.348 ns/op
 Iteration  14: 4419488.000 ns/op
 Iteration  15: 4869718.062 ns/op
 Iteration  16: 4600612.500 ns/op
 Iteration  17: 4475906.883 ns/op
 Iteration  18: 4710388.889 ns/op
 Iteration  19: 6137000.000 ns/op
 Iteration  20: 4467425.101 ns/op
 Iteration  21: 4348877.953 ns/op
 Iteration  22: 4666907.173 ns/op
 Iteration  23: 4431325.301 ns/op
 Iteration  24: 4463186.235 ns/op
 Iteration  25: 4580074.689 ns/op
 Iteration  26: 4467805.668 ns/op
 Iteration  27: 4886960.177 ns/op
 Iteration  28: 4858515.419 ns/op
 Iteration  29: 4734025.751 ns/op
 Iteration  30: 4718081.197 ns/op
 Iteration  31: 4711688.034 ns/op
 Iteration  32: 4462392.713 ns/op
 Iteration  33: 4683597.458 ns/op
 Iteration  34: 4755176.724 ns/op
 Iteration  35: 4530278.689 ns/op
 Iteration  36: 4392119.048 ns/op
 Iteration  37: 4659722.689 ns/op
 Iteration  38: 4805869.565 ns/op
 Iteration  39: 4398573.705 ns/op
 Iteration  40: 4572547.718 ns/op
 Iteration  41: 4643478.992 ns/op
 Iteration  42: 4545699.588 ns/op
 Iteration  43: 4670266.949 ns/op
 Iteration  44: 4506677.551 ns/op
 Iteration  45: 4574149.378 ns/op
 Iteration  46: 4743154.506 ns/op
 Iteration  47: 4777606.061 ns/op
 Iteration  48: 4481987.805 ns/op
 Iteration  49: 4840921.053 ns/op
 Iteration  50: 4637231.092 ns/op
 Iteration  51: 4515286.885 ns/op
 Iteration  52: 4372884.921 ns/op
 Iteration  53: 4385003.968 ns/op
 Iteration  54: 4619648.536 ns/op
 Iteration  55: 4557822.314 ns/op
 Iteration  56: 4594362.500 ns/op
 Iteration  57: 7870319.149 ns/op
 Iteration  58: 9764495.575 ns/op
 Iteration  59: 10302028.037 ns/op
 Iteration  60: 6043169.399 ns/op
 Iteration  61: 5523472.362 ns/op
 

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28674/#review63948
---

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 5, 2014, 1:09 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28674/
 ---
 
 (Updated Dec. 5, 2014, 1:09 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-466
 https://issues.apache.org/jira/browse/AURORA-466
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove Response.message field.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 7d55dce06c77b17b2f895834e88e5c8543462b31 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 d879db4157c7a2c782e3213974067d86b6184f04 
   src/main/python/apache/aurora/client/api/BUILD 
 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 
   src/main/python/apache/aurora/client/api/__init__.py 
 d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
   src/main/python/apache/aurora/client/api/command_runner.py 
 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 
   src/main/python/apache/aurora/client/api/quota_check.py 
 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 
   src/main/python/apache/aurora/client/api/restarter.py 
 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b 
   src/main/python/apache/aurora/client/api/updater.py 
 2092ff31141b6ccfedf0af673fe8dc2a74a7828e 
   src/main/python/apache/aurora/client/base.py 
 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 
   src/main/python/apache/aurora/client/cli/context.py 
 96c386e83db7b7c16419ca05b9155dd527bfb834 
   src/main/python/apache/aurora/client/cli/task.py 
 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 
   src/main/python/apache/aurora/client/commands/admin.py 
 cb5ae88e3f39b7d7fbb80593be664809fbaa8958 
   src/main/python/apache/aurora/client/commands/core.py 
 ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 91efe5248144049d6a13b1ec81ffe08522df1ee9 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  072ea2b916d9d7d01cd7ba75c79b96896dccca7f 
   src/test/python/apache/aurora/client/api/test_api.py 
 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9523ac67a67f83f55a7d79f38a5c13a9a90694c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 27d8025bc80cff22c2f025302d1fe0519d8632e9 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 cb443c227589d69559c92444232eb6ba7d9259eb 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 eb0af3bc588c088aa2aca8eb561cbd90d28209e1 
   src/test/python/apache/aurora/client/api/test_sla.py 
 50a6c47f00c77265328d6eacc835884e158b9e20 
   src/test/python/apache/aurora/client/api/test_task_util.py 
 3e772b949b0ec8b9cece62fc1ed46059a8310195 
   src/test/python/apache/aurora/client/api/test_updater.py 
 a32fc529cb1b23ab926a9180debb68bb826f66a8 
   src/test/python/apache/aurora/client/cli/util.py 
 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
   src/test/python/apache/aurora/client/commands/test_admin.py 
 f9261affcc7d2f5391712fa0d0eb84e89a13bd70 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 4ac742f4c7f3528cee0cdc25b9624ffde8384b11 
   src/test/python/apache/aurora/client/commands/util.py 
 c06de50e81be57cbf0480b1566f0efcec07f8a9d 
   src/test/python/apache/aurora/client/test_base.py 
 785784b3cb8e670111bb367363acc45772a8ea3e 
 
 Diff: https://reviews.apache.org/r/28674/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/#review63949
---

Ship it!


Ship It!

- Kevin Sweeney


On Dec. 4, 2014, 4:58 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28682/
 ---
 
 (Updated Dec. 4, 2014, 4:58 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-947
 https://issues.apache.org/jira/browse/AURORA-947
 
 
 Repository: aurora
 
 
 Description
 ---
 
 There's a subtle change in 
 `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to 
 avoid generating thermos' thrift for the scheduler.  This prevents a conflict 
 on index.html.
 
 
 Diffs
 -
 
   build.gradle 2699db8f9457a07d995d0707b69d10bdb171b873 
   
 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 
 31934f551da808951144cd474255105a9d198854 
   buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
 e6114cf0ec557b8d365140b5f413c69a61dc1563 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 8955a362d8de73263c41ae0184ca384a9e12c6f2 
   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
 ca2581cfc38a5873143e2ca8dc6e23b8ec389421 
   src/main/resources/scheduler/assets/index.html 
 cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 
 
 Diff: https://reviews.apache.org/r/28682/diff/
 
 
 Testing
 ---
 
 ./gradlew run, clicked around.
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28738: Remove unused DefaultServlet subclass.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28738/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Remove unused DefaultServlet subclass.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
424859867d7bd1aafefe406f455b831246c1cca5 

Diff: https://reviews.apache.org/r/28738/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28738: Remove unused DefaultServlet subclass.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28738/#review63959
---


Master (905137f) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 4:06 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28738/
 ---
 
 (Updated Dec. 5, 2014, 4:06 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove unused DefaultServlet subclass.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 424859867d7bd1aafefe406f455b831246c1cca5 
 
 Diff: https://reviews.apache.org/r/28738/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 

Review Request 28742: Simplify logging in the client.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28742/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-919
https://issues.apache.org/jira/browse/AURORA-919


Repository: aurora


Description
---

This patch makes multiple changes to simplify the logging done in the Aurora 
client:
1. Remove the TRANSCRIPT log level and replaced all instances with the standard 
Python DEBUG level.
2. Remove the custom aurora_client logger. This logger was designed to give 
each invocation of the client a unique id and record the username of the user 
with the intention that a hook could take this information and ship it to the 
cluster administer. However a hook could capture logs by adding a handler to 
the root log handler and generate a unique id itself.
3. Remove the 'print_log' method of the context and replaced all callers with 
the standard python logging facilities.
4. Removed duplicate printing/logging messages by just printing the information 
to the user.
5. Removed the custom PlainFormatter implementation and replaced it with 
Python's default formatter.
6. Replaced the --verbose-logging and --logging-level flags with a single 
--verbose/-v flag which enables DEBUG logging. Without this flag the user 
sees INFO and up.


Diffs
-

  src/main/python/apache/aurora/client/cli/BUILD 
ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/command_hooks.py 
aa850bf941bede1d3bd8aae4811cb094ba77965f 
  src/main/python/apache/aurora/client/cli/context.py 
51c7d24dca664e476e62f1864d095416dfab70e4 
  src/main/python/apache/aurora/client/cli/jobs.py 
8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/main/python/apache/aurora/client/cli/logsetup.py 
55d99c42f643910db0bf3c24022596383e160276 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/main/python/apache/aurora/client/cli/task.py 
91175facdc8c9fd59ab66781f86ee8b5940a 
  src/test/python/apache/aurora/client/cli/BUILD 
e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
  src/test/python/apache/aurora/client/cli/test_logging.py 
6285fbb07442291c2dc4096e68eb285c98994097 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28742/diff/


Testing
---

./pants ./src/test/python/apache/aurora::


vagrant@192:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora
jobs=[devcluster/www-data/prod/hello]

vagrant@192:~$ aurora2 job create devcluster/www-data/prod/hello 
./aurora/examples/jobs/hello_world.aurora
INFO:root:Creating job hello
INFO:root:Checking status of devcluster/www-data/prod/hello
job create succeeded: job 
url=http://192.168.33.7:8081/scheduler/www-data/prod/hello
vagrant@192:~$ aurora job list devcluster/*
Must supply one of the following commands: cancel_update, create, diff, 
get_quota, help, inspect, kill, killall, list_jobs, open, restart, run, ssh, 
start_cron, status, update, version

vagrant@192:~$ aurora2 job list devcluster/*
INFO:root:Retrieving jobs for role None
devcluster/www-data/prod/hello

vagrant@192:~$ aurora2 job update devcluster/www-data/prod/hello 
./aurora/examples/jobs/hello_world.aurora
INFO:root:Updating job: hello
INFO:root:Instances to update: [0]
INFO:root:Processing in parallel with 1 worker thread(s)
INFO:root:Examining instance: 0
INFO:root:Skipping unchanged instance: 0
INFO:root:Update successful
Update completed successfully

vagrant@192:~$ aurora2 job killall devcluster/www-data/prod/hello
INFO:root:Checking status of devcluster/www-data/prod/hello
INFO:root:Killing tasks for job: devcluster/www-data/prod/hello
INFO:root:Instances to be killed: [0]
Successfully killed shards [0]
job killall succeeded



Thanks,

Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28742/#review63972
---


This patch does not apply cleanly on master (905137f), do you need to rebase?

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 7:17 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28742/
 ---
 
 (Updated Dec. 5, 2014, 7:17 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Bugs: AURORA-919
 https://issues.apache.org/jira/browse/AURORA-919
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This patch makes multiple changes to simplify the logging done in the Aurora 
 client:
 1. Remove the TRANSCRIPT log level and replaced all instances with the 
 standard Python DEBUG level.
 2. Remove the custom aurora_client logger. This logger was designed to give 
 each invocation of the client a unique id and record the username of the user 
 with the intention that a hook could take this information and ship it to the 
 cluster administer. However a hook could capture logs by adding a handler to 
 the root log handler and generate a unique id itself.
 3. Remove the 'print_log' method of the context and replaced all callers with 
 the standard python logging facilities.
 4. Removed duplicate printing/logging messages by just printing the 
 information to the user.
 5. Removed the custom PlainFormatter implementation and replaced it with 
 Python's default formatter.
 6. Replaced the --verbose-logging and --logging-level flags with a single 
 --verbose/-v flag which enables DEBUG logging. Without this flag the user 
 sees INFO and up.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/BUILD 
 ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/main/python/apache/aurora/client/cli/command_hooks.py 
 aa850bf941bede1d3bd8aae4811cb094ba77965f 
   src/main/python/apache/aurora/client/cli/context.py 
 51c7d24dca664e476e62f1864d095416dfab70e4 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
   src/main/python/apache/aurora/client/cli/logsetup.py 
 55d99c42f643910db0bf3c24022596383e160276 
   src/main/python/apache/aurora/client/cli/standalone_client.py 
 b7c8de66d6e4664b536911f826e36a984e8d0fef 
   src/main/python/apache/aurora/client/cli/task.py 
 91175facdc8c9fd59ab66781f86ee8b5940a 
   src/test/python/apache/aurora/client/cli/BUILD 
 e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
   src/test/python/apache/aurora/client/cli/test_logging.py 
 6285fbb07442291c2dc4096e68eb285c98994097 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28742/diff/
 
 
 Testing
 ---
 
 ./pants ./src/test/python/apache/aurora::
 
 
 vagrant@192:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora
 jobs=[devcluster/www-data/prod/hello]
 
 vagrant@192:~$ aurora2 job create devcluster/www-data/prod/hello 
 ./aurora/examples/jobs/hello_world.aurora
 INFO:root:Creating job hello
 INFO:root:Checking status of devcluster/www-data/prod/hello
 job create succeeded: job 
 url=http://192.168.33.7:8081/scheduler/www-data/prod/hello
 vagrant@192:~$ aurora job list devcluster/*
 Must supply one of the following commands: cancel_update, create, diff, 
 get_quota, help, inspect, kill, killall, list_jobs, open, restart, run, ssh, 
 start_cron, status, update, version
 
 vagrant@192:~$ aurora2 job list devcluster/*
 INFO:root:Retrieving jobs for role None
 devcluster/www-data/prod/hello
 
 vagrant@192:~$ aurora2 job update devcluster/www-data/prod/hello 
 ./aurora/examples/jobs/hello_world.aurora
 INFO:root:Updating job: hello
 INFO:root:Instances to update: [0]
 INFO:root:Processing in parallel with 1 worker thread(s)
 INFO:root:Examining instance: 0
 INFO:root:Skipping unchanged instance: 0
 INFO:root:Update successful
 Update completed successfully
 
 vagrant@192:~$ aurora2 job killall devcluster/www-data/prod/hello
 INFO:root:Checking status of devcluster/www-data/prod/hello
 INFO:root:Killing tasks for job: devcluster/www-data/prod/hello
 INFO:root:Instances to be killed: [0]
 Successfully killed shards [0]
 job killall succeeded
 
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28742: Simplify logging in the client.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28742/
---

(Updated Dec. 4, 2014, 11:26 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Rebase the robot.


Bugs: AURORA-919
https://issues.apache.org/jira/browse/AURORA-919


Repository: aurora


Description
---

This patch makes multiple changes to simplify the logging done in the Aurora 
client:
1. Remove the TRANSCRIPT log level and replaced all instances with the standard 
Python DEBUG level.
2. Remove the custom aurora_client logger. This logger was designed to give 
each invocation of the client a unique id and record the username of the user 
with the intention that a hook could take this information and ship it to the 
cluster administer. However a hook could capture logs by adding a handler to 
the root log handler and generate a unique id itself.
3. Remove the 'print_log' method of the context and replaced all callers with 
the standard python logging facilities.
4. Removed duplicate printing/logging messages by just printing the information 
to the user.
5. Removed the custom PlainFormatter implementation and replaced it with 
Python's default formatter.
6. Replaced the --verbose-logging and --logging-level flags with a single 
--verbose/-v flag which enables DEBUG logging. Without this flag the user 
sees INFO and up.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/command_hooks.py 
aa850bf941bede1d3bd8aae4811cb094ba77965f 
  src/main/python/apache/aurora/client/cli/context.py 
51c7d24dca664e476e62f1864d095416dfab70e4 
  src/main/python/apache/aurora/client/cli/jobs.py 
8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/main/python/apache/aurora/client/cli/logsetup.py 
55d99c42f643910db0bf3c24022596383e160276 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/main/python/apache/aurora/client/cli/task.py 
91175facdc8c9fd59ab66781f86ee8b5940a 
  src/test/python/apache/aurora/client/cli/BUILD 
e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
  src/test/python/apache/aurora/client/cli/test_logging.py 
6285fbb07442291c2dc4096e68eb285c98994097 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 

Diff: https://reviews.apache.org/r/28742/diff/


Testing
---

./pants ./src/test/python/apache/aurora::


vagrant@192:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora
jobs=[devcluster/www-data/prod/hello]

vagrant@192:~$ aurora2 job create devcluster/www-data/prod/hello 
./aurora/examples/jobs/hello_world.aurora
INFO:root:Creating job hello
INFO:root:Checking status of devcluster/www-data/prod/hello
job create succeeded: job 
url=http://192.168.33.7:8081/scheduler/www-data/prod/hello
vagrant@192:~$ aurora job list devcluster/*
Must supply one of the following commands: cancel_update, create, diff, 
get_quota, help, inspect, kill, killall, list_jobs, open, restart, run, ssh, 
start_cron, status, update, version

vagrant@192:~$ aurora2 job list devcluster/*
INFO:root:Retrieving jobs for role None
devcluster/www-data/prod/hello

vagrant@192:~$ aurora2 job update devcluster/www-data/prod/hello 
./aurora/examples/jobs/hello_world.aurora
INFO:root:Updating job: hello
INFO:root:Instances to update: [0]
INFO:root:Processing in parallel with 1 worker thread(s)
INFO:root:Examining instance: 0
INFO:root:Skipping unchanged instance: 0
INFO:root:Update successful
Update completed successfully

vagrant@192:~$ aurora2 job killall devcluster/www-data/prod/hello
INFO:root:Checking status of devcluster/www-data/prod/hello
INFO:root:Killing tasks for job: devcluster/www-data/prod/hello
INFO:root:Instances to be killed: [0]
Successfully killed shards [0]
job killall succeeded



Thanks,

Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28742/#review63974
---

Ship it!


Master (905137f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 7:26 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28742/
 ---
 
 (Updated Dec. 5, 2014, 7:26 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Bugs: AURORA-919
 https://issues.apache.org/jira/browse/AURORA-919
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This patch makes multiple changes to simplify the logging done in the Aurora 
 client:
 1. Remove the TRANSCRIPT log level and replaced all instances with the 
 standard Python DEBUG level.
 2. Remove the custom aurora_client logger. This logger was designed to give 
 each invocation of the client a unique id and record the username of the user 
 with the intention that a hook could take this information and ship it to the 
 cluster administer. However a hook could capture logs by adding a handler to 
 the root log handler and generate a unique id itself.
 3. Remove the 'print_log' method of the context and replaced all callers with 
 the standard python logging facilities.
 4. Removed duplicate printing/logging messages by just printing the 
 information to the user.
 5. Removed the custom PlainFormatter implementation and replaced it with 
 Python's default formatter.
 6. Replaced the --verbose-logging and --logging-level flags with a single 
 --verbose/-v flag which enables DEBUG logging. Without this flag the user 
 sees INFO and up.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/BUILD 
 ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
   src/main/python/apache/aurora/client/cli/__init__.py 
 6e553d8af459e575b2d62282a3bc0d1e266203d8 
   src/main/python/apache/aurora/client/cli/command_hooks.py 
 aa850bf941bede1d3bd8aae4811cb094ba77965f 
   src/main/python/apache/aurora/client/cli/context.py 
 51c7d24dca664e476e62f1864d095416dfab70e4 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
   src/main/python/apache/aurora/client/cli/logsetup.py 
 55d99c42f643910db0bf3c24022596383e160276 
   src/main/python/apache/aurora/client/cli/standalone_client.py 
 b7c8de66d6e4664b536911f826e36a984e8d0fef 
   src/main/python/apache/aurora/client/cli/task.py 
 91175facdc8c9fd59ab66781f86ee8b5940a 
   src/test/python/apache/aurora/client/cli/BUILD 
 e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
   src/test/python/apache/aurora/client/cli/test_logging.py 
 6285fbb07442291c2dc4096e68eb285c98994097 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
 
 Diff: https://reviews.apache.org/r/28742/diff/
 
 
 Testing
 ---
 
 ./pants ./src/test/python/apache/aurora::
 
 
 vagrant@192:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora
 jobs=[devcluster/www-data/prod/hello]
 
 vagrant@192:~$ aurora2 job create devcluster/www-data/prod/hello 
 ./aurora/examples/jobs/hello_world.aurora
 INFO:root:Creating job hello
 INFO:root:Checking status of devcluster/www-data/prod/hello
 job create succeeded: job 
 url=http://192.168.33.7:8081/scheduler/www-data/prod/hello
 vagrant@192:~$ aurora job list devcluster/*
 Must supply one of the following commands: cancel_update, create, diff, 
 get_quota, help, inspect, kill, killall, list_jobs, open, restart, run, ssh, 
 start_cron, status, update, version
 
 vagrant@192:~$ aurora2 job list devcluster/*
 INFO:root:Retrieving jobs for role None
 devcluster/www-data/prod/hello
 
 vagrant@192:~$ aurora2 job update devcluster/www-data/prod/hello 
 ./aurora/examples/jobs/hello_world.aurora
 INFO:root:Updating job: hello
 INFO:root:Instances to update: [0]
 INFO:root:Processing in parallel with 1 worker thread(s)
 INFO:root:Examining instance: 0
 INFO:root:Skipping unchanged instance: 0
 INFO:root:Update successful
 Update completed successfully
 
 vagrant@192:~$ aurora2 job killall devcluster/www-data/prod/hello
 INFO:root:Checking status of devcluster/www-data/prod/hello
 INFO:root:Killing tasks for job: devcluster/www-data/prod/hello
 INFO:root:Instances to be killed: [0]
 Successfully killed shards [0]
 job killall succeeded
 
 
 
 Thanks,
 
 Zameer Manji
 

Re: Review Request 28742: Simplify logging in the client.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28742/
---

(Updated Dec. 4, 2014, 11:43 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Remove addtional failing tests.


Bugs: AURORA-919
https://issues.apache.org/jira/browse/AURORA-919


Repository: aurora


Description
---

This patch makes multiple changes to simplify the logging done in the Aurora 
client:
1. Remove the TRANSCRIPT log level and replaced all instances with the standard 
Python DEBUG level.
2. Remove the custom aurora_client logger. This logger was designed to give 
each invocation of the client a unique id and record the username of the user 
with the intention that a hook could take this information and ship it to the 
cluster administer. However a hook could capture logs by adding a handler to 
the root log handler and generate a unique id itself.
3. Remove the 'print_log' method of the context and replaced all callers with 
the standard python logging facilities.
4. Removed duplicate printing/logging messages by just printing the information 
to the user.
5. Removed the custom PlainFormatter implementation and replaced it with 
Python's default formatter.
6. Replaced the --verbose-logging and --logging-level flags with a single 
--verbose/-v flag which enables DEBUG logging. Without this flag the user 
sees INFO and up.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/command_hooks.py 
aa850bf941bede1d3bd8aae4811cb094ba77965f 
  src/main/python/apache/aurora/client/cli/context.py 
51c7d24dca664e476e62f1864d095416dfab70e4 
  src/main/python/apache/aurora/client/cli/jobs.py 
8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/main/python/apache/aurora/client/cli/logsetup.py 
55d99c42f643910db0bf3c24022596383e160276 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/main/python/apache/aurora/client/cli/task.py 
91175facdc8c9fd59ab66781f86ee8b5940a 
  src/test/python/apache/aurora/client/cli/BUILD 
e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
  src/test/python/apache/aurora/client/cli/test_logging.py 
6285fbb07442291c2dc4096e68eb285c98994097 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
  src/test/python/apache/aurora/client/cli/test_task.py 
c69a624ec7063973d365846f7df3516047ceeb68 

Diff: https://reviews.apache.org/r/28742/diff/


Testing
---

./pants ./src/test/python/apache/aurora::


vagrant@192:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora
jobs=[devcluster/www-data/prod/hello]

vagrant@192:~$ aurora2 job create devcluster/www-data/prod/hello 
./aurora/examples/jobs/hello_world.aurora
INFO:root:Creating job hello
INFO:root:Checking status of devcluster/www-data/prod/hello
job create succeeded: job 
url=http://192.168.33.7:8081/scheduler/www-data/prod/hello
vagrant@192:~$ aurora job list devcluster/*
Must supply one of the following commands: cancel_update, create, diff, 
get_quota, help, inspect, kill, killall, list_jobs, open, restart, run, ssh, 
start_cron, status, update, version

vagrant@192:~$ aurora2 job list devcluster/*
INFO:root:Retrieving jobs for role None
devcluster/www-data/prod/hello

vagrant@192:~$ aurora2 job update devcluster/www-data/prod/hello 
./aurora/examples/jobs/hello_world.aurora
INFO:root:Updating job: hello
INFO:root:Instances to update: [0]
INFO:root:Processing in parallel with 1 worker thread(s)
INFO:root:Examining instance: 0
INFO:root:Skipping unchanged instance: 0
INFO:root:Update successful
Update completed successfully

vagrant@192:~$ aurora2 job killall devcluster/www-data/prod/hello
INFO:root:Checking status of devcluster/www-data/prod/hello
INFO:root:Killing tasks for job: devcluster/www-data/prod/hello
INFO:root:Instances to be killed: [0]
Successfully killed shards [0]
job killall succeeded



Thanks,

Zameer Manji