Re: Review Request 30207: Simplify AuroraCommandContext

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30207/#review69951 --- Ship it! Master (46a0466) is green with this patch. ./build-suppo

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69945 --- Ship it! Master (46a0466) is green with this patch. ./build-suppo

Re: Review Request 30346: Only print when coverage is below the pass threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30346/#review69931 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2015, 5:09 p.m., Bi

Review Request 30346: Only print when coverage is below the pass threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30346/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1060 https://issue

Re: Review Request 30331: Fixed python tests hanging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/#review69928 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2015, 12:13 a.m., St

Re: Review Request 30341: Reverting .auroraversion and CHANGELOG changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30341/#review69924 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2015, 4:33 p.m., M

Review Request 30341: Reverting .auroraversion and CHANGELOG changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30341/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 30331: Fixed python tests hanging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/ --- (Updated Jan. 28, 2015, 12:13 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 30331: Fixed python tests hanging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/#review69921 --- Ship it! Confirmed. This eliminates the flakiness. - Maxim Khutorn

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review69910 --- Master (57a8f4f) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30331: Fixed python tests hanging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/#review69907 --- Ship it! Master (57a8f4f) is green with this patch. ./build-suppo

Re: Review Request 30331: Fixed python tests hanging

> On Jan. 27, 2015, 10:32 p.m., Kevin Sweeney wrote: > > Any idea which change introduced this breakage? Can you elaborate in the > > description? > > Steve Niemitz wrote: > Sorry yeah, I was writing up an email to the dev list. I'll just post > here instead. I actually was the one who b

Re: Review Request 30331: Fixed python tests hanging

> On Jan. 27, 2015, 10:32 p.m., Kevin Sweeney wrote: > > Any idea which change introduced this breakage? Can you elaborate in the > > description? Sorry yeah, I was writing up an email to the dev list. I'll just post here instead. I actually was the one who broke this with a tiny change in

Re: Review Request 30331: Fixed python tests hanging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/#review69902 --- Ship it! Any idea which change introduced this breakage? Can you el

Review Request 30331: Fixed python tests hanging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Review Request 30325: Implementing pulseJobUpdate RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bug

Re: Review Request 30302: Updating release publishing script to work with linked .auroraversion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30302/#review69888 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2015, 6:32 p.m., M

Re: Review Request 30225: Modifying update controller to support heartbeats.

> On Jan. 27, 2015, 5:49 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 227 > > > > > > Given how sensitive we are to storage lock contention, is

Re: Review Request 30225: Modifying update controller to support heartbeats.

> On Jan. 27, 2015, 5:49 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 227 > > > > > > Given how sensitive we are to storage lock contention, is

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/#review69860 --- Ship it! Ship It! - Bill Farner On Jan. 27, 2015, 4:27 a.m., Jef

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69854 --- @ReviewBot retry - Bill Farner On Jan. 27, 2015, 1:08 a.m., Flori

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69852 --- Ship it! Thanks, this looks great! LGTM once two rogue newlines ar

Re: Review Request 30207: Simplify AuroraCommandContext

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30207/#review69851 --- @ReviewBot retry - Bill Farner On Jan. 23, 2015, 3:32 a.m., Zamee

Re: Review Request 30225: Modifying update controller to support heartbeats.

> On Jan. 27, 2015, 5:49 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 227 > > > > > > Given how sensitive we are to storage lock contention, is

Re: Review Request 30225: Modifying update controller to support heartbeats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review69834 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControll

Re: Review Request 30225: Modifying update controller to support heartbeats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review69825 --- Ping. - Maxim Khutornenko On Jan. 23, 2015, 8:37 p.m., Maxim Khut

Re: Review Request 30207: Simplify AuroraCommandContext

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30207/#review69824 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 23, 2015, 3:32 a.m

Re: Review Request 30207: Simplify AuroraCommandContext

> On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote: > > I am not convinced there is enough value in this diff to risk possible > > regression. Besides, the majority of what this diff touches will die out > > along with the client updater. > > Zameer Manji wrote: > Is there an ETA for t

Re: Review Request 29827: End to end tests for docker in aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review69822 --- Master (0cb40d1) is red with this patch. ./build-support/jenkins/b

Re: Review Request 29827: End to end tests for docker in aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 27, 2015, 4:58 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/#review69766 --- Master (0cb40d1) is red with this patch. ./build-support/jenkins/b