Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:16 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 30710: add mesos role feature

2015-02-05 Thread Bill Farner
On Feb. 6, 2015, 7:02 a.m., Aurora ReviewBot wrote: Master (5059040) is red with this patch. ./build-support/jenkins/build.sh 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle]

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:18 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:16 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote: src/test/python/apache/thermos/monitoring/test_resource.py, line 64 https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64 patching a private method assumes intimate knowledge of the class under test and suggests

Review Request 30710: add mesos role feature

2015-02-05 Thread lozh...@ebay.com zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 30710: add mesos role feature

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71386 --- Master (5059040) is red with this patch.

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/#review71378 --- Ship it! Master (5059040) is green with this patch.

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 1:38 p.m.) Review request for Aurora, Chris Aniszczyk,

Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-05 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-95

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:17 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71276 --- Master (1c78721) is red with this patch.

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-05 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71331 --- @ReviewBot retry - George Sirois On Feb. 5, 2015, 10:32 p.m.,

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71323 --- Ship it! Master (1c78721) is green with this patch.

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71325 --- docs/vagrant.md https://reviews.apache.org/r/30681/#comment117002

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71335 --- Master (1c78721) is red with this patch.

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 3:37 p.m.) Review request for Aurora, Chris Aniszczyk,

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Ricardo Cervera-Navarro
On Feb. 5, 2015, 2:16 p.m., Joshua Cohen wrote: docs/vagrant.md, lines 83-84 https://reviews.apache.org/r/30681/diff/2/?file=851289#file851289line83 s/Master/Mesos Master s/Slave/Mesos Slave Done. On Feb. 5, 2015, 2:16 p.m., Joshua Cohen wrote: docs/vagrant.md, line 99

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71343 --- Ship it! Master (1c78721) is green with this patch.

Review Request 30704: Remove default root in TaskPath.

2015-02-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-1024

Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-05 Thread Joe Smith
On Feb. 5, 2015, 11:49 a.m., Brian Wickman wrote: Ship It! Brian, any chance you can commit this for me? Thanks! Joe - Joe --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 30704: Remove default root in TaskPath.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/#review71355 --- Ship it! Master (1c78721) is green with this patch.

Re: Review Request 30704: Remove default root in TaskPath.

2015-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/#review71352 --- Ship it! Ship It! - Brian Wickman On Feb. 6, 2015, 1:19 a.m.,

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-05 Thread Maxim Khutornenko
On Feb. 5, 2015, 6:07 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 308 https://reviews.apache.org/r/30225/diff/5/?file=849498#file849498line308 Deferrment is not quite what i had in mind. I was thinking something

Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and Zameer Manji.

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review71245 ---

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen
On Feb. 5, 2015, 2:32 a.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/executor/common/test_health_checker.py, line 106 https://reviews.apache.org/r/30647/diff/2/?file=849475#file849475line106 Any chance to have test coverage for the other two metrics? +1 - Joshua

Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649/#review71284 --- Ship it! Ship It! - Brian Wickman On Feb. 5, 2015, 4:13 a.m.,

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71281 --- Master (1c78721) is red with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71282 --- @ReviewBot retry - Joshua Cohen On Feb. 5, 2015, 7:17 p.m.,

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71294 --- Master (1c78721) is red with this patch.

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71300 --- Can you please also add jcohen to the reviewers list? - Zameer

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71303 --- Ship it! Ship It! - Zameer Manji On Feb. 5, 2015, 10:46 a.m.,