Re: Review Request 27182: Add a test for the thermos resource module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:16 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Add a test for the thermos resource module Diffs - src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION Diff: https://reviews.apache.org/r/27182/diff/ Testing (updated) --- [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest ./src/test/python/apache/thermos/monitoring:test_resource 21:15:56 00:00 [main] (To run a reporting server: ./pants server) 21:15:56 00:00 [bootstrap] 21:15:57 00:01 [setup] 21:15:57 00:01 [parse] Executing tasks in goals: bootstrap - imports - gen - check-exclusives - resolve - compile - resources - test 21:15:57 00:01 [bootstrap] 21:15:57 00:01 [bootstrap-jvm-tools] 21:15:57 00:01 [imports] 21:15:57 00:01 [ivy-imports] 21:15:57 00:01 [gen] 21:15:57 00:01 [thrift] 21:15:57 00:01 [scrooge] 21:15:57 00:01 [protoc] 21:15:57 00:01 [antlr] 21:15:57 00:01 [ragel] 21:15:57 00:01 [jaxb] 21:15:57 00:01 [wire] 21:15:57 00:01 [aapt] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [resolve] 21:15:57 00:01 [ivy] 21:15:57 00:01 [compile] 21:15:57 00:01 [jvm] 21:15:57 00:01 [jvm-compilers] 21:15:57 00:01 [resources] 21:15:57 00:01 [prepare] 21:15:57 00:01 [test] 21:15:57 00:01 [run_prep_command] 21:15:57 00:01 [pytest] 21:15:57 00:01 [run] == test session starts === platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 5 items src/test/python/apache/thermos/monitoring/test_resource.py . 5 passed in 0.18 seconds 21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith
Re: Review Request 30710: add mesos role feature
On Feb. 6, 2015, 7:02 a.m., Aurora ReviewBot wrote: Master (5059040) is red with this patch. ./build-support/jenkins/build.sh 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:18: Wrong order for 'java.util.Collections' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:51: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:185: Line is longer than 100 characters (found 111). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:188:5: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:103: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:105:1: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:105:5: 'if' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:128:83: ',' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:145: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:317: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:319: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:331: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:56: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:115:27: '+' is not preceded with whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:118:1: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:18: Wrong order for 'java.util.List' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:47: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:115: File contains a sequence of empty lines. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:120:1: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:177: Line is longer than 100 characters (found 104). FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or
Re: Review Request 27182: Add a test for the thermos resource module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:18 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Add a missing assert Repository: aurora Description --- Add a test for the thermos resource module Diffs (updated) - src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION Diff: https://reviews.apache.org/r/27182/diff/ Testing --- [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest ./src/test/python/apache/thermos/monitoring:test_resource 21:15:56 00:00 [main] (To run a reporting server: ./pants server) 21:15:56 00:00 [bootstrap] 21:15:57 00:01 [setup] 21:15:57 00:01 [parse] Executing tasks in goals: bootstrap - imports - gen - check-exclusives - resolve - compile - resources - test 21:15:57 00:01 [bootstrap] 21:15:57 00:01 [bootstrap-jvm-tools] 21:15:57 00:01 [imports] 21:15:57 00:01 [ivy-imports] 21:15:57 00:01 [gen] 21:15:57 00:01 [thrift] 21:15:57 00:01 [scrooge] 21:15:57 00:01 [protoc] 21:15:57 00:01 [antlr] 21:15:57 00:01 [ragel] 21:15:57 00:01 [jaxb] 21:15:57 00:01 [wire] 21:15:57 00:01 [aapt] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [resolve] 21:15:57 00:01 [ivy] 21:15:57 00:01 [compile] 21:15:57 00:01 [jvm] 21:15:57 00:01 [jvm-compilers] 21:15:57 00:01 [resources] 21:15:57 00:01 [prepare] 21:15:57 00:01 [test] 21:15:57 00:01 [run_prep_command] 21:15:57 00:01 [pytest] 21:15:57 00:01 [run] == test session starts === platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 5 items src/test/python/apache/thermos/monitoring/test_resource.py . 5 passed in 0.18 seconds 21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith
Re: Review Request 27182: Add a test for the thermos resource module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:16 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Kevin + Bill's suggestion Repository: aurora Description --- Add a test for the thermos resource module Diffs (updated) - src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION Diff: https://reviews.apache.org/r/27182/diff/ Testing --- [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest ./src/test/python/apache/thermos/monitoring:test_resource 21:15:56 00:00 [main] (To run a reporting server: ./pants server) 21:15:56 00:00 [bootstrap] 21:15:57 00:01 [setup] 21:15:57 00:01 [parse] Executing tasks in goals: bootstrap - imports - gen - check-exclusives - resolve - compile - resources - test 21:15:57 00:01 [bootstrap] 21:15:57 00:01 [bootstrap-jvm-tools] 21:15:57 00:01 [imports] 21:15:57 00:01 [ivy-imports] 21:15:57 00:01 [gen] 21:15:57 00:01 [thrift] 21:15:57 00:01 [scrooge] 21:15:57 00:01 [protoc] 21:15:57 00:01 [antlr] 21:15:57 00:01 [ragel] 21:15:57 00:01 [jaxb] 21:15:57 00:01 [wire] 21:15:57 00:01 [aapt] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [resolve] 21:15:57 00:01 [ivy] 21:15:57 00:01 [compile] 21:15:57 00:01 [jvm] 21:15:57 00:01 [jvm-compilers] 21:15:57 00:01 [resources] 21:15:57 00:01 [prepare] 21:15:57 00:01 [test] 21:15:57 00:01 [run_prep_command] 21:15:57 00:01 [pytest] 21:15:57 00:01 [run] == test session starts === platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 5 items src/test/python/apache/thermos/monitoring/test_resource.py . 5 passed in 0.18 seconds 21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith
Re: Review Request 27182: Add a test for the thermos resource module
On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote: src/test/python/apache/thermos/monitoring/test_resource.py, line 64 https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64 patching a private method assumes intimate knowledge of the class under test and suggests refactoring Joe Smith wrote: Not quite- if this were for a different test then I'd agree, but since we're actually testing TaskResourceMonitor, we'll want to mock out that behavior (and test it separately) to ensure this method is using it right. (At some point in the TestTaskResourceMonitor we'll need to mock out this behavior- so there will always be a patch around this spot) Bill Farner wrote: I agree with Kevin, patching a private method is an encapsulation violation, it should be used as a last resort. Consider, for example, if the true implementation of `_get_active_processes` handled internal state in a way that is expected to be consistent with other methods in the class. Swapping out the behavior compromises the encapsulation put in place. In this case, you should be mocking `TaskMonitor`, the external interface consumed by the class, to supply behavior for `get_active_processes()`. Done - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/#review58668 --- On Feb. 5, 2015, 9:16 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 5, 2015, 9:16 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Add a test for the thermos resource module Diffs - src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION Diff: https://reviews.apache.org/r/27182/diff/ Testing --- [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest ./src/test/python/apache/thermos/monitoring:test_resource 21:15:56 00:00 [main] (To run a reporting server: ./pants server) 21:15:56 00:00 [bootstrap] 21:15:57 00:01 [setup] 21:15:57 00:01 [parse] Executing tasks in goals: bootstrap - imports - gen - check-exclusives - resolve - compile - resources - test 21:15:57 00:01 [bootstrap] 21:15:57 00:01 [bootstrap-jvm-tools] 21:15:57 00:01 [imports] 21:15:57 00:01 [ivy-imports] 21:15:57 00:01 [gen] 21:15:57 00:01 [thrift] 21:15:57 00:01 [scrooge] 21:15:57 00:01 [protoc] 21:15:57 00:01 [antlr] 21:15:57 00:01 [ragel] 21:15:57 00:01 [jaxb] 21:15:57 00:01 [wire] 21:15:57 00:01 [aapt] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [resolve] 21:15:57 00:01 [ivy] 21:15:57 00:01 [compile] 21:15:57 00:01 [jvm] 21:15:57 00:01 [jvm-compilers] 21:15:57 00:01 [resources] 21:15:57 00:01 [prepare] 21:15:57 00:01 [test] 21:15:57 00:01 [run_prep_command] 21:15:57 00:01 [pytest] 21:15:57 00:01 [run] == test session starts === platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 5 items src/test/python/apache/thermos/monitoring/test_resource.py . 5 passed in 0.18 seconds 21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith
Review Request 30710: add mesos role feature
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30710/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
## Problems
We are from eBay platform team. Previously, we used marathon to generate
Jenkins master instance in dedicated vms and recieve resource offer from same
dedicated vms. For the details, please refer to
http://www.ebaytechblog.com/2014/04/04/delivering-ebays-ci-solution-with-apache-mesos-part-i/#.VNQUuC6_SPU
Now, we found Aurora is more stable and powerful. We are moving from Marathon
to Aurora. During the move, we found there is no mesos role in Aurora now. But
we need use mesos role way to solve the problem in section Frameworks stopped
receiving offers after a while of the given url.
Here is a snippet of the problem description:
*We noticed occurred after we used Marathon to create the initial set of CI
masters. As those CI masters started registering themselves as frameworks,
Marathon stopped receiving any offers from Mesos; essentially, no new CI
masters could be launched. Let’s start with Marathon. In the DRF model, it was
unfair to treat Marathon in the same bucket/role alongside hundreds of
connected Jenkins frameworks. After launching all these Jenkins frameworks,
Marathon had a large resource share and Mesos would aggressively offer
resources to frameworks that were using little or no resources. Marathon was
placed last in priority and got starved out.*
*We decided to define a dedicated Mesos role for Marathon and to have all of
the Mesos slaves that were reserved for Jenkins master instances support that
Mesos role. Jenkins frameworks were left with the default role “*”.*This solved
the problem – Mesos offered resources per role and hence Marathon never got
starved out. A framework with a special role will get resource offers from both
slaves supporting that special role and also from the default role “*”.*
However, since we were using placement constraints, Marathon accepted resource
offers only from slaves that supported both the role and the placement
constraints.*
## Solution
So we add role feature is the source code to solve the problem in same way:
When accept a resource offer, Aurora will send back the needed resources to
Mesos with the mesos role in resource offer.
How to configure the Mesos role:
1.Add cmd option --mesos_role=${Mesos role name} when start Aurora scheduler.
We change the test cases according code change. Each changed test case is green
Merge https://github.com/zhanglong2015/incubator-aurora
Diffs
-
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java
1a158b4e0be94762ad0480e8ce74b19bacc90c97
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java
31aa2bbaab3d97875493ad75c4d2c7c82ac7fa58
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java
b5a3140e3560f790d1db496dca3c2ee0dc96a195
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
d0994203b5650f44ca2eb32e1e2aa61875163854
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
5340d651b298ec8aa079e73d6d2f652fdf876293
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
e1c29747c9854cf75bf63f6f085cf40ca68989af
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
422d5a9a42310979752eb7282658316c2b772419
src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java
d6febb8998e05257cabe8d193cefa0b6c79f197e
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
5f08d00d39f016af9bc296e517ad49b66ab5a8de
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
411a55a8d85f60bb2703468f2d69b64b2736eee4
Diff: https://reviews.apache.org/r/30710/diff/
Testing
---
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar UP-TO-DATE
:buildSrc:assemble UP-TO-DATE
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build UP-TO-DATE
:api:generateThriftJava
:api:classesThrift
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJava
Note: Writing
file:/root/incubator-aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:assemble
:compileJmhJava
warning: Supported source version 'RELEASE_6' from annotation processor
Re: Review Request 30710: add mesos role feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71386 --- Master (5059040) is red with this patch. ./build-support/jenkins/build.sh 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:18: Wrong order for 'java.util.Collections' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:51: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:185: Line is longer than 100 characters (found 111). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java:188:5: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:103: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:105:1: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:105:5: 'if' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:128:83: ',' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:145: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:317: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:319: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/Resources.java:331: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:56: Line has trailing spaces. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:115:27: '+' is not preceded with whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:118:1: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:18: Wrong order for 'java.util.List' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:47: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:115: File contains a sequence of empty lines. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:120:1: File contains tab characters (this is the first instance). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:177: Line is longer than 100 characters (found 104). FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or
Re: Review Request 27182: Add a test for the thermos resource module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/#review71378 --- Ship it! Master (5059040) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 6, 2015, 5:18 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Feb. 6, 2015, 5:18 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Add a test for the thermos resource module Diffs - src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION Diff: https://reviews.apache.org/r/27182/diff/ Testing --- [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest ./src/test/python/apache/thermos/monitoring:test_resource 21:15:56 00:00 [main] (To run a reporting server: ./pants server) 21:15:56 00:00 [bootstrap] 21:15:57 00:01 [setup] 21:15:57 00:01 [parse] Executing tasks in goals: bootstrap - imports - gen - check-exclusives - resolve - compile - resources - test 21:15:57 00:01 [bootstrap] 21:15:57 00:01 [bootstrap-jvm-tools] 21:15:57 00:01 [imports] 21:15:57 00:01 [ivy-imports] 21:15:57 00:01 [gen] 21:15:57 00:01 [thrift] 21:15:57 00:01 [scrooge] 21:15:57 00:01 [protoc] 21:15:57 00:01 [antlr] 21:15:57 00:01 [ragel] 21:15:57 00:01 [jaxb] 21:15:57 00:01 [wire] 21:15:57 00:01 [aapt] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [check-exclusives] 21:15:57 00:01 [resolve] 21:15:57 00:01 [ivy] 21:15:57 00:01 [compile] 21:15:57 00:01 [jvm] 21:15:57 00:01 [jvm-compilers] 21:15:57 00:01 [resources] 21:15:57 00:01 [prepare] 21:15:57 00:01 [test] 21:15:57 00:01 [run_prep_command] 21:15:57 00:01 [pytest] 21:15:57 00:01 [run] == test session starts === platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 5 items src/test/python/apache/thermos/monitoring/test_resource.py . 5 passed in 0.18 seconds 21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 1:38 p.m.) Review request for Aurora, Chris Aniszczyk, Joshua Cohen, Marko Gargenta, and Zameer Manji. Changes --- Cut lines at 100. Repository: aurora Description --- docs: Expand Getting Started document Diffs (updated) - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Review Request 30695: Implements log rotation in the Thermos runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-95 https://issues.apache.org/jira/browse/AURORA-95 Repository: aurora Description --- Implements log rotation in the Thermos runner. Diffs - docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f src/main/python/apache/aurora/executor/bin/thermos_executor_main.py dd638801c377065711378b3639b98b8116d8e526 src/main/python/apache/aurora/executor/thermos_task_runner.py dd5cf12856e0412f4e2e03ad7fb5f031776c38c4 src/main/python/apache/thermos/bin/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211 src/main/python/apache/thermos/core/process.py 5ce138dab161d880c0bd58b87a6f5a54d4ca2f99 src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa src/test/python/apache/thermos/core/test_process.py e261249b977802851ffc3d89437761c532fcd3f8 Diff: https://reviews.apache.org/r/30695/diff/ Testing --- ./pants test src/test/python/apache/thermos/core:all Thanks, George Sirois
Re: Review Request 30647: Instrument the HealthChecker to export stats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:15 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Add coverage for snooze/latency. Bugs: AURORA-1062 https://issues.apache.org/jira/browse/AURORA-1062 Repository: aurora Description --- Instrument the HealthChecker to export stats. HealthChecker plugin now should export three stats: consecutive_failures: number of consecutive failures experienced (resets on success) latency: how long health checks are taking in practice snoozed: whether or not the health checker is snoozed Diffs (updated) - src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83 Diff: https://reviews.apache.org/r/30647/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 30647: Instrument the HealthChecker to export stats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:17 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Actually compare latency metric. Bugs: AURORA-1062 https://issues.apache.org/jira/browse/AURORA-1062 Repository: aurora Description --- Instrument the HealthChecker to export stats. HealthChecker plugin now should export three stats: consecutive_failures: number of consecutive failures experienced (resets on success) latency: how long health checks are taking in practice snoozed: whether or not the health checker is snoozed Diffs (updated) - src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83 Diff: https://reviews.apache.org/r/30647/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71276 --- Master (1c78721) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 5, 2015, 6:46 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 6:46 p.m.) Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and
Re: Review Request 30695: Implements log rotation in the Thermos runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71331 --- @ReviewBot retry - George Sirois On Feb. 5, 2015, 10:32 p.m., George Sirois wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Feb. 5, 2015, 10:32 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-95 https://issues.apache.org/jira/browse/AURORA-95 Repository: aurora Description --- Implements log rotation in the Thermos runner. Diffs - docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f src/main/python/apache/aurora/executor/bin/thermos_executor_main.py dd638801c377065711378b3639b98b8116d8e526 src/main/python/apache/aurora/executor/thermos_task_runner.py dd5cf12856e0412f4e2e03ad7fb5f031776c38c4 src/main/python/apache/thermos/bin/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211 src/main/python/apache/thermos/core/process.py 5ce138dab161d880c0bd58b87a6f5a54d4ca2f99 src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa src/test/python/apache/thermos/core/test_process.py e261249b977802851ffc3d89437761c532fcd3f8 Diff: https://reviews.apache.org/r/30695/diff/ Testing --- ./pants test src/test/python/apache/thermos/core:all Thanks, George Sirois
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71323 --- Ship it! Master (1c78721) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 5, 2015, 9:38 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 9:38 p.m.) Review request for Aurora, Chris Aniszczyk, Joshua Cohen, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71325 --- docs/vagrant.md https://reviews.apache.org/r/30681/#comment117002 s/Master/Mesos Master s/Slave/Mesos Slave docs/vagrant.md https://reviews.apache.org/r/30681/#comment117003 s/cluster/VM docs/vagrant.md https://reviews.apache.org/r/30681/#comment117004 Maybe mention `vagrant halt` to simply shut down the VM without destroying it? - Joshua Cohen On Feb. 5, 2015, 9:38 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 9:38 p.m.) Review request for Aurora, Chris Aniszczyk, Joshua Cohen, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Re: Review Request 30695: Implements log rotation in the Thermos runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71335 --- Master (1c78721) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_process . FAILURE src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 5, 2015, 10:32 p.m., George Sirois wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Feb. 5, 2015, 10:32 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs:
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 3:37 p.m.) Review request for Aurora, Chris Aniszczyk, Joshua Cohen, Marko Gargenta, and Zameer Manji. Changes --- Addressing review feedback. Repository: aurora Description --- docs: Expand Getting Started document Diffs (updated) - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Re: Review Request 30681: docs: Expand Getting Started document
On Feb. 5, 2015, 2:16 p.m., Joshua Cohen wrote: docs/vagrant.md, lines 83-84 https://reviews.apache.org/r/30681/diff/2/?file=851289#file851289line83 s/Master/Mesos Master s/Slave/Mesos Slave Done. On Feb. 5, 2015, 2:16 p.m., Joshua Cohen wrote: docs/vagrant.md, line 99 https://reviews.apache.org/r/30681/diff/2/?file=851289#file851289line99 s/cluster/VM Done. On Feb. 5, 2015, 2:16 p.m., Joshua Cohen wrote: docs/vagrant.md, lines 130-131 https://reviews.apache.org/r/30681/diff/2/?file=851289#file851289line130 Maybe mention `vagrant halt` to simply shut down the VM without destroying it? Done. - Ricardo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71325 --- On Feb. 5, 2015, 3:37 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 3:37 p.m.) Review request for Aurora, Chris Aniszczyk, Joshua Cohen, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71343 --- Ship it! Master (1c78721) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 5, 2015, 11:37 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 11:37 p.m.) Review request for Aurora, Chris Aniszczyk, Joshua Cohen, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Review Request 30704: Remove default root in TaskPath.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-1024 https://issues.apache.org/jira/browse/AURORA-1024 Repository: aurora Description --- To allow for an API that will allow for multiple thermos roots it would be best to remove the default root in TaskPath. This way code that does not explictly pass in a root will cause an exception. Diffs - src/main/python/apache/aurora/executor/bin/gc_executor_main.py 890bfaa28f1e72d283958659598befee8f47c7b7 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/main/python/apache/thermos/bin/thermos.py ebf5488a76f8f1199972532118fda61b411df3bd src/main/python/apache/thermos/common/BUILD 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa src/main/python/apache/thermos/common/constants.py PRE-CREATION src/main/python/apache/thermos/common/path.py 9e617051f16f4270b3958f48e0cc43706d245eec src/main/python/apache/thermos/observer/bin/thermos_observer.py 53c331c221b84bef4f2ab80829d51347c6232ad7 src/test/python/apache/thermos/common/test_pathspec.py 3437b196d33d7c2ff6ba292ff99b6881954e7ecb Diff: https://reviews.apache.org/r/30704/diff/ Testing --- ./pants test src/test/python/apache/thermos:: Thanks, Zameer Manji
Re: Review Request 30649: Upgrade pants to 0.0.28
On Feb. 5, 2015, 11:49 a.m., Brian Wickman wrote: Ship It! Brian, any chance you can commit this for me? Thanks! Joe - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649/#review71284 --- On Feb. 4, 2015, 8:13 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649/ --- (Updated Feb. 4, 2015, 8:13 p.m.) Review request for Aurora, Brian Wickman and Zameer Manji. Bugs: AURORA-1104 https://issues.apache.org/jira/browse/AURORA-1104 Repository: aurora Description --- Upgrade pants to 0.0.28 pants = [0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and selected highlights: * bump virtualenv version to 12.0.5 RB #1621 * Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466 * Support use of pytest’s –pdb mode RB #1570 * Upgrade pex dependency to 0.8.4 Pick up several perf wins Pick up fix that allows pex to read older pexes RB #1648 RB #1693 * Refactor setting of PYTHONPATH in pants.ini RB #1586 Diffs - .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 build-support/pants_requirements.txt fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 Diff: https://reviews.apache.org/r/30649/diff/ Testing --- Reviewed the diff [for twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194) ``` $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all ``` Thanks, Joe Smith
Re: Review Request 30704: Remove default root in TaskPath.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/#review71355 --- Ship it! Master (1c78721) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 6, 2015, 1:19 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/ --- (Updated Feb. 6, 2015, 1:19 a.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-1024 https://issues.apache.org/jira/browse/AURORA-1024 Repository: aurora Description --- To allow for an API that will allow for multiple thermos roots it would be best to remove the default root in TaskPath. This way code that does not explictly pass in a root will cause an exception. Diffs - src/main/python/apache/aurora/executor/bin/gc_executor_main.py 890bfaa28f1e72d283958659598befee8f47c7b7 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/main/python/apache/thermos/bin/thermos.py ebf5488a76f8f1199972532118fda61b411df3bd src/main/python/apache/thermos/common/BUILD 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa src/main/python/apache/thermos/common/constants.py PRE-CREATION src/main/python/apache/thermos/common/path.py 9e617051f16f4270b3958f48e0cc43706d245eec src/main/python/apache/thermos/observer/bin/thermos_observer.py 53c331c221b84bef4f2ab80829d51347c6232ad7 src/test/python/apache/thermos/common/test_pathspec.py 3437b196d33d7c2ff6ba292ff99b6881954e7ecb Diff: https://reviews.apache.org/r/30704/diff/ Testing --- ./pants test src/test/python/apache/thermos:: Thanks, Zameer Manji
Re: Review Request 30704: Remove default root in TaskPath.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/#review71352 --- Ship it! Ship It! - Brian Wickman On Feb. 6, 2015, 1:19 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30704/ --- (Updated Feb. 6, 2015, 1:19 a.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-1024 https://issues.apache.org/jira/browse/AURORA-1024 Repository: aurora Description --- To allow for an API that will allow for multiple thermos roots it would be best to remove the default root in TaskPath. This way code that does not explictly pass in a root will cause an exception. Diffs - src/main/python/apache/aurora/executor/bin/gc_executor_main.py 890bfaa28f1e72d283958659598befee8f47c7b7 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/main/python/apache/thermos/bin/thermos.py ebf5488a76f8f1199972532118fda61b411df3bd src/main/python/apache/thermos/common/BUILD 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa src/main/python/apache/thermos/common/constants.py PRE-CREATION src/main/python/apache/thermos/common/path.py 9e617051f16f4270b3958f48e0cc43706d245eec src/main/python/apache/thermos/observer/bin/thermos_observer.py 53c331c221b84bef4f2ab80829d51347c6232ad7 src/test/python/apache/thermos/common/test_pathspec.py 3437b196d33d7c2ff6ba292ff99b6881954e7ecb Diff: https://reviews.apache.org/r/30704/diff/ Testing --- ./pants test src/test/python/apache/thermos:: Thanks, Zameer Manji
Re: Review Request 30225: Modifying update controller to support heartbeats.
On Feb. 5, 2015, 6:07 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 308 https://reviews.apache.org/r/30225/diff/5/?file=849498#file849498line308 Deferrment is not quite what i had in mind. I was thinking something more along the lines of how `TaskTimeout` works, where receiving a pulse causes you to schedule an action in the future that will change the update state (provided no more pulses are received). If we go this route, i think a separate class should be used to manage heartbeats, and this presents a logical place to break this diff apart. As the code stands, we still have the problem where a scheduler with idle inputs will not transition the update state. As the code stands, we still have the problem where a scheduler with idle inputs will not transition the update state. I still don't see a reason to overcomplicate the logic here. Why move the update into a new state when there is no internal activity and why should it be any different that instance-driven transition events? - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review71245 --- On Feb. 5, 2015, 2:34 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/ --- (Updated Feb. 5, 2015, 2:34 a.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1010 https://issues.apache.org/jira/browse/AURORA-1010 Repository: aurora Description --- Added pulsing support into the JobUpdateController. The qualified coordinated updates get blocked until a pulse arrives. An update then becomes active and proceeds until `blockIfNoPulsesAfterMs` expires or the update reaches a terminal state (whichever comes first). Not particularly happy with plumbing through OneWayJobUpdater but the alternative is a state machine change, which is much hairier and will require more changes in the JobUpdaterController. Going with the minimal diff here. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 7f2ec71d744d5fafac84291cc79feba3398d0e1e src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java b7d8d524e15f101416889c00efc3ecf2c8d9c1a1 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d479d20259f284528b2291e2e486b36d8e47fe5e src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 60f535988a20638fb16515d5027bfa65f1afb73c src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java d3b30d48b76d8d7c64cda006a34f7ed3296526f2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec9d1e07abca1bf30262e1c0f741a34741e96f5d src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 76460f95e058181b711fb6869f5a34c1d5bdfe31 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 27a5b9026f5ac3b3bdeb32813b10435bc3dab173 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml f9c9ceddc559b43b4a5c45c745d54ff47484edde src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java ca7c0c2675477cc727ca006697665f997972dfde src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 92cfa2b30c1c4daa3ae225fc8609fbeaecdaff7a src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 89765ac3d34a827d3748fb96a275d78e9d1b8b72 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 41d422939209d0808235128e4242c11e8ef25969 src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987 Diff: https://reviews.apache.org/r/30225/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Re: Review Request 30225: Modifying update controller to support heartbeats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review71245 --- src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java https://reviews.apache.org/r/30225/#comment116915 s/query/fetch/ src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java https://reviews.apache.org/r/30225/#comment116917 Deferrment is not quite what i had in mind. I was thinking something more along the lines of how `TaskTimeout` works, where receiving a pulse causes you to schedule an action in the future that will change the update state (provided no more pulses are received). If we go this route, i think a separate class should be used to manage heartbeats, and this presents a logical place to break this diff apart. As the code stands, we still have the problem where a scheduler with idle inputs will not transition the update state. - Bill Farner On Feb. 5, 2015, 2:34 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/ --- (Updated Feb. 5, 2015, 2:34 a.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1010 https://issues.apache.org/jira/browse/AURORA-1010 Repository: aurora Description --- Added pulsing support into the JobUpdateController. The qualified coordinated updates get blocked until a pulse arrives. An update then becomes active and proceeds until `blockIfNoPulsesAfterMs` expires or the update reaches a terminal state (whichever comes first). Not particularly happy with plumbing through OneWayJobUpdater but the alternative is a state machine change, which is much hairier and will require more changes in the JobUpdaterController. Going with the minimal diff here. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 7f2ec71d744d5fafac84291cc79feba3398d0e1e src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java b7d8d524e15f101416889c00efc3ecf2c8d9c1a1 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d479d20259f284528b2291e2e486b36d8e47fe5e src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 60f535988a20638fb16515d5027bfa65f1afb73c src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java d3b30d48b76d8d7c64cda006a34f7ed3296526f2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec9d1e07abca1bf30262e1c0f741a34741e96f5d src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 76460f95e058181b711fb6869f5a34c1d5bdfe31 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 27a5b9026f5ac3b3bdeb32813b10435bc3dab173 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml f9c9ceddc559b43b4a5c45c745d54ff47484edde src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java ca7c0c2675477cc727ca006697665f997972dfde src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 92cfa2b30c1c4daa3ae225fc8609fbeaecdaff7a src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 89765ac3d34a827d3748fb96a275d78e9d1b8b72 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 41d422939209d0808235128e4242c11e8ef25969 src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987 Diff: https://reviews.apache.org/r/30225/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30647: Instrument the HealthChecker to export stats.
On Feb. 5, 2015, 2:32 a.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/executor/common/test_health_checker.py, line 106 https://reviews.apache.org/r/30647/diff/2/?file=849475#file849475line106 Any chance to have test coverage for the other two metrics? +1 - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71137 --- On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 1:46 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1062 https://issues.apache.org/jira/browse/AURORA-1062 Repository: aurora Description --- Instrument the HealthChecker to export stats. HealthChecker plugin now should export three stats: consecutive_failures: number of consecutive failures experienced (resets on success) latency: how long health checks are taking in practice snoozed: whether or not the health checker is snoozed Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83 Diff: https://reviews.apache.org/r/30647/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 30649: Upgrade pants to 0.0.28
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649/#review71284 --- Ship it! Ship It! - Brian Wickman On Feb. 5, 2015, 4:13 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649/ --- (Updated Feb. 5, 2015, 4:13 a.m.) Review request for Aurora, Brian Wickman and Zameer Manji. Bugs: AURORA-1104 https://issues.apache.org/jira/browse/AURORA-1104 Repository: aurora Description --- Upgrade pants to 0.0.28 pants = [0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and selected highlights: * bump virtualenv version to 12.0.5 RB #1621 * Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466 * Support use of pytest’s –pdb mode RB #1570 * Upgrade pex dependency to 0.8.4 Pick up several perf wins Pick up fix that allows pex to read older pexes RB #1648 RB #1693 * Refactor setting of PYTHONPATH in pants.ini RB #1586 Diffs - .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 build-support/pants_requirements.txt fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 Diff: https://reviews.apache.org/r/30649/diff/ Testing --- Reviewed the diff [for twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194) ``` $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all ``` Thanks, Joe Smith
Re: Review Request 30647: Instrument the HealthChecker to export stats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71281 --- Master (1c78721) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . FAILURE src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:17 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs:
Re: Review Request 30647: Instrument the HealthChecker to export stats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71282 --- @ReviewBot retry - Joshua Cohen On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:17 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1062 https://issues.apache.org/jira/browse/AURORA-1062 Repository: aurora Description --- Instrument the HealthChecker to export stats. HealthChecker plugin now should export three stats: consecutive_failures: number of consecutive failures experienced (resets on success) latency: how long health checks are taking in practice snoozed: whether or not the health checker is snoozed Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83 Diff: https://reviews.apache.org/r/30647/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 30647: Instrument the HealthChecker to export stats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71294 --- Master (1c78721) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . FAILURE src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:17 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs:
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71300 --- Can you please also add jcohen to the reviewers list? - Zameer Manji On Feb. 5, 2015, 10:46 a.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 10:46 a.m.) Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
Re: Review Request 30681: docs: Expand Getting Started document
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71303 --- Ship it! Ship It! - Zameer Manji On Feb. 5, 2015, 10:46 a.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/ --- (Updated Feb. 5, 2015, 10:46 a.m.) Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d Diff: https://reviews.apache.org/r/30681/diff/ Testing --- Thanks, Ricardo Cervera-Navarro
