Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
On March 13, 2015, 2:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 255 https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line255 This is a pretty weird log entry to have. Can it be done in the client

Re: Review Request 32050: Show update status change messages in the scheduler UI.

2015-03-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32050/#review76394 --- Ship it! Ship It! - David McLaughlin On March 13, 2015, 4:12

Re: Review Request 32051: Detect an invalid .auroraversion expansion and provide a helpful error message.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32051/#review76388 --- Ship it! Ship It! - Kevin Sweeney On March 13, 2015, 9:41 a.m.,

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 5:59 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-13 Thread Brian Wickman
On March 13, 2015, 1:10 a.m., Brian Wickman wrote: @ReviewBot retry Bill Farner wrote: If you believe you have discovered a flaky test (which i assume you're asking the bot to try again), can you please file a ticket? Not a flaky test -- a legitimate breakage that I did not

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
On March 13, 2015, 12:59 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 95 https://reviews.apache.org/r/32055/diff/1/?file=894545#file894545line95 I thought it's generally preferable when installing user-supplied

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:18 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76409 --- Ship it! Ship It! - Zameer Manji On March 13, 2015, 12:38 p.m.,

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76419 --- Ship it! Master (128e554) is green with this patch.

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:26 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Joshua Cohen
On March 13, 2015, 7:59 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 95 https://reviews.apache.org/r/32055/diff/1/?file=894545#file894545line95 I thought it's generally preferable when installing user-supplied

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76427 --- Ship it! Master (128e554) is green with this patch.

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:31 p.m.) Review request for Aurora, Joshua Cohen

Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 8:05 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 8:06 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76421 --- Master (128e554) is red with this patch.

Review Request 32050: Show update status change messages in the scheduler UI.

2015-03-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32050/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-1077

Re: Review Request 32050: Show update status change messages in the scheduler UI.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32050/#review76378 --- Ship it! Master (e598f5b) is green with this patch.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Bill Farner
On March 13, 2015, 2:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 279 https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line279 Ditto - this really seems like it should be client-side logging. The

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
On March 13, 2015, 2:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 255 https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line255 This is a pretty weird log entry to have. Can it be done in the client

Re: Review Request 32048: Build all components before running the end-to-end tests.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32048/#review76375 --- Ship it! Ship It! - Maxim Khutornenko On March 13, 2015, 3:45

Review Request 32051: Detect an invalid .auroraversion expansion and provide a helpful error message.

2015-03-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32051/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1169

Re: Review Request 32051: Detect an invalid .auroraversion expansion and provide a helpful error message.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32051/#review76385 --- Ship it! Master (e598f5b) is green with this patch.