widely known issue:
https://github.com/twbs/bootstrap/issues/5889
Thanks,
David McLaughlin
/observer/http/templates/task.tpl
b71c80d11255c111873a46b99478c36d39cc8733
src/main/python/apache/thermos/observer/task_observer.py
ea40bfa610e2af90904487c809bc83b8b5f214d9
Diff: https://reviews.apache.org/r/20394/diff/
Testing
---
Thanks,
David McLaughlin
On April 6, 2014, 12:24 a.m., Bill Farner wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html, line 62
https://reviews.apache.org/r/19833/diff/6/?file=549472#file549472line62
Can you make this an anchor instead of span?
Also, the issue i pointed out
---
Thanks,
David McLaughlin
/20344/diff/
Testing
---
Ran locally and verified. This is a pretty widely known issue:
https://github.com/twbs/bootstrap/issues/5889
Thanks,
David McLaughlin
,
taskConstraint.value.values will always exist and will always be an array?
Otherwise you should add checks for that too.
- David McLaughlin
On April 16, 2014, 8:37 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply
,
David McLaughlin
On April 17, 2014, 12:21 a.m., David McLaughlin wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 365
https://reviews.apache.org/r/19833/diff/7/?file=560830#file560830line365
Why are you passing $scope.role, $scope.environment and $scope.job
be clearer, but that doesn't
need to block this. I can always cut a branch with a suggested refactor once
this ships.
- David McLaughlin
On April 18, 2014, 2 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail
be clearer, but that doesn't
need to block this. I can always cut a branch with a suggested refactor once
this ships.
- David McLaughlin
On April 18, 2014, 2 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail
April 24, 2014, 7:30 p.m.)
Review request for Aurora, David McLaughlin and Suman Karumuri.
Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270
Repository: aurora
Description
---
Stage 1 of implementing command hooks for aurora v2.
This change includes
in the hook.
David McLaughlin wrote:
I think exceptions are designed for exactly this... the hook authors can
also give their own error messages.
I'm not sure I understand why the distinction between an error in the hook and
a request to stop the command is important. Why not just ask
://reviews.apache.org/r/20723/#comment74960
Shouldn't this be batch_size for consistency with the other commands?
- David McLaughlin
On April 25, 2014, 6:23 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review41509
---
Ship it!
lgtm
- David McLaughlin
On April 25, 2014, 7:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41510
---
Ship it!
Ship It!
- David McLaughlin
On April 25, 2014, 12:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/#review41512
---
Ship it!
lgtm
- David McLaughlin
On April 25, 2014, 6:33 p.m
---
Thanks,
David McLaughlin
/#comment75616
Further to above, could you add some test cases for some partially defined
JSON documents?
- David McLaughlin
On May 1, 2014, 8:47 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21023/#review42055
---
Ship it!
Ship It!
- David McLaughlin
On May 2, 2014, 8:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/#review42232
---
Ship it!
Ship It!
- David McLaughlin
On May 6, 2014, 12:43 a.m
://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
https://reviews.apache.org/r/21205/#comment76401
checkstyle: extra newline
- David McLaughlin
On May 8, 2014, 2:26 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review42425
---
Ship it!
Ship It!
- David McLaughlin
On May 7, 2014, 7:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20394/#review42339
---
On April 28, 2014, 10:48 p.m., David McLaughlin wrote
/test_restarter.py
https://reviews.apache.org/r/21223/#comment76403
trailing ws
- David McLaughlin
On May 8, 2014, 3:45 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/
---
(Updated May 9, 2014, 11:47 p.m.)
Review request
---
On May 8, 2014, 11:45 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42617
---
On May 12, 2014, 6:50 p.m., David McLaughlin wrote
On May 9, 2014, 10:27 p.m., Bill Farner wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 400
https://reviews.apache.org/r/21247/diff/1/?file=577123#file577123line400
s/if(/if (/
David McLaughlin wrote:
done. would be nice to have
-732e782204b6__Screen_Shot_2014-05-08_at_4.25.36_PM.png
Viewing multiple configs at the same time
https://reviews.apache.org/media/uploaded/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png
Thanks,
David McLaughlin
/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png
Thanks,
David McLaughlin
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html,
line 1
https://reviews.apache.org/r/21247/diff/1/?file=577119#file577119line1
wrap this in a div.
David McLaughlin wrote:
Why?
Suman Karumuri
?
- David McLaughlin
On May 12, 2014, 8:36 p.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/
---
(Updated
-08_at_4.25.42_PM.png
screenshot of really small group
https://reviews.apache.org/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png
Thanks,
David McLaughlin
---
On May 8, 2014, 11:45 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 8
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
/MemLockStoreTest.java
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
:
private static ILock makeLock(JobKey job) {
...
}
David McLaughlin wrote:
ack.
Since it is useful to be able to differentiate between two locks (and we
do this in at least one test), I'm going to add two methods. One which
returns a Lock and one
.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review42729
---
On May 9, 2014, 11:47 p.m., David McLaughlin wrote
34377430268002e8e8e5bc803b409e092bb86720
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
-12_at_1.27.59_PM.png
Thanks,
David McLaughlin
: 1 mins 16.824 secs
Thanks,
David McLaughlin
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42937
---
On May 14, 2014, 1:30 a.m., David McLaughlin wrote
/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png
Thanks,
David McLaughlin
://aurora.incubator.apache.org/
Although preferably with the logo made smaller to avoid taking up so much
screen real estate.
- David McLaughlin
On May 14, 2014, 3:43 a.m., Suman Karumuri wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/#review42587
---
Ship it!
- David McLaughlin
On May 7, 2014, 6:48 p.m., Mark Chu
-08_at_4.25.36_PM.png
Viewing multiple configs at the same time
https://reviews.apache.org/media/uploaded/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png
Thanks,
David McLaughlin
---
On May 6, 2014, 11 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132
.
:jacocoTestReport
Coverage report generated:
file:Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
:check
:build
BUILD SUCCESSFUL
Total time: 1 mins 16.824 secs
Thanks,
David McLaughlin
.
By passing in $scope, it is very unclear what inputs buildGroupSummary
depends on.
David McLaughlin wrote:
The function signature is quite clear that buildGroupSummary is a
function which depends on the global $scope (it both reads and writes to it -
this is how Angular passes around
.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21407/#review43123
---
On May 14, 2014, 10:22 p.m., David McLaughlin wrote
/#comment77221
Please give a brief code comment describing what this code is doing.
- David McLaughlin
On May 15, 2014, 12:46 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
https://reviews.apache.org/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png
Thanks,
David McLaughlin
/QuotaMapper.java
https://reviews.apache.org/r/21459/#comment77236
Please add docs, particularly to merge.
- David McLaughlin
On May 14, 2014, 9:22 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply
On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 17
https://reviews.apache.org/r/21523/diff/1/?file=582876#file582876line17
Why?
David McLaughlin wrote:
Good question.
JavaScript
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/#review43164
---
Ship it!
Ship It!
- David McLaughlin
On May 15, 2014, 9:07 p.m
Diff: https://reviews.apache.org/r/21523/diff/
Testing
---
Thanks,
David McLaughlin
https://reviews.apache.org/r/21497/#comment77200
Please either add an additional flag that allows you to set the origin, or
just modify this flag to accept that value.
i.e.
--enable_cors_for=*
- David McLaughlin
On May 15, 2014, 7:28 p.m., Suman Karumuri wrote
. Does it mean we would have to add n mappers here if we add n
new fields into the LockKey? Any way this could be generalized or
abstracted out?
David McLaughlin wrote:
We would need to add n mappers if the we expand LockKey's fields. Most
likely we would change the design when
---
On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523
.
- David McLaughlin
On April 27, 2014, 2:17 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43192
---
Ship it!
Ship It!
- David McLaughlin
On May 16, 2014, 12:16 a.m
/html/index.html
:check
:build
BUILD SUCCESSFUL
Total time: 3 mins 19.979 secs
Thanks,
David McLaughlin
://reviews.apache.org/r/21662/diff/
Testing
---
Ran locally.
File Attachments
Screen Shot 2014-05-19 at 2.24.30 PM.png
https://reviews.apache.org/media/uploaded/files/2014/05/19/00d7bd0c-6c8f-4932-aaea-abbea7d54d36__Screen_Shot_2014-05-19_at_2.24.30_PM.png
Thanks,
David
---
On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
---
(Updated May 16, 2014, 1:30
/index.html
:check
:build
BUILD SUCCESSFUL
Total time: 3 mins 19.979 secs
Thanks,
David McLaughlin
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
34377430268002e8e8e5bc803b409e092bb86720
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
fields into the LockKey? Any way this could be generalized or
abstracted out?
David McLaughlin wrote:
We would need to add n mappers if the we expand LockKey's fields. Most
likely we would change the design when that happens.
I don't see a way to create a storage abstraction
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21383/#review43535
---
Ship it!
lgtm.
- David McLaughlin
On May 20, 2014, 12:25 a.m
)
---
$ ./gradlew clean build
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21753/#review43644
---
Ship it!
- David McLaughlin
On May 21, 2014, 5:13 a.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21754/#review43646
---
Ship it!
Ship It!
- David McLaughlin
On May 21, 2014, 6:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21780/#review43647
---
Ship it!
Ship It!
- David McLaughlin
On May 21, 2014, 5:45 p.m
: https://reviews.apache.org/r/21791/diff/
Testing
---
Tested locally.
Thanks,
David McLaughlin
-
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43664
---
On May 21, 2014, 10:35 p.m., David McLaughlin wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review43377
---
On May 22, 2014, 5:59 p.m., David McLaughlin wrote
/scheduler/storage/mem/MemLockStoreTest.java
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
Thanks,
David McLaughlin
34377430268002e8e8e5bc803b409e092bb86720
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java
a5191500b2958253e14843089a15a1ffd58e6846
Diff: https://reviews.apache.org/r/21132/diff/
Testing (updated)
---
./gradlew clean build
Thanks,
David McLaughlin
generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review43743
---
On May 22, 2014, 6:26 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail
: https://reviews.apache.org/r/21828/diff/
Testing
---
./gradlew clean build ./gradlew clean run
Thanks,
David McLaughlin
://reviews.apache.org/r/21790/#comment78079
Do we have a value like columns.length we can use for this value rather
than use a magic number?
- David McLaughlin
On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43871
---
Ship it!
Ship It!
- David McLaughlin
On May 23, 2014, 6:54 p.m
/
---
(Updated May 23, 2014, 6:54 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
---
Moved task tables into active and completed tabs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21849/#review44003
---
Ship it!
- David McLaughlin
On May 23, 2014, 8:26 p.m., Bill
6f6d9a46bd78c8e96c69240be8cb9ac6d564f0f8
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java
d4fe607f2881a628ac4dc017fbed02a9509f2ce2
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
./gradlew clean build
Thanks,
David McLaughlin
/mem/MemLockStoreTest.java
d4fe607f2881a628ac4dc017fbed02a9509f2ce2
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
./gradlew clean build
Thanks,
David McLaughlin
/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java
d4fe607f2881a628ac4dc017fbed02a9509f2ce2
Diff: https://reviews.apache.org/r/21132/diff/
Testing
---
./gradlew clean build
Thanks,
David McLaughlin
://reviews.apache.org/r/21945/diff/
Testing
---
Thanks,
David McLaughlin
/IsolatedSchedulerModule.java
e9d9bc47d8e0c9590f14dad298b731ded741
Diff: https://reviews.apache.org/r/21945/diff/
Testing
---
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21951/#review44141
---
Ship it!
- David McLaughlin
On May 28, 2014, 12:57 a.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review44142
---
Ping.
- David McLaughlin
On May 22, 2014, 9:31 p.m., David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review44143
---
Ping. This can be shipped to master.
- David McLaughlin
On May
a log level for
this use case. Can you explain a little why this is needed?
src/main/python/apache/aurora/client/cli/client.py
https://reviews.apache.org/r/21980/#comment78468
Does this import pass checkstyle?
- David McLaughlin
On May 28, 2014, 4:02 p.m., Mark Chu-Carroll wrote
On May 28, 2014, 6:49 p.m., David McLaughlin wrote:
I don't have all the context, but it seems unusual to me to add a log level
for this use case. Can you explain a little why this is needed?
Mark Chu-Carroll wrote:
Sure. We're trying to create a centralized logging/analytics
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21980/#review44150
---
Ship it!
- David McLaughlin
On May 28, 2014, 4:02 p.m., Mark Chu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21980/#review44149
---
Ship it!
- David McLaughlin
On May 28, 2014, 4:02 p.m., Mark Chu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22065/#review44396
---
Ship it!
Ship It!
- David McLaughlin
On May 30, 2014, 1:32 a.m
1 - 100 of 331 matches
Mail list logo
