Re: Review Request 28879: Make abstract decorators effective in CommandHook class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28879/#review64828 --- On master now. - Maxim Khutornenko On Dec. 9, 2014, 11:36 p.m

Review Request 28914: Adding PMD rule to check @Timed annotation placement.

with --info or --debug option to get more log output. BUILD FAILED Total time: 12.981 secs ``` Thanks, Maxim Khutornenko

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

/pmd/main.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 12.981 secs ``` Thanks, Maxim Khutornenko

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64617 --- On Dec. 10, 2014, 8:02 p.m., Maxim Khutornenko wrote

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64618 --- On Dec. 10, 2014, 8:02 p.m., Maxim Khutornenko wrote

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 12.981 secs ``` Thanks, Maxim Khutornenko

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

/pmd/main.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 12.981 secs ``` Thanks, Maxim Khutornenko

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64624 --- On Dec. 10, 2014, 8:06 p.m., Maxim Khutornenko wrote

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 12.981 secs ``` Thanks, Maxim Khutornenko

Re: Review Request 28915: Use pip to pre-fetch python dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28915/#review64651 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 10, 2014, 9:39

Re: Review Request 28876: Suppressing redundant client command error messaging.

. Instead of creating a new type of exception can we just prevent the double printing in general? Maxim Khutornenko wrote: Not sure I buy it. This `print_err()` is needed when a CommandError is raised to bail out due to some internal problem (i.e. not related to scheduler call

Re: Review Request 28872: Improving quota check message in the client.

, Maxim Khutornenko

Re: Review Request 28872: Improving quota check message in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/#review64466 --- On Dec. 9, 2014, 9:30 p.m., Maxim Khutornenko wrote

Re: Review Request 28872: Improving quota check message in the client.

9.0 RAM 0.00 GB Disk0.00 GB Update failed due to error: Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.) Error executing command: Update failed due to error: ``` Thanks, Maxim Khutornenko

Re: Review Request 28831: Changing the default --batch-size to 1.

--- On Dec. 9, 2014, 1:25 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831

Re: Review Request 28831: Changing the default --batch-size to 1.

/apache/aurora/client/cli:all Thanks, Maxim Khutornenko

Re: Review Request 28831: Changing the default --batch-size to 1.

/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko

Review Request 28872: Improving quota check message in the client.

0.00 GB Update failed due to error: Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.) Error executing command: Update failed due to error: ``` Thanks, Maxim Khutornenko

Review Request 28876: Suppressing redundant client command error messaging.

: ``` $ aurora2 job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job already exists: www-data/prod/hello ``` Thanks, Maxim Khutornenko

Re: Review Request 28876: Suppressing redundant client command error messaging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28876/#review64460 --- On Dec. 9, 2014, 10:32 p.m., Maxim Khutornenko wrote

Re: Review Request 28876: Suppressing redundant client command error messaging.

. Instead of creating a new type of exception can we just prevent the double printing in general? Maxim Khutornenko wrote: Not sure I buy it. This `print_err()` is needed when a CommandError is raised to bail out due to some internal problem (i.e. not related to scheduler call

Review Request 28883: Fixing @Timed method visibility.

task_schedule_attempt_locked_nanos_total 45453749 task_schedule_attempt_locked_nanos_total_per_sec 1573257.5921699686 task_schedule_attempt_nanos_per_event 1759287.885810068 task_schedule_attempt_nanos_total 48291560 task_schedule_attempt_nanos_total_per_sec 1757397.369105048 ``` Thanks, Maxim Khutornenko

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review64487 --- On Dec. 6, 2014, 12:33 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

o.a.a.b.SchedulerBenchmark.examplethrpt3 3383949750.729 ± 1237528915.517 ops/s ``` Thanks, Maxim Khutornenko

Re: Review Request 28876: Suppressing redundant client command error messaging.

. Instead of creating a new type of exception can we just prevent the double printing in general? Maxim Khutornenko wrote: Not sure I buy it. This `print_err()` is needed when a CommandError is raised to bail out due to some internal problem (i.e. not related to scheduler call

Review Request 28806: More logging in MaintenanceController.

/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 28742: Simplify logging in the client.

://reviews.apache.org/r/28742/#comment106906 Is there a test for this? src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/28742/#comment106904 This can now be simplified with `base.combine_messages(resp)`. - Maxim Khutornenko On Dec. 8, 2014, 7:58 p.m., Zameer

Review Request 28811: Improving logging experience in admin drain_hosts.

/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64283 --- On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

strange that if we're watching 2 hosts, and 1 moves to DRAINED, we keep querying for its state. Coupled with the logging change in this diff, it appears that you'll keep logging the same hostnames over and over. Maxim Khutornenko wrote: Not sure I understand

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

--- On Dec. 5, 2014, 10:57 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png StaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png Thanks, Maxim Khutornenko

Re: Review Request 28742: Simplify logging in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64310 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 8, 2014, 11:18

Re: Review Request 28742: Simplify logging in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64311 --- On master now. - Maxim Khutornenko On Dec. 8, 2014, 11:18 p.m

Review Request 28831: Changing the default --batch-size to 1.

1eda72af4c19831ae27733f506858e67772b2075 src/test/python/apache/aurora/client/cli/util.py 67d7eaa6eff4e1dbaaa485166e084812a4f04074 Diff: https://reviews.apache.org/r/28831/diff/ Testing --- ./pants src/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko

Re: Review Request 28738: Remove unused DefaultServlet subclass.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28738/#review64016 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 4:06 a.m

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

thrpt3 3383949750.729 ± 1237528915.517 ops/s ``` Thanks, Maxim Khutornenko

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review64066 --- On Dec. 5, 2014, 6:32 p.m., Maxim Khutornenko wrote

Re: Review Request 28771: Don't fall back to old command syntax in the new client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64103 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 9:12 p.m

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

/media/uploaded/files/2014/12/03/7945c60b-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png StaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png Thanks, Maxim Khutornenko

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example avgt 100 5011738.309 ± 160249.620 ns/op ``` Thanks, Maxim Khutornenko

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

o.a.a.b.SchedulerBenchmark.examplethrpt3 3383949750.729 ± 1237528915.517 ops/s ``` Thanks, Maxim Khutornenko

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

--- On Dec. 5, 2014, 6:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710

Re: Review Request 28660: Reduce minimum branch coverage requirement to avoid flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28660/#review63707 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 3, 2014, 7:02 p.m

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

://reviews.apache.org/r/28674/#comment106029 same here src/test/python/apache/aurora/client/api/test_task_util.py https://reviews.apache.org/r/28674/#comment106032 same here - Maxim Khutornenko On Dec. 3, 2014, 8:34 p.m., Bill Farner wrote

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

://reviews.apache.org/r/28693/#comment106171 Why not keeping @abstractmethod attributes and dropping the return statements instead? With your modification there is no need to keep this noop behavior as tests like EmptyPlugin below would not be possible anyway. - Maxim Khutornenko On Dec. 4, 2014

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

On Dec. 4, 2014, 5:21 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/__init__.py, lines 172-175 https://reviews.apache.org/r/28693/diff/1/?file=782496#file782496line172 Why not keeping @abstractmethod attributes and dropping the return statements instead

Re: Review Request 28692: Simplify logging in the Aurora client.

/client/cli/context.py https://reviews.apache.org/r/28692/#comment106185 same question here - Maxim Khutornenko On Dec. 4, 2014, 6:27 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 28710: Adding JMH framework support for scheduler performance analysis.

, Maxim Khutornenko

Re: Review Request 28474: Added manual perf tests for the scheduling pipeline.

://reviews.apache.org/r/28710/. - Maxim Khutornenko On Nov. 26, 2014, 6:15 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28474

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

suggestion. Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review63896 --- On Dec. 4, 2014, 7:36 p.m., Maxim Khutornenko

Review Request 28731: Implemented TaskScheduler benchmarks.

o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example avgt 100 5165386.898 ± 344576.928 ns/op o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example avgt 100 5011738.309 ± 160249.620 ns/op ``` Thanks, Maxim Khutornenko

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63948 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 1:09 a.m

Re: Review Request 28607: Add a caching ClusterState implementation.

/#comment105877 Would it make sense to do it conditionally, i.e.: ```java if (!Tasks.SLAVE_ASSIGNED_STATES.contains(stateChange.getNewState()) { Iterables.remove... } else { victims.put... } ``` - Maxim Khutornenko On Dec. 2, 2014, 10:03 p.m., Bill Farner wrote

Review Request 28617: Implemented offer filtering for tasks with static vetoes.

StaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png Thanks, Maxim Khutornenko

Re: Review Request 28607: Add a caching ClusterState implementation.

On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 58 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line58 Would it make sense to do it conditionally, i.e.: ```java

Re: Review Request 28607: Add a caching ClusterState implementation.

/preemptor/CachedClusterState.java https://reviews.apache.org/r/28607/#comment105910 This can be further simplified (unless you are concerned about the heap churn): ```java victims.remove(slaveId, PreemptionVictim.fromTask(stateChange.getTask().getAssignedTask()); ``` - Maxim Khutornenko

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/#review63638 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 3, 2014, 2:13 a.m

Re: Review Request 28571: Reject jobs containing an empty cron schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28571/#review63487 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 1, 2014, 8:07 p.m

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

/preemptor/LiveClusterState.java https://reviews.apache.org/r/28572/#comment105758 Please, drop the now unused TASK_TO_SLAVE_ID. - Maxim Khutornenko On Dec. 1, 2014, 8:32 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 28411: Adding quota check into replaceCronTemplate rpc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28411/#review63162 --- @ReviewBot retry - Maxim Khutornenko On Nov. 24, 2014, 9:27 p.m

Re: Review Request 28411: Adding quota check into replaceCronTemplate rpc.

! Fatal error: Response from scheduler: INVALID_REQUEST (message: Insufficient resource quota: CPU quota exceeded by 1.00 core(s); RAM quota exceeded by 1024.00 MB; DISK quota exceeded by 1024.00 MB)) Thanks, Maxim Khutornenko

Re: Review Request 28398: Adding cron check into aurora beta-update start.

src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3 Diff: https://reviews.apache.org/r/28398/diff/ Testing --- ./pants src/test/python:all Tested in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 28398: Adding cron check into aurora beta-update start.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28398/#review62853 --- On Nov. 24, 2014, 7:19 p.m., Maxim Khutornenko wrote

Review Request 28445: Improving messages in CronJobManager.

/CronJobManagerImpl.java 28f1ae72aec392d6b2666e8993920106b8e3138f src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java 934e9bb669e6647dfbc2b43f00d036bad19932e5 Diff: https://reviews.apache.org/r/28445/diff/ Testing --- ./graldew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 28361: Extract thrift into an API subproject.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/#review63029 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 25, 2014, 7:39

Review Request 28450: Fixing admin query command

/client/commands/test_admin.py 7dd61cdd6735bd0f274722249276d60084b4dd93 Diff: https://reviews.apache.org/r/28450/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 28350: Add cron replace command.

. Will send a new diff to fix help/messaging. - Maxim Khutornenko On Nov. 22, 2014, 12:54 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28350

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

, MIN_THERMOS_RESOURCES))? - Maxim Khutornenko On Nov. 21, 2014, 5:01 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28193

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

/Preemptor.java https://reviews.apache.org/r/28310/#comment104668 newline? src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java https://reviews.apache.org/r/28310/#comment104669 Reads awkward. Was this supposed to be a TODO? - Maxim Khutornenko On Nov. 21, 2014, 6:28

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

On Nov. 21, 2014, 6:48 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 301 https://reviews.apache.org/r/28310/diff/3/?file=772285#file772285line301 newline? Bill Farner wrote: Not sure what you're requesting here. Where

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

On Nov. 21, 2014, 6:41 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, line 196 https://reviews.apache.org/r/28193/diff/2/?file=772028#file772028line196 This is only used in tests outside of this class. Consider reverting

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

- awesome! - Maxim Khutornenko On Nov. 21, 2014, 7:52 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345

Review Request 28350: Add cron replace command.

/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3 Diff: https://reviews.apache.org/r/28350/diff/ Testing --- ./pants src/test/python:all tested in vagrant as well Thanks, Maxim Khutornenko

Re: Review Request 28350: Add cron replace command.

. To reply, visit: https://reviews.apache.org/r/28350/#review62676 --- On Nov. 21, 2014, 11:14 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 28350: Add cron replace command.

--- On Nov. 21, 2014, 11:14 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28350/ --- (Updated

Re: Review Request 28350: Add cron replace command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28350/#review62675 --- On Nov. 21, 2014, 11:14 p.m., Maxim Khutornenko wrote

Re: Review Request 28350: Add cron replace command.

/test/python:all tested in vagrant as well Thanks, Maxim Khutornenko

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28193/#review62694 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 21, 2014, 10:50

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28193/#review62696 --- On master now. - Maxim Khutornenko On Nov. 21, 2014, 10:50 p.m

Re: Review Request 28350: Add cron replace command.

On Nov. 21, 2014, 11:26 p.m., Kevin Sweeney wrote: docs/cron-jobs.md, line 89 https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89 Hold on a sec - why do we have this and cron schedule (see above)? Maxim Khutornenko wrote: The cron replace is an atomic

Re: Review Request 28350: Add cron replace command.

On Nov. 21, 2014, 11:26 p.m., Kevin Sweeney wrote: docs/cron-jobs.md, line 89 https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89 Hold on a sec - why do we have this and cron schedule (see above)? Maxim Khutornenko wrote: The cron replace is an atomic

Re: Review Request 28361: Extract thrift into an API subproject.

/aurora/build/ThriftEntitiesPlugin.groovy https://reviews.apache.org/r/28361/#comment104798 same here - Maxim Khutornenko On Nov. 22, 2014, 1:35 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62403 --- @ReviewBot retry - Maxim Khutornenko On Nov. 20, 2014, 3:01 a.m

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62407 --- @ReviewBot retry - last attempt - Maxim Khutornenko On Nov. 20

Re: Review Request 28306: Return an iterable of frame chunks.

/EntrySerializer.java https://reviews.apache.org/r/28306/#comment104522 Mind commenting on the algorithm here? Why the magic -2? - Maxim Khutornenko On Nov. 21, 2014, 12:54 a.m., Kevin Sweeney wrote: --- This is an automatically generated e

Re: Review Request 28306: Return an iterable of frame chunks.

On Nov. 21, 2014, 1:09 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 92 https://reviews.apache.org/r/28306/diff/1/?file=771713#file771713line92 Mind commenting on the algorithm here? Why the magic -2? Kevin

Re: Review Request 28306: Return an iterable of frame chunks.

On Nov. 21, 2014, 1:09 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 92 https://reviews.apache.org/r/28306/diff/1/?file=771713#file771713line92 Mind commenting on the algorithm here? Why the magic -2? Kevin

Re: Review Request 28306: Return an iterable of frame chunks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62502 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 21, 2014, 1:10

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28097/#review62320 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 19, 2014, 11:41

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- On Nov. 15, 2014, 12:15 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

://reviews.apache.org/r/27705/#review62256 --- On Nov. 15, 2014, 12:15 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

/scheduler/thrift/SchedulerThriftInterfaceTest.java 168290af9f84750e66dca69cf056dacb5f38aaa3 Diff: https://reviews.apache.org/r/27705/diff/ Testing --- ./gradlew -Pq build Verified new stats in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 1787 https://reviews.apache.org/r/28026/diff/1/?file=763222#file763222line1787 Can you file a JIRA for this? This is now tracked by

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61763 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 16, 2014, 10:29

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

used in mem storage AFAICT. src/main/java/org/apache/aurora/scheduler/storage/Storage.java https://reviews.apache.org/r/28097/#comment103650 typo - Maxim Khutornenko On Nov. 16, 2014, 10:43 p.m., Bill Farner wrote

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

, 2014, 12:30 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 14, 2014, 12:30

Re: Review Request 28048: Fix task_util dependency and add it to all target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28048/#review61475 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 14, 2014, 7 p.m

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

affects multiple counters disproportionately. Maxim Khutornenko wrote: Isn't it the same problem with the aggregate counters? I.e. in the above example we would still see static=1 (or 3?) and dynamic=1. To address your concern of excessive counting, how about maintaining unique veto

<    1   2   3   4   5   6   7   8   9   10   >