Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/
---

(Updated June 25, 2014, 7:29 p.m.)


Review request for Aurora.


Changes
---

CR comments.


Bugs: AURORA-528
https://issues.apache.org/jira/browse/AURORA-528


Repository: aurora


Description
---

Documenting SLA stats.


Diffs (updated)
-

  docs/sla.md PRE-CREATION 

Diff: https://reviews.apache.org/r/22697/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Maxim Khutornenko 


> On June 25, 2014, 7:26 p.m., Joe Smith wrote:
> > docs/sla.md, line 82
> > 
> >
> > This is a purely

Done.


> On June 25, 2014, 7:26 p.m., Joe Smith wrote:
> > docs/sla.md, line 102
> > 
> >
> > that helps track

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46670
---


On June 25, 2014, 4:48 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> ---
> 
> (Updated June 25, 2014, 4:48 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
> https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46670
---

Ship it!


Awesome, thanks Maxim!


docs/sla.md


This is a purely



docs/sla.md


that helps track


- Joe Smith


On June 25, 2014, 9:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> ---
> 
> (Updated June 25, 2014, 9:48 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
> https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46667
---

Ship it!


Ship It!

- Bill Farner


On June 25, 2014, 4:48 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> ---
> 
> (Updated June 25, 2014, 4:48 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
> https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/
---

(Updated June 25, 2014, 4:48 p.m.)


Review request for Aurora.


Changes
---

CR comments.
Pushed for preview to: 
https://github.com/maxim111333/incubator-aurora/blob/docs/docs/sla.md


Bugs: AURORA-528
https://issues.apache.org/jira/browse/AURORA-528


Repository: aurora


Description
---

Documenting SLA stats.


Diffs (updated)
-

  docs/sla.md PRE-CREATION 

Diff: https://reviews.apache.org/r/22697/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Maxim Khutornenko 


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 1
> > 
> >
> > How about "Aurora SLA Measurement"?  Given that this works above a job, 
> > broadened scope seems like a good idea.

Sure.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 23
> > 
> >
> > s/core //?

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 21
> > 
> >
> > Might want to eschew discussion of implementation details a bit.  How 
> > about "Counters that track SLA measurements are computed periodically 
> > within the scheduler."

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 31
> > 
> >
> > Before this, a bit of prose about how we detect platform unavailability 
> > would be useful.  i.e. it's a red flag that the term LOST does not appear 
> > in the document.  It's good that you link to the source of truth 
> > (SlaAlgorithm.java), but a sentence or two about mesos and LOST status 
> > would fill in a big contextual blank.

Extended the definition and added a few examples of downtime events below.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 45
> > 
> >
> > Nit: a user can indirectly cause service downtime when their 
> > application exits.

I think that would be considered as "unhealthy" service task. Modified.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 51
> > 
> >
> > You can actually link directly to the source path for simpler discovery.

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 88
> > 
> >
> > s/Average/Median/
> > 
> > s/get host-assigned/be assigned to a host/
> > s/A combined/This is a combined/

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 89
> > 
> >
> > Rewording:
> > "job scheduling performance dependency"
> > 
> > to
> > 
> > "the dependency of scheduling performance"

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 96
> > 
> >
> > Please link to the source defining these sizes.

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 118
> > 
> >
> > s/The //

Done.


> On June 23, 2014, 8:34 p.m., Bill Farner wrote:
> > docs/sla.md, line 124
> > 
> >
> > s/Average/Median/

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46442
---


On June 17, 2014, 9:14 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> ---
> 
> (Updated June 17, 2014, 9:14 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
> https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22697: Documenting SLA stats.

2014-06-23 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46442
---


Overall the content looks good and thorough.  Can you push a branch to github 
and link to it in the review description?  This way we can have a preview of 
the rendering.


docs/sla.md


How about "Aurora SLA Measurement"?  Given that this works above a job, 
broadened scope seems like a good idea.



docs/sla.md


Might want to eschew discussion of implementation details a bit.  How about 
"Counters that track SLA measurements are computed periodically within the 
scheduler."



docs/sla.md


s/core //?



docs/sla.md


Before this, a bit of prose about how we detect platform unavailability 
would be useful.  i.e. it's a red flag that the term LOST does not appear in 
the document.  It's good that you link to the source of truth 
(SlaAlgorithm.java), but a sentence or two about mesos and LOST status would 
fill in a big contextual blank.



docs/sla.md


Nit: a user can indirectly cause service downtime when their application 
exits.



docs/sla.md


You can actually link directly to the source path for simpler discovery.



docs/sla.md


s/Average/Median/

s/get host-assigned/be assigned to a host/
s/A combined/This is a combined/



docs/sla.md


Rewording:
"job scheduling performance dependency"

to

"the dependency of scheduling performance"



docs/sla.md


Please link to the source defining these sizes.



docs/sla.md


s/The //



docs/sla.md


s/Average/Median/


- Bill Farner


On June 17, 2014, 9:14 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> ---
> 
> (Updated June 17, 2014, 9:14 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
> https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22697: Documenting SLA stats.

2014-06-20 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46273
---


Anyone?

- Maxim Khutornenko


On June 17, 2014, 9:14 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> ---
> 
> (Updated June 17, 2014, 9:14 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
> https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>