Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/#review60696 --- Ship it! This is now on master: $ git log -1 origin/master commit 01958b1dfa4192549802ee39595cd050b27f5a69 Author: Zameer Manji zma...@twopensource.com Date: Mon Nov 10 14:42:08 2014 -0800 Print out the job url after scheduling a cron job. Bugs closed: AURORA-857 Reviewed at https://reviews.apache.org/r/27657/ - Bill Farner On Nov. 6, 2014, 9:28 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 6, 2014, 9:28 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 6, 2014, 10:47 a.m.) Review request for Aurora and Bill Farner. Changes --- Josh's feedback. Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs (updated) - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/#review60211 --- Ship it! Ship It! - Joshua Cohen On Nov. 6, 2014, 6:47 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 6, 2014, 6:47 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/#review60213 --- Ship it! Master (d01f0c3) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 6:47 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 6, 2014, 6:47 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 6, 2014, 1:27 p.m.) Review request for Aurora and Bill Farner. Changes --- Bill's feedback. Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs (updated) - build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 3a3c95e0a2a7fe3ea1a95b8a9ee5e2702ce67037 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a src/test/python/apache/thermos/monitoring/test_disk.py 913f87d90944e2c5359ac0b7c2205ddf7db676ba Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 6, 2014, 1:28 p.m.) Review request for Aurora and Bill Farner. Changes --- Rebase from master. Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs (updated) - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27657/#review60089
---
Master (0ad2fca) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status
PASSED
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status_multiple_jobs
PASSED
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_deschedule_cron_deep_api
PASSED
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_cron_deep_api
Fatal error running command; traceback can be found in
/home/jenkins/.aurora/errors/aurora-1415238529.error-log
FAILED
=== FAILURES ===
___ TestCronNoun.test_schedule_cron_deep_api ___
self = client.cli.test_cron.TestCronNoun
testMethod=test_schedule_cron_deep_api
def test_schedule_cron_deep_api(self):
(mock_api, mock_scheduler_proxy) = self.create_mock_api()
with contextlib.nested(
patch('time.sleep'),
patch('apache.aurora.client.api.SchedulerProxy',
return_value=mock_scheduler_proxy),
patch('apache.aurora.client.factory.CLUSTERS',
new=self.TEST_CLUSTERS)):
mock_scheduler_proxy.scheduleCronJob.return_value =
self.create_simple_success_response()
with temporary_file() as fp:
fp.write(self.get_valid_config())
fp.flush()
cmd = AuroraCommandLine()
result = cmd.execute(['cron', 'schedule', 'west/bozo/test/hello',
fp.name])
assert result == EXIT_OK
E AssertionError: assert 20 == 0
src/test/python/apache/aurora/client/cli/test_cron.py:100: AssertionError
generated xml file:
/jenkins/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.cli.cron.xml
Interrupted: stopping after 1 failures
== 1 failed, 3 passed in 1.55 seconds ==
Build operating on top level addresses:
set([BuildFileAddress(/jenkins/workspace/AuroraBot/src/test/python/BUILD, all)])
src.test.python.apache.aurora.admin.admin_util
. SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
. SUCCESS
src.test.python.apache.aurora.client.api.api
. SUCCESS
src.test.python.apache.aurora.client.api.disambiguator
. SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher
. SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
. SUCCESS
src.test.python.apache.aurora.client.api.mux
. SUCCESS
src.test.python.apache.aurora.client.api.quota_check
. SUCCESS
src.test.python.apache.aurora.client.api.restarter
. SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client
. SUCCESS
src.test.python.apache.aurora.client.api.sla
. SUCCESS
src.test.python.apache.aurora.client.api.updater
. SUCCESS
src.test.python.apache.aurora.client.api.updater_util
. SUCCESS
src.test.python.apache.aurora.client.binding_helper
. SUCCESS
src.test.python.apache.aurora.client.cli.api
. SUCCESS
src.test.python.apache.aurora.client.cli.bridge
. SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks
. SUCCESS
src.test.python.apache.aurora.client.cli.cron
. FAILURE
src.test.python.apache.aurora.client.config
. SUCCESS
- Aurora ReviewBot
On Nov. 6, 2014, 1:33 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27657/
---
(Updated Nov. 6, 2014, 1:33 a.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-857
https://issues.apache.org/jira/browse/AURORA-857
Repository: aurora
Description
---
Print out the job url after scheduling a cron job.
Diffs
-
src/main/python/apache/aurora/client/cli/cron.py
3416c8e1932056725880f2007b60d77112759428
src/test/python/apache/aurora/client/cli/test_cron.py
f488432cd68cc68fab8fce968e8605625ea3f56a
Diff: https://reviews.apache.org/r/27657/diff/
Testing
---
Re: Review Request 27657: Print out the job url after scheduling a cron job.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/ --- (Updated Nov. 5, 2014, 6:14 p.m.) Review request for Aurora and Bill Farner. Changes --- Depend on review 27628 Bugs: AURORA-857 https://issues.apache.org/jira/browse/AURORA-857 Repository: aurora Description --- Print out the job url after scheduling a cron job. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/27657/diff/ Testing --- ./pants build --timeout=60 src/test/python:all -vxs vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora log(info): Registering job cron_hello_world with cron cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world Thanks, Zameer Manji
Re: Review Request 27657: Print out the job url after scheduling a cron job.
I have no idea how this did not fail locally. I have traced the problem
down to improper mocking and I will wait until
https://reviews.apache.org/r/27628 lands before I address it.
On Wed, Nov 5, 2014 at 5:48 PM, Aurora ReviewBot wfar...@apache.org wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27657/
Master (0ad2fca) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status
PASSED
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status_multiple_jobs
PASSED
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_deschedule_cron_deep_api
PASSED
src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_cron_deep_api
Fatal error running command; traceback can be found in
/home/jenkins/.aurora/errors/aurora-1415238529.error-log
FAILED
=== FAILURES
===
___ TestCronNoun.test_schedule_cron_deep_api
___
self = client.cli.test_cron.TestCronNoun
testMethod=test_schedule_cron_deep_api
def test_schedule_cron_deep_api(self):
(mock_api, mock_scheduler_proxy) = self.create_mock_api()
with contextlib.nested(
patch('time.sleep'),
patch('apache.aurora.client.api.SchedulerProxy',
return_value=mock_scheduler_proxy),
patch('apache.aurora.client.factory.CLUSTERS',
new=self.TEST_CLUSTERS)):
mock_scheduler_proxy.scheduleCronJob.return_value =
self.create_simple_success_response()
with temporary_file() as fp:
fp.write(self.get_valid_config())
fp.flush()
cmd = AuroraCommandLine()
result = cmd.execute(['cron', 'schedule', 'west/bozo/test/hello',
fp.name])
assert result == EXIT_OK
E AssertionError: assert 20 == 0
src/test/python/apache/aurora/client/cli/test_cron.py:100: AssertionError
generated xml file:
/jenkins/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.cli.cron.xml
Interrupted: stopping after 1 failures
== 1 failed, 3 passed in 1.55 seconds
==
Build operating on top level addresses:
set([BuildFileAddress(/jenkins/workspace/AuroraBot/src/test/python/BUILD,
all)])
src.test.python.apache.aurora.admin.admin_util
. SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
. SUCCESS
src.test.python.apache.aurora.client.api.api
. SUCCESS
src.test.python.apache.aurora.client.api.disambiguator
. SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher
. SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
. SUCCESS
src.test.python.apache.aurora.client.api.mux
. SUCCESS
src.test.python.apache.aurora.client.api.quota_check
. SUCCESS
src.test.python.apache.aurora.client.api.restarter
. SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client
. SUCCESS
src.test.python.apache.aurora.client.api.sla
. SUCCESS
src.test.python.apache.aurora.client.api.updater
. SUCCESS
src.test.python.apache.aurora.client.api.updater_util
. SUCCESS
src.test.python.apache.aurora.client.binding_helper
. SUCCESS
src.test.python.apache.aurora.client.cli.api
. SUCCESS
src.test.python.apache.aurora.client.cli.bridge
. SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks
. SUCCESS
src.test.python.apache.aurora.client.cli.cron
. FAILURE
src.test.python.apache.aurora.client.config
. SUCCESS
- Aurora ReviewBot
On November 6th, 2014, 1:33 a.m. UTC, Zameer Manji wrote:
Review request for Aurora and Bill Farner.
By Zameer Manji.
*Updated Nov. 6, 2014, 1:33 a.m.*
*Bugs: * AURORA-857 https://issues.apache.org/jira/browse/AURORA-857
*Repository: * aurora
Description
Print out the job url after scheduling a cron job.
Testing
./pants build --timeout=60 src/test/python:all -vxs
vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule
devcluster/www-data/test/cron_hello_world
/vagrant/examples/jobs/cron_hello_world.aurora
log(info): Registering job cron_hello_world with cron
cron schedule
