---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70419
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2015, 8:26 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70281
---
Brian - ping?
- Bill Farner
On Jan. 28, 2015, 8:26 p.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70079
---
Ship it!
Master (5902574) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/
---
(Updated Jan. 28, 2015, 8:26 p.m.)
Review request for Aurora, Brian Wickman
On Jan. 26, 2015, 8:16 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/common/clusters.py, line 42
https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
For the purposes of sheparding this review along would you consider
moving this to another change?
On Jan. 26, 2015, 8:40 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/common/clusters.py, line 42
https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
wait -- the # noqa is necessary, otherwise checkstyle will fail.
Reverted
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69663
---
src/main/python/apache/aurora/common/clusters.py
On Jan. 26, 2015, 8:16 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/common/clusters.py, line 42
https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
For the purposes of sheparding this review along would you consider
moving this to another change?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69668
---
src/main/python/apache/aurora/common/clusters.py
On Jan. 26, 2015, 12:16 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/common/clusters.py, line 42
https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
For the purposes of sheparding this review along would you consider
moving this to another change?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69469
---
@ReviewBot retry
- Bill Farner
On Jan. 22, 2015, 9:09 p.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69478
---
Master (e3b8905) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69269
---
I think we should leave the yaml code but drop the PyYAML
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69268
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 22, 2015, 1:09 p.m.,
On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
On Jan. 22, 2015, 1:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
17 matches
Mail list logo
