---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43972
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 23, 2014, 3:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---
src/main/java/org/apache/aurora/scheduler/thrift/Util.java
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
Would it make sense to change it to list instead? I can imagine how the
order may be helpful
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/
---
(Updated May 27, 2014, 5:39 p.m.)
Review request for Aurora, David McLaughlin,
On May 27, 2014, 12:36 p.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
Would it make sense to change it to list instead? I can imagine how the
order may be helpful
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java,
line 49
https://reviews.apache.org/r/21830/diff/2/?file=590896#file590896line49
We don't inline @Inject with methods, why here?
Bill Farner wrote:
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
Would it make sense to change it to list instead? I can imagine how the
order may be helpful
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
Would it make sense to change it to list instead? I can imagine how the
order may be helpful
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
Would it make sense to change it to list instead? I can imagine how the
order may be helpful
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/
---
(Updated May 23, 2014, 7:30 p.m.)
Review request for Aurora, David McLaughlin,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43868
---
Also passes old and new end-to-end tests.
- Bill Farner
On May
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43801
---
Ship it!
Looks great; thanks for doing this so quickly!
- Mark
12 matches
Mail list logo
