Re: Review Request 27762: Use async eventbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60442 --- Ship it! src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java https://reviews.apache.org/r/27762/#comment101841 Just to make tests a _bit_ closer to production, consider using AsyncEventBus with a same-thread executor in this branch. - Bill Farner On Nov. 8, 2014, 12:39 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 8, 2014, 12:39 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This change uses AsyncEventBus in production code. Some test code still expects eventSink.post() to block. I plan to address in a follow-up review. Diffs - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb Diff: https://reviews.apache.org/r/27762/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27762: Use async eventbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60447 --- src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java https://reviews.apache.org/r/27762/#comment101849 This will introduce the unhandled error hiding fixed earlier for most executor cases via AsyncUtil helpers. Mind using an AsyncUtil created executor instead? There is a TODO somewhere to add a non-scheduled executor but it does not have to be addressed now. - Maxim Khutornenko On Nov. 8, 2014, 12:39 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 8, 2014, 12:39 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This change uses AsyncEventBus in production code. Some test code still expects eventSink.post() to block. I plan to address in a follow-up review. Diffs - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb Diff: https://reviews.apache.org/r/27762/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27762: Use async eventbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 7, 2014, 4:50 p.m.) Review request for Aurora and Bill Farner. Changes --- Bill's feedback. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This change uses AsyncEventBus in production code. Some test code still expects eventSink.post() to block. I plan to address in a follow-up review. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb Diff: https://reviews.apache.org/r/27762/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27762: Use async eventbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60451 --- Master (66bd6fe) is red with this patch. ./build-support/jenkins/build.sh File /usr/lib/python2.7/sysconfig.py, line 355, in _init_posix raise IOError(msg) IOError: invalid Python installation: unable to open /x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h (No such file or directory) Build operating on top level addresses: set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au th/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, base)), PythonLibrary (BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/ workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, job_monitor)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, quota_check)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD, util)),
Re: Review Request 27762: Use async eventbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 7, 2014, 4:57 p.m.) Review request for Aurora and Bill Farner. Changes --- Retry buildbot. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This change uses AsyncEventBus in production code. Some test code still expects eventSink.post() to block. I plan to address in a follow-up review. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb Diff: https://reviews.apache.org/r/27762/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27762: Use async eventbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60452 --- Ship it! Master (66bd6fe) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 12:57 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 8, 2014, 12:57 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This change uses AsyncEventBus in production code. Some test code still expects eventSink.post() to block. I plan to address in a follow-up review. Diffs - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb Diff: https://reviews.apache.org/r/27762/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
