Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ --- (Updated Oct. 15, 2014, 12:41 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ --- (Updated Oct. 15, 2014, 12:46 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
On Oct. 14, 2014, 12:46 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_help.py, line 75 https://reviews.apache.org/r/26688/diff/1/?file=720844#file720844line75 Are option names guaranteed to be unique? If not this test could potentially pass if any help

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56733 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56737 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ --- (Updated Oct. 15, 2014, 1:57 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56750 --- Ship it! Ship It! - Zameer Manji On Oct. 15, 2014, 10:57 a.m.,

Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ --- Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: aurora-831

Re: Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56541 --- This looks good to me, just a couple of questions about the tests.

Re: Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56545 --- src/test/python/apache/aurora/client/cli/test_help.py

Re: Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Mark Chu-Carroll
On Oct. 14, 2014, 1 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_help.py, line 75 https://reviews.apache.org/r/26688/diff/1/?file=720844#file720844line75 Yes, they are guaranteed to be unique. The argparse framework that this is built on checks