Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66891 --- Ship it! Master (c1174a7) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66910 --- Ship it! Ship It! - Kevin Sweeney On Jan. 5, 2015, 11:07 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 11:07 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66909 --- *ping* - Joshua Cohen On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66685 --- src/main/python/apache/aurora/client/cli/BUILD https://reviews.apache.org/r/29586/#comment110267 nit: keep these sorted, here and below - Kevin Sweeney On Jan. 5, 2015, 10:52 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 10:52 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66687 --- Can you add details about why this is being done? At a quick glance, it appears as though we're relying on transitive dependencies of pex, but i suspect there's more to it. - Bill Farner On Jan. 5, 2015, 6:52 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 6:52 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Sort BUILD dependencies. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs (updated) - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
On Jan. 5, 2015, 6:53 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/BUILD, line 36 https://reviews.apache.org/r/29586/diff/1/?file=806793#file806793line36 nit: keep these sorted, here and below Done for the rest (this particular one was in the right place afaict). - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66685 --- On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
On Jan. 5, 2015, 6:55 p.m., Bill Farner wrote: Can you add details about why this is being done? At a quick glance, it appears as though we're relying on transitive dependencies of pex, but i suspect there's more to it. We were depending on all of twitter.common.python for only pex. Depending on pex directly lets us more easily consume upstream pex changes without going through the dance of getting a new version of t.c.p published. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66687 --- On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66697 --- Ship it! Ship It! - Bill Farner On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).
On Jan. 5, 2015, 6:55 p.m., Bill Farner wrote: Can you add details about why this is being done? At a quick glance, it appears as though we're relying on transitive dependencies of pex, but i suspect there's more to it. Joshua Cohen wrote: We were depending on all of twitter.common.python for only pex. Depending on pex directly lets us more easily consume upstream pex changes without going through the dance of getting a new version of t.c.p published. pex is twitter.common.python. they were merged at 0.7.0. versions after that are published as 'pex'. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66687 --- On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Replace twitter.common.python dependency with a direct pex dependency (at the latest version). Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a src/main/python/apache/aurora/client/commands/BUILD 78a2f57b4b42edf363f40e2988cf9a69c36ad003 src/main/python/apache/aurora/common/BUILD 1c6464d8a91a84ca74191814edacaac5e83b78e8 src/main/python/apache/aurora/common/pex_version.py 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec src/main/python/apache/aurora/executor/BUILD 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded src/test/python/apache/aurora/common/test_pex_version.py 7280f703463c6205493a718310f20a7fd21a0c6b Diff: https://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen
