Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72449 --- I'm over capacity on reviews at the moment, mind passing this one to somebody else? - Bill Farner On Feb. 13, 2015, 10:15 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 10:15 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 10:15 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Zameer's comments. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs (updated) - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72443 --- src/test/python/apache/aurora/client/cli/test_supdate.py https://reviews.apache.org/r/31022/#comment118499 Shouldn't 'test' be self.TEST_CLUSTER or similar? - Zameer Manji On Feb. 13, 2015, 1:54 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 1:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Adding ticket. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
On Feb. 13, 2015, 10:06 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 120 https://reviews.apache.org/r/31022/diff/1/?file=863675#file863675line120 Shouldn't 'test' be self.TEST_CLUSTER or similar? Cluster parameter is not actually used in this context. Changed it to empty string to avoid confusion. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72443 --- On Feb. 13, 2015, 9:54 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72445 --- Ship it! Ship It! - Zameer Manji On Feb. 13, 2015, 2:15 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 2:15 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72462 --- Ship it! Master (9da3ef0) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 14, 2015, 12:15 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 14, 2015, 12:15 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
Re: Review Request 31022: Fixing aurora beta-update status command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72459 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 11:27 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 11:27 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1124 https://issues.apache.org/jira/browse/AURORA-1124 Repository: aurora Description --- Fixing aurora beta-update status command. Also, refactored tests a bit and fixed a related issue with aurora `beta-update list` formatting. Diffs - src/main/python/apache/aurora/client/base.py 480728d4c3b574897ea0897f2cc6467af3ba08e6 src/main/python/apache/aurora/client/cli/update.py 6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e src/test/python/apache/aurora/client/cli/test_supdate.py 0114e200be4d5fb07db855085fce5bc3bc2dded5 src/test/python/apache/aurora/client/test_base.py bc4424b5870ae0c351323bd43d5b38b888f548d5 Diff: https://reviews.apache.org/r/31022/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Before: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] Command failure: Fatal error running command: Traceback (most recent call last): File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 312, in _execute result = noun.execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/__init__.py, line 390, in execute return self.verbs[context.options.verb].execute(context) File /usr/local/bin/aurora/apache/aurora/client/cli/update.py, line 252, in execute context.log_response_and_raise(response) File /usr/local/bin/aurora/apache/aurora/client/cli/context.py, line 135, in log_response_and_raise self.print_err(\t%s % combine_messages(resp)) File /usr/local/bin/aurora/apache/aurora/client/base.py, line 50, in combine_messages return ', '.join([d.message for d in (response.details or [])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko
