Re: Review Request 17270: Bridge framework for client v2.
On Feb. 6, 2014, 5:36 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 149
https://reviews.apache.org/r/17270/diff/3/?file=456886#file456886line149
That's actually the way that I originally wrote it, and wickman wanted
me to change it to this.
Jonathan Boulle wrote:
Well, not quite - he proposed something like
def register_noun(self, noun):
if self.registered:
raise self.Error('Cannot add new nouns after registration')
which is a different behaviour from what's here, although I don't
understand what he was trying to achieve...
Overall I guess I'm unclear on the exact semantics you're trying to
implement. Should register_nouns only be callable once?
register_nouns should be idempotent; calling it repeatedly is a waste of time,
but it shouldn't harm anything.
The point of the check is to allowed a delayed initialization of the verbs map.
The idea is that I can imagine usecases where a commandline needs to look at
the environment in order to determine whether or not to register a particular
noun. For example, I can imagine a situation where packer is an optional
component of aurora. Then the aurora client starts up, and checks to see if
there's a packer, and if so, it would register the package noun, otherwise it
wouldn't. That kind of test relies on other pieces of the system being
initialized - for example, it could rely on CLUSTERS being properly populated
for the environment, so that it can examine the clusters and see if any of them
have a packer. So I don't want to eagerly run noun registration before other
things have been initialized. So all that this is trying to do is delay the
population of the nouns until they're needed. (That's why I mostly followed
Brian's suggestion, but didn't include the raising of an error, because I don
't care if it gets called more than once; I just care that it doesn't get
called until after other things have been initialized.)
I've tried a change that gets rid of the registered field which I'll upload
shortly; hopefully that's better.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/#review33855
---
On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/
---
(Updated Jan. 30, 2014, 4:03 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: aurora-76
https://issues.apache.org/jira/browse/aurora-76
Repository: aurora
Description
---
Bridge framework for client v2.
Diffs
-
src/main/python/apache/aurora/client/bin/BUILD
46695b423663c8e970773714c3dcb7de1046a9fb
src/main/python/apache/aurora/client/cli/BUILD
8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
src/main/python/apache/aurora/client/cli/__init__.py
20ecbcf5d3a868f91922244162b516a66d24d32b
src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION
src/main/python/apache/aurora/client/cli/client.py PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD
f9ebe0cf626a040aa67654faea07b8902e558282
src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION
src/test/python/apache/aurora/client/cli/test_create.py
64eb51be32f33de7d67962ff9300e64820a37baf
src/test/python/apache/aurora/client/cli/test_diff.py
32433c17322e52c4ffb005bcc620fba56e728879
src/test/python/apache/aurora/client/cli/test_kill.py
714d5fbeebaaba6cede438c40b3b370d0ee99934
src/test/python/apache/aurora/client/cli/test_status.py
efcf164682a56294863a2aec916b9382a50032b7
Diff: https://reviews.apache.org/r/17270/diff/
Testing
---
[sun-wukong incubator-aurora (bridge)]$ ./pants
src/test/python/apache/aurora/client:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
test session starts
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
= 2 passed in 0.31 seconds
==
test session starts
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/test_config.py ..
= 6 passed in 0.41 seconds
==
test session starts
platform darwin --
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Feb. 7, 2014, 10:31 a.m.) Review request for Aurora, Jonathan Boulle and Bill Farner. Changes --- Improve lazy registration of command line nouns. This gets rid of the registered field, and uses the actual initialization status of the nouns map directly to determine whether or not nouns are registered. With this change, it will not cause any problems if subclasses of CommandLine do not call the superclass register_nouns method. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs (updated) - src/main/python/apache/aurora/client/bin/BUILD 19fd9d34ec2bfab9b8fb5ea7b468bb0b0db6341b src/main/python/apache/aurora/client/cli/BUILD 63954d6709b4aac32661f306e1809363bdac2aae src/main/python/apache/aurora/client/cli/__init__.py 14a66762c5217f2eeb6f0762278ed460f72c745d src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 51cc3806736ee277b76e4f3609a07cc2a910f31e src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_cancel_update.py 92de1b953efb865157b297909ade4b5c49f6e84a src/test/python/apache/aurora/client/cli/test_create.py 330bde5ca019ed468935cfe846b4f2a3fad209cc src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 9c593b923bba483e6877c5acc770a8ecb5fd5dbe src/test/python/apache/aurora/client/cli/test_quota.py d582fce95a95d611b3474f01d6639654b476de84 src/test/python/apache/aurora/client/cli/test_restart.py 3c0443339fca135dd3a2829a77e673fa9bb88cdb src/test/python/apache/aurora/client/cli/test_status.py 38e14b1403a14c3a622bf0c498f63aa3ae38ad04 src/test/python/apache/aurora/client/cli/test_update.py c469da4a1aead30426881dd65d82dd182f14b2bf Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33946 --- Ship it! Ship It! - Jonathan Boulle On Feb. 7, 2014, 3:31 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Feb. 7, 2014, 3:31 p.m.) Review request for Aurora, Jonathan Boulle and Bill Farner. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 19fd9d34ec2bfab9b8fb5ea7b468bb0b0db6341b src/main/python/apache/aurora/client/cli/BUILD 63954d6709b4aac32661f306e1809363bdac2aae src/main/python/apache/aurora/client/cli/__init__.py 14a66762c5217f2eeb6f0762278ed460f72c745d src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 51cc3806736ee277b76e4f3609a07cc2a910f31e src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_cancel_update.py 92de1b953efb865157b297909ade4b5c49f6e84a src/test/python/apache/aurora/client/cli/test_create.py 330bde5ca019ed468935cfe846b4f2a3fad209cc src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 9c593b923bba483e6877c5acc770a8ecb5fd5dbe src/test/python/apache/aurora/client/cli/test_quota.py d582fce95a95d611b3474f01d6639654b476de84 src/test/python/apache/aurora/client/cli/test_restart.py 3c0443339fca135dd3a2829a77e673fa9bb88cdb src/test/python/apache/aurora/client/cli/test_status.py 38e14b1403a14c3a622bf0c498f63aa3ae38ad04 src/test/python/apache/aurora/client/cli/test_update.py c469da4a1aead30426881dd65d82dd182f14b2bf Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds =
Re: Review Request 17270: Bridge framework for client v2.
On Feb. 3, 2014, 2:15 p.m., Bill Farner wrote: Ship It! brian, ping? can't ship without shipits from everyone on the People line. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 4:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2014, 9:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 9:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds = test session starts
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33360 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 4:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds = test session starts
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 4:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Addressed review comments. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs (updated) - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. = 6 passed in 0.10 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review32992 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/17270/#comment62125 I'll add a note about this to the code, but it's also worth explaining here. It's not intended to be truly lazy registration; it's explicit registration, but giving things a chance to initialize before they're registered. The idea is that a command-line object could peek at its environment, and decide whether or not a noun is appropriate. For example, you could have specific commands in the command-line tool for checking AWS quotas - but you don't even want those to be registered if the clusters file doesn't declare and AWS clusters. - Mark Chu-Carroll On Jan. 23, 2014, 6:10 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 23, 2014, 6:10 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 28, 2014, 10:23 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Addressed wfarner's review comments. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs (updated) - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. = 6 passed in 0.10 seconds == test session starts platform darwin -- Python 2.7.2 --
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33035 --- Ship it! cool, drive-by LGTM! src/main/python/apache/aurora/client/cli/bridge.py https://reviews.apache.org/r/17270/#comment62199 receive src/main/python/apache/aurora/client/cli/bridge.py https://reviews.apache.org/r/17270/#comment62200 kill src/main/python/apache/aurora/client/cli/client.py https://reviews.apache.org/r/17270/#comment62204 s/ // - Jonathan Boulle On Jan. 28, 2014, 3:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 28, 2014, 3:23 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts
