Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ --- (Updated Feb. 20, 2014, 4:37 p.m.) Review request for Aurora, David Robinson an

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-20 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/#review35069 --- Ship it! Ship It! - David Robinson On Feb. 19, 2014, 5:55 p.m.,

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-20 Thread Mark Chu-Carroll
Ping? I would really like to get this pushed and hopefully deployed soon. -Mark On Wed, Feb 19, 2014 at 12:55 PM, Mark Chu-Carroll < mchucarr...@twopensource.com> wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18265/ > Review request

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Mark Chu-Carroll
> On Feb. 19, 2014, 12:23 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 250 > > > > > > Inconsistent use of positional file arg. Ah, good catch. Supposed to be "file=sys

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ --- (Updated Feb. 19, 2014, 12:55 p.m.) Review request for Aurora, David Robinson a

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/#review34876 --- Ship it! src/main/python/apache/aurora/client/cli/__init__.py

Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ --- Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-2