Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35461 --- Fix committed at https://git-wip-us.apache.org/repos/asf?p=incubato

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

> On Feb. 25, 2014, 7:46 p.m., Bill Farner wrote: > > build-support/virtualenv, line 19 > > > > > > I may be missing something, but isn't the pushd/popd obviated by the cd? > > Kevin Sweeney wrote: > The cd only ha

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

> On Feb. 25, 2014, 11:46 a.m., Bill Farner wrote: > > build-support/virtualenv, line 19 > > > > > > I may be missing something, but isn't the pushd/popd obviated by the cd? The cd only happens in the subshell ($()), w

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35446 --- Ship it! Ship It! - Kevin Sweeney On Feb. 24, 2014, 6:45 p.m., D

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35444 --- Ship it! build-support/virtualenv

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 25, 2014, 2:45 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35366 --- pants Shoul

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 25, 2014, 2:21 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35311 --- Dan, do you have an updated version of this patch? - Kevin Sweeney

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

> On Feb. 21, 2014, 6:34 p.m., Bill Farner wrote: > > build-support/pex, line 21 > > > > > > Prefer to keep the naming consistent across the scripts. In the past, > > i've called this variable called HERE, which i lik

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35173 --- This LGTM, deferring ship for the conversation. build-support/pex

Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issue