Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
On Feb. 25, 2014, 11:46 a.m., Bill Farner wrote: build-support/virtualenv, line 19 https://reviews.apache.org/r/18345/diff/3/?file=503119#file503119line19 I may be missing something, but isn't the pushd/popd obviated by the cd? The cd only happens in the subshell ($()), which is a different process than the parent. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35444 --- On Feb. 24, 2014, 6:45 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 24, 2014, 6:45 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
On Feb. 25, 2014, 7:46 p.m., Bill Farner wrote: build-support/virtualenv, line 19 https://reviews.apache.org/r/18345/diff/3/?file=503119#file503119line19 I may be missing something, but isn't the pushd/popd obviated by the cd? Kevin Sweeney wrote: The cd only happens in the subshell ($()), which is a different process than the parent. Ah, duh — thanks! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35444 --- On Feb. 25, 2014, 2:45 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 25, 2014, 2:45 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35461 --- Fix committed at https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=commitdiff;h=6e7acbfb7a8b4cb9694fbc510fc67e07c1b34454 - Kevin Sweeney On Feb. 24, 2014, 6:45 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 24, 2014, 6:45 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 25, 2014, 2:21 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Unifies top-level dir variable to be called HERE. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs (updated) - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35173 --- This LGTM, deferring ship for the conversation. build-support/pex https://reviews.apache.org/r/18345/#comment65600 Prefer to keep the naming consistent across the scripts. In the past, i've called this variable called HERE, which i like since it's more correct than TOP_DIR (we want the dir the script is in, rather than the git dir). pants https://reviews.apache.org/r/18345/#comment65599 I learned something new today! I've always used dirname $0, but i landed at a StackOverflow question [1] that explains why that has gotchas. [1] http://stackoverflow.com/questions/59895/can-a-bash-script-tell-what-directory-its-stored-in - Bill Farner On Feb. 21, 2014, 6:05 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 21, 2014, 6:05 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
