Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58431 --- +1: Master (669981d) is green with this patch. ./build-support/jen

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 24, 2014, 4:08 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58426 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 24, 2014, 10:38 p.

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58415 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/OfferQueu

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 24, 2014, 3:38 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Bill Farner
> On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, > > line 119 > > > > > > I don't understand what you mean by "matches what we do for dedic

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58400 --- +1: Master (5be667f) is green with this patch. ./build-support/jen

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji
> On Oct. 24, 2014, 2:10 p.m., Maxim Khutornenko wrote: > > It's not obvious from the diff: where do we gain perf? Can you point to the > > place where we don't do store calls anymore? If you notice in `SchedulingFilterImplTest.java` many of the tests no longer make calls to the maintenance co

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58374 --- It's not obvious from the diff: where do we gain perf? Can you point

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58339 --- src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.j

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 24, 2014, 12:59 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58300 --- LGTM! Master (53f4e73) is green with this patch. ./build-support/j

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 23, 2014, 6:50 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58202 --- This patch does not apply cleanly on master (53f4e73), do you need t

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58198 --- src/main/java/org/apache/aurora/scheduler/async/Preemptor.java