Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review65987 --- Discarding this as it was addressed by a subsequent review. - Kevin Sweeney On Nov. 4, 2014, 7:35 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 7:35 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review62646 --- Looks like master has drifted from this patch, please update or discard. - Kevin Sweeney On Nov. 4, 2014, 7:35 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 7:35 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review61303 --- @ReviewBot retry - Joshua Cohen On Nov. 4, 2014, 3:35 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review61308 --- This patch does not apply cleanly on master (de5a9b7), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Nov. 4, 2014, 3:35 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:02 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59771 --- Master (9ef905a) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 3:35 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 3, 2014, 2:49 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- There we go. Uploaded the right diff this time. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59573 --- Ship it! Master (9186f2e) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 3, 2014, 2:49 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 3, 2014, 2:49 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
On Nov. 3, 2014, 6:03 p.m., Joshua Cohen wrote: 3rdparty/python/requirements.txt, line 1 https://reviews.apache.org/r/27492/diff/2/?file=747354#file747354line1 We should be able to skip argparse now that we're pinned to python2.7 (it was added to the stdlib). Didn't even think about that when I was converting the file. Removed. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59600 --- On Nov. 4, 2014, 12:42 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Removed argparse requirement Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59699 --- Master (9ef905a) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 12:42 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59707 --- Mind resubmitting your patch (just rerun the rbt command with no change)? The build bot is sometimes flaky due to PyPI slowness and lack of retries in pants. - Kevin Sweeney On Nov. 3, 2014, 4:42 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 3, 2014, 4:42 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59541 --- This patch does not apply cleanly on master (9186f2e), do you need to rebase? - Aurora ReviewBot On Nov. 2, 2014, 10:18 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 2, 2014, 10:18 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
