Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:57 a.m.) Review request for Aurora, Maxim

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:58 a.m.) Review request for Aurora, Maxim

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64266 --- Ship it! Ship It! - Bill Farner On Dec. 8, 2014, 7:58 p.m.,

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64268 --- Ship it! Master (a9e1217) is green with this patch.

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64270 --- src/main/python/apache/aurora/client/cli/client.py

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Zameer Manji
On Dec. 8, 2014, 12:33 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/client.py, lines 52-54 https://reviews.apache.org/r/28742/diff/4/?file=785651#file785651line52 Is there a test for this? There isn't a test. Adding a unit test is difficult because it

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 12:50 p.m.) Review request for Aurora, Maxim

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64278 --- Ship it! Master (a9e1217) is green with this patch.

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Zameer Manji
On Dec. 8, 2014, 12:33 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/client.py, lines 52-54 https://reviews.apache.org/r/28742/diff/4/?file=785651#file785651line52 Is there a test for this? Zameer Manji wrote: There isn't a test. Adding a unit test

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 3:18 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64309 --- Ship it! Master (a9e1217) is green with this patch.

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64310 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 8, 2014, 11:18

Re: Review Request 28742: Simplify logging in the client.

2014-12-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64311 --- On master now. - Maxim Khutornenko On Dec. 8, 2014, 11:18 p.m.,

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review63976 --- Ship it! Master (905137f) is green with this patch.

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64075 --- What would it take to massage the log format? I'd love to drop the

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Zameer Manji
On Dec. 5, 2014, 12:37 p.m., Bill Farner wrote: What would it take to massage the log format? I'd love to drop the `INFO:root:` prefix to every line. Personally, i find it noisy for a command line tool to include the log level on each line of output, though others may feel

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Bill Farner
On Dec. 5, 2014, 8:37 p.m., Bill Farner wrote: What would it take to massage the log format? I'd love to drop the `INFO:root:` prefix to every line. Personally, i find it noisy for a command line tool to include the log level on each line of output, though others may feel

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Bill Farner
On Dec. 5, 2014, 8:37 p.m., Bill Farner wrote: What would it take to massage the log format? I'd love to drop the `INFO:root:` prefix to every line. Personally, i find it noisy for a command line tool to include the log level on each line of output, though others may feel

Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review63972 --- This patch does not apply cleanly on master (905137f), do you need

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 4, 2014, 11:26 p.m.) Review request for Aurora, Maxim

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review63974 --- Ship it! Master (905137f) is green with this patch.

Re: Review Request 28742: Simplify logging in the client.

2014-12-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 4, 2014, 11:43 p.m.) Review request for Aurora, Maxim