Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner
On Dec. 11, 2014, 10:56 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/BUILD, line 102 https://reviews.apache.org/r/28971/diff/1/?file=789841#file789841line102 Are we going to keep the artifact name like this? Good catch, i think we should not. Fixed. - Bill

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/#review66912 --- Ship it! docs/clientv2.md

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/ --- (Updated Jan. 6, 2015, 9:23 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner
On Jan. 6, 2015, 9:20 p.m., Kevin Sweeney wrote: docs/clientv2.md, line 180 https://reviews.apache.org/r/28971/diff/2/?file=808002#file808002line180 remove reference to more consistent. I think this doc was initially written as a design doc to justify the client rewrite, might

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner
On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote: docs/client-commands.md, line 192 https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line192 while at it, how about s/shard/instance/g/ Done. On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/ --- (Updated Jan. 6, 2015, 9:15 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28971: Begin dismantling client v1.

2014-12-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/#review65152 --- docs/client-commands.md

Review Request 28971: Begin dismantling client v1.

2014-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 28971: Begin dismantling client v1.

2014-12-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/#review64805 --- src/main/python/apache/aurora/client/BUILD

Re: Review Request 28971: Begin dismantling client v1.

2014-12-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/#review64816 --- Ship it! Master (07bc3ab) is green with this patch.