Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66891 --- Ship it! Master (c1174a7) is green with this patch.

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66910 --- Ship it! Ship It! - Kevin Sweeney On Jan. 5, 2015, 11:07 a.m.,

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66909 --- *ping* - Joshua Cohen On Jan. 5, 2015, 7:07 p.m., Joshua Cohen

Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66685 --- src/main/python/apache/aurora/client/cli/BUILD

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66687 --- Can you add details about why this is being done? At a quick

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/ --- (Updated Jan. 5, 2015, 7:07 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
On Jan. 5, 2015, 6:53 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/BUILD, line 36 https://reviews.apache.org/r/29586/diff/1/?file=806793#file806793line36 nit: keep these sorted, here and below Done for the rest (this particular one was in the right place

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
On Jan. 5, 2015, 6:55 p.m., Bill Farner wrote: Can you add details about why this is being done? At a quick glance, it appears as though we're relying on transitive dependencies of pex, but i suspect there's more to it. We were depending on all of twitter.common.python for only pex.

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66697 --- Ship it! Ship It! - Bill Farner On Jan. 5, 2015, 7:07 p.m.,

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Brian Wickman
On Jan. 5, 2015, 6:55 p.m., Bill Farner wrote: Can you add details about why this is being done? At a quick glance, it appears as though we're relying on transitive dependencies of pex, but i suspect there's more to it. Joshua Cohen wrote: We were depending on all of