---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30535/#review70680
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 3, 2015, 12:42
On Feb. 3, 2015, 12:48 a.m., Maxim Khutornenko wrote:
The ticket suggests a possibility of the optimization route. Would you mind
commenting why you decided to remove it after all?
Bill Farner wrote:
Sure. Kevin rightly pointed out that it's odd for us to check this _one_
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30535/#review70675
---
The ticket suggests a possibility of the optimization route. Would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30535/#review70671
---
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 2, 2015, 4:42 p.m.,
On Feb. 3, 2015, 12:48 a.m., Maxim Khutornenko wrote:
The ticket suggests a possibility of the optimization route. Would you mind
commenting why you decided to remove it after all?
Sure. Kevin rightly pointed out that it's odd for us to check this _one_
invariant when there are many
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30535/#review70684
---
Ship it!
Master (a674581) is green with this patch.
Could the impact of this change be verified by our performance benchmarks?
On Mon, Feb 2, 2015 at 5:06 PM, Aurora ReviewBot wfar...@apache.org wrote:
---
This is an automatically generated e-mail. To reply, visit:
+1 to moving forward to this patch as-is
On Mon, Feb 2, 2015 at 5:39 PM, Bill Farner wfar...@apache.org wrote:
They could, but I don't think it would be worth the effort here. In this
case, the code itself is of little value, it's a bonus that it is also a
performance hog.
On Monday,
They could, but I don't think it would be worth the effort here. In this
case, the code itself is of little value, it's a bonus that it is also a
performance hog.
On Monday, February 2, 2015, Zameer Manji zma...@twopensource.com wrote:
Could the impact of this change be verified by our
