Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review73324 --- src/main/python/apache/aurora/executor/common/health_checker.py

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Bill Farner
On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote: src/test/python/apache/aurora/executor/common/test_health_checker.py, line 136 https://reviews.apache.org/r/30647/diff/8/?file=870602#file870602line136 Is it necessary to use a real clock + real threads + sleeps in this test?

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review73338 --- Ship it! Ship It! - Bill Farner On Feb. 20, 2015, 11:09 p.m.,

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Brian Wickman
On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote: src/test/python/apache/aurora/executor/common/test_health_checker.py, line 136 https://reviews.apache.org/r/30647/diff/8/?file=870602#file870602line136 Is it necessary to use a real clock + real threads + sleeps in this test?

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review73384 --- This patch does not apply cleanly on master (e5de618), do you need

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review73308 --- Ship it! Master (e0e3f2e) is green with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 17, 2015, 10:46 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review72858 --- Ship it! Ship It! - Joshua Cohen On Feb. 18, 2015, 1 a.m.,

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71835 ---

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71836 ---

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71711 --- ping. - Brian Wickman On Feb. 6, 2015, 11:13 p.m., Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-08 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 6, 2015, 11:13 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71488 --- Master (da296a3) is red with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 6, 2015, 7:44 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71484 --- whoops, there is a legit breakage due to the removal of the

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 7:17 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen
On Feb. 5, 2015, 2:32 a.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/executor/common/test_health_checker.py, line 106 https://reviews.apache.org/r/30647/diff/2/?file=849475#file849475line106 Any chance to have test coverage for the other two metrics? +1 - Joshua

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71281 --- Master (1c78721) is red with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71282 --- @ReviewBot retry - Joshua Cohen On Feb. 5, 2015, 7:17 p.m.,

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71294 --- Master (1c78721) is red with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 1:46 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 1:45 a.m.) Review request for Aurora, Joshua Cohen and

Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- Review request for Aurora. Repository: aurora Description ---

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71127 --- Master (edcc252) is red with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71137 ---