---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/#review73603
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 21, 2015, 6:33 p.m.,
On Feb. 21, 2015, 12:53 a.m., Joshua Cohen wrote:
Can you fill in testing done?
Bill Farner wrote:
Honest question - do you find that useful for changes like this? I find
it redundant to always type `./gradlew build -Pq`, especially since the build
bot will do that anyhow.
My
On Feb. 23, 2015, 6:22 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
lines 199-201
https://reviews.apache.org/r/31248/diff/5/?file=871734#file871734line199
Well, I think this is actually worse than it was. In case there is
On Feb. 23, 2015, 8:02 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
lines 204-205
https://reviews.apache.org/r/31248/diff/5-6/?file=871734#file871734line204
one line
I'm indifferent, figured whichever line break i chose i'd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
(Updated Feb. 23, 2015, 10:34 p.m.)
Review request for Aurora, Joshua Cohen
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
(Updated Feb. 21, 2015, 6:33 p.m.)
Review request for Aurora, Joshua Cohen and
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java, line
78
https://reviews.apache.org/r/31248/diff/1/?file=871337#file871337line78
Any reason to lower case these? I'd actually prefer upper cased
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
(Updated Feb. 21, 2015, 1:36 a.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/#review73372
---
Ship it!
Master (e5de618) is green with this patch.
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
(Updated Feb. 21, 2015, 1:11 a.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
(Updated Feb. 21, 2015, 1:34 a.m.)
Review request for Aurora, Joshua Cohen and
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Bugs:
On Feb. 21, 2015, 12:53 a.m., Joshua Cohen wrote:
Can you fill in testing done?
Honest question - do you find that useful for changes like this? I find it
redundant to always type `./gradlew build -Pq`, especially since the build bot
will do that anyhow.
On Feb. 21, 2015, 12:53 a.m.,
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/#review73351
---
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote:
19 matches
Mail list logo