Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 1:58 a.m.) Review request for Aurora, Maxim

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76331 --- Master (ee1a13a) is red with this patch.

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 2:12 a.m.) Review request for Aurora, Maxim

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76243 --- Ship it! src/main/python/apache/aurora/client/api/__init__.py

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76257 --- Ship it! Ship It! - Zameer Manji On March 11, 2015, 6:27 p.m.,

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/__init__.py, line 157 https://reviews.apache.org/r/31966/diff/2/?file=891871#file891871line157 Spacing seems off here and below. Fixed. On March 12, 2015, 4:23 p.m., Maxim Khutornenko

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, lines 123-127 https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123 Mind sorting them alphabetically? Bill Farner wrote: Done. Spoke too soon here -

Review Request 31966: Add client support for including messages when changing update state.

2015-03-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76191 --- Master (f62e0f1) is red with this patch.

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76193 --- @ReviewBot retry - Bill Farner On March 12, 2015, 1:27 a.m.,

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76194 --- Master (f62e0f1) is red with this patch.

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-11 Thread Bill Farner
On March 12, 2015, 1:38 a.m., Aurora ReviewBot wrote: Master (f62e0f1) is red with this patch. ./build-support/jenkins/build.sh 01:37:22 00:00 [deferred-sources] 01:37:22 00:00 [deferred-sources] 01:37:22 00:00 [gen] 01:37:22 00:00 [thrift]