Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/30
Changes LGTM
Could you please use a shorter and more readable pr title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/34
Great @ckadner, could you make the commit title a little smaller, something
like:
[MINOR] Prompt for PGP passphrase when not exported
other then that, LGTM
---
If your project is set up
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/23
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/27#discussion_r88346116
--- Diff:
datasource-webhdfs/src/main/scala/org/apache/bahir/datasource/webhdfs/DefaultSource.scala
---
@@ -0,0 +1,265 @@
+/*
+ * Licensed
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/27#discussion_r88345454
--- Diff: datasource-webhdfs/pom.xml ---
@@ -0,0 +1,83 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/27#discussion_r88347239
--- Diff: pom.xml ---
@@ -446,6 +447,7 @@
.classpath
.project
**/dependency-reduced-pom.xml
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/24#discussion_r86030626
--- Diff: NOTICE ---
@@ -2,4 +2,17 @@ Apache Bahir
Copyright (c) 2016 The Apache Software Foundation.
This product includes software developed
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/24
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/24#discussion_r83519004
--- Diff: NOTICE ---
@@ -2,4 +2,17 @@ Apache Bahir
Copyright (c) 2016 The Apache Software Foundation.
This product includes software developed
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/31
@ckadner @akchinSTC Can we get a link to the build results as well ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/19
ping @ScrapCodes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/14#discussion_r108084723
--- Diff: dev/release-build.sh ---
@@ -0,0 +1,330 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/14#discussion_r108084585
--- Diff: dev/release-build.sh ---
@@ -0,0 +1,330 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/39
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/39
Please test this Jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/38
Please test this Jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/38
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/39
Thank you very much @yanglei99, build is passing, samples and readme looks
good...
LGTM, we can take care of tests on a new PR.
Will merge if there are no more comments
---
If your
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/41#discussion_r110724252
--- Diff: sql-cloudant/README.md ---
@@ -62,6 +62,8 @@ cloudant.protocol|https|protocol to use to transfer data:
http or https
cloudant.host||cloudant
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/41
LGTM, merging if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/40
@emlaver Sorry, I didn't realized this was re-using the same jira for
cloudant initial code. Next time create a new jira so it becomes easier to
count your contributions.
---
If your project
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/38#discussion_r110021854
--- Diff:
sql-streaming-akka/src/test/scala/org/apache/bahir/sql/streaming/akka/AkkaStreamSourceSuite.scala
---
@@ -0,0 +1,188 @@
+/*
+ * Licensed
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/38#discussion_r110021902
--- Diff:
sql-streaming-akka/src/test/scala/org/apache/bahir/sql/streaming/akka/AkkaStreamSourceSuite.scala
---
@@ -0,0 +1,188 @@
+/*
+ * Licensed
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/40#discussion_r110016552
--- Diff: sql-cloudant/README.md ---
@@ -1,24 +1,10 @@
-Spark Cloudant Connector
-
+A library for reading data from Cloudant
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/38
Once we remove the deprecated api usages, we should be ready to merge
unless someone has other comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/47#discussion_r128406934
--- Diff: streaming-mqtt/README.md ---
@@ -52,12 +52,14 @@ this actor can be configured to handle failures, etc.
val lines
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/47
Please update the PR title and comments following the guidelines for
creating a PR in bahir.apache.org/contributing/
---
If your project is set up for it, you can reply to this email and have your
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/15
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/16
Small comment, the license header format could be avoided, but no big
deal...
Otherwise, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/43#discussion_r117160442
--- Diff:
streaming-twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -85,10 +85,8 @@ class TwitterReceiver
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/42
@bchen-talend Sorry for delaying the review, I am at a conference and
finishing up slides/demo and should be able to get to this after today.
---
If your project is set up for it, you can reply
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/46
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/46
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/43
@c-w Sorry, didn't see your response.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/44
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/43
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/18
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/18
@yew1eb Could you please start a discussion on the dev list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/59
test please
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/59
ok to test
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/59
LGTM, merging if no other comments
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/55
ok to test
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/57
@emlaver Could you please rebase to latest master.
---
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/64#discussion_r191637286
--- Diff: bahir-mqtt/mqtt.py ---
@@ -0,0 +1,103 @@
+#
--- End diff --
What's the difference between this newly added file and [this existing
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/65
Thank you for these updates @ScrapCodes. Just clarifying, this should not
be applied until we do the Bahir release that supports Spark 2.3, correct?
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/61
@emlaver Could you please rebase this pr
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/63
add to whitelist
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/63
ok to test
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/61
ok to test
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/60
ok to test
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/29
@eskabetxe do you have a jira account so that I can assign the jira to
yourself?
---
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208011210
--- Diff: flink-connector-kudu/dockers/run_kudu_tests.sh ---
@@ -0,0 +1,52 @@
+#!/bin/bash
--- End diff --
Could you please add Apache
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208011331
--- Diff: flink-connector-kudu/dockers/stop-images.sh ---
@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
--- End diff --
Could you please add
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208011160
--- Diff: flink-connector-kudu/dockers/role/docker-entrypoint.sh ---
@@ -0,0 +1,53 @@
+#!/bin/bash
--- End diff --
Could you please add
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208011089
--- Diff: flink-connector-kudu/dockers/docker-compose.yml ---
@@ -0,0 +1,77 @@
+
--- End diff --
Could you please add Apache License
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208011311
--- Diff: flink-connector-kudu/dockers/start-images.sh ---
@@ -0,0 +1,27 @@
+#!/usr/bin/env bash
--- End diff --
Could you please add
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208012315
--- Diff:
flink-connector-kudu/src/main/java/org/apache/flink/streaming/connectors/kudu/KuduOutputFormat.java
---
@@ -0,0 +1,110
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208016782
--- Diff: pom.xml ---
@@ -274,6 +275,7 @@
**/dependency-reduced-pom.xml
**/target
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/31#discussion_r208011128
--- Diff: flink-connector-kudu/dockers/role/Dockerfile ---
@@ -0,0 +1,24 @@
+FROM bitnami/minideb:jessie
--- End diff --
Could you
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/68
@ScrapCodes would you mind reviewing this when you have a chance?
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/29
LGTM, any other comments?
---
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/29#discussion_r204740329
--- Diff: .travis.yml ---
@@ -32,19 +32,19 @@ matrix:
include:
- jdk: oraclejdk8
env:
-- FLINK_VERSION="
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/28
Should you also look into the rest of the code for any other references of
1.0-SNAPSHOT?
https://github.com/apache/bahir-flink/search?q=1.0-SNAPSHOT_q=1.0-SNAPSHOT
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/35
BTW, I have disabled the failing docker tests in master after applying your
last pr #33
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@eskabetxe Please rebase your PR. Also, I see a few changes on different
projects other than the flume tests from bahir-114 (including disabling tests
that are working on current master
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/69
Please let me know your jira username so I can assign BAHIR-181 to
yourself.
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/68
@lukasz-antoniak Could you please rebase to latest master. BTW, thanks for
looking into the old API warnings as well.
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/33
With the current PR, what's the developer experience when he clones the
repository and tries to build?
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/76
Could you start a conversation on the dev list regarding the direction this
is going to take, are we droping 2.10 and continue support with 211 and 212 but
making 212 the default, and all other
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/75
@emlaver could you please rebase and force a new build
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/39
@Wosin do you have an apache jira account so I can assign the jira to
yourself ?
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/35
@eskabetxe if you update to latest master and try to rebase this, do you
get any conflicts ?
This is what I am getting :
```
First, rewinding head to replay your work on top
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/70
@lukasz-antoniak Could you please add a readme.md that documents the new
extension which is used to generate the extension documentation on the website.
---
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/71#discussion_r237038699
--- Diff:
streaming-zeromq/src/main/scala/org/apache/spark/streaming/zeromq/ZeroMQUtils.scala
---
@@ -17,147 +17,75 @@
package
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/71#discussion_r237031835
--- Diff: streaming-zeromq/pom.xml ---
@@ -45,22 +45,18 @@
${spark.version}
provided
+
+ org.zeromq
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/71#discussion_r237029598
--- Diff:
streaming-zeromq/examples/src/main/scala/org/apache/spark/examples/streaming/zeromq/ZeroMQWordCount.scala
---
@@ -15,105 +15,123
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/71
Thanks, LGTM.
---
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/70
@lukasz-antoniak LGTM.
As for the build failure, I did run it successfully on my local machine
with the Oracle JDK..., could you please force a new build to make sure all
things are ok...
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/33
Thanks @eskabetxe.
Could this be automated, or fail silently if running locally and be
automated on travis.ci?
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/31
@eskabetxe This has been merged to master, could you please close the PR
(as the commit didn't trigger that)
---
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/33
@eskabetxe Could you please rebase this? I rebased locally and the tests
started failing with
```
---
T E S T S
81 matches
Mail list logo
